<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>115386</bug_id>
          
          <creation_ts>2013-04-29 16:46:45 -0700</creation_ts>
          <short_desc>REGRESSION(r149287): Assertion failure in fast/frames/flattening/iframe-flattening-crash.html</short_desc>
          <delta_ts>2013-05-22 00:39:20 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Frames</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar, LayoutTestFailure</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>115476</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alexey Proskuryakov">ap</reporter>
          <assigned_to name="Andreas Kling">kling</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>ggaren</cc>
    
    <cc>kling</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>882824</commentid>
    <comment_count>0</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2013-04-29 16:46:45 -0700</bug_when>
    <thetext>Looks like an assertion started to happen on all WK2 testers reproducibly:

0   com.apple.WebCore             	0x000000010e768a98 WebCore::Document::updateLayout() + 200 (Document.cpp:1881)
1   com.apple.WebCore             	0x000000010e768ad4 WebCore::Document::updateLayout() + 260 (Document.cpp:1888)
2   com.apple.WebCore             	0x000000010e76bf35 WebCore::Document::updateLayoutIgnorePendingStylesheets() + 197 (Document.cpp:1928)
3   com.apple.WebCore             	0x000000010e8c8f37 WebCore::Element::clientWidth() + 39 (Element.cpp:579)
4   com.apple.WebCore             	0x000000010ef8e427 WebCore::jsElementClientWidth(JSC::ExecState*, JSC::JSValue, JSC::PropertyName) + 71 (JSElement.cpp:384)
5   com.apple.JavaScriptCore      	0x000000010d253a99 JSC::PropertySlot::getValue(JSC::ExecState*, JSC::PropertyName) const + 249 (PropertySlot.h:76)
6   com.apple.JavaScriptCore      	0x000000010d26c312 JSC::JSValue::get(JSC::ExecState*, JSC::PropertyName, JSC::PropertySlot&amp;) const + 242 (JSCJSValueInlines.h:639)
7   com.apple.JavaScriptCore      	0x000000010d5c7cd1 llint_slow_path_get_by_id + 241 (LLIntSlowPaths.cpp:910)
8   com.apple.JavaScriptCore      	0x000000010d5d1555 llint_op_get_by_id + 122
9   com.apple.JavaScriptCore      	0x000000010d4ae4b4 JSC::JITCode::execute(JSC::JSStack*, JSC::ExecState*, JSC::VM*) + 84 (JITCode.h:135)
10  com.apple.JavaScriptCore      	0x000000010d4ab224 JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&amp;, JSC::JSValue, JSC::ArgList const&amp;) + 1620 (Interpreter.cpp:1061)
11  com.apple.JavaScriptCore      	0x000000010d2bc7b2 JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&amp;, JSC::JSValue, JSC::ArgList const&amp;) + 306 (CallData.cpp:40)
12  com.apple.WebCore             	0x000000010ee5e682 WebCore::JSMainThreadExecState::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&amp;, JSC::JSValue, JSC::ArgList const&amp;) + 146 (JSMainThreadExecState.h:56)
13  com.apple.WebCore             	0x000000010efb6491 WebCore::JSEventListener::handleEvent(WebCore::ScriptExecutionContext*, WebCore::Event*) + 1217 (JSEventListener.cpp:129)
14  com.apple.WebCore             	0x000000010e9219b2 WebCore::EventTarget::fireEventListeners(WebCore::Event*, WebCore::EventTargetData*, WTF::Vector&lt;WebCore::RegisteredEventListener, 1ul, WTF::CrashOnOverflow&gt;&amp;) + 498 (EventTarget.cpp:259)
15  com.apple.WebCore             	0x000000010e9215cc WebCore::EventTarget::fireEventListeners(WebCore::Event*) + 380 (EventTarget.cpp:204)
16  com.apple.WebCore             	0x000000010e865cf0 WebCore::DOMWindow::dispatchEvent(WTF::PassRefPtr&lt;WebCore::Event&gt;, WTF::PassRefPtr&lt;WebCore::EventTarget&gt;) + 272 (DOMWindow.cpp:1711)
17  com.apple.WebCore             	0x000000010e773ee1 WebCore::Document::dispatchWindowEvent(WTF::PassRefPtr&lt;WebCore::Event&gt;, WTF::PassRefPtr&lt;WebCore::EventTarget&gt;) + 193 (Document.cpp:3656)
18  com.apple.WebCore             	0x000000010e906336 WebCore::EventHandler::dispatchResizeEvent() + 150 (EventHandler.cpp:3790)
19  com.apple.WebCore             	0x000000010ea16614 WebCore::FrameView::dispatchResizeEvent() + 148 (FrameView.cpp:2791)
20  com.apple.WebCore             	0x000000010ea164f6 WebCore::FrameView::setFrameRect(WebCore::IntRect const&amp;) + 678 (FrameView.cpp:500)
21  com.apple.WebCore             	0x000000010f92452d WebCore::RenderWidget::setWidgetGeometry(WebCore::LayoutRect const&amp;) + 381 (RenderWidget.cpp:160)
22  com.apple.WebCore             	0x000000010f924848 WebCore::RenderWidget::updateWidgetGeometry() + 456 (RenderWidget.cpp:180)
23  com.apple.WebCore             	0x000000010f925c33 WebCore::RenderWidget::updateWidgetPosition() + 83 (RenderWidget.cpp:348)
24  com.apple.WebCore             	0x000000010f745250 WebCore::RenderFrameBase::layoutWithFlattening(bool, bool) + 1568 (RenderFrameBase.cpp:98)
25  com.apple.WebCore             	0x000000010f75c555 WebCore::RenderIFrame::layout() + 325 (RenderIFrame.cpp:168)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>882829</commentid>
    <comment_count>1</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2013-04-29 16:53:10 -0700</bug_when>
    <thetext>Actually, maybe all Mac ones, wk1 or wk2. E.g.&lt;http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r149322%20(9330)/fast/frames/flattening/iframe-flattening-crash-crash-log.txt&gt;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>882834</commentid>
    <comment_count>2</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2013-04-29 16:57:36 -0700</bug_when>
    <thetext>Skipped on Mac in http://trac.webkit.org/r149333</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>882908</commentid>
    <comment_count>3</comment_count>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2013-04-29 20:18:35 -0700</bug_when>
    <thetext>Re-entrant layout is definitely a no-no. This could cause lots of serious problems.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>882909</commentid>
    <comment_count>4</comment_count>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2013-04-29 20:19:48 -0700</bug_when>
    <thetext>&lt;rdar://problem/13769995&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>883161</commentid>
    <comment_count>5</comment_count>
      <attachid>200132</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2013-04-30 11:03:26 -0700</bug_when>
    <thetext>Created attachment 200132
Proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>883162</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-04-30 11:05:06 -0700</bug_when>
    <thetext>Attachment 200132 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;LayoutTests/ChangeLog&apos;, u&apos;LayoutTests/platform/mac/TestExpectations&apos;, u&apos;Source/WebCore/ChangeLog&apos;, u&apos;Source/WebCore/page/EventHandler.cpp&apos;, u&apos;Source/WebCore/page/EventHandler.h&apos;, u&apos;Source/WebCore/page/FrameView.cpp&apos;]&quot; exit_code: 1
Source/WebCore/page/FrameView.cpp:38:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>883167</commentid>
    <comment_count>7</comment_count>
    <who name="Andreas Kling">kling</who>
    <bug_when>2013-04-30 11:08:52 -0700</bug_when>
    <thetext>Committed r149382: &lt;http://trac.webkit.org/changeset/149382&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>883431</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-05-01 09:31:00 -0700</bug_when>
    <thetext>Re-opened since this is blocked by bug 115476</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>883436</commentid>
    <comment_count>9</comment_count>
      <attachid>200217</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2013-05-01 09:44:27 -0700</bug_when>
    <thetext>Created attachment 200217
Follow-up patch

Because I am a muppet who only tested the previous patch with a release build, it kept on failing in debug.
This patch changes limits synchronous resize events to the main frame.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>883437</commentid>
    <comment_count>10</comment_count>
      <attachid>200217</attachid>
    <who name="Antti Koivisto">koivisto</who>
    <bug_when>2013-05-01 09:47:58 -0700</bug_when>
    <thetext>Comment on attachment 200217
Follow-up patch

View in context: https://bugs.webkit.org/attachment.cgi?id=200217&amp;action=review

r=me

&gt; Source/WebCore/page/FrameView.cpp:2792
&gt; +    bool isMainFrame = page ? page-&gt;mainFrame() == m_frame : false;

page &amp;&amp; page-&gt;mainFrame() == m_frame ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>883438</commentid>
    <comment_count>11</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2013-05-01 09:51:04 -0700</bug_when>
    <thetext>Is the test still skipped in TestExpectations?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>883439</commentid>
    <comment_count>12</comment_count>
    <who name="Andreas Kling">kling</who>
    <bug_when>2013-05-01 09:52:20 -0700</bug_when>
    <thetext>(In reply to comment #11)
&gt; Is the test still skipped in TestExpectations?

It is not skipped.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>883440</commentid>
    <comment_count>13</comment_count>
    <who name="Andreas Kling">kling</who>
    <bug_when>2013-05-01 09:55:01 -0700</bug_when>
    <thetext>Committed r149435: &lt;http://trac.webkit.org/changeset/149435&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>200132</attachid>
            <date>2013-04-30 11:03:26 -0700</date>
            <delta_ts>2013-04-30 11:05:16 -0700</delta_ts>
            <desc>Proposed patch</desc>
            <filename>bug-115386.diff</filename>
            <type>text/plain</type>
            <size>4542</size>
            <attacher name="Andreas Kling">kling</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCA2MzBhOGQ4Li5hZGIyMWNkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTMtMDQt
MzAgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJ
T04ocjE0OTI4Nyk6IEFzc2VydGlvbiBmYWlsdXJlIGluIGZhc3QvZnJhbWVzL2ZsYXR0ZW5pbmcv
aWZyYW1lLWZsYXR0ZW5pbmctY3Jhc2guaHRtbAorICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcv
Yi8xMTUzODY+CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMzc2OTk5NT4KKworICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9UZXN0
RXhwZWN0YXRpb25zOgorCiAyMDEzLTA0LTMwICBHbGVubiBBZGFtcyAgPGdsZW5uQHNreW5hdi5j
b20+CiAKICAgICAgICAgVGhlIGJpc29uIGdyYW1tYXIgZm9yIEBzdXBwb3J0cyBzaG91bGQgcmV0
dXJuIDAgaW4gY2FzZSBvZiBhbiBlcnJvcgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZv
cm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4
cGVjdGF0aW9ucwppbmRleCBlMDA1NDQ0Li5hMWEwYjkwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0
cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9y
bS9tYWMvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTU0Nyw2ICsxNTQ3LDMgQEAgd2Via2l0Lm9yZy9i
LzExNTI5MiBmYXN0L3dyaXRpbmctbW9kZS9qYXBhbmVzZS1ydWJ5LXZlcnRpY2FsLWxyLmh0bWwK
IHdlYmtpdC5vcmcvYi8xMTUyOTIgZmFzdC93cml0aW5nLW1vZGUvamFwYW5lc2UtcnVieS12ZXJ0
aWNhbC1ybC5odG1sCiB3ZWJraXQub3JnL2IvMTE1MjkyIGZhc3Qvd3JpdGluZy1tb2RlL3ZlcnRp
Y2FsLWJhc2VsaW5lLWFsaWdubWVudC5odG1sCiB3ZWJraXQub3JnL2IvMTE1MjkyIGZhc3Qvd3Jp
dGluZy1tb2RlL3ZlcnRpY2FsLWZvbnQtZmFsbGJhY2suaHRtbAotCi0jIFJFR1JFU1NJT04gKHIx
NDkyODc/KTogQXNzZXJ0aW9uIGZhaWx1cmUgaW4gZmFzdC9mcmFtZXMvZmxhdHRlbmluZy9pZnJh
bWUtZmxhdHRlbmluZy1jcmFzaC5odG1sCi13ZWJraXQub3JnL2IvMTE1Mzg2IFsgRGVidWcgXSBm
YXN0L2ZyYW1lcy9mbGF0dGVuaW5nL2lmcmFtZS1mbGF0dGVuaW5nLWNyYXNoLmh0bWwgWyBTa2lw
IF0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3Jl
L0NoYW5nZUxvZwppbmRleCA3OWMzOGI5Li5iMmUxNWJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEs
MjMgQEAKIDIwMTMtMDQtMzAgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCisg
ICAgICAgIFJFR1JFU1NJT04ocjE0OTI4Nyk6IEFzc2VydGlvbiBmYWlsdXJlIGluIGZhc3QvZnJh
bWVzL2ZsYXR0ZW5pbmcvaWZyYW1lLWZsYXR0ZW5pbmctY3Jhc2guaHRtbAorICAgICAgICA8aHR0
cDovL3dlYmtpdC5vcmcvYi8xMTUzODY+CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMzc2OTk5
NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQdXQg
dGhlIHJlc2l6ZSBldmVudCBvbiB0aGUgRG9jdW1lbnQncyBldmVudCBxdWV1ZSBpZiBpdCBoYXBw
ZW5zIHdoaWxlIGxheW91dCBpcyBpbiBwcm9ncmVzcy4KKyAgICAgICAgVGhpcyBhdm9pZHMgcmUt
ZW50ZXJpbmcgbGF5b3V0IHdoaWxlIGxheWluZyBvdXQgZmxhdHRlbmVkIHN1YmZyYW1lcy4KKwor
ICAgICAgICBBbHNvIG1vdmUgdGhlIGxpdHRsZSBsb2dpYyBmb3IgdGhlIHJlc2l6ZSBldmVudCBm
cm9tIEV2ZW50SGFuZGxlciB0byBGcmFtZVZpZXcgKHRoZSBvbmx5IGNsaWVudC4pCisKKyAgICAg
ICAgKiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6CisgICAgICAgICogcGFnZS9FdmVudEhhbmRsZXIu
aDoKKyAgICAgICAgKiBwYWdlL0ZyYW1lVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFt
ZVZpZXc6OmRpc3BhdGNoUmVzaXplRXZlbnQpOgorCisyMDEzLTA0LTMwICBBbmRyZWFzIEtsaW5n
ICA8YWtsaW5nQGFwcGxlLmNvbT4KKwogICAgICAgICBSRUdSRVNTSU9OKHIxNDkzMTMpIENyYXNo
IGF0IFdlYkNvcmU6OkZyYW1lVmlldzo6c2V0RnJhbWVSZWN0KCkgd2hlbiBuYXZpZ2F0aW5nIGJh
Y2sgdG8gcHJldmlvdXMgcGFnZSB3aGlsZSBmaW5kIGJhbm5lciBpcyBkaXNwbGF5ZWQuCiAgICAg
ICAgIDxodHRwOi8vd2Via2l0Lm9yZy9iLzExNTQyMT4KICAgICAgICAgPHJkYXI6Ly9wcm9ibGVt
LzEzNzY1NzM5PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIu
Y3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCmluZGV4IDQyN2ZlMjEu
LjVhZTVkM2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNw
cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKQEAgLTM3ODQsMTIg
KzM3ODQsNiBAQCB2b2lkIEV2ZW50SGFuZGxlcjo6Y2Fwc0xvY2tTdGF0ZU1heUhhdmVDaGFuZ2Vk
KCkKICAgICB9CiB9CiAKLXZvaWQgRXZlbnRIYW5kbGVyOjpkaXNwYXRjaFJlc2l6ZUV2ZW50KCkK
LXsKLSAgICBSZWZQdHI8RXZlbnQ+IHJlc2l6ZUV2ZW50ID0gRXZlbnQ6OmNyZWF0ZShldmVudE5h
bWVzKCkucmVzaXplRXZlbnQsIGZhbHNlLCBmYWxzZSk7Ci0gICAgbV9mcmFtZS0+ZG9jdW1lbnQo
KS0+ZGlzcGF0Y2hXaW5kb3dFdmVudChyZXNpemVFdmVudC5yZWxlYXNlKCksIG1fZnJhbWUtPmRv
Y3VtZW50KCktPmRvbVdpbmRvdygpKTsKLX0KLQogdm9pZCBFdmVudEhhbmRsZXI6OnNlbmRTY3Jv
bGxFdmVudCgpCiB7CiAgICAgc2V0RnJhbWVXYXNTY3JvbGxlZEJ5VXNlcigpOwpkaWZmIC0tZ2l0
IGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3Bh
Z2UvRXZlbnRIYW5kbGVyLmgKaW5kZXggMDAwMzE4OS4uNGNhZTU1NyAxMDA2NDQKLS0tIGEvU291
cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdl
L0V2ZW50SGFuZGxlci5oCkBAIC0yMzAsNyArMjMwLDYgQEAgcHVibGljOgogCiAgICAgdm9pZCBj
YXBzTG9ja1N0YXRlTWF5SGF2ZUNoYW5nZWQoKTsgLy8gT25seSBjYWxsZWQgYnkgRnJhbWVTZWxl
Y3Rpb24KICAgICAKLSAgICB2b2lkIGRpc3BhdGNoUmVzaXplRXZlbnQoKTsgLy8gT25seSBjYWxs
ZWQgaW4gRnJhbWVWaWV3CiAgICAgdm9pZCBzZW5kU2Nyb2xsRXZlbnQoKTsgLy8gRGl0dG8KIAog
I2lmIFBMQVRGT1JNKE1BQykgJiYgZGVmaW5lZChfX09CSkNfXykKZGlmZiAtLWdpdCBhL1NvdXJj
ZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVW
aWV3LmNwcAppbmRleCAyYWJjN2Q4Li5mNTVlM2NhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9wYWdlL0ZyYW1lVmlldy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcu
Y3BwCkBAIC0zNSw2ICszNSw3IEBACiAjaW5jbHVkZSAiQ2hyb21lLmgiCiAjaW5jbHVkZSAiQ2hy
b21lQ2xpZW50LmgiCiAjaW5jbHVkZSAiRG9jdW1lbnRNYXJrZXJDb250cm9sbGVyLmgiCisjaW5j
bHVkZSAiRE9NV2luZG93LmgiCiAjaW5jbHVkZSAiRXZlbnRIYW5kbGVyLmgiCiAjaW5jbHVkZSAi
RmxvYXRSZWN0LmgiCiAjaW5jbHVkZSAiRm9jdXNDb250cm9sbGVyLmgiCkBAIC0yNzg3LDcgKzI3
ODgsMTIgQEAgdm9pZCBGcmFtZVZpZXc6OmRpc3BhdGNoUmVzaXplRXZlbnQoKQogewogICAgIEFT
U0VSVChtX2ZyYW1lKTsKIAotICAgIG1fZnJhbWUtPmV2ZW50SGFuZGxlcigpLT5kaXNwYXRjaFJl
c2l6ZUV2ZW50KCk7CisgICAgLy8gSWYgd2UgcmVzaXplZCBkdXJpbmcgbGF5b3V0LCBxdWV1ZSB1
cCBhIHJlc2l6ZSBldmVudCBmb3IgbGF0ZXIsIG90aGVyd2lzZSBmaXJlIGl0IHJpZ2h0IGF3YXku
CisgICAgUmVmUHRyPEV2ZW50PiByZXNpemVFdmVudCA9IEV2ZW50OjpjcmVhdGUoZXZlbnROYW1l
cygpLnJlc2l6ZUV2ZW50LCBmYWxzZSwgZmFsc2UpOworICAgIGlmIChpc0luTGF5b3V0KCkpCisg
ICAgICAgIG1fZnJhbWUtPmRvY3VtZW50KCktPmVucXVldWVXaW5kb3dFdmVudChyZXNpemVFdmVu
dC5yZWxlYXNlKCkpOworICAgIGVsc2UKKyAgICAgICAgbV9mcmFtZS0+ZG9jdW1lbnQoKS0+ZGlz
cGF0Y2hXaW5kb3dFdmVudChyZXNpemVFdmVudC5yZWxlYXNlKCksIG1fZnJhbWUtPmRvY3VtZW50
KCktPmRvbVdpbmRvdygpKTsKIAogI2lmIEVOQUJMRShJTlNQRUNUT1IpCiAgICAgaWYgKEluc3Bl
Y3Rvckluc3RydW1lbnRhdGlvbjo6aGFzRnJvbnRlbmRzKCkpIHsK
</data>
<flag name="review"
          id="221651"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>200217</attachid>
            <date>2013-05-01 09:44:27 -0700</date>
            <delta_ts>2013-05-01 09:47:58 -0700</delta_ts>
            <desc>Follow-up patch</desc>
            <filename>bug-115386-2.diff</filename>
            <type>text/plain</type>
            <size>2443</size>
            <attacher name="Andreas Kling">kling</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCA4ZThhOGQ1Li5hODVhMzdiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg
QEAKKzIwMTMtMDUtMDEgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg
ICAgIFJFR1JFU1NJT04ocjE0OTI4Nyk6IEFzc2VydGlvbiBmYWlsdXJlIGluIGZhc3QvZnJhbWVz
L2ZsYXR0ZW5pbmcvaWZyYW1lLWZsYXR0ZW5pbmctY3Jhc2guaHRtbAorICAgICAgICA8aHR0cDov
L3dlYmtpdC5vcmcvYi8xMTUzODY+CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMzc2OTk5NT4K
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPbmx5IHNl
bmQgc3luY2hyb25vdXMgcmVzaXplIGV2ZW50cyBmb3IgdGhlIG1haW4gZnJhbWUuIFN1YmZyYW1l
cyBjaGFuZ2Ugc2l6ZSBkdXJpbmcgbGF5b3V0LAorICAgICAgICBzbyBpdCBuZXZlciByZWFsbHkg
bWFrZXMgc2Vuc2UgZm9yIHRoZW0gdG8gdXNlIHN5bmNocm9ub3VzIGRpc3BhdGNoIGFueXdheS4K
KworICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1l
Vmlldzo6ZGlzcGF0Y2hSZXNpemVFdmVudCk6CisKIDIwMTMtMDUtMDEgIENzYWJhIE9zenRyb2dv
bsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIHRyaXZpYWwgYnVp
bGRmaXggYWZ0ZXIgcjE0OTQzMi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJh
bWVWaWV3LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAppbmRleCBlMGQx
YmZkLi5iOTY3NmE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5j
cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCkBAIC0yNzg4LDIxICsy
Nzg4LDIxIEBAIHZvaWQgRnJhbWVWaWV3OjpkaXNwYXRjaFJlc2l6ZUV2ZW50KCkKIHsKICAgICBB
U1NFUlQobV9mcmFtZSk7CiAKKyAgICBQYWdlKiBwYWdlID0gbV9mcmFtZS0+cGFnZSgpOworICAg
IGJvb2wgaXNNYWluRnJhbWUgPSBwYWdlID8gcGFnZS0+bWFpbkZyYW1lKCkgPT0gbV9mcmFtZSA6
IGZhbHNlOworICAgIGJvb2wgY2FuU2VuZFJlc2l6ZUV2ZW50U3luY2hyb25vdXNseSA9IGlzTWFp
bkZyYW1lICYmICFpc0luTGF5b3V0KCk7CisKICAgICAvLyBJZiB3ZSByZXNpemVkIGR1cmluZyBs
YXlvdXQsIHF1ZXVlIHVwIGEgcmVzaXplIGV2ZW50IGZvciBsYXRlciwgb3RoZXJ3aXNlIGZpcmUg
aXQgcmlnaHQgYXdheS4KICAgICBSZWZQdHI8RXZlbnQ+IHJlc2l6ZUV2ZW50ID0gRXZlbnQ6OmNy
ZWF0ZShldmVudE5hbWVzKCkucmVzaXplRXZlbnQsIGZhbHNlLCBmYWxzZSk7Ci0gICAgaWYgKGlz
SW5MYXlvdXQoKSkKLSAgICAgICAgbV9mcmFtZS0+ZG9jdW1lbnQoKS0+ZW5xdWV1ZVdpbmRvd0V2
ZW50KHJlc2l6ZUV2ZW50LnJlbGVhc2UoKSk7Ci0gICAgZWxzZQorICAgIGlmIChjYW5TZW5kUmVz
aXplRXZlbnRTeW5jaHJvbm91c2x5KQogICAgICAgICBtX2ZyYW1lLT5kb2N1bWVudCgpLT5kaXNw
YXRjaFdpbmRvd0V2ZW50KHJlc2l6ZUV2ZW50LnJlbGVhc2UoKSwgbV9mcmFtZS0+ZG9jdW1lbnQo
KS0+ZG9tV2luZG93KCkpOworICAgIGVsc2UKKyAgICAgICAgbV9mcmFtZS0+ZG9jdW1lbnQoKS0+
ZW5xdWV1ZVdpbmRvd0V2ZW50KHJlc2l6ZUV2ZW50LnJlbGVhc2UoKSk7CiAKICNpZiBFTkFCTEUo
SU5TUEVDVE9SKQotICAgIGlmIChJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246Omhhc0Zyb250ZW5k
cygpKSB7Ci0gICAgICAgIGlmIChQYWdlKiBwYWdlID0gbV9mcmFtZS0+cGFnZSgpKSB7Ci0gICAg
ICAgICAgICBpZiAocGFnZS0+bWFpbkZyYW1lKCkgPT0gbV9mcmFtZSkgewotICAgICAgICAgICAg
ICAgIGlmIChJbnNwZWN0b3JDbGllbnQqIGluc3BlY3RvckNsaWVudCA9IHBhZ2UtPmluc3BlY3Rv
ckNvbnRyb2xsZXIoKS0+aW5zcGVjdG9yQ2xpZW50KCkpCi0gICAgICAgICAgICAgICAgICAgIGlu
c3BlY3RvckNsaWVudC0+ZGlkUmVzaXplTWFpbkZyYW1lKG1fZnJhbWUuZ2V0KCkpOwotICAgICAg
ICAgICAgfQotICAgICAgICB9CisgICAgaWYgKEluc3BlY3Rvckluc3RydW1lbnRhdGlvbjo6aGFz
RnJvbnRlbmRzKCkgJiYgaXNNYWluRnJhbWUpIHsKKyAgICAgICAgaWYgKEluc3BlY3RvckNsaWVu
dCogaW5zcGVjdG9yQ2xpZW50ID0gcGFnZSA/IHBhZ2UtPmluc3BlY3RvckNvbnRyb2xsZXIoKS0+
aW5zcGVjdG9yQ2xpZW50KCkgOiAwKQorICAgICAgICAgICAgaW5zcGVjdG9yQ2xpZW50LT5kaWRS
ZXNpemVNYWluRnJhbWUobV9mcmFtZS5nZXQoKSk7CiAgICAgfQogI2VuZGlmCiB9Cg==
</data>
<flag name="review"
          id="221707"
          type_id="1"
          status="+"
          setter="koivisto"
    />
          </attachment>
      

    </bug>

</bugzilla>