115358 2013-04-29 08:29:59 -0700 EventSource: Loss of reconnect time precision due to integer division 2013-05-01 10:14:51 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 per-erik.brodin webkit-unassigned ap commit-queue oldest_to_newest 882598 0 per-erik.brodin 2013-04-29 08:29:59 -0700 Precision is lost when the reconnect time is converted from milliseconds to seconds. 882603 1 200016 per-erik.brodin 2013-04-29 08:34:11 -0700 Created attachment 200016 patch 882606 2 200017 per-erik.brodin 2013-04-29 08:38:19 -0700 Created attachment 200017 patch 2 Added missing file. 883442 3 200017 commit-queue 2013-05-01 10:14:50 -0700 Comment on attachment 200017 patch 2 Clearing flags on attachment: 200017 Committed r149436: <http://trac.webkit.org/changeset/149436> 883443 4 commit-queue 2013-05-01 10:14:51 -0700 All reviewed patches have been landed. Closing bug. 200016 2013-04-29 08:34:11 -0700 2013-04-29 08:38:19 -0700 patch es_retry_precision_01.patch text/plain 3493 per-erik.brodin ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5MTU5MTQ1Li5jZjg2MTY1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTMtMDQt MjkgIFBlci1FcmlrIEJyb2RpbiAgPHBlci1lcmlrLmJyb2RpbkBlcmljc3Nvbi5jb20+CisKKyAg ICAgICAgRXZlbnRTb3VyY2U6IExvc3Mgb2YgcmVjb25uZWN0IHRpbWUgcHJlY2lzaW9uIGR1ZSB0 byBpbnRlZ2VyIGRpdmlzaW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMTUzNTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIGh0dHAvdGVzdHMvZXZlbnRzb3VyY2UvZXZlbnRzb3VyY2UtcmV0cnktcHJl Y2lzaW9uLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogaHR0cC90ZXN0cy9ldmVudHNv dXJjZS9ldmVudHNvdXJjZS1yZXRyeS1wcmVjaXNpb24uaHRtbDogQWRkZWQuCisKIDIwMTMtMDQt MjggIFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFJlbmFt ZSBUZXN0UnVubmVyJ3Mgc2V0QXVkaW9EYXRhIHRvIHNldEF1ZGlvUmVzdWx0CmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2V2ZW50c291cmNlL2V2ZW50c291cmNlLXJldHJ5LXBy ZWNpc2lvbi1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2V2ZW50c291cmNl L2V2ZW50c291cmNlLXJldHJ5LXByZWNpc2lvbi1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMC4uZWFhN2VhNwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRl c3RzL2h0dHAvdGVzdHMvZXZlbnRzb3VyY2UvZXZlbnRzb3VyY2UtcmV0cnktcHJlY2lzaW9uLWV4 cGVjdGVkLnR4dApAQCAtMCwwICsxLDUgQEAKK1Rlc3QgRXZlbnRTb3VyY2UgcmV0cnkgdGltZSBw cmVjaXNpb24uIFNob3VsZCBwcmludCBQQVNTIGZvbGxvd2VkIGJ5IERPTkUuCisKK1BBU1M6IGRp ZCBub3QgaW1tZWRpYXRlbHkgcmVjb25uZWN0CitET05FCisKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2h0dHAvdGVzdHMvZXZlbnRzb3VyY2UvZXZlbnRzb3VyY2UtcmV0cnktcHJlY2lzaW9uLmh0 bWwgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2V2ZW50c291cmNlL2V2ZW50c291cmNlLXJldHJ5 LXByZWNpc2lvbi5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjU4NzJj YzQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2V2ZW50c291cmNl L2V2ZW50c291cmNlLXJldHJ5LXByZWNpc2lvbi5odG1sCkBAIC0wLDAgKzEsMzcgQEAKKzxodG1s PgorPGJvZHk+Cis8cD5UZXN0IEV2ZW50U291cmNlIHJldHJ5IHRpbWUgcHJlY2lzaW9uLiBTaG91 bGQgcHJpbnQgUEFTUyBmb2xsb3dlZCBieSBET05FLjwvcD4KKzxzY3JpcHQ+CitmdW5jdGlvbiBs b2cobXNnKSB7CisgICAgZG9jdW1lbnQuYm9keS5pbm5lckhUTUwgKz0gbXNnICsgIjxicj4iOwor fQorCitpZiAod2luZG93LnRlc3RSdW5uZXIpIHsKKyAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQo KTsKKyAgICB0ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKK30KKwordmFyIHRpbWVvdXRJZCA9 IHNldFRpbWVvdXQoZnVuY3Rpb24gKCkgeworICAgIGxvZygiUEFTUzogZGlkIG5vdCBpbW1lZGlh dGVseSByZWNvbm5lY3QiKTsKKyAgICBlbmQoKTsKK30sIDUwMCk7CisKK3ZhciBjb3VudCA9IDA7 Cit2YXIgZXMgPSBuZXcgRXZlbnRTb3VyY2UoInJlc291cmNlcy9wcmVjaXNlLXJldHJ5LmFzaXMi KTsKK2VzLm9ub3BlbiA9IGZ1bmN0aW9uICgpIHsKKyAgICBpZiAoY291bnQrKyAhPSAyKQorICAg ICAgICByZXR1cm47CisgICAgY2xlYXJUaW1lb3V0KHRpbWVvdXRJZCk7CisgICAgbG9nKCJGQUlM OiByZWNvbm5lY3RlZCB0b28gc29vbiIpOworICAgIGVuZCgpOworfTsKKworZnVuY3Rpb24gZW5k KCkgeworICAgIGVzLmNsb3NlKCk7CisgICAgbG9nKCJET05FIik7CisgICAgaWYgKHdpbmRvdy50 ZXN0UnVubmVyKQorICAgICAgICB0ZXN0UnVubmVyLm5vdGlmeURvbmUoKTsKK30KKzwvc2NyaXB0 PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n IGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGYyMWFmYzAuLjUxM2Q2Y2YgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMy0wNC0yOSAgUGVyLUVyaWsgQnJvZGluICA8cGVy LWVyaWsuYnJvZGluQGVyaWNzc29uLmNvbT4KKworICAgICAgICBFdmVudFNvdXJjZTogTG9zcyBv ZiByZWNvbm5lY3QgdGltZSBwcmVjaXNpb24gZHVlIHRvIGludGVnZXIgZGl2aXNpb24KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNTM1OAorCisgICAg ICAgIE1ha2Ugc3VyZSBwcmVjaXNpb24gaXMgbm90IGxvc3Qgd2hlbiBjb252ZXJ0aW5nIHRoZSBy ZWNvbm5lY3QgdGltZSBmcm9tIG1pbGxpc2Vjb25kcyB0byBzZWNvbmRzLgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IGh0dHAvdGVzdHMvZXZl bnRzb3VyY2UvZXZlbnRzb3VyY2UtcmV0cnktcHJlY2lzaW9uLmh0bWwKKworICAgICAgICAqIHBh Z2UvRXZlbnRTb3VyY2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRTb3VyY2U6OnNjaGVk dWxlUmVjb25uZWN0KToKKwogMjAxMy0wNC0yNSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0 Lm9yZz4KIAogICAgICAgICBTdGF0aWNIYXNoU2V0Tm9kZUxpc3QgaXMgdW5uZWNlc3NhcnkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRTb3VyY2UuY3BwIGIvU291cmNlL1dl YkNvcmUvcGFnZS9FdmVudFNvdXJjZS5jcHAKaW5kZXggNDcyMWQwZS4uNzdhOGU2ZiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudFNvdXJjZS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGFnZS9FdmVudFNvdXJjZS5jcHAKQEAgLTE2Niw3ICsxNjYsNyBAQCB2b2lkIEV2ZW50 U291cmNlOjpzY2hlZHVsZUluaXRpYWxDb25uZWN0KCkKIHZvaWQgRXZlbnRTb3VyY2U6OnNjaGVk dWxlUmVjb25uZWN0KCkKIHsKICAgICBtX3N0YXRlID0gQ09OTkVDVElORzsKLSAgICBtX2Nvbm5l Y3RUaW1lci5zdGFydE9uZVNob3QobV9yZWNvbm5lY3REZWxheSAvIDEwMDApOworICAgIG1fY29u bmVjdFRpbWVyLnN0YXJ0T25lU2hvdChtX3JlY29ubmVjdERlbGF5IC8gMTAwMC4wKTsKICAgICBk aXNwYXRjaEV2ZW50KEV2ZW50OjpjcmVhdGUoZXZlbnROYW1lcygpLmVycm9yRXZlbnQsIGZhbHNl LCBmYWxzZSkpOwogfQogCg== 200017 2013-04-29 08:38:19 -0700 2013-05-01 10:14:49 -0700 patch 2 es_retry_precision_02.patch text/plain 3900 per-erik.brodin ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5MTU5MTQ1Li41YTE1NGI1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTMtMDQt MjkgIFBlci1FcmlrIEJyb2RpbiAgPHBlci1lcmlrLmJyb2RpbkBlcmljc3Nvbi5jb20+CisKKyAg ICAgICAgRXZlbnRTb3VyY2U6IExvc3Mgb2YgcmVjb25uZWN0IHRpbWUgcHJlY2lzaW9uIGR1ZSB0 byBpbnRlZ2VyIGRpdmlzaW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMTUzNTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIGh0dHAvdGVzdHMvZXZlbnRzb3VyY2UvZXZlbnRzb3VyY2UtcmV0cnktcHJl Y2lzaW9uLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogaHR0cC90ZXN0cy9ldmVudHNv dXJjZS9ldmVudHNvdXJjZS1yZXRyeS1wcmVjaXNpb24uaHRtbDogQWRkZWQuCisgICAgICAgICog aHR0cC90ZXN0cy9ldmVudHNvdXJjZS9yZXNvdXJjZXMvcHJlY2lzZS1yZXRyeS5hc2lzOiBBZGRl ZC4KKwogMjAxMy0wNC0yOCAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAK ICAgICAgICAgUmVuYW1lIFRlc3RSdW5uZXIncyBzZXRBdWRpb0RhdGEgdG8gc2V0QXVkaW9SZXN1 bHQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvZXZlbnRzb3VyY2UvZXZlbnRz b3VyY2UtcmV0cnktcHJlY2lzaW9uLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2h0dHAvdGVz dHMvZXZlbnRzb3VyY2UvZXZlbnRzb3VyY2UtcmV0cnktcHJlY2lzaW9uLWV4cGVjdGVkLnR4dApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5lYWE3ZWE3Ci0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9ldmVudHNvdXJjZS9ldmVudHNvdXJjZS1yZXRy eS1wcmVjaXNpb24tZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNSBAQAorVGVzdCBFdmVudFNvdXJj ZSByZXRyeSB0aW1lIHByZWNpc2lvbi4gU2hvdWxkIHByaW50IFBBU1MgZm9sbG93ZWQgYnkgRE9O RS4KKworUEFTUzogZGlkIG5vdCBpbW1lZGlhdGVseSByZWNvbm5lY3QKK0RPTkUKKwpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9ldmVudHNvdXJjZS9ldmVudHNvdXJjZS1yZXRy eS1wcmVjaXNpb24uaHRtbCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvZXZlbnRzb3VyY2UvZXZl bnRzb3VyY2UtcmV0cnktcHJlY2lzaW9uLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMC4uNTg3MmNjNAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVz dHMvZXZlbnRzb3VyY2UvZXZlbnRzb3VyY2UtcmV0cnktcHJlY2lzaW9uLmh0bWwKQEAgLTAsMCAr MSwzNyBAQAorPGh0bWw+Cis8Ym9keT4KKzxwPlRlc3QgRXZlbnRTb3VyY2UgcmV0cnkgdGltZSBw cmVjaXNpb24uIFNob3VsZCBwcmludCBQQVNTIGZvbGxvd2VkIGJ5IERPTkUuPC9wPgorPHNjcmlw dD4KK2Z1bmN0aW9uIGxvZyhtc2cpIHsKKyAgICBkb2N1bWVudC5ib2R5LmlubmVySFRNTCArPSBt c2cgKyAiPGJyPiI7Cit9CisKK2lmICh3aW5kb3cudGVzdFJ1bm5lcikgeworICAgIHRlc3RSdW5u ZXIuZHVtcEFzVGV4dCgpOworICAgIHRlc3RSdW5uZXIud2FpdFVudGlsRG9uZSgpOworfQorCit2 YXIgdGltZW91dElkID0gc2V0VGltZW91dChmdW5jdGlvbiAoKSB7CisgICAgbG9nKCJQQVNTOiBk aWQgbm90IGltbWVkaWF0ZWx5IHJlY29ubmVjdCIpOworICAgIGVuZCgpOworfSwgNTAwKTsKKwor dmFyIGNvdW50ID0gMDsKK3ZhciBlcyA9IG5ldyBFdmVudFNvdXJjZSgicmVzb3VyY2VzL3ByZWNp c2UtcmV0cnkuYXNpcyIpOworZXMub25vcGVuID0gZnVuY3Rpb24gKCkgeworICAgIGlmIChjb3Vu dCsrICE9IDIpCisgICAgICAgIHJldHVybjsKKyAgICBjbGVhclRpbWVvdXQodGltZW91dElkKTsK KyAgICBsb2coIkZBSUw6IHJlY29ubmVjdGVkIHRvbyBzb29uIik7CisgICAgZW5kKCk7Cit9Owor CitmdW5jdGlvbiBlbmQoKSB7CisgICAgZXMuY2xvc2UoKTsKKyAgICBsb2coIkRPTkUiKTsKKyAg ICBpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgp OworfQorPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9odHRwL3Rlc3RzL2V2ZW50c291cmNlL3Jlc291cmNlcy9wcmVjaXNlLXJldHJ5LmFzaXMgYi9M YXlvdXRUZXN0cy9odHRwL3Rlc3RzL2V2ZW50c291cmNlL3Jlc291cmNlcy9wcmVjaXNlLXJldHJ5 LmFzaXMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uMDNjNDM4NQotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvZXZlbnRzb3VyY2UvcmVzb3VyY2Vz L3ByZWNpc2UtcmV0cnkuYXNpcwpAQCAtMCwwICsxLDQgQEAKK0NvbnRlbnQtVHlwZTogdGV4dC9l dmVudC1zdHJlYW0KKworcmV0cnk6IDk5OQorCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjIxYWZjMC4uNTEzZDZj ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA0LTI5ICBQZXItRXJpayBCcm9k aW4gIDxwZXItZXJpay5icm9kaW5AZXJpY3Nzb24uY29tPgorCisgICAgICAgIEV2ZW50U291cmNl OiBMb3NzIG9mIHJlY29ubmVjdCB0aW1lIHByZWNpc2lvbiBkdWUgdG8gaW50ZWdlciBkaXZpc2lv bgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1MzU4 CisKKyAgICAgICAgTWFrZSBzdXJlIHByZWNpc2lvbiBpcyBub3QgbG9zdCB3aGVuIGNvbnZlcnRp bmcgdGhlIHJlY29ubmVjdCB0aW1lIGZyb20gbWlsbGlzZWNvbmRzIHRvIHNlY29uZHMuCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogaHR0cC90 ZXN0cy9ldmVudHNvdXJjZS9ldmVudHNvdXJjZS1yZXRyeS1wcmVjaXNpb24uaHRtbAorCisgICAg ICAgICogcGFnZS9FdmVudFNvdXJjZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFdmVudFNvdXJj ZTo6c2NoZWR1bGVSZWNvbm5lY3QpOgorCiAyMDEzLTA0LTI1ICBSeW9zdWtlIE5pd2EgIDxybml3 YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFN0YXRpY0hhc2hTZXROb2RlTGlzdCBpcyB1bm5lY2Vz c2FyeQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudFNvdXJjZS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50U291cmNlLmNwcAppbmRleCA0NzIxZDBlLi43N2E4ZTZm IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50U291cmNlLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50U291cmNlLmNwcApAQCAtMTY2LDcgKzE2Niw3IEBAIHZv aWQgRXZlbnRTb3VyY2U6OnNjaGVkdWxlSW5pdGlhbENvbm5lY3QoKQogdm9pZCBFdmVudFNvdXJj ZTo6c2NoZWR1bGVSZWNvbm5lY3QoKQogewogICAgIG1fc3RhdGUgPSBDT05ORUNUSU5HOwotICAg IG1fY29ubmVjdFRpbWVyLnN0YXJ0T25lU2hvdChtX3JlY29ubmVjdERlbGF5IC8gMTAwMCk7Cisg ICAgbV9jb25uZWN0VGltZXIuc3RhcnRPbmVTaG90KG1fcmVjb25uZWN0RGVsYXkgLyAxMDAwLjAp OwogICAgIGRpc3BhdGNoRXZlbnQoRXZlbnQ6OmNyZWF0ZShldmVudE5hbWVzKCkuZXJyb3JFdmVu dCwgZmFsc2UsIGZhbHNlKSk7CiB9CiAK