11535 2006-11-06 14:53:43 -0800 REGRESSION: onclick="this.select();" not working on new forms 2007-02-05 15:51:27 -0800 1 1 1 Unclassified WebKit Forms 420+ Mac OS X 10.4 RESOLVED FIXED data:text/html,%20<input%20type="text"%20onclick="this.select();"%20value="Foobar"> HasReduction, InRadar, Regression P1 Normal --- 1 dev+webkit darin oldest_to_newest 46734 0 dev+webkit 2006-11-06 14:53:43 -0800 When you load the url and click the text field "Foobar" should become selected, but doesn't. Seems to be a problem with the new forms since shipping Safari and Omniweb (as well as Gecko-based browsers) both behave properly. This isn't an issue with this.select() as it works perfectly on other event handlers (onfocus, onmouseover, etc), nor is it an issue with onclick as other javascript works fine. 33326 1 slewis 2007-01-22 17:26:37 -0800 radar <rdar://problem/4946959> 27367 2 12956 darin 2007-02-05 15:40:44 -0800 Created attachment 12956 patch, change log, layout test 27368 3 12956 sullivan 2007-02-05 15:45:43 -0800 Comment on attachment 12956 patch, change log, layout test Looks good to me, and has nice layout test. r=me 27283 4 darin 2007-02-05 15:51:27 -0800 Committed revision 19416. 12956 2007-02-05 15:40:44 -0800 2007-02-05 15:45:43 -0800 patch, change log, layout test SelectOnClickPatch.txt text/plain 7658 darin SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE5NDEyKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDctMDItMDUgIERhcmluIEFkbGVyICA8ZGFy aW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIC0gdGVzdCBmb3IgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTE1MzUKKyAgICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDk0Njk1OT4gUkVHUkVTU0lPTjogb25j bGljaz0idGhpcy5zZWxlY3QoKTsiCisgICAgICAgICAgbm90IHdvcmtpbmcgb24gbmV3IGZvcm1z ICgxMTUzNSkKKworICAgICAgICAqIGZhc3QvZm9ybXMvaW5wdXQtc2VsZWN0LW9uLWNsaWNrLWV4 cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9mb3Jtcy9pbnB1dC1zZWxlY3Qtb24t Y2xpY2suaHRtbDogQWRkZWQuCisKIDIwMDctMDItMDUgIE1pdHogUGV0dGVsICA8bWl0ekB3ZWJr aXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkZWxlLgpJbmRleDogTGF5b3V0VGVzdHMv ZmFzdC9mb3Jtcy9pbnB1dC1zZWxlY3Qtb24tY2xpY2stZXhwZWN0ZWQudHh0Cj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW5wdXQtc2VsZWN0LW9uLWNsaWNrLWV4cGVjdGVk LnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW5wdXQtc2VsZWN0 LW9uLWNsaWNrLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw5IEBACitUZXN0 cyBiZWhhdmlvciBvZiBjb2RlIHRoYXQgY2FsbHMgc2VsZWN0KCkgaW5zaWRlIGFuIG9uY2xpY2sg aGFuZGxlci4gVGhlIGVudGlyZSBmaWVsZCBzaG91bGQgZW5kIHVwIHNlbGVjdGVkLgorCitUaGUg dGVzdCBydW5zIG9ubHkgdW5kZXIgRHVtcFJlbmRlclRyZWUgd2l0aCBldmVudFNlbmRlcjsgaWYg eW91IHRlc3QgYnkgaGFuZCB0aGUgdGVzdCByZXN1bHQgYmVsb3cgd2lsbCBzYXkgRkFJTC4KKwor CisKK1BBU1MKKworCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lucHV0LXNlbGVjdC1v bi1jbGljay5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW5wdXQt c2VsZWN0LW9uLWNsaWNrLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Zv cm1zL2lucHV0LXNlbGVjdC1vbi1jbGljay5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDMw IEBACis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdD4KK2Z1bmN0aW9uIHRlc3QoKSB7CisgICAgaWYg KHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xs ZXIuZHVtcEFzVGV4dCgpOworICAgIHZhciB0ZiA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd0 ZicpOworICAgIHZhciB4ID0gdGYub2Zmc2V0TGVmdCArIHRmLm9mZnNldFdpZHRoIC8gMjsKKyAg ICB2YXIgeSA9IHRmLm9mZnNldFRvcCArIHRmLm9mZnNldEhlaWdodCAvIDI7CisgICAgaWYgKHdp bmRvdy5ldmVudFNlbmRlcikgeworICAgICAgICBldmVudFNlbmRlci5tb3VzZU1vdmVUbyh4LCB5 KTsKKyAgICAgICAgZXZlbnRTZW5kZXIubW91c2VEb3duKCk7CisgICAgICAgIGV2ZW50U2VuZGVy Lm1vdXNlVXAoKTsKKyAgICB9CisgICAgaWYgKHRmLnNlbGVjdGlvblN0YXJ0ID09IDAgJiYgdGYu c2VsZWN0aW9uRW5kID09IDEwKSB7IC8vIDsKKyAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoInJlc3VsdCIpLmlubmVySFRNTCA9ICJQQVNTIjsKKyAgICB9IGVsc2UgeworICAgICAgICBk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgicmVzdWx0IikuaW5uZXJIVE1MID0gIkZBSUw6IHNlbGVj dGlvbiBzdGFydCBpcyAiCisgICAgICAgICAgICArIHRmLnNlbGVjdGlvblN0YXJ0ICsgIiBhbmQg ZW5kIGlzICIgKyB0Zi5zZWxlY3Rpb25FbmQgKyAiLiI7CisgICAgfQorfQorPC9zY3JpcHQ+Cis8 L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9InRlc3QoKSI+Cis8cD5UZXN0cyBiZWhhdmlvciBvZiBjb2Rl IHRoYXQgY2FsbHMgc2VsZWN0KCkgaW5zaWRlIGFuIG9uY2xpY2sgaGFuZGxlci4gVGhlIGVudGly ZSBmaWVsZCBzaG91bGQgZW5kIHVwIHNlbGVjdGVkLjwvcD4KKzxwPlRoZSB0ZXN0IHJ1bnMgb25s eSB1bmRlciBEdW1wUmVuZGVyVHJlZSB3aXRoIGV2ZW50U2VuZGVyOyBpZiB5b3UgdGVzdCBieSBo YW5kIHRoZSB0ZXN0IHJlc3VsdCBiZWxvdyB3aWxsIHNheSBGQUlMLjwvcD4KKzxwPjxpbnB1dCB0 eXBlPSJ0ZXh0IiBpZD0idGYiIG9uY2xpY2s9InRoaXMuc2VsZWN0KCkiIHZhbHVlPSJpbnB1dCB0 ZXh0Ij48L2lucHV0PjwvcD4KKzxwIGlkPSJyZXN1bHQiPlRFU1QgTk9UIFJVTiBZRVQ8L3A+Cis8 L2JvZHk+Cis8L2h0bWw+CkluZGV4OiBXZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk0MTIpCisrKyBXZWJDb3JlL0NoYW5nZUxvZwko d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDA3LTAyLTA1ICBEYXJpbiBBZGxlciAg PGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAtIGZpeCBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MTUzNQorICAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80OTQ2OTU5PiBSRUdSRVNTSU9OOiBvbmNs aWNrPSJ0aGlzLnNlbGVjdCgpOyIgbm90IHdvcmtpbmcgb24gbmV3IGZvcm1zICgxMTUzNSkKKwor ICAgICAgICBUZXN0OiBmYXN0L2Zvcm1zL2lucHV0LXNlbGVjdC1vbi1jbGljay5odG1sCisKKyAg ICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5oOiBBZGRlZCBtX21vdXNlRG93bldhc1NpbmdsZUNs aWNrSW5TZWxlY3Rpb24gYm9vbGVhbi4KKyAgICAgICAgT3JnYW5pemVkIG90aGVyIGJvb2xlYW5z IGEgYml0IG1vcmUgbG9naWNhbGx5LgorICAgICAgICAqIHBhZ2UvRXZlbnRIYW5kbGVyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6RXZlbnRIYW5kbGVyKTogUmVhcnJhbmdl IG9yZGVyIHRvIG1hdGNoIEV2ZW50SGFuZGxlci5oLCBhZGQKKyAgICAgICAgbV9tb3VzZURvd25X YXNTaW5nbGVDbGlja0luU2VsZWN0aW9uIGluaXRpYWxpemF0aW9uLgorICAgICAgICAoV2ViQ29y ZTo6RXZlbnRIYW5kbGVyOjpoYW5kbGVNb3VzZVByZXNzRXZlbnRTaW5nbGVDbGljayk6IFNldCBt X21vdXNlRG93bldhc1NpbmdsZUNsaWNrSW5TZWxlY3Rpb24KKyAgICAgICAgdG8gdHJ1ZSBpbiB0 aGUgYXBwcm9wcmlhdGUgc3BlY2lhbCBjYXNlLgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRIYW5k bGVyOjpoYW5kbGVNb3VzZVByZXNzRXZlbnQpOiBTZXQgbV9tb3VzZURvd25XYXNTaW5nbGVDbGlj a0luU2VsZWN0aW9uIHRvIGZhbHNlLgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRIYW5kbGVyOjpo YW5kbGVNb3VzZVJlbGVhc2VFdmVudCk6IENoYW5nZSBjb2RlIHRvIGNsZWFyIHNlbGVjdGlvbiBv ciBzZXQgdG8gY2FyZXQgdG8KKyAgICAgICAgb25seSBmaXJlIGlmIG1fbW91c2VEb3duV2FzU2lu Z2xlQ2xpY2tJblNlbGVjdGlvbiB3YXMgdHJ1ZSByYXRoZXIgdGhhbiBmaXJpbmcgZm9yIGFueQor ICAgICAgICBtX21vdXNlRG93bk1heVN0YXJ0U2VsZWN0IGNhc2UuCisKIDIwMDctMDItMDUgIE1p dHogUGV0dGVsICA8bWl0ekB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkZWxl LgpJbmRleDogV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAJKHJldmlzaW9uIDE5NDEwKQorKysgV2ViQ29yZS9w YWdlL0V2ZW50SGFuZGxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTg3LDE4ICs4NywxOSBAQCBz dGF0aWMgRnJhbWUqIHN1YmZyYW1lRm9yVGFyZ2V0Tm9kZShOb2RlCiBFdmVudEhhbmRsZXI6OkV2 ZW50SGFuZGxlcihGcmFtZSogZnJhbWUpCiAgICAgOiBtX2ZyYW1lKGZyYW1lKQogICAgICwgbV9t b3VzZVByZXNzZWQoZmFsc2UpCisgICAgLCBtX21vdXNlRG93bk1heVN0YXJ0U2VsZWN0KGZhbHNl KQorICAgICwgbV9tb3VzZURvd25NYXlTdGFydERyYWcoZmFsc2UpCisgICAgLCBtX21vdXNlRG93 bldhc1NpbmdsZUNsaWNrSW5TZWxlY3Rpb24oZmFsc2UpCiAgICAgLCBtX2JlZ2FuU2VsZWN0aW5n VGV4dChmYWxzZSkKICAgICAsIG1faG92ZXJUaW1lcih0aGlzLCAmRXZlbnRIYW5kbGVyOjpob3Zl clRpbWVyRmlyZWQpCiAgICAgLCBtX2F1dG9zY3JvbGxUaW1lcih0aGlzLCAmRXZlbnRIYW5kbGVy OjphdXRvc2Nyb2xsVGltZXJGaXJlZCkKICAgICAsIG1fYXV0b3Njcm9sbFJlbmRlcmVyKDApCiAg ICAgLCBtX21vdXNlRG93bk1heVN0YXJ0QXV0b3Njcm9sbChmYWxzZSkKLSAgICAsIG1fbW91c2VE b3duTWF5U3RhcnREcmFnKGZhbHNlKQorICAgICwgbV9tb3VzZURvd25XYXNJblN1YmZyYW1lKGZh bHNlKQogICAgICwgbV9yZXNpemVMYXllcigwKQogICAgICwgbV9jYXB0dXJpbmdNb3VzZUV2ZW50 c05vZGUoMCkKICAgICAsIG1fY2xpY2tDb3VudCgwKQogICAgICwgbV9tb3VzZURvd25UaW1lc3Rh bXAoMCkKLSAgICAsIG1fbW91c2VEb3duV2FzSW5TdWJmcmFtZShmYWxzZSkKLSAgICAsIG1fbW91 c2VEb3duTWF5U3RhcnRTZWxlY3QoZmFsc2UpCiAjaWYgUExBVEZPUk0oTUFDKQogICAgICwgbV9t b3VzZURvd25WaWV3KG5pbCkKICAgICAsIG1fc2VuZGluZ0V2ZW50VG9TdWJ2aWV3KGZhbHNlKQpA QCAtMjE3LDggKzIxOCwxMCBAQCBib29sIEV2ZW50SGFuZGxlcjo6aGFuZGxlTW91c2VQcmVzc0V2 ZW50CiAgICAgLy8gRG9uJ3QgcmVzdGFydCB0aGUgc2VsZWN0aW9uIHdoZW4gdGhlIG1vdXNlIGlz IHByZXNzZWQgb24gYW4KICAgICAvLyBleGlzdGluZyBzZWxlY3Rpb24gc28gd2UgY2FuIGFsbG93 IGZvciB0ZXh0IGRyYWdnaW5nLgogICAgIEludFBvaW50IHZQb2ludCA9IG1fZnJhbWUtPnZpZXco KS0+d2luZG93VG9Db250ZW50cyhldmVudC5ldmVudCgpLnBvcygpKTsKLSAgICBpZiAoIWV4dGVu ZFNlbGVjdGlvbiAmJiBtX2ZyYW1lLT5zZWxlY3Rpb25Db250cm9sbGVyKCktPmNvbnRhaW5zKHZQ b2ludCkpCisgICAgaWYgKCFleHRlbmRTZWxlY3Rpb24gJiYgbV9mcmFtZS0+c2VsZWN0aW9uQ29u dHJvbGxlcigpLT5jb250YWlucyh2UG9pbnQpKSB7CisgICAgICAgIG1fbW91c2VEb3duV2FzU2lu Z2xlQ2xpY2tJblNlbGVjdGlvbiA9IHRydWU7CiAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB9 CiAKICAgICBWaXNpYmxlUG9zaXRpb24gdmlzaWJsZVBvcyhpbm5lck5vZGUtPnJlbmRlcmVyKCkt PnBvc2l0aW9uRm9yUG9pbnQoZXZlbnQubG9jYWxQb2ludCgpKSk7CiAgICAgaWYgKHZpc2libGVQ b3MuaXNOdWxsKCkpCkBAIC0yNjQsNiArMjY3LDggQEAgYm9vbCBFdmVudEhhbmRsZXI6OmhhbmRs ZU1vdXNlUHJlc3NFdmVudAogICAgIC8vIENhcmVmdWwgdGhhdCB0aGUgZHJhZyBzdGFydGluZyBs b2dpYyBzdGF5cyBpbiBzeW5jIHdpdGggZXZlbnRNYXlTdGFydERyYWcoKQogICAgIG1fbW91c2VE b3duTWF5U3RhcnREcmFnID0gc2luZ2xlQ2xpY2s7CiAKKyAgICBtX21vdXNlRG93bldhc1Npbmds ZUNsaWNrSW5TZWxlY3Rpb24gPSBmYWxzZTsKKwogICAgIGlmIChwYXNzV2lkZ2V0TW91c2VEb3du RXZlbnRUb1dpZGdldChldmVudCkpCiAgICAgICAgIHJldHVybiB0cnVlOwogCkBAIC00MjQsNyAr NDI5LDcgQEAgYm9vbCBFdmVudEhhbmRsZXI6OmhhbmRsZU1vdXNlUmVsZWFzZUV2ZQogICAgIC8v IENsZWFyIHRoZSBzZWxlY3Rpb24gaWYgdGhlIG1vdXNlIGRpZG4ndCBtb3ZlIGFmdGVyIHRoZSBs YXN0IG1vdXNlIHByZXNzLgogICAgIC8vIFdlIGRvIHRoaXMgc28gd2hlbiBjbGlja2luZyBvbiB0 aGUgc2VsZWN0aW9uLCB0aGUgc2VsZWN0aW9uIGdvZXMgYXdheS4KICAgICAvLyBIb3dldmVyLCBp ZiB3ZSBhcmUgZWRpdGluZywgcGxhY2UgdGhlIGNhcmV0LgotICAgIGlmIChtX21vdXNlRG93bk1h eVN0YXJ0U2VsZWN0ICYmICFtX2JlZ2FuU2VsZWN0aW5nVGV4dAorICAgIGlmIChtX21vdXNlRG93 bldhc1NpbmdsZUNsaWNrSW5TZWxlY3Rpb24gJiYgIW1fYmVnYW5TZWxlY3RpbmdUZXh0CiAgICAg ICAgICAgICAmJiBtX2RyYWdTdGFydFBvcyA9PSBldmVudC5ldmVudCgpLnBvcygpCiAgICAgICAg ICAgICAmJiBtX2ZyYW1lLT5zZWxlY3Rpb25Db250cm9sbGVyKCktPmlzUmFuZ2UoKSkgewogICAg ICAgICBTZWxlY3Rpb24gbmV3U2VsZWN0aW9uOwpJbmRleDogV2ViQ29yZS9wYWdlL0V2ZW50SGFu ZGxlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuaAkocmV2aXNp b24gMTk0MTApCisrKyBXZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmgJKHdvcmtpbmcgY29weSkK QEAgLTI1MSw2ICsyNTEsOSBAQCBwcml2YXRlOgogICAgIGJvb2wgbV9tb3VzZVByZXNzZWQ7CiAg ICAgUmVmUHRyPE5vZGU+IG1fbW91c2VQcmVzc05vZGU7CiAKKyAgICBib29sIG1fbW91c2VEb3du TWF5U3RhcnRTZWxlY3Q7CisgICAgYm9vbCBtX21vdXNlRG93bk1heVN0YXJ0RHJhZzsKKyAgICBi b29sIG1fbW91c2VEb3duV2FzU2luZ2xlQ2xpY2tJblNlbGVjdGlvbjsKICAgICBib29sIG1fYmVn YW5TZWxlY3RpbmdUZXh0OwogCiAgICAgSW50UG9pbnQgbV9kcmFnU3RhcnRQb3M7CkBAIC0yNjAs NyArMjYzLDcgQEAgcHJpdmF0ZToKICAgICBUaW1lcjxFdmVudEhhbmRsZXI+IG1fYXV0b3Njcm9s bFRpbWVyOwogICAgIFJlbmRlck9iamVjdCogbV9hdXRvc2Nyb2xsUmVuZGVyZXI7CiAgICAgYm9v bCBtX21vdXNlRG93bk1heVN0YXJ0QXV0b3Njcm9sbDsKLSAgICBib29sIG1fbW91c2VEb3duTWF5 U3RhcnREcmFnOworICAgIGJvb2wgbV9tb3VzZURvd25XYXNJblN1YmZyYW1lOwogCiAgICAgUmVu ZGVyTGF5ZXIqIG1fcmVzaXplTGF5ZXI7CiAKQEAgLTI4NCw5ICsyODcsNiBAQCBwcml2YXRlOgog ICAgIEludFBvaW50IG1fbW91c2VEb3duUG9zOyAvLyBpbiBvdXIgdmlldydzIGNvb3JkcwogICAg IGRvdWJsZSBtX21vdXNlRG93blRpbWVzdGFtcDsKIAotICAgIGJvb2wgbV9tb3VzZURvd25XYXNJ blN1YmZyYW1lOwotICAgIGJvb2wgbV9tb3VzZURvd25NYXlTdGFydFNlbGVjdDsKLQogI2lmIFBM QVRGT1JNKE1BQykKICAgICBOU1ZpZXcgKm1fbW91c2VEb3duVmlldzsKICAgICBib29sIG1fc2Vu ZGluZ0V2ZW50VG9TdWJ2aWV3Owo=