115344 2013-04-28 23:22:00 -0700 [WK2] Remove build warnings by -Wunused-parameter 2013-04-29 07:15:25 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jinwoo7.song jinwoo7.song cmarcelo commit-queue luiz noam zeno oldest_to_newest 882478 0 jinwoo7.song 2013-04-28 23:22:00 -0700 Fix build warnings occurred by -Wunused-parameter. 882479 1 199986 jinwoo7.song 2013-04-28 23:30:17 -0700 Created attachment 199986 Patch 882480 2 199986 noam 2013-04-28 23:35:31 -0700 Comment on attachment 199986 Patch LGTM, needs WK2 owner. 882517 3 199986 andersca 2013-04-29 06:02:18 -0700 Comment on attachment 199986 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199986&action=review > Source/WebKit2/UIProcess/DrawingAreaProxy.h:71 > + virtual void waitForPossibleGeometryUpdate(double timeout = didUpdateBackingStoreStateTimeout) { UNUSED_PARAM(timeout); } This can just be virtual void waitForPossibleGeometryUpdate(double = didUpdateBackingStoreStateTimeout) { } 882522 4 199997 jinwoo7.song 2013-04-29 06:15:28 -0700 Created attachment 199997 patch for landing. Applied Anders's comment. 882527 5 199997 commit-queue 2013-04-29 06:27:28 -0700 Comment on attachment 199997 patch for landing. Rejecting attachment 199997 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--non-interactive', 199997, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/195674 882546 6 199997 commit-queue 2013-04-29 07:15:23 -0700 Comment on attachment 199997 patch for landing. Clearing flags on attachment: 199997 Committed r149279: <http://trac.webkit.org/changeset/149279> 882547 7 commit-queue 2013-04-29 07:15:25 -0700 All reviewed patches have been landed. Closing bug. 199986 2013-04-28 23:30:17 -0700 2013-04-29 06:15:28 -0700 Patch bug-115344-20130429152933.patch text/plain 3098 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5MjY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTE4MTYwMmUzYjZkOWE3 YmJiOTIxMzc2MmZjNTYzYWUzY2Q0NmVlMC4uYzZkOTZiNjZmZWMyMjJiYjMwZmI0NDIyMWY1MzIx Mjg0ZThiNTQ5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA0LTI4ICBKaW53 b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbV0syXSBSZW1v dmUgYnVpbGQgd2FybmluZ3MgYnkgLVd1bnVzZWQtcGFyYW1ldGVyCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTUzNDQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggYnVpbGQgd2FybmlncyAtV3VudXNl ZC1wYXJhbWV0ZXIuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9X ZWJWaWV3LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmlldzo6Y3JlYXRlQ29udGV4dE1lbnVQ cm94eSk6CisgICAgICAgICogVUlQcm9jZXNzL0RyYXdpbmdBcmVhUHJveHkuaDoKKyAgICAgICAg KFdlYktpdDo6RHJhd2luZ0FyZWFQcm94eTo6d2FpdEZvclBvc3NpYmxlR2VvbWV0cnlVcGRhdGUp OgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0 OjpXZWJQYWdlUHJveHk6OmNvbm5lY3Rpb25XaWxsQ2xvc2UpOgorCiAyMDEzLTA0LTI4ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgVW5yZXZpZXdl ZCBmaXggYnVpbGQgYnJlYWsgb24gRUZMIHBvcnQgc2luY2UgcjE0OTI1OS4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL1dlYlZpZXcuY3Bw IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV2ViVmlldy5j cHAKaW5kZXggOTNmOGEyOWE3ZDYyZWUwYmFmZjU1ZTEwN2FlOTQ0ZGExNmUwMmNhNi4uZWI2YWJm MTU5OGE4ZDI5YWI2YmJjZGY3MDdiMTVmZDUwZDVlZTc0OCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV2ViVmlldy5jcHAKKysrIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV2ViVmlldy5jcHAKQEAg LTM2MSw3ICszNjEsNyBAQCBQYXNzUmVmUHRyPFdlYlBvcHVwTWVudVByb3h5PiBXZWJWaWV3Ojpj cmVhdGVQb3B1cE1lbnVQcm94eShXZWJQYWdlUHJveHkqIHBhZ2UpCiAgICAgcmV0dXJuIDA7CiB9 CiAKLVBhc3NSZWZQdHI8V2ViQ29udGV4dE1lbnVQcm94eT4gV2ViVmlldzo6Y3JlYXRlQ29udGV4 dE1lbnVQcm94eShXZWJQYWdlUHJveHkqIHBhZ2UpCitQYXNzUmVmUHRyPFdlYkNvbnRleHRNZW51 UHJveHk+IFdlYlZpZXc6OmNyZWF0ZUNvbnRleHRNZW51UHJveHkoV2ViUGFnZVByb3h5KikKIHsK ICAgICBub3RJbXBsZW1lbnRlZCgpOwogICAgIHJldHVybiAwOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0RyYXdpbmdBcmVhUHJveHkuaCBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9EcmF3aW5nQXJlYVByb3h5LmgKaW5kZXggNzgxZjJiYzkzOWNjMWEzYjA4YzMyNDA5 YTc3Y2E0MThiYjhlNGEwMS4uNDFiNzQ3ZjhiYjUwNDlmMmZiNWZmZDFjMzgwOGU3MTk1YTNhYTY5 NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0RyYXdpbmdBcmVhUHJveHku aAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvRHJhd2luZ0FyZWFQcm94eS5oCkBAIC02 OCw3ICs2OCw3IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgY29uc3QgZG91YmxlIGRpZFVwZGF0ZUJh Y2tpbmdTdG9yZVN0YXRlVGltZW91dDsKIAogICAgIHZpcnR1YWwgdm9pZCBwYWdlQ3VzdG9tUmVw cmVzZW50YXRpb25DaGFuZ2VkKCkgeyB9Ci0gICAgdmlydHVhbCB2b2lkIHdhaXRGb3JQb3NzaWJs ZUdlb21ldHJ5VXBkYXRlKGRvdWJsZSB0aW1lb3V0ID0gZGlkVXBkYXRlQmFja2luZ1N0b3JlU3Rh dGVUaW1lb3V0KSB7IH0KKyAgICB2aXJ0dWFsIHZvaWQgd2FpdEZvclBvc3NpYmxlR2VvbWV0cnlV cGRhdGUoZG91YmxlIHRpbWVvdXQgPSBkaWRVcGRhdGVCYWNraW5nU3RvcmVTdGF0ZVRpbWVvdXQp IHsgVU5VU0VEX1BBUkFNKHRpbWVvdXQpOyB9CiAKICAgICB2aXJ0dWFsIHZvaWQgY29sb3JTcGFj ZURpZENoYW5nZSgpIHsgfQogICAgIHZpcnR1YWwgdm9pZCBtaW5pbXVtTGF5b3V0V2lkdGhEaWRD aGFuZ2UoKSB7IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdl UHJveHkuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKaW5k ZXggZTc5MTExNjhlYzA0MzdiY2JhZTUxNGRkZjE5ZTI0Y2EzODBhZjcxOS4uZjY0ZTJhMmYzM2Rj OGQ2MmRjNmFkYmQ5MGZlNzU0NzdkZmU5MmFmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L1dlYlBhZ2VQcm94eS5jcHAKQEAgLTI2NTQsNyArMjY1NCw3IEBAIHZvaWQgV2ViUGFnZVByb3h5 Ojpjb25uZWN0aW9uV2lsbE9wZW4oQ29yZUlQQzo6Q29ubmVjdGlvbiogY29ubmVjdGlvbikKIAog dm9pZCBXZWJQYWdlUHJveHk6OmNvbm5lY3Rpb25XaWxsQ2xvc2UoQ29yZUlQQzo6Q29ubmVjdGlv biogY29ubmVjdGlvbikKIHsKLSAgICBBU1NFUlQoY29ubmVjdGlvbiA9PSBtX3Byb2Nlc3MtPmNv bm5lY3Rpb24oKSk7CisgICAgQVNTRVJUX1VOVVNFRChjb25uZWN0aW9uLCBjb25uZWN0aW9uID09 IG1fcHJvY2Vzcy0+Y29ubmVjdGlvbigpKTsKIAogICAgIG1fcHJvY2Vzcy0+Y29udGV4dCgpLT5z dG9yYWdlTWFuYWdlcigpLnNldEFsbG93ZWRTZXNzaW9uU3RvcmFnZU5hbWVzcGFjZUNvbm5lY3Rp b24obV9wYWdlSUQsIDApOwogfQo= 199997 2013-04-29 06:15:28 -0700 2013-04-29 07:15:23 -0700 patch for landing. bug-115344.patch text/plain 2775 jinwoo7.song ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1MTgxNjAyLi5jNmQ5NmI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTMtMDQtMjggIEppbndvbyBTb25nICA8amlud29vNy5zb25nQHNhbXN1bmcuY29tPgor CisgICAgICAgIFtXSzJdIFJlbW92ZSBidWlsZCB3YXJuaW5ncyBieSAtV3VudXNlZC1wYXJhbWV0 ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNTM0 NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBi dWlsZCB3YXJuaWdzIC1XdW51c2VkLXBhcmFtZXRlci4KKworICAgICAgICAqIFVJUHJvY2Vzcy9D b29yZGluYXRlZEdyYXBoaWNzL1dlYlZpZXcuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3 OjpjcmVhdGVDb250ZXh0TWVudVByb3h5KToKKyAgICAgICAgKiBVSVByb2Nlc3MvRHJhd2luZ0Fy ZWFQcm94eS5oOgorICAgICAgICAoV2ViS2l0OjpEcmF3aW5nQXJlYVByb3h5Ojp3YWl0Rm9yUG9z c2libGVHZW9tZXRyeVVwZGF0ZSk6CisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5j cHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6Y29ubmVjdGlvbldpbGxDbG9zZSk6 CisKIDIwMTMtMDQtMjggIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4K IAogICAgICAgICBVbnJldmlld2VkIGZpeCBidWlsZCBicmVhayBvbiBFRkwgcG9ydCBzaW5jZSBy MTQ5MjU5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVk R3JhcGhpY3MvV2ViVmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0 ZWRHcmFwaGljcy9XZWJWaWV3LmNwcAppbmRleCA5M2Y4YTI5Li5lYjZhYmYxIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9XZWJWaWV3LmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9XZWJW aWV3LmNwcApAQCAtMzYxLDcgKzM2MSw3IEBAIFBhc3NSZWZQdHI8V2ViUG9wdXBNZW51UHJveHk+ IFdlYlZpZXc6OmNyZWF0ZVBvcHVwTWVudVByb3h5KFdlYlBhZ2VQcm94eSogcGFnZSkKICAgICBy ZXR1cm4gMDsKIH0KIAotUGFzc1JlZlB0cjxXZWJDb250ZXh0TWVudVByb3h5PiBXZWJWaWV3Ojpj cmVhdGVDb250ZXh0TWVudVByb3h5KFdlYlBhZ2VQcm94eSogcGFnZSkKK1Bhc3NSZWZQdHI8V2Vi Q29udGV4dE1lbnVQcm94eT4gV2ViVmlldzo6Y3JlYXRlQ29udGV4dE1lbnVQcm94eShXZWJQYWdl UHJveHkqKQogewogICAgIG5vdEltcGxlbWVudGVkKCk7CiAgICAgcmV0dXJuIDA7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvRHJhd2luZ0FyZWFQcm94eS5oIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0RyYXdpbmdBcmVhUHJveHkuaAppbmRleCA3ODFmMmJjLi5mZWUy MzE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvRHJhd2luZ0FyZWFQcm94 eS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9EcmF3aW5nQXJlYVByb3h5LmgKQEAg LTY4LDcgKzY4LDcgQEAgcHVibGljOgogICAgIHN0YXRpYyBjb25zdCBkb3VibGUgZGlkVXBkYXRl QmFja2luZ1N0b3JlU3RhdGVUaW1lb3V0OwogCiAgICAgdmlydHVhbCB2b2lkIHBhZ2VDdXN0b21S ZXByZXNlbnRhdGlvbkNoYW5nZWQoKSB7IH0KLSAgICB2aXJ0dWFsIHZvaWQgd2FpdEZvclBvc3Np YmxlR2VvbWV0cnlVcGRhdGUoZG91YmxlIHRpbWVvdXQgPSBkaWRVcGRhdGVCYWNraW5nU3RvcmVT dGF0ZVRpbWVvdXQpIHsgfQorICAgIHZpcnR1YWwgdm9pZCB3YWl0Rm9yUG9zc2libGVHZW9tZXRy eVVwZGF0ZShkb3VibGUgPSBkaWRVcGRhdGVCYWNraW5nU3RvcmVTdGF0ZVRpbWVvdXQpIHsgfQog CiAgICAgdmlydHVhbCB2b2lkIGNvbG9yU3BhY2VEaWRDaGFuZ2UoKSB7IH0KICAgICB2aXJ0dWFs IHZvaWQgbWluaW11bUxheW91dFdpZHRoRGlkQ2hhbmdlKCkgeyB9CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCmluZGV4IGU3OTExMTYuLmY2NGUyYTIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCkBAIC0yNjU0LDcgKzI2NTQsNyBA QCB2b2lkIFdlYlBhZ2VQcm94eTo6Y29ubmVjdGlvbldpbGxPcGVuKENvcmVJUEM6OkNvbm5lY3Rp b24qIGNvbm5lY3Rpb24pCiAKIHZvaWQgV2ViUGFnZVByb3h5Ojpjb25uZWN0aW9uV2lsbENsb3Nl KENvcmVJUEM6OkNvbm5lY3Rpb24qIGNvbm5lY3Rpb24pCiB7Ci0gICAgQVNTRVJUKGNvbm5lY3Rp b24gPT0gbV9wcm9jZXNzLT5jb25uZWN0aW9uKCkpOworICAgIEFTU0VSVF9VTlVTRUQoY29ubmVj dGlvbiwgY29ubmVjdGlvbiA9PSBtX3Byb2Nlc3MtPmNvbm5lY3Rpb24oKSk7CiAKICAgICBtX3By b2Nlc3MtPmNvbnRleHQoKS0+c3RvcmFnZU1hbmFnZXIoKS5zZXRBbGxvd2VkU2Vzc2lvblN0b3Jh Z2VOYW1lc3BhY2VDb25uZWN0aW9uKG1fcGFnZUlELCAwKTsKIH0K