115320 2013-04-27 22:24:21 -0700 Unifty the data access of StringImpl members from JavaScriptCore 2013-04-29 18:22:05 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin oldest_to_newest 882358 0 benjamin 2013-04-27 22:24:21 -0700 Unifty the data access of StringImpl members from JavaScriptCore 882359 1 199958 benjamin 2013-04-27 22:29:13 -0700 Created attachment 199958 Patch 882529 2 199958 kling 2013-04-29 06:39:11 -0700 Comment on attachment 199958 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199958&action=review Cute cleanup. > Source/JavaScriptCore/ChangeLog:3 > + Unifty the data access of StringImpl members from JavaScriptCore Unifty -> Unify > Source/JavaScriptCore/ChangeLog:9 > + DFG access the member infos by directly calling the methods on StringImpl, > + while the baseline JIT was using helper methods on ThunkHelpers. access -> accesses 882883 3 benjamin 2013-04-29 18:22:05 -0700 Committed r149344: <http://trac.webkit.org/changeset/149344> 199958 2013-04-27 22:29:13 -0700 2013-04-29 06:39:11 -0700 Patch bug-115320-20130427222831.patch text/plain 7055 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5MjUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 YTUxYzM4NjkxN2FkMjlmZmJiNWQ2Yjk0ZjNkZTM5ZjVlZTg2NTQ2Li5lODgwZDE3YzhlOWRkZjQ1 NzE2NGQ0YzRlMDhlNzFiNDMyNTA4MjRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNSBAQAorMjAxMy0wNC0yNyAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtp dC5vcmc+CisKKyAgICAgICAgVW5pZnR5IHRoZSBkYXRhIGFjY2VzcyBvZiBTdHJpbmdJbXBsIG1l bWJlcnMgZnJvbSBKYXZhU2NyaXB0Q29yZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTE1MzIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgREZHIGFjY2VzcyB0aGUgbWVtYmVyIGluZm9zIGJ5IGRpcmVjdGx5 IGNhbGxpbmcgdGhlIG1ldGhvZHMgb24gU3RyaW5nSW1wbCwKKyAgICAgICAgd2hpbGUgdGhlIGJh c2VsaW5lIEpJVCB3YXMgdXNpbmcgaGVscGVyIG1ldGhvZHMgb24gVGh1bmtIZWxwZXJzLgorCisg ICAgICAgIEN1dCB0aGUgbWlkZGxlIG1hbiwgYW5kIHVzZSBTdHJpbmdJbXBsIGRpcmVjdGx5IGV2 ZXJ5d2hlcmUuCisKKyAgICAgICAgKiBqaXQvSklUSW5saW5lcy5oOgorICAgICAgICAoSlNDOjpK SVQ6OmVtaXRMb2FkQ2hhcmFjdGVyU3RyaW5nKToKKyAgICAgICAgKiBqaXQvSklUUHJvcGVydHlB Y2Nlc3MuY3BwOgorICAgICAgICAoSlNDOjpKSVQ6OnN0cmluZ0dldEJ5VmFsU3R1YkdlbmVyYXRv cik6CisgICAgICAgICogaml0L0pJVFByb3BlcnR5QWNjZXNzMzJfNjQuY3BwOgorICAgICAgICAo SlNDOjpKSVQ6OnN0cmluZ0dldEJ5VmFsU3R1YkdlbmVyYXRvcik6CisgICAgICAgICogaml0L0pT SW50ZXJmYWNlSklULmg6CisgICAgICAgICogaml0L1RodW5rR2VuZXJhdG9ycy5jcHA6CisgICAg ICAgIChKU0M6OnN0cmluZ0NoYXJMb2FkKToKKwogMjAxMy0wNC0yNSAgR2VvZmZyZXkgR2FyZW4g IDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIENsZWFuZWQgdXAgcHJlL3Bvc3QgaW5jL2Rl YyBpbiBieXRlY29kZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRJ bmxpbmVzLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVElubGluZXMuaAppbmRleCA1 ZmNiNzg2YmRlMTkzY2Q2ZmVlZmQ4MTYyNGIyNGM0Y2I0ZTU0YjQ3Li5iYjFkOWU3NWMxNTk1ZGU2 Y2MzZDI3NjU5ZWZkYWFiZjNiNDdmODI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvaml0L0pJVElubGluZXMuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVElu bGluZXMuaApAQCAtODIsMTIgKzgyLDEyIEBAIEFMV0FZU19JTkxJTkUgdm9pZCBKSVQ6OmVtaXRM b2FkQ2hhcmFjdGVyU3RyaW5nKFJlZ2lzdGVySUQgc3JjLCBSZWdpc3RlcklEIGRzdCwKICAgICBm YWlsdXJlcy5hcHBlbmQoYnJhbmNoMzIoTm90RXF1YWwsIE1hY3JvQXNzZW1ibGVyOjpBZGRyZXNz KHNyYywgVGh1bmtIZWxwZXJzOjpqc1N0cmluZ0xlbmd0aE9mZnNldCgpKSwgVHJ1c3RlZEltbTMy KDEpKSk7CiAgICAgbG9hZFB0cihNYWNyb0Fzc2VtYmxlcjo6QWRkcmVzcyhzcmMsIFRodW5rSGVs cGVyczo6anNTdHJpbmdWYWx1ZU9mZnNldCgpKSwgZHN0KTsKICAgICBmYWlsdXJlcy5hcHBlbmQo YnJhbmNoVGVzdDMyKFplcm8sIGRzdCkpOwotICAgIGxvYWRQdHIoTWFjcm9Bc3NlbWJsZXI6OkFk ZHJlc3MoZHN0LCBUaHVua0hlbHBlcnM6OnN0cmluZ0ltcGxGbGFnc09mZnNldCgpKSwgcmVnVDEp OwotICAgIGxvYWRQdHIoTWFjcm9Bc3NlbWJsZXI6OkFkZHJlc3MoZHN0LCBUaHVua0hlbHBlcnM6 OnN0cmluZ0ltcGxEYXRhT2Zmc2V0KCkpLCBkc3QpOworICAgIGxvYWRQdHIoTWFjcm9Bc3NlbWJs ZXI6OkFkZHJlc3MoZHN0LCBTdHJpbmdJbXBsOjpmbGFnc09mZnNldCgpKSwgcmVnVDEpOworICAg IGxvYWRQdHIoTWFjcm9Bc3NlbWJsZXI6OkFkZHJlc3MoZHN0LCBTdHJpbmdJbXBsOjpkYXRhT2Zm c2V0KCkpLCBkc3QpOwogCiAgICAgSnVtcExpc3QgaXMxNkJpdDsKICAgICBKdW1wTGlzdCBjb250 OEJpdDsKLSAgICBpczE2Qml0LmFwcGVuZChicmFuY2hUZXN0MzIoWmVybywgcmVnVDEsIFRydXN0 ZWRJbW0zMihUaHVua0hlbHBlcnM6OnN0cmluZ0ltcGw4Qml0RmxhZygpKSkpOworICAgIGlzMTZC aXQuYXBwZW5kKGJyYW5jaFRlc3QzMihaZXJvLCByZWdUMSwgVHJ1c3RlZEltbTMyKFN0cmluZ0lt cGw6OmZsYWdJczhCaXQoKSkpKTsKICAgICBsb2FkOChNYWNyb0Fzc2VtYmxlcjo6QWRkcmVzcyhk c3QsIDApLCBkc3QpOwogICAgIGNvbnQ4Qml0LmFwcGVuZChqdW1wKCkpOwogICAgIGlzMTZCaXQu bGluayh0aGlzKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUUHJv cGVydHlBY2Nlc3MuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRQcm9wZXJ0eUFj Y2Vzcy5jcHAKaW5kZXggOTUzZWQ3NTQ2NGE5MGUyZjdhNDdmYmQ2ZDdlODBlYWQ3Y2M0NzkyZC4u MmQxYjI5MjlkNzk5YmZjZjQxYTUwYTBlNTIwN2IyZDlkZDhkMGVmZCAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRQcm9wZXJ0eUFjY2Vzcy5jcHAKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2ppdC9KSVRQcm9wZXJ0eUFjY2Vzcy5jcHAKQEAgLTcxLDkgKzcxLDkg QEAgSklUOjpDb2RlUmVmIEpJVDo6c3RyaW5nR2V0QnlWYWxTdHViR2VuZXJhdG9yKFZNKiB2bSkK ICAgICBKdW1wTGlzdCBpczE2Qml0OwogICAgIEp1bXBMaXN0IGNvbnQ4Qml0OwogICAgIC8vIExv YWQgdGhlIHN0cmluZyBmbGFncwotICAgIGppdC5sb2FkUHRyKEFkZHJlc3MocmVnVDAsIFRodW5r SGVscGVyczo6c3RyaW5nSW1wbEZsYWdzT2Zmc2V0KCkpLCByZWdUMik7Ci0gICAgaml0LmxvYWRQ dHIoQWRkcmVzcyhyZWdUMCwgVGh1bmtIZWxwZXJzOjpzdHJpbmdJbXBsRGF0YU9mZnNldCgpKSwg cmVnVDApOwotICAgIGlzMTZCaXQuYXBwZW5kKGppdC5icmFuY2hUZXN0MzIoWmVybywgcmVnVDIs IFRydXN0ZWRJbW0zMihUaHVua0hlbHBlcnM6OnN0cmluZ0ltcGw4Qml0RmxhZygpKSkpOworICAg IGppdC5sb2FkUHRyKEFkZHJlc3MocmVnVDAsIFN0cmluZ0ltcGw6OmZsYWdzT2Zmc2V0KCkpLCBy ZWdUMik7CisgICAgaml0LmxvYWRQdHIoQWRkcmVzcyhyZWdUMCwgU3RyaW5nSW1wbDo6ZGF0YU9m ZnNldCgpKSwgcmVnVDApOworICAgIGlzMTZCaXQuYXBwZW5kKGppdC5icmFuY2hUZXN0MzIoWmVy bywgcmVnVDIsIFRydXN0ZWRJbW0zMihTdHJpbmdJbXBsOjpmbGFnSXM4Qml0KCkpKSk7CiAgICAg aml0LmxvYWQ4KEJhc2VJbmRleChyZWdUMCwgcmVnVDEsIFRpbWVzT25lLCAwKSwgcmVnVDApOwog ICAgIGNvbnQ4Qml0LmFwcGVuZChqaXQuanVtcCgpKTsKICAgICBpczE2Qml0LmxpbmsoJmppdCk7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFByb3BlcnR5QWNjZXNz MzJfNjQuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRQcm9wZXJ0eUFjY2VzczMy XzY0LmNwcAppbmRleCBjYWI1ZTY3MmY4ODM4ZmE1ZWJlZjA3NGJhMjYxZjJmMDg2ZDgyNDk4Li4x Y2M5OGVmNjZjOWY2OWJjYTMwOTE2YmYyYWRjNmFkYWY0Y2M0NzkwIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFByb3BlcnR5QWNjZXNzMzJfNjQuY3BwCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUUHJvcGVydHlBY2Nlc3MzMl82NC5jcHAKQEAgLTEx MCw5ICsxMTAsOSBAQCBKSVQ6OkNvZGVSZWYgSklUOjpzdHJpbmdHZXRCeVZhbFN0dWJHZW5lcmF0 b3IoVk0qIHZtKQogICAgIEp1bXBMaXN0IGlzMTZCaXQ7CiAgICAgSnVtcExpc3QgY29udDhCaXQ7 CiAgICAgLy8gTG9hZCB0aGUgc3RyaW5nIGZsYWdzCi0gICAgaml0LmxvYWRQdHIoQWRkcmVzcyhy ZWdUMCwgVGh1bmtIZWxwZXJzOjpzdHJpbmdJbXBsRmxhZ3NPZmZzZXQoKSksIHJlZ1QxKTsKLSAg ICBqaXQubG9hZFB0cihBZGRyZXNzKHJlZ1QwLCBUaHVua0hlbHBlcnM6OnN0cmluZ0ltcGxEYXRh T2Zmc2V0KCkpLCByZWdUMCk7Ci0gICAgaXMxNkJpdC5hcHBlbmQoaml0LmJyYW5jaFRlc3QzMiha ZXJvLCByZWdUMSwgVHJ1c3RlZEltbTMyKFRodW5rSGVscGVyczo6c3RyaW5nSW1wbDhCaXRGbGFn KCkpKSk7CisgICAgaml0LmxvYWRQdHIoQWRkcmVzcyhyZWdUMCwgU3RyaW5nSW1wbDo6ZmxhZ3NP ZmZzZXQoKSksIHJlZ1QxKTsKKyAgICBqaXQubG9hZFB0cihBZGRyZXNzKHJlZ1QwLCBTdHJpbmdJ bXBsOjpkYXRhT2Zmc2V0KCkpLCByZWdUMCk7CisgICAgaXMxNkJpdC5hcHBlbmQoaml0LmJyYW5j aFRlc3QzMihaZXJvLCByZWdUMSwgVHJ1c3RlZEltbTMyKFN0cmluZ0ltcGw6OmZsYWdJczhCaXQo KSkpKTsKICAgICBqaXQubG9hZDgoQmFzZUluZGV4KHJlZ1QwLCByZWdUMiwgVGltZXNPbmUsIDAp LCByZWdUMCk7CiAgICAgY29udDhCaXQuYXBwZW5kKGppdC5qdW1wKCkpOwogICAgIGlzMTZCaXQu bGluaygmaml0KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSlNJbnRl cmZhY2VKSVQuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSlNJbnRlcmZhY2VKSVQuaApp bmRleCA5OWMxODkwNzVkYmIwOWE2NmUyYThiNzNkNWQxNGI5Y2UyN2EyYWFmLi5kOTFlOTUzMmE4 ZDZmOGEwODZmNTVlZTFmNjI1ZTRiNGVlYTgzMTBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvaml0L0pTSW50ZXJmYWNlSklULmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L2ppdC9KU0ludGVyZmFjZUpJVC5oCkBAIC0yMTksOSArMjE5LDYgQEAgbmFtZXNwYWNlIEpTQyB7 CiAgICAgfTsKIAogICAgIHN0cnVjdCBUaHVua0hlbHBlcnMgewotICAgICAgICBzdGF0aWMgdW5z aWduZWQgc3RyaW5nSW1wbEZsYWdzT2Zmc2V0KCkgeyByZXR1cm4gU3RyaW5nSW1wbDo6ZmxhZ3NP ZmZzZXQoKTsgfQotICAgICAgICBzdGF0aWMgdW5zaWduZWQgc3RyaW5nSW1wbDhCaXRGbGFnKCkg eyByZXR1cm4gU3RyaW5nSW1wbDo6ZmxhZ0lzOEJpdCgpOyB9Ci0gICAgICAgIHN0YXRpYyB1bnNp Z25lZCBzdHJpbmdJbXBsRGF0YU9mZnNldCgpIHsgcmV0dXJuIFN0cmluZ0ltcGw6OmRhdGFPZmZz ZXQoKTsgfQogICAgICAgICBzdGF0aWMgdW5zaWduZWQganNTdHJpbmdMZW5ndGhPZmZzZXQoKSB7 IHJldHVybiBPQkpFQ1RfT0ZGU0VUT0YoSlNTdHJpbmcsIG1fbGVuZ3RoKTsgfQogICAgICAgICBz dGF0aWMgdW5zaWduZWQganNTdHJpbmdWYWx1ZU9mZnNldCgpIHsgcmV0dXJuIE9CSkVDVF9PRkZT RVRPRihKU1N0cmluZywgbV92YWx1ZSk7IH0KICAgICB9OwpkaWZmIC0tZ2l0IGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2ppdC9UaHVua0dlbmVyYXRvcnMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2ppdC9UaHVua0dlbmVyYXRvcnMuY3BwCmluZGV4IGE0NTA3ODkzYzBhMGZiOWVkZTJkNzA0 NDQ0MmQxYjY5MDVlNzU2ZjQuLmUyYzJkYzdmYTI0NTNhN2FjZmNiNzI2MTRhMTU1ZDBlMzQzNWIx YzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvVGh1bmtHZW5lcmF0b3Jz LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1RodW5rR2VuZXJhdG9ycy5jcHAK QEAgLTQzNiw5ICs0MzYsOSBAQCBzdGF0aWMgdm9pZCBzdHJpbmdDaGFyTG9hZChTcGVjaWFsaXpl ZFRodW5rSklUJiBqaXQsIFZNKiB2bSkKICAgICBTcGVjaWFsaXplZFRodW5rSklUOjpKdW1wTGlz dCBpczE2Qml0OwogICAgIFNwZWNpYWxpemVkVGh1bmtKSVQ6Okp1bXBMaXN0IGNvbnQ4Qml0Owog ICAgIC8vIExvYWQgdGhlIHN0cmluZyBmbGFncwotICAgIGppdC5sb2FkUHRyKE1hY3JvQXNzZW1i bGVyOjpBZGRyZXNzKFNwZWNpYWxpemVkVGh1bmtKSVQ6OnJlZ1QwLCBUaHVua0hlbHBlcnM6OnN0 cmluZ0ltcGxGbGFnc09mZnNldCgpKSwgU3BlY2lhbGl6ZWRUaHVua0pJVDo6cmVnVDIpOwotICAg IGppdC5sb2FkUHRyKE1hY3JvQXNzZW1ibGVyOjpBZGRyZXNzKFNwZWNpYWxpemVkVGh1bmtKSVQ6 OnJlZ1QwLCBUaHVua0hlbHBlcnM6OnN0cmluZ0ltcGxEYXRhT2Zmc2V0KCkpLCBTcGVjaWFsaXpl ZFRodW5rSklUOjpyZWdUMCk7Ci0gICAgaXMxNkJpdC5hcHBlbmQoaml0LmJyYW5jaFRlc3QzMihN YWNyb0Fzc2VtYmxlcjo6WmVybywgU3BlY2lhbGl6ZWRUaHVua0pJVDo6cmVnVDIsIE1hY3JvQXNz ZW1ibGVyOjpUcnVzdGVkSW1tMzIoVGh1bmtIZWxwZXJzOjpzdHJpbmdJbXBsOEJpdEZsYWcoKSkp KTsKKyAgICBqaXQubG9hZFB0cihNYWNyb0Fzc2VtYmxlcjo6QWRkcmVzcyhTcGVjaWFsaXplZFRo dW5rSklUOjpyZWdUMCwgU3RyaW5nSW1wbDo6ZmxhZ3NPZmZzZXQoKSksIFNwZWNpYWxpemVkVGh1 bmtKSVQ6OnJlZ1QyKTsKKyAgICBqaXQubG9hZFB0cihNYWNyb0Fzc2VtYmxlcjo6QWRkcmVzcyhT cGVjaWFsaXplZFRodW5rSklUOjpyZWdUMCwgU3RyaW5nSW1wbDo6ZGF0YU9mZnNldCgpKSwgU3Bl Y2lhbGl6ZWRUaHVua0pJVDo6cmVnVDApOworICAgIGlzMTZCaXQuYXBwZW5kKGppdC5icmFuY2hU ZXN0MzIoTWFjcm9Bc3NlbWJsZXI6Olplcm8sIFNwZWNpYWxpemVkVGh1bmtKSVQ6OnJlZ1QyLCBN YWNyb0Fzc2VtYmxlcjo6VHJ1c3RlZEltbTMyKFN0cmluZ0ltcGw6OmZsYWdJczhCaXQoKSkpKTsK ICAgICBqaXQubG9hZDgoTWFjcm9Bc3NlbWJsZXI6OkJhc2VJbmRleChTcGVjaWFsaXplZFRodW5r SklUOjpyZWdUMCwgU3BlY2lhbGl6ZWRUaHVua0pJVDo6cmVnVDEsIE1hY3JvQXNzZW1ibGVyOjpU aW1lc09uZSwgMCksIFNwZWNpYWxpemVkVGh1bmtKSVQ6OnJlZ1QwKTsKICAgICBjb250OEJpdC5h cHBlbmQoaml0Lmp1bXAoKSk7CiAgICAgaXMxNkJpdC5saW5rKCZqaXQpOwo=