115317 2013-04-27 17:03:40 -0700 WebGL shouldn't allocate a "length" Identifier just to move some numbers around 2013-04-27 17:08:14 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ggaren ggaren dino oldest_to_newest 882267 0 ggaren 2013-04-27 17:03:40 -0700 WebGL shouldn't allocate a "length" Identifier just to move some numbers around 882268 1 199924 ggaren 2013-04-27 17:05:48 -0700 Created attachment 199924 Patch 882269 2 ggaren 2013-04-27 17:08:14 -0700 Committed r149249: <http://trac.webkit.org/changeset/149249> 199924 2013-04-27 17:05:48 -0700 2013-04-27 17:06:44 -0700 Patch bug-115317-20130427170506.patch text/plain 4130 ggaren SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0OTI0OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDEzLTA0LTI3ICBHZW9mZnJl eSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViR0wgc2hvdWxkbid0IGFs bG9jYXRlIGEgImxlbmd0aCIgSWRlbnRpZmllciBqdXN0IHRvIG1vdmUgc29tZSBudW1iZXJzIGFy b3VuZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1 MzE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2F3 IHRoaXMgd2hpbGUgZGVidWdnaW5nIGFuIGFtbW8uanMgYnVnLgorCisgICAgICAgICogYmluZGlu Z3MvanMvSlNBcnJheUJ1ZmZlclZpZXdIZWxwZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6OnNldFdl YkdMQXJyYXlXaXRoVHlwZWRBcnJheUFyZ3VtZW50KToKKyAgICAgICAgKFdlYkNvcmU6OnNldFdl YkdMQXJyYXlIZWxwZXIpOgorICAgICAgICAoV2ViQ29yZTo6Y29uc3RydWN0QXJyYXlCdWZmZXJW aWV3V2l0aFR5cGVkQXJyYXlBcmd1bWVudCk6CisgICAgICAgIChXZWJDb3JlOjpjb25zdHJ1Y3RB cnJheUJ1ZmZlclZpZXcpOgorICAgICAgICAqIGJpbmRpbmdzL2pzL0pTV2ViR0xSZW5kZXJpbmdD b250ZXh0Q3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnRvVmVjdG9yKTogVXNlIHRoZSBw cmUtY29tcHV0ZWQgImxlbmd0aCIgaWRlbnRpZmllciBpbnN0ZWFkIG9mCisgICAgICAgIGFsbG9j YXRpbmcgYSBuZXcgb25lIGZvciBlYWNoIHZlY3RvciBvcGVyYXRpb24uIFRoZXJlIGFyZSBsb3Rz IG1vcmUKKyAgICAgICAgb3B0aW1pemF0aW9ucyB3ZSBjb3VsZCBkbyBoZXJlLiBUaGlzIGlzIGEg c3RhcnQuCisKIDIwMTMtMDQtMjcgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNv bT4KIAogICAgICAgICBSZW1vdmUgdHdvIG1vcmUgU3RvcmFnZVRhc2sgdHlwZXMKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTQXJyYXlCdWZmZXJWaWV3SGVscGVyLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNBcnJheUJ1ZmZlclZpZXdIZWxw ZXIuaAkocmV2aXNpb24gMTQ5MjQ4KQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNB cnJheUJ1ZmZlclZpZXdIZWxwZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMTE0LDcgKzExNCw3IEBA IGJvb2wgc2V0V2ViR0xBcnJheVdpdGhUeXBlZEFycmF5QXJndW1lbnQKICAgICBpZiAoZXhlYy0+ YXJndW1lbnRDb3VudCgpID09IDIpCiAgICAgICAgIG9mZnNldCA9IGV4ZWMtPmFyZ3VtZW50KDEp LnRvSW50MzIoZXhlYyk7CiAKLSAgICB1aW50MzJfdCBsZW5ndGggPSBhc09iamVjdChleGVjLT5h cmd1bWVudCgwKSktPmdldChleGVjLCBKU0M6OklkZW50aWZpZXIoZXhlYywgImxlbmd0aCIpKS50 b1VJbnQzMihleGVjKTsKKyAgICB1aW50MzJfdCBsZW5ndGggPSBhc09iamVjdChleGVjLT5hcmd1 bWVudCgwKSktPmdldChleGVjLCBleGVjLT52bSgpLnByb3BlcnR5TmFtZXMtPmxlbmd0aCkudG9V SW50MzIoZXhlYyk7CiAKICAgICBpZiAoIShjb3B5VHlwZWRBcnJheUJ1ZmZlcjxDLCBUPihpbXBs LCBhcnJheS5nZXQoKSwgbGVuZ3RoLCBvZmZzZXQpKSkKICAgICAgICAgdGhyb3dFcnJvcihleGVj LCBjcmVhdGVSYW5nZUVycm9yKGV4ZWMsICJJbmRleCBpcyBvdXQgb2YgcmFuZ2UuIikpOwpAQCAt MTM4LDcgKzEzOCw3IEBAIEpTQzo6SlNWYWx1ZSBzZXRXZWJHTEFycmF5SGVscGVyKEpTQzo6RXgK ICAgICAgICAgdWludDMyX3Qgb2Zmc2V0ID0gMDsKICAgICAgICAgaWYgKGV4ZWMtPmFyZ3VtZW50 Q291bnQoKSA9PSAyKQogICAgICAgICAgICAgb2Zmc2V0ID0gZXhlYy0+YXJndW1lbnQoMSkudG9J bnQzMihleGVjKTsKLSAgICAgICAgdWludDMyX3QgbGVuZ3RoID0gYXJyYXktPmdldChleGVjLCBK U0M6OklkZW50aWZpZXIoZXhlYywgImxlbmd0aCIpKS50b0ludDMyKGV4ZWMpOworICAgICAgICB1 aW50MzJfdCBsZW5ndGggPSBhcnJheS0+Z2V0KGV4ZWMsIGV4ZWMtPnZtKCkucHJvcGVydHlOYW1l cy0+bGVuZ3RoKS50b0ludDMyKGV4ZWMpOwogICAgICAgICBpZiAoIWltcGwtPmNoZWNrSW5ib3Vu ZERhdGEob2Zmc2V0LCBsZW5ndGgpKQogICAgICAgICAgICAgdGhyb3dFcnJvcihleGVjLCBjcmVh dGVSYW5nZUVycm9yKGV4ZWMsICJJbmRleCBpcyBvdXQgb2YgcmFuZ2UuIikpOwogICAgICAgICBl bHNlIHsKQEAgLTE2OSw3ICsxNjksNyBAQCBQYXNzUmVmUHRyPEM+IGNvbnN0cnVjdEFycmF5QnVm ZmVyVmlld1dpCiAgICAgaWYgKHNvdXJjZVR5cGUgPT0gQXJyYXlCdWZmZXJWaWV3OjpUeXBlRGF0 YVZpZXcpCiAgICAgICAgIHJldHVybiAwOwogCi0gICAgdWludDMyX3QgbGVuZ3RoID0gYXNPYmpl Y3QoZXhlYy0+YXJndW1lbnQoMCkpLT5nZXQoZXhlYywgSlNDOjpJZGVudGlmaWVyKGV4ZWMsICJs ZW5ndGgiKSkudG9VSW50MzIoZXhlYyk7CisgICAgdWludDMyX3QgbGVuZ3RoID0gYXNPYmplY3Qo ZXhlYy0+YXJndW1lbnQoMCkpLT5nZXQoZXhlYywgZXhlYy0+dm0oKS5wcm9wZXJ0eU5hbWVzLT5s ZW5ndGgpLnRvVUludDMyKGV4ZWMpOwogICAgIFJlZlB0cjxDPiBhcnJheSA9IEM6OmNyZWF0ZVVu aW5pdGlhbGl6ZWQobGVuZ3RoKTsKICAgICBpZiAoIWFycmF5KSB7CiAgICAgICAgIHRocm93RXJy b3IoZXhlYywgY3JlYXRlUmFuZ2VFcnJvcihleGVjLCB0b29MYXJnZVNpemUpKTsKQEAgLTI0NCw3 ICsyNDQsNyBAQCBQYXNzUmVmUHRyPEM+IGNvbnN0cnVjdEFycmF5QnVmZmVyVmlldyhKCiAgICAg ICAgICAgICByZXR1cm4gdmlldzsKIAogICAgICAgICBKU0M6OkpTT2JqZWN0KiBzcmNBcnJheSA9 IGFzT2JqZWN0KGV4ZWMtPmFyZ3VtZW50KDApKTsKLSAgICAgICAgdWludDMyX3QgbGVuZ3RoID0g c3JjQXJyYXktPmdldChleGVjLCBKU0M6OklkZW50aWZpZXIoZXhlYywgImxlbmd0aCIpKS50b1VJ bnQzMihleGVjKTsKKyAgICAgICAgdWludDMyX3QgbGVuZ3RoID0gc3JjQXJyYXktPmdldChleGVj LCBleGVjLT52bSgpLnByb3BlcnR5TmFtZXMtPmxlbmd0aCkudG9VSW50MzIoZXhlYyk7CiAgICAg ICAgIFJlZlB0cjxDPiBhcnJheSA9IEM6OmNyZWF0ZVVuaW5pdGlhbGl6ZWQobGVuZ3RoKTsKICAg ICAgICAgaWYgKCFhcnJheSkgewogICAgICAgICAgICAgdGhyb3dFcnJvcihleGVjLCBjcmVhdGVS YW5nZUVycm9yKGV4ZWMsIHRvb0xhcmdlU2l6ZSkpOwpJbmRleDogU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvanMvSlNXZWJHTFJlbmRlcmluZ0NvbnRleHRDdXN0b20uY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTV2ViR0xSZW5kZXJpbmdDb250ZXh0Q3VzdG9t LmNwcAkocmV2aXNpb24gMTQ5MjQ4KQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNX ZWJHTFJlbmRlcmluZ0NvbnRleHRDdXN0b20uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MjksNyAr NDI5LDcgQEAgYm9vbCB0b1ZlY3RvcihKU0M6OkV4ZWNTdGF0ZSogZXhlYywgSlNDOgogICAgICAg ICByZXR1cm4gZmFsc2U7CiAKICAgICBKU0M6OkpTT2JqZWN0KiBvYmplY3QgPSBhc09iamVjdCh2 YWx1ZSk7Ci0gICAgaW50MzJfdCBsZW5ndGggPSBvYmplY3QtPmdldChleGVjLCBKU0M6OklkZW50 aWZpZXIoZXhlYywgImxlbmd0aCIpKS50b0ludDMyKGV4ZWMpOworICAgIGludDMyX3QgbGVuZ3Ro ID0gb2JqZWN0LT5nZXQoZXhlYywgZXhlYy0+dm0oKS5wcm9wZXJ0eU5hbWVzLT5sZW5ndGgpLnRv SW50MzIoZXhlYyk7CiAKICAgICBpZiAoIXZlY3Rvci50cnlSZXNlcnZlQ2FwYWNpdHkobGVuZ3Ro KSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwo=