115316 2013-04-27 16:52:31 -0700 Do not allocate Static Strings for Notification::permissionString 2013-04-29 16:58:36 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin oldest_to_newest 882265 0 benjamin 2013-04-27 16:52:31 -0700 Do not allocate Static Strings for Notification::permissionString 882266 1 199923 benjamin 2013-04-27 16:56:13 -0700 Created attachment 199923 Patch 882273 2 199923 ggaren 2013-04-27 17:46:51 -0700 Comment on attachment 199923 Patch r=me 882836 3 199923 benjamin 2013-04-29 16:58:35 -0700 Comment on attachment 199923 Patch Clearing flags on attachment: 199923 Committed r149334: <http://trac.webkit.org/changeset/149334> 882837 4 benjamin 2013-04-29 16:58:36 -0700 All reviewed patches have been landed. Closing bug. 199923 2013-04-27 16:56:13 -0700 2013-04-29 16:58:34 -0700 Patch bug-115316-20130427165532.patch text/plain 3540 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5MjQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjUyZGQ5YmFmOTVkM2Y2 ODM1NDQ1Mjg2ZjE0Y2I3ZjgxN2FlNjFmMi4uYWU1ODRmOGNhNzIwYjRjY2MxZDY1ODRlODllMDU1 MmYyMjA3ZmU3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA0LTI3ICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBEbyBub3QgYWxs b2NhdGUgU3RhdGljIFN0cmluZ3MgZm9yIE5vdGlmaWNhdGlvbjo6cGVybWlzc2lvblN0cmluZwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1MzE2CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGNvZGUg aXMgbm90IG5lYXJseSBob3QgZW5vdWdoIHRvIGp1c3RpZnkga2VlcGluZyB0aGlzIG1lbW9yeSBh cm91bmQuCisKKyAgICAgICAgKiBNb2R1bGVzL25vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6Ok5vdGlmaWNhdGlvbjo6cGVybWlzc2lvbik6CisgICAgICAg IChXZWJDb3JlOjpOb3RpZmljYXRpb246OnBlcm1pc3Npb25TdHJpbmcpOgorICAgICAgICAqIE1v ZHVsZXMvbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb24uaDoKKyAgICAgICAgKE5vdGlmaWNhdGlv bik6CisKIDIwMTMtMDQtMjcgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4K IAogICAgICAgICBSZW1vdmUgdHdvIG1vcmUgU3RvcmFnZVRhc2sgdHlwZXMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb24uY3BwIGIv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9ub3RpZmljYXRpb25zL05vdGlmaWNhdGlvbi5jcHAKaW5k ZXggMWEzMThlMGMwYTBiNGI1OGU0ZTQ3NDA3NGJiYTljNDM2ZDk4YzkyMC4uNDgxMTg0ZjI2YWMx MWI0Mzg2OWQxYmFjNjEwYzQ1MDUwYzI1NzFlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9ub3RpZmljYXRpb25zL05vdGlmaWNhdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9ub3RpZmljYXRpb25zL05vdGlmaWNhdGlvbi5jcHAKQEAgLTIyNiwyOSArMjI2 LDI1IEBAIHZvaWQgTm90aWZpY2F0aW9uOjp0YXNrVGltZXJGaXJlZChUaW1lcjxOb3RpZmljYXRp b24+KiB0aW1lcikKIAogCiAjaWYgRU5BQkxFKE5PVElGSUNBVElPTlMpCi1jb25zdCBTdHJpbmcm IE5vdGlmaWNhdGlvbjo6cGVybWlzc2lvbihTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0 KQorY29uc3QgU3RyaW5nIE5vdGlmaWNhdGlvbjo6cGVybWlzc2lvbihTY3JpcHRFeGVjdXRpb25D b250ZXh0KiBjb250ZXh0KQogewogICAgIEFTU0VSVCh0b0RvY3VtZW50KGNvbnRleHQpLT5wYWdl KCkpOwogICAgIHJldHVybiBwZXJtaXNzaW9uU3RyaW5nKE5vdGlmaWNhdGlvbkNvbnRyb2xsZXI6 OmZyb20odG9Eb2N1bWVudChjb250ZXh0KS0+cGFnZSgpKS0+Y2xpZW50KCktPmNoZWNrUGVybWlz c2lvbihjb250ZXh0KSk7CiB9CiAKLWNvbnN0IFN0cmluZyYgTm90aWZpY2F0aW9uOjpwZXJtaXNz aW9uU3RyaW5nKE5vdGlmaWNhdGlvbkNsaWVudDo6UGVybWlzc2lvbiBwZXJtaXNzaW9uKQorY29u c3QgU3RyaW5nIE5vdGlmaWNhdGlvbjo6cGVybWlzc2lvblN0cmluZyhOb3RpZmljYXRpb25DbGll bnQ6OlBlcm1pc3Npb24gcGVybWlzc2lvbikKIHsKLSAgICBERUZJTkVfU1RBVElDX0xPQ0FMKGNv bnN0IFN0cmluZywgYWxsb3dlZFBlcm1pc3Npb24sIChBU0NJSUxpdGVyYWwoImdyYW50ZWQiKSkp OwotICAgIERFRklORV9TVEFUSUNfTE9DQUwoY29uc3QgU3RyaW5nLCBkZW5pZWRQZXJtaXNzaW9u LCAoQVNDSUlMaXRlcmFsKCJkZW5pZWQiKSkpOwotICAgIERFRklORV9TVEFUSUNfTE9DQUwoY29u c3QgU3RyaW5nLCBkZWZhdWx0UGVybWlzc2lvbiwgKEFTQ0lJTGl0ZXJhbCgiZGVmYXVsdCIpKSk7 Ci0KICAgICBzd2l0Y2ggKHBlcm1pc3Npb24pIHsKICAgICBjYXNlIE5vdGlmaWNhdGlvbkNsaWVu dDo6UGVybWlzc2lvbkFsbG93ZWQ6Ci0gICAgICAgIHJldHVybiBhbGxvd2VkUGVybWlzc2lvbjsK KyAgICAgICAgcmV0dXJuIEFTQ0lJTGl0ZXJhbCgiZ3JhbnRlZCIpOwogICAgIGNhc2UgTm90aWZp Y2F0aW9uQ2xpZW50OjpQZXJtaXNzaW9uRGVuaWVkOgotICAgICAgICByZXR1cm4gZGVuaWVkUGVy bWlzc2lvbjsKKyAgICAgICAgcmV0dXJuIEFTQ0lJTGl0ZXJhbCgiZGVuaWVkIik7CiAgICAgY2Fz ZSBOb3RpZmljYXRpb25DbGllbnQ6OlBlcm1pc3Npb25Ob3RBbGxvd2VkOgotICAgICAgICByZXR1 cm4gZGVmYXVsdFBlcm1pc3Npb247CisgICAgICAgIHJldHVybiBBU0NJSUxpdGVyYWwoImRlZmF1 bHQiKTsKICAgICB9CiAgICAgCiAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Ci0gICAgcmV0dXJu IGRlbmllZFBlcm1pc3Npb247CisgICAgcmV0dXJuIFN0cmluZygpOwogfQogCiB2b2lkIE5vdGlm aWNhdGlvbjo6cmVxdWVzdFBlcm1pc3Npb24oU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4 dCwgUGFzc1JlZlB0cjxOb3RpZmljYXRpb25QZXJtaXNzaW9uQ2FsbGJhY2s+IGNhbGxiYWNrKQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9ub3RpZmljYXRpb25zL05vdGlmaWNh dGlvbi5oIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9ub3RpZmljYXRpb25zL05vdGlmaWNhdGlv bi5oCmluZGV4IGZlYWYxZmIzYTEzOTVjNjdlNzc5N2Y5OTM1OTE0MmQ5MjI3NDNjOGUuLjAxYjdh NGM0ZjhmNmVmZTI3NmI1M2RhNGViN2E1Y2VkYjU4MmM4MTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb24uaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL25vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uLmgKQEAgLTEzNiw4ICsx MzYsOCBAQCBwdWJsaWM6CiAgICAgdm9pZCBmaW5hbGl6ZSgpOwogCiAjaWYgRU5BQkxFKE5PVElG SUNBVElPTlMpCi0gICAgc3RhdGljIGNvbnN0IFN0cmluZyYgcGVybWlzc2lvbihTY3JpcHRFeGVj dXRpb25Db250ZXh0Kik7Ci0gICAgc3RhdGljIGNvbnN0IFN0cmluZyYgcGVybWlzc2lvblN0cmlu ZyhOb3RpZmljYXRpb25DbGllbnQ6OlBlcm1pc3Npb24pOworICAgIHN0YXRpYyBjb25zdCBTdHJp bmcgcGVybWlzc2lvbihTY3JpcHRFeGVjdXRpb25Db250ZXh0Kik7CisgICAgc3RhdGljIGNvbnN0 IFN0cmluZyBwZXJtaXNzaW9uU3RyaW5nKE5vdGlmaWNhdGlvbkNsaWVudDo6UGVybWlzc2lvbik7 CiAgICAgc3RhdGljIHZvaWQgcmVxdWVzdFBlcm1pc3Npb24oU2NyaXB0RXhlY3V0aW9uQ29udGV4 dCosIFBhc3NSZWZQdHI8Tm90aWZpY2F0aW9uUGVybWlzc2lvbkNhbGxiYWNrPiA9IDApOwogI2Vu ZGlmCiAK