115315 2013-04-27 16:41:26 -0700 [WK2] Streamline the use of strings in WebProcess::getWebCoreStatistics 2013-04-29 16:55:51 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin oldest_to_newest 882263 0 benjamin 2013-04-27 16:41:26 -0700 [WK2] Streamline the use of strings in WebProcess::getWebCoreStatistics 882264 1 199922 benjamin 2013-04-27 16:43:49 -0700 Created attachment 199922 Patch 882272 2 199922 ggaren 2013-04-27 17:46:30 -0700 Comment on attachment 199922 Patch r=me 882832 3 199922 benjamin 2013-04-29 16:55:49 -0700 Comment on attachment 199922 Patch Clearing flags on attachment: 199922 Committed r149332: <http://trac.webkit.org/changeset/149332> 882833 4 benjamin 2013-04-29 16:55:51 -0700 All reviewed patches have been landed. Closing bug. 199922 2013-04-27 16:43:49 -0700 2013-04-29 16:55:49 -0700 Patch bug-115315-20130427164308.patch text/plain 6460 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5MjQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggM2U1MjE5ZGVkNTA2MjRm NWExNGYzZTY0YmQ0NjNjZTVjNjAzNDc5MS4uMDY4OTA4MWRjYTVkZTk4NWU2ODc1ZjA4YjQ0ZjQ4 MzI5NjdiYzBlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA0LTI3ICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBbV0syXSBTdHJl YW1saW5lIHRoZSB1c2Ugb2Ygc3RyaW5ncyBpbiBXZWJQcm9jZXNzOjpnZXRXZWJDb3JlU3RhdGlz dGljcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1 MzE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVt b3ZlIGEgY291cGxlIG9mIHVuanVzdGlmaWVkIERFRklORV9TVEFUSUNfTE9DQUwuCisgICAgICAg IFVzZSBBU0NJSUxpdGVyYWwgd2hlbiBhbGxvY2F0aW5nIG5ldyBTdHJpbmcuCisKKyAgICAgICAg KiBXZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwOgorICAgICAgICAoV2ViS2l0OjpnZXRXZWJDb3Jl TWVtb3J5Q2FjaGVTdGF0aXN0aWNzKToKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzczo6Z2V0 V2ViQ29yZVN0YXRpc3RpY3MpOgorCiAyMDEzLTA0LTI2ICBZYWVsIEFoYXJvbiAgPHlhZWwuYWhh cm9uQGludGVsLmNvbT4KIAogICAgICAgICBbV0syXVtFRkxdIEJ1aWxkIGJyZWFrIGFmdGVyIHIx NDkyMTIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5j cHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwCmluZGV4IDYxM2Y2 MzA5YTk2ODAyMjNjMzc0MTQ0NDQwOTJjZjEwNmM3ZTczOWIuLjE1NjI2YjI1NzM3ZGZjYzZlMGU3 YmJjOThmMzc4ZDJlZmNlOWI3YjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViUHJvY2Vzcy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQcm9j ZXNzLmNwcApAQCAtODg4LDEwICs4ODgsMTAgQEAgc3RhdGljIHZvaWQgZnJvbUNvdW50ZWRTZXRU b0hhc2hNYXAoVHlwZUNvdW50U2V0KiBjb3VudGVkU2V0LCBIYXNoTWFwPFN0cmluZywgdWkKIAog c3RhdGljIHZvaWQgZ2V0V2ViQ29yZU1lbW9yeUNhY2hlU3RhdGlzdGljcyhWZWN0b3I8SGFzaE1h cDxTdHJpbmcsIHVpbnQ2NF90PiA+JiByZXN1bHQpCiB7Ci0gICAgREVGSU5FX1NUQVRJQ19MT0NB TChTdHJpbmcsIGltYWdlc1N0cmluZywgKEFTQ0lJTGl0ZXJhbCgiSW1hZ2VzIikpKTsKLSAgICBE RUZJTkVfU1RBVElDX0xPQ0FMKFN0cmluZywgY3NzU3RyaW5nLCAoQVNDSUlMaXRlcmFsKCJDU1Mi KSkpOwotICAgIERFRklORV9TVEFUSUNfTE9DQUwoU3RyaW5nLCB4c2xTdHJpbmcsIChBU0NJSUxp dGVyYWwoIlhTTCIpKSk7Ci0gICAgREVGSU5FX1NUQVRJQ19MT0NBTChTdHJpbmcsIGphdmFTY3Jp cHRTdHJpbmcsIChBU0NJSUxpdGVyYWwoIkphdmFTY3JpcHQiKSkpOworICAgIFN0cmluZyBpbWFn ZXNTdHJpbmcoQVNDSUlMaXRlcmFsKCJJbWFnZXMiKSk7CisgICAgU3RyaW5nIGNzc1N0cmluZyhB U0NJSUxpdGVyYWwoIkNTUyIpKTsKKyAgICBTdHJpbmcgeHNsU3RyaW5nKEFTQ0lJTGl0ZXJhbCgi WFNMIikpOworICAgIFN0cmluZyBqYXZhU2NyaXB0U3RyaW5nKEFTQ0lJTGl0ZXJhbCgiSmF2YVNj cmlwdCIpKTsKICAgICAKICAgICBNZW1vcnlDYWNoZTo6U3RhdGlzdGljcyBtZW1vcnlDYWNoZVN0 YXRpc3RpY3MgPSBtZW1vcnlDYWNoZSgpLT5nZXRTdGF0aXN0aWNzKCk7CiAgICAgCkBAIC05NDUs MTAgKzk0NSwxMCBAQCB2b2lkIFdlYlByb2Nlc3M6OmdldFdlYkNvcmVTdGF0aXN0aWNzKHVpbnQ2 NF90IGNhbGxiYWNrSUQpCiAgICAgLy8gR2F0aGVyIEphdmFTY3JpcHQgc3RhdGlzdGljcy4KICAg ICB7CiAgICAgICAgIEpTTG9ja0hvbGRlciBsb2NrKEpTRE9NV2luZG93Ojpjb21tb25WTSgpKTsK LSAgICAgICAgZGF0YS5zdGF0aXN0aWNzTnVtYmVycy5zZXQoIkphdmFTY3JpcHRPYmplY3RzQ291 bnQiLCBKU0RPTVdpbmRvdzo6Y29tbW9uVk0oKS0+aGVhcC5vYmplY3RDb3VudCgpKTsKLSAgICAg ICAgZGF0YS5zdGF0aXN0aWNzTnVtYmVycy5zZXQoIkphdmFTY3JpcHRHbG9iYWxPYmplY3RzQ291 bnQiLCBKU0RPTVdpbmRvdzo6Y29tbW9uVk0oKS0+aGVhcC5nbG9iYWxPYmplY3RDb3VudCgpKTsK LSAgICAgICAgZGF0YS5zdGF0aXN0aWNzTnVtYmVycy5zZXQoIkphdmFTY3JpcHRQcm90ZWN0ZWRP YmplY3RzQ291bnQiLCBKU0RPTVdpbmRvdzo6Y29tbW9uVk0oKS0+aGVhcC5wcm90ZWN0ZWRPYmpl Y3RDb3VudCgpKTsKLSAgICAgICAgZGF0YS5zdGF0aXN0aWNzTnVtYmVycy5zZXQoIkphdmFTY3Jp cHRQcm90ZWN0ZWRHbG9iYWxPYmplY3RzQ291bnQiLCBKU0RPTVdpbmRvdzo6Y29tbW9uVk0oKS0+ aGVhcC5wcm90ZWN0ZWRHbG9iYWxPYmplY3RDb3VudCgpKTsKKyAgICAgICAgZGF0YS5zdGF0aXN0 aWNzTnVtYmVycy5zZXQoQVNDSUlMaXRlcmFsKCJKYXZhU2NyaXB0T2JqZWN0c0NvdW50IiksIEpT RE9NV2luZG93Ojpjb21tb25WTSgpLT5oZWFwLm9iamVjdENvdW50KCkpOworICAgICAgICBkYXRh LnN0YXRpc3RpY3NOdW1iZXJzLnNldChBU0NJSUxpdGVyYWwoIkphdmFTY3JpcHRHbG9iYWxPYmpl Y3RzQ291bnQiKSwgSlNET01XaW5kb3c6OmNvbW1vblZNKCktPmhlYXAuZ2xvYmFsT2JqZWN0Q291 bnQoKSk7CisgICAgICAgIGRhdGEuc3RhdGlzdGljc051bWJlcnMuc2V0KEFTQ0lJTGl0ZXJhbCgi SmF2YVNjcmlwdFByb3RlY3RlZE9iamVjdHNDb3VudCIpLCBKU0RPTVdpbmRvdzo6Y29tbW9uVk0o KS0+aGVhcC5wcm90ZWN0ZWRPYmplY3RDb3VudCgpKTsKKyAgICAgICAgZGF0YS5zdGF0aXN0aWNz TnVtYmVycy5zZXQoQVNDSUlMaXRlcmFsKCJKYXZhU2NyaXB0UHJvdGVjdGVkR2xvYmFsT2JqZWN0 c0NvdW50IiksIEpTRE9NV2luZG93Ojpjb21tb25WTSgpLT5oZWFwLnByb3RlY3RlZEdsb2JhbE9i amVjdENvdW50KCkpOwogICAgICAgICAKICAgICAgICAgT3duUHRyPFR5cGVDb3VudFNldD4gcHJv dGVjdGVkT2JqZWN0VHlwZUNvdW50cyhKU0RPTVdpbmRvdzo6Y29tbW9uVk0oKS0+aGVhcC5wcm90 ZWN0ZWRPYmplY3RUeXBlQ291bnRzKCkpOwogICAgICAgICBmcm9tQ291bnRlZFNldFRvSGFzaE1h cChwcm90ZWN0ZWRPYmplY3RUeXBlQ291bnRzLmdldCgpLCBkYXRhLmphdmFTY3JpcHRQcm90ZWN0 ZWRPYmplY3RUeXBlQ291bnRzKTsKQEAgLTk1NywyNyArOTU3LDI3IEBAIHZvaWQgV2ViUHJvY2Vz czo6Z2V0V2ViQ29yZVN0YXRpc3RpY3ModWludDY0X3QgY2FsbGJhY2tJRCkKICAgICAgICAgZnJv bUNvdW50ZWRTZXRUb0hhc2hNYXAob2JqZWN0VHlwZUNvdW50cy5nZXQoKSwgZGF0YS5qYXZhU2Ny aXB0T2JqZWN0VHlwZUNvdW50cyk7CiAgICAgICAgIAogICAgICAgICB1aW50NjRfdCBqYXZhU2Ny aXB0SGVhcFNpemUgPSBKU0RPTVdpbmRvdzo6Y29tbW9uVk0oKS0+aGVhcC5zaXplKCk7Ci0gICAg ICAgIGRhdGEuc3RhdGlzdGljc051bWJlcnMuc2V0KCJKYXZhU2NyaXB0SGVhcFNpemUiLCBqYXZh U2NyaXB0SGVhcFNpemUpOwotICAgICAgICBkYXRhLnN0YXRpc3RpY3NOdW1iZXJzLnNldCgiSmF2 YVNjcmlwdEZyZWVTaXplIiwgSlNET01XaW5kb3c6OmNvbW1vblZNKCktPmhlYXAuY2FwYWNpdHko KSAtIGphdmFTY3JpcHRIZWFwU2l6ZSk7CisgICAgICAgIGRhdGEuc3RhdGlzdGljc051bWJlcnMu c2V0KEFTQ0lJTGl0ZXJhbCgiSmF2YVNjcmlwdEhlYXBTaXplIiksIGphdmFTY3JpcHRIZWFwU2l6 ZSk7CisgICAgICAgIGRhdGEuc3RhdGlzdGljc051bWJlcnMuc2V0KEFTQ0lJTGl0ZXJhbCgiSmF2 YVNjcmlwdEZyZWVTaXplIiksIEpTRE9NV2luZG93Ojpjb21tb25WTSgpLT5oZWFwLmNhcGFjaXR5 KCkgLSBqYXZhU2NyaXB0SGVhcFNpemUpOwogICAgIH0KIAogICAgIFdURjo6RmFzdE1hbGxvY1N0 YXRpc3RpY3MgZmFzdE1hbGxvY1N0YXRpc3RpY3MgPSBXVEY6OmZhc3RNYWxsb2NTdGF0aXN0aWNz KCk7Ci0gICAgZGF0YS5zdGF0aXN0aWNzTnVtYmVycy5zZXQoIkZhc3RNYWxsb2NSZXNlcnZlZFZN Qnl0ZXMiLCBmYXN0TWFsbG9jU3RhdGlzdGljcy5yZXNlcnZlZFZNQnl0ZXMpOwotICAgIGRhdGEu c3RhdGlzdGljc051bWJlcnMuc2V0KCJGYXN0TWFsbG9jQ29tbWl0dGVkVk1CeXRlcyIsIGZhc3RN YWxsb2NTdGF0aXN0aWNzLmNvbW1pdHRlZFZNQnl0ZXMpOwotICAgIGRhdGEuc3RhdGlzdGljc051 bWJlcnMuc2V0KCJGYXN0TWFsbG9jRnJlZUxpc3RCeXRlcyIsIGZhc3RNYWxsb2NTdGF0aXN0aWNz LmZyZWVMaXN0Qnl0ZXMpOworICAgIGRhdGEuc3RhdGlzdGljc051bWJlcnMuc2V0KEFTQ0lJTGl0 ZXJhbCgiRmFzdE1hbGxvY1Jlc2VydmVkVk1CeXRlcyIpLCBmYXN0TWFsbG9jU3RhdGlzdGljcy5y ZXNlcnZlZFZNQnl0ZXMpOworICAgIGRhdGEuc3RhdGlzdGljc051bWJlcnMuc2V0KEFTQ0lJTGl0 ZXJhbCgiRmFzdE1hbGxvY0NvbW1pdHRlZFZNQnl0ZXMiKSwgZmFzdE1hbGxvY1N0YXRpc3RpY3Mu Y29tbWl0dGVkVk1CeXRlcyk7CisgICAgZGF0YS5zdGF0aXN0aWNzTnVtYmVycy5zZXQoQVNDSUlM aXRlcmFsKCJGYXN0TWFsbG9jRnJlZUxpc3RCeXRlcyIpLCBmYXN0TWFsbG9jU3RhdGlzdGljcy5m cmVlTGlzdEJ5dGVzKTsKICAgICAKICAgICAvLyBHYXRoZXIgaWNvbiBzdGF0aXN0aWNzLgotICAg IGRhdGEuc3RhdGlzdGljc051bWJlcnMuc2V0KCJJY29uUGFnZVVSTE1hcHBpbmdDb3VudCIsIGlj b25EYXRhYmFzZSgpLnBhZ2VVUkxNYXBwaW5nQ291bnQoKSk7Ci0gICAgZGF0YS5zdGF0aXN0aWNz TnVtYmVycy5zZXQoIkljb25SZXRhaW5lZFBhZ2VVUkxDb3VudCIsIGljb25EYXRhYmFzZSgpLnJl dGFpbmVkUGFnZVVSTENvdW50KCkpOwotICAgIGRhdGEuc3RhdGlzdGljc051bWJlcnMuc2V0KCJJ Y29uUmVjb3JkQ291bnQiLCBpY29uRGF0YWJhc2UoKS5pY29uUmVjb3JkQ291bnQoKSk7Ci0gICAg ZGF0YS5zdGF0aXN0aWNzTnVtYmVycy5zZXQoIkljb25zV2l0aERhdGFDb3VudCIsIGljb25EYXRh YmFzZSgpLmljb25SZWNvcmRDb3VudFdpdGhEYXRhKCkpOworICAgIGRhdGEuc3RhdGlzdGljc051 bWJlcnMuc2V0KEFTQ0lJTGl0ZXJhbCgiSWNvblBhZ2VVUkxNYXBwaW5nQ291bnQiKSwgaWNvbkRh dGFiYXNlKCkucGFnZVVSTE1hcHBpbmdDb3VudCgpKTsKKyAgICBkYXRhLnN0YXRpc3RpY3NOdW1i ZXJzLnNldChBU0NJSUxpdGVyYWwoIkljb25SZXRhaW5lZFBhZ2VVUkxDb3VudCIpLCBpY29uRGF0 YWJhc2UoKS5yZXRhaW5lZFBhZ2VVUkxDb3VudCgpKTsKKyAgICBkYXRhLnN0YXRpc3RpY3NOdW1i ZXJzLnNldChBU0NJSUxpdGVyYWwoIkljb25SZWNvcmRDb3VudCIpLCBpY29uRGF0YWJhc2UoKS5p Y29uUmVjb3JkQ291bnQoKSk7CisgICAgZGF0YS5zdGF0aXN0aWNzTnVtYmVycy5zZXQoQVNDSUlM aXRlcmFsKCJJY29uc1dpdGhEYXRhQ291bnQiKSwgaWNvbkRhdGFiYXNlKCkuaWNvblJlY29yZENv dW50V2l0aERhdGEoKSk7CiAgICAgCiAgICAgLy8gR2F0aGVyIGZvbnQgc3RhdGlzdGljcy4KLSAg ICBkYXRhLnN0YXRpc3RpY3NOdW1iZXJzLnNldCgiQ2FjaGVkRm9udERhdGFDb3VudCIsIGZvbnRD YWNoZSgpLT5mb250RGF0YUNvdW50KCkpOwotICAgIGRhdGEuc3RhdGlzdGljc051bWJlcnMuc2V0 KCJDYWNoZWRGb250RGF0YUluYWN0aXZlQ291bnQiLCBmb250Q2FjaGUoKS0+aW5hY3RpdmVGb250 RGF0YUNvdW50KCkpOworICAgIGRhdGEuc3RhdGlzdGljc051bWJlcnMuc2V0KEFTQ0lJTGl0ZXJh bCgiQ2FjaGVkRm9udERhdGFDb3VudCIpLCBmb250Q2FjaGUoKS0+Zm9udERhdGFDb3VudCgpKTsK KyAgICBkYXRhLnN0YXRpc3RpY3NOdW1iZXJzLnNldChBU0NJSUxpdGVyYWwoIkNhY2hlZEZvbnRE YXRhSW5hY3RpdmVDb3VudCIpLCBmb250Q2FjaGUoKS0+aW5hY3RpdmVGb250RGF0YUNvdW50KCkp OwogICAgIAogICAgIC8vIEdhdGhlciBnbHlwaCBwYWdlIHN0YXRpc3RpY3MuCi0gICAgZGF0YS5z dGF0aXN0aWNzTnVtYmVycy5zZXQoIkdseXBoUGFnZUNvdW50IiwgR2x5cGhQYWdlVHJlZU5vZGU6 OnRyZWVHbHlwaFBhZ2VDb3VudCgpKTsKKyAgICBkYXRhLnN0YXRpc3RpY3NOdW1iZXJzLnNldChB U0NJSUxpdGVyYWwoIkdseXBoUGFnZUNvdW50IiksIEdseXBoUGFnZVRyZWVOb2RlOjp0cmVlR2x5 cGhQYWdlQ291bnQoKSk7CiAgICAgCiAgICAgLy8gR2V0IFdlYkNvcmUgbWVtb3J5IGNhY2hlIHN0 YXRpc3RpY3MKICAgICBnZXRXZWJDb3JlTWVtb3J5Q2FjaGVTdGF0aXN0aWNzKGRhdGEud2ViQ29y ZUNhY2hlU3RhdGlzdGljcyk7Cg==