115312 2013-04-27 13:51:16 -0700 Remove two more StorageTask types 2013-04-27 20:18:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca commit-queue rniwa oldest_to_newest 882220 0 andersca 2013-04-27 13:51:16 -0700 Remove two more StorageTask types 882221 1 199914 andersca 2013-04-27 13:51:58 -0700 Created attachment 199914 Patch 882222 2 199914 dino 2013-04-27 13:53:04 -0700 Comment on attachment 199914 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199914&action=review > Source/WebCore/storage/StorageTask.h:41 > + enum Type { Dispatch }; Any point in this now? 882223 3 commit-queue 2013-04-27 13:53:26 -0700 Attachment 199914 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/storage/StorageTask.cpp', u'Source/WebCore/storage/StorageTask.h', u'Source/WebCore/storage/StorageTracker.cpp', u'Source/WebCore/storage/StorageTracker.h']" exit_code: 1 Source/WebCore/storage/StorageTracker.cpp:305: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 882224 4 andersca 2013-04-27 13:54:41 -0700 Committed r149245: <http://trac.webkit.org/changeset/149245> 882282 5 rniwa 2013-04-27 20:18:29 -0700 This patch broke Windows builds: http://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/66210/steps/compile-webkit/logs/stdio 199914 2013-04-27 13:51:58 -0700 2013-04-27 13:53:03 -0700 Patch bug-115312-20130427135116.patch text/plain 6149 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5MjQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzY0MTI1Y2E0ODc2Nzkx ZmM4NTk2ZDI4MjUxYjQzNTM2ODVjZTBkMy4uYTQyZGE0ZTA4ZmM2YTVkYTQyMzZhMmEyNTVlYTU0 ZmIxZDRhZjIyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEzLTA0LTI3ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgUmVtb3ZlIHR3byBt b3JlIFN0b3JhZ2VUYXNrIHR5cGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMTUzMTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIHN0b3JhZ2UvU3RvcmFnZVRhc2suY3BwOgorICAgICAgICAoV2ViQ29y ZTo6U3RvcmFnZVRhc2s6OnBlcmZvcm1UYXNrKToKKyAgICAgICAgKiBzdG9yYWdlL1N0b3JhZ2VU YXNrLmg6CisgICAgICAgICogc3RvcmFnZS9TdG9yYWdlVHJhY2tlci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpTdG9yYWdlVHJhY2tlcjo6c2V0T3JpZ2luRGV0YWlscyk6CisgICAgICAgIChXZWJD b3JlOjpTdG9yYWdlVHJhY2tlcjo6ZGVsZXRlT3JpZ2luKToKKyAgICAgICAgKiBzdG9yYWdlL1N0 b3JhZ2VUcmFja2VyLmg6CisKKzIwMTMtMDQtMjcgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2Nh QGFwcGxlLmNvbT4KKwogICAgICAgICBHZXQgcmlkIG9mIG1vcmUgdXNlcyBvZiBTdG9yYWdlVGFz awogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1MzEx CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvU3RvcmFnZVRhc2suY3BwIGIv U291cmNlL1dlYkNvcmUvc3RvcmFnZS9TdG9yYWdlVGFzay5jcHAKaW5kZXggMGQzZmI2ZDkzMTMx ZWNlYWFiOGViMDBjYzczOTg2NWI3Y2ZmZGFjMi4uODZjMzQ3NDY3ZDdiYmRiNDVkMjc3NjQyYjdl YTBmOTcyN2U4ZjY1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3RvcmFnZS9TdG9yYWdl VGFzay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvc3RvcmFnZS9TdG9yYWdlVGFzay5jcHAKQEAg LTQwLDIxICs0MCw2IEBAIFN0b3JhZ2VUYXNrOjpTdG9yYWdlVGFzayhUeXBlIHR5cGUsIGNvbnN0 IEZ1bmN0aW9uPHZvaWQoKT4mIGZ1bmN0aW9uKQogICAgIEFTU0VSVChtX3R5cGUgPT0gRGlzcGF0 Y2gpOwogfQogCi1TdG9yYWdlVGFzazo6U3RvcmFnZVRhc2soVHlwZSB0eXBlLCBjb25zdCBTdHJp bmcmIG9yaWdpbklkZW50aWZpZXIpCi0gICAgOiBtX3R5cGUodHlwZSkKLSAgICAsIG1fb3JpZ2lu SWRlbnRpZmllcihvcmlnaW5JZGVudGlmaWVyKQotewotICAgIEFTU0VSVChtX3R5cGUgPT0gRGVs ZXRlT3JpZ2luKTsKLX0KLQotU3RvcmFnZVRhc2s6OlN0b3JhZ2VUYXNrKFR5cGUgdHlwZSwgY29u c3QgU3RyaW5nJiBvcmlnaW5JZGVudGlmaWVyLCBjb25zdCBTdHJpbmcmIGRhdGFiYXNlRmlsZW5h bWUpCi0gICAgOiBtX3R5cGUodHlwZSkKLSAgICAsIG1fb3JpZ2luSWRlbnRpZmllcihvcmlnaW5J ZGVudGlmaWVyKQotICAgICwgbV9kYXRhYmFzZUZpbGVuYW1lKGRhdGFiYXNlRmlsZW5hbWUpCi17 Ci0gICAgQVNTRVJUKG1fdHlwZSA9PSBTZXRPcmlnaW5EZXRhaWxzKTsKLX0KLQogU3RvcmFnZVRh c2s6On5TdG9yYWdlVGFzaygpCiB7CiB9CkBAIC02NSwxMiArNTAsNiBAQCB2b2lkIFN0b3JhZ2VU YXNrOjpwZXJmb3JtVGFzaygpCiAgICAgICAgIGNhc2UgRGlzcGF0Y2g6CiAgICAgICAgICAgICBt X2Z1bmN0aW9uKCk7CiAgICAgICAgICAgICBicmVhazsKLSAgICAgICAgY2FzZSBTZXRPcmlnaW5E ZXRhaWxzOgotICAgICAgICAgICAgU3RvcmFnZVRyYWNrZXI6OnRyYWNrZXIoKS5zeW5jU2V0T3Jp Z2luRGV0YWlscyhtX29yaWdpbklkZW50aWZpZXIsIG1fZGF0YWJhc2VGaWxlbmFtZSk7Ci0gICAg ICAgICAgICBicmVhazsKLSAgICAgICAgY2FzZSBEZWxldGVPcmlnaW46Ci0gICAgICAgICAgICBT dG9yYWdlVHJhY2tlcjo6dHJhY2tlcigpLnN5bmNEZWxldGVPcmlnaW4obV9vcmlnaW5JZGVudGlm aWVyKTsKLSAgICAgICAgICAgIGJyZWFrOwogICAgIH0KIH0KIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvc3RvcmFnZS9TdG9yYWdlVGFzay5oIGIvU291cmNlL1dlYkNvcmUvc3RvcmFnZS9T dG9yYWdlVGFzay5oCmluZGV4IDFjOGVjNThkMjBiMjU3YmQxMjQwOWZhM2U1MDhkMjA1ZDBhZjg4 MjAuLmU4YmIyYTY1NTExMzc3MmRhMWQyOWI4ODBiMzFiYzNhODY1Njc4YTggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvU3RvcmFnZVRhc2suaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9zdG9yYWdlL1N0b3JhZ2VUYXNrLmgKQEAgLTM4LDI1ICszOCwxOSBAQCBuYW1lc3BhY2UgV2Vi Q29yZSB7CiAgICAgY2xhc3MgU3RvcmFnZVRhc2sgewogICAgICAgICBXVEZfTUFLRV9OT05DT1BZ QUJMRShTdG9yYWdlVGFzayk7IFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwogICAgIHB1YmxpYzoK LSAgICAgICAgZW51bSBUeXBlIHsgRGlzcGF0Y2gsIFNldE9yaWdpbkRldGFpbHMsIERlbGV0ZU9y aWdpbiB9OworICAgICAgICBlbnVtIFR5cGUgeyBEaXNwYXRjaCB9OwogCiAgICAgICAgIH5TdG9y YWdlVGFzaygpOwogCiAgICAgICAgIHN0YXRpYyBQYXNzT3duUHRyPFN0b3JhZ2VUYXNrPiBjcmVh dGVEaXNwYXRjaChjb25zdCBGdW5jdGlvbjx2b2lkKCk+JiBmdW5jdGlvbikgeyByZXR1cm4gYWRv cHRQdHIobmV3IFN0b3JhZ2VUYXNrKERpc3BhdGNoLCBmdW5jdGlvbikpOyB9Ci0gICAgICAgIHN0 YXRpYyBQYXNzT3duUHRyPFN0b3JhZ2VUYXNrPiBjcmVhdGVTZXRPcmlnaW5EZXRhaWxzKGNvbnN0 IFN0cmluZyYgb3JpZ2luSWRlbnRpZmllciwgY29uc3QgU3RyaW5nJiBkYXRhYmFzZUZpbGVuYW1l KSB7IHJldHVybiBhZG9wdFB0cihuZXcgU3RvcmFnZVRhc2soU2V0T3JpZ2luRGV0YWlscywgb3Jp Z2luSWRlbnRpZmllciwgZGF0YWJhc2VGaWxlbmFtZSkpOyB9Ci0gICAgICAgIHN0YXRpYyBQYXNz T3duUHRyPFN0b3JhZ2VUYXNrPiBjcmVhdGVEZWxldGVPcmlnaW4oY29uc3QgU3RyaW5nJiBvcmln aW5JZGVudGlmaWVyKSB7IHJldHVybiBhZG9wdFB0cihuZXcgU3RvcmFnZVRhc2soRGVsZXRlT3Jp Z2luLCBvcmlnaW5JZGVudGlmaWVyKSk7IH0KIAogICAgICAgICB2b2lkIHBlcmZvcm1UYXNrKCk7 CiAKICAgICBwcml2YXRlOgogICAgICAgICBTdG9yYWdlVGFzayhUeXBlLCBjb25zdCBGdW5jdGlv bjx2b2lkKCk+Jik7Ci0gICAgICAgIFN0b3JhZ2VUYXNrKFR5cGUsIGNvbnN0IFN0cmluZyYgb3Jp Z2luSWRlbnRpZmllcik7Ci0gICAgICAgIFN0b3JhZ2VUYXNrKFR5cGUsIGNvbnN0IFN0cmluZyYg b3JpZ2luSWRlbnRpZmllciwgY29uc3QgU3RyaW5nJiBkYXRhYmFzZUZpbGVuYW1lKTsKIAogICAg ICAgICBUeXBlIG1fdHlwZTsKICAgICAgICAgRnVuY3Rpb248dm9pZCAoKT4gbV9mdW5jdGlvbjsK LSAgICAgICAgU3RyaW5nIG1fb3JpZ2luSWRlbnRpZmllcjsKLSAgICAgICAgU3RyaW5nIG1fZGF0 YWJhc2VGaWxlbmFtZTsKICAgICB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9zdG9yYWdlL1N0b3JhZ2VUcmFja2VyLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3N0b3JhZ2UvU3RvcmFnZVRyYWNrZXIuY3BwCmluZGV4IGVmMzgyYmZjZDcwYTkzNTg5 YTA5MmE5NmViYjVjZTRkZTE0Y2M4NDguLjEyYmMzN2ZmY2Y1Nzc0ODhmZWMxYzYxZTg4ZWY1MDg3 NjYwNzI2ZDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvU3RvcmFnZVRyYWNr ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvU3RvcmFnZVRyYWNrZXIuY3BwCkBA IC0zMDIsMjMgKzMwMiwxNSBAQCB2b2lkIFN0b3JhZ2VUcmFja2VyOjpzZXRPcmlnaW5EZXRhaWxz KGNvbnN0IFN0cmluZyYgb3JpZ2luSWRlbnRpZmllciwgY29uc3QgU3RyaQogICAgICAgICBtX29y aWdpblNldC5hZGQob3JpZ2luSWRlbnRpZmllcik7CiAgICAgfQogCi0gICAgT3duUHRyPFN0b3Jh Z2VUYXNrPiB0YXNrID0gU3RvcmFnZVRhc2s6OmNyZWF0ZVNldE9yaWdpbkRldGFpbHMob3JpZ2lu SWRlbnRpZmllci5pc29sYXRlZENvcHkoKSwgZGF0YWJhc2VGaWxlKTsKKyAgICBGdW5jdGlvbjx2 b2lkICgpPiBmdW5jdGlvbiA9IGJpbmQoJlN0b3JhZ2VUcmFja2VyOjpzeW5jU2V0T3JpZ2luRGV0 YWlscywgdGhpcywgb3JpZ2luSWRlbnRpZmllci5pc29sYXRlZENvcHkoKSwgZGF0YWJhc2VGaWxl Lmlzb2xhdGVkQ29weSgpKTsKIAogICAgIGlmIChpc01haW5UaHJlYWQoKSkgewogICAgICAgICBB U1NFUlQobV90aHJlYWQpOwotICAgICAgICBtX3RocmVhZC0+c2NoZWR1bGVUYXNrKHRhc2sucmVs ZWFzZSgpKTsKLSAgICB9IGVsc2UgCi0gICAgICAgIGNhbGxPbk1haW5UaHJlYWQoc2NoZWR1bGVU YXNrLCByZWludGVycHJldF9jYXN0PHZvaWQqPih0YXNrLmxlYWtQdHIoKSkpOwotfQotCi12b2lk IFN0b3JhZ2VUcmFja2VyOjpzY2hlZHVsZVRhc2sodm9pZCogdGFza0luKQotewotICAgIEFTU0VS VChpc01haW5UaHJlYWQoKSk7Ci0gICAgQVNTRVJUKFN0b3JhZ2VUcmFja2VyOjp0cmFja2VyKCku bV90aHJlYWQpOwotICAgIAotICAgIE93blB0cjxTdG9yYWdlVGFzaz4gdGFzayA9IGFkb3B0UHRy KHJlaW50ZXJwcmV0X2Nhc3Q8U3RvcmFnZVRhc2sqPih0YXNrSW4pKTsKLQotICAgIFN0b3JhZ2VU cmFja2VyOjp0cmFja2VyKCkubV90aHJlYWQtPnNjaGVkdWxlVGFzayh0YXNrLnJlbGVhc2UoKSk7 CisgICAgICAgIG1fdGhyZWFkLT5kaXNwYXRjaChmdW5jdGlvbik7CisgICAgfSBlbHNlIHsKKyAg ICAgICAgLy8gRklYTUU6IFRoaXMgd2VpcmQgcGluZy1wb25naW5nIHdhcyBkb25lIHRvIGZpeCBh IGRlYWRsb2NrLiBXZSBzaG91bGQgZmlndXJlIG91dCBhIGNsZWFuZXIgd2F5IHRvIGF2b2lkIGl0 IGluc3RlYWQuCisgICAgICAgIGNhbGxPbk1haW5UaHJlYWQoYmluZCgmU3RvcmFnZVRocmVhZDo6 ZGlzcGF0Y2gsIG1fdGhyZWFkLmdldCgpLCBmdW5jdGlvbikpOworICAgIH0KIH0KIAogdm9pZCBT dG9yYWdlVHJhY2tlcjo6c3luY1NldE9yaWdpbkRldGFpbHMoY29uc3QgU3RyaW5nJiBvcmlnaW5J ZGVudGlmaWVyLCBjb25zdCBTdHJpbmcmIGRhdGFiYXNlRmlsZSkKQEAgLTQ4Myw4ICs0NzUsOCBA QCB2b2lkIFN0b3JhZ2VUcmFja2VyOjpkZWxldGVPcmlnaW4oU2VjdXJpdHlPcmlnaW4qIG9yaWdp bikKICAgICAgICAgd2lsbERlbGV0ZU9yaWdpbihvcmlnaW5JZCk7CiAgICAgICAgIG1fb3JpZ2lu U2V0LnJlbW92ZShvcmlnaW5JZCk7CiAgICAgfQotICAgIAotICAgIG1fdGhyZWFkLT5zY2hlZHVs ZVRhc2soU3RvcmFnZVRhc2s6OmNyZWF0ZURlbGV0ZU9yaWdpbihvcmlnaW5JZCkpOworCisgICAg bV90aHJlYWQtPmRpc3BhdGNoKGJpbmQoJlN0b3JhZ2VUcmFja2VyOjpzeW5jRGVsZXRlT3JpZ2lu LCB0aGlzLCBvcmlnaW5JZC5pc29sYXRlZENvcHkoKSkpOwogfQogCiB2b2lkIFN0b3JhZ2VUcmFj a2VyOjpzeW5jRGVsZXRlT3JpZ2luKGNvbnN0IFN0cmluZyYgb3JpZ2luSWRlbnRpZmllcikKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvU3RvcmFnZVRyYWNrZXIuaCBiL1NvdXJj ZS9XZWJDb3JlL3N0b3JhZ2UvU3RvcmFnZVRyYWNrZXIuaAppbmRleCA4MGVmMjEyYzE1NDhmZWJk NzYyMzgzNDJmNWEwYjIxODUyNzBlMzUwLi41MGFlMzIzZDY1OWI3ZTU5YmIxMGQ1ZDc4ZjU4MjY0 YTlmNDk2MjFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdG9yYWdlL1N0b3JhZ2VUcmFj a2VyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvc3RvcmFnZS9TdG9yYWdlVHJhY2tlci5oCkBAIC03 OSw3ICs3OSw2IEBAIHB1YmxpYzoKIAogcHJpdmF0ZToKICAgICBleHBsaWNpdCBTdG9yYWdlVHJh Y2tlcihjb25zdCBTdHJpbmcmIHN0b3JhZ2VQYXRoKTsKLSAgICBzdGF0aWMgdm9pZCBzY2hlZHVs ZVRhc2sodm9pZCopOwogCiAgICAgdm9pZCBpbnRlcm5hbEluaXRpYWxpemUoKTsKIAo=