115287 2013-04-26 16:19:42 -0700 ~BlockAllocator should ASSERT that it has no more Regions left 2013-04-29 12:51:19 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg oldest_to_newest 882070 0 mhahnenberg 2013-04-26 16:19:42 -0700 Title says it all. 882097 1 199879 mhahnenberg 2013-04-26 17:23:09 -0700 Created attachment 199879 Patch 882183 2 199879 kling 2013-04-27 09:52:51 -0700 Comment on attachment 199879 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199879&action=review r=me > Source/JavaScriptCore/heap/BlockAllocator.cpp:61 > + ASSERT(allRegionSetsAreEmpty() && m_emptyRegions.isEmpty()); You could make this two separate ASSERTs so it's easy to see which one is failing. > Source/JavaScriptCore/heap/BlockAllocator.h:75 > + bool isEmpty() I'd make this const. > Source/JavaScriptCore/heap/BlockAllocator.h:88 > + bool allRegionSetsAreEmpty(); Ditto. 882724 3 mhahnenberg 2013-04-29 12:51:19 -0700 Committed r149305: <http://trac.webkit.org/changeset/149305> 199879 2013-04-26 17:23:09 -0700 2013-04-27 09:52:51 -0700 Patch bug-115287-20130426172239.patch text/plain 2476 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ5MjI0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDEzLTA0LTI2ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgfkJsb2NrQWxsb2NhdG9yIHNob3VsZCBBU1NFUlQgdGhhdCBpdCBoYXMgbm8gbW9y ZSBSZWdpb25zIGxlZnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTExNTI4NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogaGVhcC9CbG9ja0FsbG9jYXRvci5jcHA6CisgICAgICAgIChKU0M6OkJsb2NrQWxs b2NhdG9yOjp+QmxvY2tBbGxvY2F0b3IpOgorICAgICAgICAoSlNDOjpCbG9ja0FsbG9jYXRvcjo6 YWxsUmVnaW9uU2V0c0FyZUVtcHR5KToKKyAgICAgICAgKiBoZWFwL0Jsb2NrQWxsb2NhdG9yLmg6 CisgICAgICAgIChSZWdpb25TZXQpOgorICAgICAgICAoSlNDOjpCbG9ja0FsbG9jYXRvcjo6UmVn aW9uU2V0Ojppc0VtcHR5KToKKyAgICAgICAgKEJsb2NrQWxsb2NhdG9yKToKKwogMjAxMy0wNC0y NiAgUm9nZXIgRm9uZyAgPHJvZ2VyX2ZvbmdAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgQXBw bGUgV2luZG93cyBWUzIwMTAgYnVpbGQgcmVzdWx0cyBpbnRvIGFuZCBnZXQgZGVwZW5kZW5jaWVz IGZyb20gX18zMiBzdWZmaXhlZCBmb2xkZXJzLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L2hlYXAvQmxvY2tBbGxvY2F0b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9oZWFwL0Jsb2NrQWxsb2NhdG9yLmNwcAkocmV2aXNpb24gMTQ5MjIwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL2hlYXAvQmxvY2tBbGxvY2F0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC01OCw2ICs1OCwxNSBAQCBCbG9ja0FsbG9jYXRvcjo6fkJsb2NrQWxsb2NhdG9yKCkKICAgICAg ICAgbV9lbXB0eVJlZ2lvbkNvbmRpdGlvbi5icm9hZGNhc3QoKTsKICAgICB9CiAgICAgd2FpdEZv clRocmVhZENvbXBsZXRpb24obV9ibG9ja0ZyZWVpbmdUaHJlYWQpOworICAgIEFTU0VSVChhbGxS ZWdpb25TZXRzQXJlRW1wdHkoKSAmJiBtX2VtcHR5UmVnaW9ucy5pc0VtcHR5KCkpOworfQorCiti b29sIEJsb2NrQWxsb2NhdG9yOjphbGxSZWdpb25TZXRzQXJlRW1wdHkoKQoreworICAgIHJldHVy biBtX2NvcGllZFJlZ2lvblNldC5pc0VtcHR5KCkKKyAgICAgICAgJiYgbV9tYXJrZWRSZWdpb25T ZXQuaXNFbXB0eSgpCisgICAgICAgICYmIG1fZm91cktCQmxvY2tSZWdpb25TZXQuaXNFbXB0eSgp CisgICAgICAgICYmIG1fd29ya0xpc3RSZWdpb25TZXQuaXNFbXB0eSgpOwogfQogCiB2b2lkIEJs b2NrQWxsb2NhdG9yOjpyZWxlYXNlRnJlZVJlZ2lvbnMoKQpJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL2hlYXAvQmxvY2tBbGxvY2F0b3IuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvaGVhcC9CbG9ja0FsbG9jYXRvci5oCShyZXZpc2lvbiAxNDkyMjApCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaGVhcC9CbG9ja0FsbG9jYXRvci5oCSh3b3JraW5nIGNvcHkpCkBA IC03MSw2ICs3MSwxMiBAQCBwcml2YXRlOgogICAgICAgICAgICAgLCBtX2Jsb2NrU2l6ZShibG9j a1NpemUpCiAgICAgICAgIHsKICAgICAgICAgfQorCisgICAgICAgIGJvb2wgaXNFbXB0eSgpCisg ICAgICAgIHsKKyAgICAgICAgICAgIHJldHVybiBtX2Z1bGxSZWdpb25zLmlzRW1wdHkoKSAmJiBt X3BhcnRpYWxSZWdpb25zLmlzRW1wdHkoKTsKKyAgICAgICAgfQorCiAgICAgICAgIERvdWJseUxp bmtlZExpc3Q8UmVnaW9uPiBtX2Z1bGxSZWdpb25zOwogICAgICAgICBEb3VibHlMaW5rZWRMaXN0 PFJlZ2lvbj4gbV9wYXJ0aWFsUmVnaW9uczsKICAgICAgICAgc2l6ZV90IG1fbnVtYmVyT2ZQYXJ0 aWFsUmVnaW9uczsKQEAgLTc5LDYgKzg1LDcgQEAgcHJpdmF0ZToKIAogICAgIERlYWRCbG9jayog dHJ5QWxsb2NhdGVGcm9tUmVnaW9uKFJlZ2lvblNldCYsIERvdWJseUxpbmtlZExpc3Q8UmVnaW9u PiYsIHNpemVfdCYpOwogCisgICAgYm9vbCBhbGxSZWdpb25TZXRzQXJlRW1wdHkoKTsKICAgICB2 b2lkIHJlbGVhc2VGcmVlUmVnaW9ucygpOwogCiAgICAgdGVtcGxhdGUgPHR5cGVuYW1lIFQ+IFJl Z2lvblNldCYgcmVnaW9uU2V0Rm9yKCk7Cg==