115280 2013-04-26 14:50:14 -0700 [BlackBerry] Fake-bold monospace fonts need to use non-fake-bold advances 2013-04-29 07:45:09 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 efidler efidler commit-queue oldest_to_newest 882038 0 efidler 2013-04-26 14:50:14 -0700 Bold versions of monospace fonts should have the same advance width as the regular version. iType's fake-bolding increases the advance width. 882041 1 199864 efidler 2013-04-26 14:53:24 -0700 Created attachment 199864 Patch 882559 2 199864 commit-queue 2013-04-29 07:45:08 -0700 Comment on attachment 199864 Patch Clearing flags on attachment: 199864 Committed r149282: <http://trac.webkit.org/changeset/149282> 882560 3 commit-queue 2013-04-29 07:45:09 -0700 All reviewed patches have been landed. Closing bug. 199864 2013-04-26 14:53:24 -0700 2013-04-29 07:45:08 -0700 Patch bug-115280-20130426175244.patch text/plain 4755 efidler U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5MTQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzAxZTFiNmE1YzJhMDQ4 NmQ2MGVkMGMzZjU1ZTY1ZGU2NDgwZTk5MC4uZWZhMTZjYTAyYjI0MjJhYTY5YmUxOWYzYWU5NGIw OGJiNDFiOTRiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTA0LTI2ICBFbGkg RmlkbGVyICA8ZWZpZGxlckBibGFja2JlcnJ5LmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0g RmFrZS1ib2xkIG1vbm9zcGFjZSBmb250cyBuZWVkIHRvIHVzZSBub24tZmFrZS1ib2xkIGFkdmFu Y2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTUy ODAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCbGFj a0JlcnJ5IFBSIDMzMDg2NAorCisgICAgICAgIFRlc3RlZCBieSBmYXN0L2Nzcy9jc3MzLWNoLXVu aXQuaHRtbAorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9Gb250UGxh dGZvcm1EYXRhQmxhY2tCZXJyeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGb250UGxhdGZvcm1E YXRhOjphcHBseVN0YXRlKToKKyAgICAgICAgKFdlYkNvcmU6OkZvbnRQbGF0Zm9ybURhdGE6Omlz Rml4ZWRQaXRjaCk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9JVHlw ZVV0aWxzLmg6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9TaW1wbGVG b250RGF0YUJsYWNrQmVycnkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2ltcGxlRm9udERhdGE6 OnBsYXRmb3JtV2lkdGhGb3JHbHlwaCk6CisKIDIwMTMtMDQtMjQgIE90dG8gRGVyZWsgQ2hldW5n ICA8b3RjaGV1bmdAcmltLmNvbT4KIAogICAgICAgICBCYXR0ZXJ5IEFQSSB3b24ndCByZXR1cm4g dXBkYXRlZCBiYXR0ZXJ5IHN0YXR1cyB1bnRpbCBjbGllbnQgY2FsbHMgZGlkQ2hhbmdlQmF0dGVy eVN0YXR1cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxh Y2tiZXJyeS9Gb250UGxhdGZvcm1EYXRhQmxhY2tCZXJyeS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0ZvbnRQbGF0Zm9ybURhdGFCbGFja0JlcnJ5LmNw cAppbmRleCA1ODQ1MzQ4NTdjNzlmNmE4YzA3MTMwZWM5YWZkZmNmYzQ4OGY5ZjJhLi41MzE5YjRh NGRkNzMwMjdiZTYyOTI5ODRlMGQ5ODVhZDcxZGYzYTJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0ZvbnRQbGF0Zm9ybURhdGFCbGFja0Jl cnJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5 L0ZvbnRQbGF0Zm9ybURhdGFCbGFja0JlcnJ5LmNwcApAQCAtNzUsNyArNzUsNyBAQCBib29sIEZv bnRQbGF0Zm9ybURhdGE6OmFwcGx5U3RhdGUoRlNfU1RBVEUqIGZvbnQsIGZsb2F0IHNjYWxlKSBj b25zdAogICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIGlmIChtX3N5bnRoZXRp Y0JvbGQpIHsKLSAgICAgICAgaWYgKEZTX3NldF9ib2xkX3BjdChmb250LCBmbG9hdFRvSVR5cGVG aXhlZCgwLjA2KSkgIT0gU1VDQ0VTUykgLy8gNiUgcHNldWRvIGJvbGQKKyAgICAgICAgaWYgKEZT X3NldF9ib2xkX3BjdChmb250LCBJVFlQRUZBS0VCT0xEQU1PVU5UKSAhPSBTVUNDRVNTKQogICAg ICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICBGU19zZXRfZmxhZ3MoZm9udCwgRkxBR1Nf Q0hFQ0tfQ09OVE9VUl9XSU5ESU5HX09OKTsgLy8gd2UgbmVlZCBjb3JyZWN0bHktd291bmQgY29u dG91cnMgdG8gZmFrZSBib2xkCiAgICAgfSBlbHNlIHsKQEAgLTIxNiw5ICsyMTYsMTMgQEAgY29u c3Qgdm9pZCogRm9udFBsYXRmb3JtRGF0YTo6cGxhdGZvcm1Gb250SGFuZGxlKCkgY29uc3QKIAog Ym9vbCBGb250UGxhdGZvcm1EYXRhOjppc0ZpeGVkUGl0Y2goKSBjb25zdAogewotICAgIFRURl9Q T1NUIHBvc3Q7Ci0gICAgaWYgKG1fZm9udCAmJiBGU19nZXRfdGFibGVfc3RydWN0dXJlKG1fZm9u dCwgVEFHX3Bvc3QsICZwb3N0KSA9PSBTVUNDRVNTKQotICAgICAgICByZXR1cm4gcG9zdC5pc0Zp eGVkUGl0Y2g7CisgICAgRlNfQllURSogcG9zdFRhYmxlOworICAgIEZTX1VMT05HIGxlbmd0aDsK KyAgICBpZiAobV9mb250ICYmIChwb3N0VGFibGUgPSBGU19nZXRfdGFibGUobV9mb250LCBUQUdf cG9zdCwgVEJMX0VYVFJBQ1QsICZsZW5ndGgpKSkgeworICAgICAgICBib29sIGZpeGVkID0gcmVp bnRlcnByZXRfY2FzdDxUVEZfUE9TVCo+KHBvc3RUYWJsZSktPmlzRml4ZWRQaXRjaDsKKyAgICAg ICAgRlNfZnJlZV90YWJsZShtX2ZvbnQsIHBvc3RUYWJsZSk7CisgICAgICAgIHJldHVybiBmaXhl ZDsKKyAgICB9CiAgICAgcmV0dXJuIGZhbHNlOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0lUeXBlVXRpbHMuaCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvSVR5cGVVdGlscy5oCmluZGV4IGY2 MTRmMjJkYmE5M2VmMjgyNmNhNTRiMzhlYzNjOTkxYTVhMjc3NzQuLjQzMDMyMTgyMzBkMThmNjM3 YjJjM2U3NGZlYzMxODViYTcyZDg5YjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvSVR5cGVVdGlscy5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvSVR5cGVVdGlscy5oCkBAIC00MCw0ICs0MCw2 IEBAIHN0YXRpYyBpbmxpbmUgZmxvYXQgaVR5cGVGaXhlZFRvRmxvYXQoRlNfRklYRUQgbikgeyBy ZXR1cm4gbiAvIDY1NTM2LjA7IH0KIAogc3RhdGljIGNvbnN0IEZTX0ZJWEVEIE1BWElUWVBFRk9O VFNDQUxFID0gaW50VG9JVHlwZUZpeGVkKDEwMDAwKSAtIDE7CiAKK3N0YXRpYyBjb25zdCBGU19G SVhFRCBJVFlQRUZBS0VCT0xEQU1PVU5UID0gZmxvYXRUb0lUeXBlRml4ZWQoMC4wNik7IC8vIDYl IHBzZXVkbyBib2xkCisKICNlbmRpZiAvLyBJVHlwZVV0aWxzX2gKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvU2ltcGxlRm9udERhdGFCbGFj a0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkv U2ltcGxlRm9udERhdGFCbGFja0JlcnJ5LmNwcAppbmRleCAyOTQxNTlkYzhiZjZhOWVjYTdlOTNh MTE1NzI3YWIyMGFhNjk3ODAwLi4zYTEzODk0YWNmNTI4MDU5ZDMxMDkzNWFhZDBiN2Q0MzIzYzUz M2NiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2Jl cnJ5L1NpbXBsZUZvbnREYXRhQmxhY2tCZXJyeS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9TaW1wbGVGb250RGF0YUJsYWNrQmVycnkuY3BwCkBA IC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoQykgMjAxMiBSZXNlYXJjaCBJbiBNb3Rp b24gTGltaXRlZC4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAxMiwg MjAxMyBSZXNlYXJjaCBJbiBNb3Rpb24gTGltaXRlZC4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAq CiAgKiBUaGlzIGxpYnJhcnkgaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUg aXQgYW5kL29yCiAgKiBtb2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgTGVzc2Vy IEdlbmVyYWwgUHVibGljCkBAIC0xNTcsOCArMTU3LDIyIEBAIGZsb2F0IFNpbXBsZUZvbnREYXRh OjpwbGF0Zm9ybVdpZHRoRm9yR2x5cGgoR2x5cGggZ2x5cGgpIGNvbnN0CiB7CiAgICAgRlNfU0hP UlQgaWR4LCBpZHk7CiAgICAgRlNfRklYRUQgZHgsIGR5OworICAgIEZTX0ZJWEVEIHMwMCwgczAx LCBzMTAsIHMxMTsKKyAgICBib29sIG5lZWRzRmFrZUJvbGRSZXNldCA9IG1fcGxhdGZvcm1EYXRh LnN5bnRoZXRpY0JvbGQoKSAmJiBtX3RyZWF0QXNGaXhlZFBpdGNoOworCisgICAgaWYgKG5lZWRz RmFrZUJvbGRSZXNldCkgeworICAgICAgICBGU19nZXRfc2NhbGUobV9wbGF0Zm9ybURhdGEuZm9u dCgpLCAmczAwLCAmczAxLCAmczEwLCAmczExKTsKKyAgICAgICAgRlNfc2V0X2JvbGRfcGN0KG1f cGxhdGZvcm1EYXRhLmZvbnQoKSwgMCk7CisgICAgICAgIEZTX3NldF9zY2FsZShtX3BsYXRmb3Jt RGF0YS5mb250KCksIHMwMCwgczAxLCBzMTAsIHMxMSk7CisgICAgfQorCiAgICAgaWYgKEZTX2dl dF9hZHZhbmNlKG1fcGxhdGZvcm1EYXRhLmZvbnQoKSwgZ2x5cGgsIEZTX01BUF9ESVNUQU5DRUZJ RUxEIHwgRlNfTUFQX0dSQVlNQVA4LCAmaWR4LCAmaWR5LCAmZHgsICZkeSkgIT0gU1VDQ0VTUykK LSAgICAgICAgcmV0dXJuIDA7CisgICAgICAgIGR4ID0gMDsKKworICAgIGlmIChuZWVkc0Zha2VC b2xkUmVzZXQpIHsKKyAgICAgICAgRlNfc2V0X2JvbGRfcGN0KG1fcGxhdGZvcm1EYXRhLmZvbnQo KSwgSVRZUEVGQUtFQk9MREFNT1VOVCk7CisgICAgICAgIEZTX3NldF9zY2FsZShtX3BsYXRmb3Jt RGF0YS5mb250KCksIHMwMCwgczAxLCBzMTAsIHMxMSk7CisgICAgfQogCiAgICAgcmV0dXJuIGlU eXBlRml4ZWRUb0Zsb2F0KGR4KTsKIH0K