115276 2013-04-26 14:11:29 -0700 WebCore ObjC bridge is missing support for bool type 2013-04-26 15:20:02 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff commit-queue oldest_to_newest 882024 0 msaboff 2013-04-26 14:11:29 -0700 The ObjC bridge doesn't handle boolean arguments or return types. 882028 1 199859 msaboff 2013-04-26 14:16:45 -0700 Created attachment 199859 Patch 882030 2 199859 ggaren 2013-04-26 14:27:58 -0700 Comment on attachment 199859 Patch r=me rs=me to change the ASSERT to RELEASE_ASSERT, as we discussed. 882050 3 msaboff 2013-04-26 15:20:02 -0700 Committed r149216: <http://trac.webkit.org/changeset/149216> 199859 2013-04-26 14:16:45 -0700 2013-04-26 14:27:57 -0700 Patch 115276.patch text/plain 3438 msaboff SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0OTIwOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA0LTI2ICBNaWNoYWVs IFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIFdlYkNvcmUgT2JqQyBicmlk Z2UgaXMgbWlzc2luZyBzdXBwb3J0IGZvciBib29sIHR5cGUKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNTI3NgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIGNvZGUgdG8gaGFuZGxlIGNvbnZlcnNp b24gYmV0d2VlbiBPYmpDIGFuZCBKUyBib29sZWFucy4KKworICAgICAgICAqIGJyaWRnZS9vYmpj L29iamNfaW5zdGFuY2UubW06CisgICAgICAgIChPYmpjSW5zdGFuY2U6Omludm9rZU9iamNNZXRo b2QpOgorICAgICAgICAqIGJyaWRnZS9vYmpjL29iamNfdXRpbGl0eS5oOgorICAgICAgICAqIGJy aWRnZS9vYmpjL29iamNfdXRpbGl0eS5tbToKKyAgICAgICAgKEpTQzo6QmluZGluZ3M6OmNvbnZl cnRWYWx1ZVRvT2JqY1ZhbHVlKToKKyAgICAgICAgKEpTQzo6QmluZGluZ3M6OmNvbnZlcnRPYmpj VmFsdWVUb1ZhbHVlKToKKyAgICAgICAgKEpTQzo6QmluZGluZ3M6Om9iamNWYWx1ZVR5cGVGb3JU eXBlKToKKwogMjAxMy0wNC0yNiAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNv bT4KIAogICAgICAgICBMYXllci1iYWNrZWQgV2ViVmlld3MgZG9uJ3QgcmVwYWludCBjb250ZW50 IG91dHNpZGUgdGhlIHZpc2libGUgYXJlYQpJbmRleDogU291cmNlL1dlYkNvcmUvYnJpZGdlL29i amMvb2JqY19pbnN0YW5jZS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9icmlkZ2Uv b2JqYy9vYmpjX2luc3RhbmNlLm1tCShyZXZpc2lvbiAxNDkyMDUpCisrKyBTb3VyY2UvV2ViQ29y ZS9icmlkZ2Uvb2JqYy9vYmpjX2luc3RhbmNlLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yODksNiAr Mjg5LDkgQEAgSlNWYWx1ZSBPYmpjSW5zdGFuY2U6Omludm9rZU9iamNNZXRob2QoRQogICAgICAg ICAgICAgICAgIGNhc2UgT2JqY1Vuc2lnbmVkU2hvcnRUeXBlOgogICAgICAgICAgICAgICAgICAg ICBbaW52b2NhdGlvbiBzZXRBcmd1bWVudDomdmFsdWUuc2hvcnRWYWx1ZSBhdEluZGV4OmldOwog ICAgICAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgICAgICBjYXNlIE9iamNCb29s VHlwZToKKyAgICAgICAgICAgICAgICAgICAgW2ludm9jYXRpb24gc2V0QXJndW1lbnQ6JnZhbHVl LmJvb2xlYW5WYWx1ZSBhdEluZGV4OmldOworICAgICAgICAgICAgICAgICAgICBicmVhazsKICAg ICAgICAgICAgICAgICBjYXNlIE9iamNJbnRUeXBlOgogICAgICAgICAgICAgICAgIGNhc2UgT2Jq Y1Vuc2lnbmVkSW50VHlwZToKICAgICAgICAgICAgICAgICAgICAgW2ludm9jYXRpb24gc2V0QXJn dW1lbnQ6JnZhbHVlLmludFZhbHVlIGF0SW5kZXg6aV07CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9i cmlkZ2Uvb2JqYy9vYmpjX3V0aWxpdHkuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9i cmlkZ2Uvb2JqYy9vYmpjX3V0aWxpdHkuaAkocmV2aXNpb24gMTQ5MjA1KQorKysgU291cmNlL1dl YkNvcmUvYnJpZGdlL29iamMvb2JqY191dGlsaXR5LmgJKHdvcmtpbmcgY29weSkKQEAgLTY0LDYg KzY0LDcgQEAgdHlwZWRlZiBlbnVtIHsKICAgICBPYmpjVW5zaWduZWRMb25nTG9uZ1R5cGUsCiAg ICAgT2JqY0Zsb2F0VHlwZSwKICAgICBPYmpjRG91YmxlVHlwZSwKKyAgICBPYmpjQm9vbFR5cGUs CiAgICAgT2JqY0ludmFsaWRUeXBlCiB9IE9iamNWYWx1ZVR5cGU7CiAKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL2JyaWRnZS9vYmpjL29iamNfdXRpbGl0eS5tbQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9icmlkZ2Uvb2JqYy9vYmpjX3V0aWxpdHkubW0JKHJldmlzaW9uIDE0OTIwNSkKKysr IFNvdXJjZS9XZWJDb3JlL2JyaWRnZS9vYmpjL29iamNfdXRpbGl0eS5tbQkod29ya2luZyBjb3B5 KQpAQCAtMTEzLDYgKzExMyw5IEBAIE9iamNWYWx1ZSBjb252ZXJ0VmFsdWVUb09iamNWYWx1ZShF eGVjU3QKICAgICAgICAgY2FzZSBPYmpjVW5zaWduZWRTaG9ydFR5cGU6CiAgICAgICAgICAgICBy ZXN1bHQuc2hvcnRWYWx1ZSA9IChzaG9ydClkOwogICAgICAgICAgICAgYnJlYWs7CisgICAgICAg IGNhc2UgT2JqY0Jvb2xUeXBlOgorICAgICAgICAgICAgcmVzdWx0LmJvb2xlYW5WYWx1ZSA9IChi b29sKWQ7CisgICAgICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSBPYmpjSW50VHlwZToKICAg ICAgICAgY2FzZSBPYmpjVW5zaWduZWRJbnRUeXBlOgogICAgICAgICAgICAgcmVzdWx0LmludFZh bHVlID0gKGludClkOwpAQCAtMjA2LDYgKzIwOSw4IEBAIEpTVmFsdWUgY29udmVydE9iamNWYWx1 ZVRvVmFsdWUoRXhlY1N0YXQKICAgICAgICAgICAgIHJldHVybiBqc051bWJlcigqKHNob3J0Kili dWZmZXIpOwogICAgICAgICBjYXNlIE9iamNVbnNpZ25lZFNob3J0VHlwZToKICAgICAgICAgICAg IHJldHVybiBqc051bWJlcigqKHVuc2lnbmVkIHNob3J0KilidWZmZXIpOworICAgICAgICBjYXNl IE9iamNCb29sVHlwZToKKyAgICAgICAgICAgIHJldHVybiBqc0Jvb2xlYW4oKihib29sKilidWZm ZXIpOwogICAgICAgICBjYXNlIE9iamNJbnRUeXBlOgogICAgICAgICAgICAgcmV0dXJuIGpzTnVt YmVyKCooaW50KilidWZmZXIpOwogICAgICAgICBjYXNlIE9iamNVbnNpZ25lZEludFR5cGU6CkBA IC0yNjEsNiArMjY2LDkgQEAgT2JqY1ZhbHVlVHlwZSBvYmpjVmFsdWVUeXBlRm9yVHlwZShjb25z dAogICAgICAgICAgICAgY2FzZSBfQ19VU0hUOgogICAgICAgICAgICAgICAgIG9iamNWYWx1ZVR5 cGUgPSBPYmpjVW5zaWduZWRTaG9ydFR5cGU7CiAgICAgICAgICAgICAgICAgYnJlYWs7CisgICAg ICAgICAgICBjYXNlIF9DX0JPT0w6CisgICAgICAgICAgICAgICAgb2JqY1ZhbHVlVHlwZSA9IE9i amNCb29sVHlwZTsKKyAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIGNhc2UgX0Nf SU5UOgogICAgICAgICAgICAgICAgIG9iamNWYWx1ZVR5cGUgPSBPYmpjSW50VHlwZTsKICAgICAg ICAgICAgICAgICBicmVhazsK