115266 2013-04-26 10:55:20 -0700 RenderMeter::valueRatio() is private 2013-04-29 13:15:15 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Minor --- 115343 0 daker.pinheiro webkit-unassigned benjamin commit-queue esprehn+autocc jesus menard morrita oldest_to_newest 881959 0 daker.pinheiro 2013-04-26 10:55:20 -0700 This function is currently unused. However, it is necessary to implement a RenderTheme capable of rendering Meter elements. 881962 1 199845 daker.pinheiro 2013-04-26 11:07:31 -0700 Created attachment 199845 Change method visibility 881965 2 199845 jesus 2013-04-26 11:11:42 -0700 Comment on attachment 199845 Change method visibility View in context: https://bugs.webkit.org/attachment.cgi?id=199845&action=review > Source/WebCore/ChangeLog:8 > + No new tests. You should specify the reason why no new tests were needed (e.g.: "No new tests, no behavior was changed"). > Source/WebCore/rendering/RenderMeter.h:41 > + double valueRatio() const; Why do you need it to public? A 1-line explanation in Changelog should be enough. :) 881971 3 199846 daker.pinheiro 2013-04-26 11:15:55 -0700 Created attachment 199846 Change method visibility with fixed ChangeLog 881989 4 199846 commit-queue 2013-04-26 12:08:55 -0700 Comment on attachment 199846 Change method visibility with fixed ChangeLog Clearing flags on attachment: 199846 Committed r149203: <http://trac.webkit.org/changeset/149203> 881990 5 commit-queue 2013-04-26 12:08:58 -0700 All reviewed patches have been landed. Closing bug. 882465 6 benjamin 2013-04-28 21:59:52 -0700 What? Please explain this change. I could understand for <progress> but for <meter> the rendering depends on the gaugeRegion and you cannot access that from the renderer. You must access the MeterElement to style the element correctly, and have all styling parameters available there. 882467 7 commit-queue 2013-04-28 22:07:48 -0700 Re-opened since this is blocked by bug 115343 882551 8 daker.pinheiro 2013-04-29 07:26:04 -0700 I also though strange that it is a private method and no one was using it. It looked to me like a forgotten piece of code. I was using the valueRatio because is a simplest way to paint a minimal meter element, since it already does the ratio math. Since it looked like RenderProgress position parameter, I made it public to use it in my own style. Since it is not used anywhere, shouldn't it be deleted? 882676 9 200025 daker.pinheiro 2013-04-29 10:41:00 -0700 Created attachment 200025 Remove unused method RenderMeter::valueRatio() 882734 10 200025 commit-queue 2013-04-29 13:15:13 -0700 Comment on attachment 200025 Remove unused method RenderMeter::valueRatio() Clearing flags on attachment: 200025 Committed r149308: <http://trac.webkit.org/changeset/149308> 882735 11 commit-queue 2013-04-29 13:15:15 -0700 All reviewed patches have been landed. Closing bug. 199845 2013-04-26 11:07:31 -0700 2013-04-26 11:15:55 -0700 Change method visibility meter.diff text/plain 1459 daker.pinheiro ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3N2QxNTMzLi45OWIzM2JkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTMtMDQtMjYgIERha2VyIEZlcm5hbmRlcyBQaW5oZWlybyAgPGRha2VyLnBpbmhlaXJv QG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgQ2hhbmdlIFJlbmRlck1ldGVyOjp2YWx1ZVJhdGlv KCkgdmlzaWJpbGl0eSB0byBwdWJsaWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExNTI2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5k ZXJNZXRlci5oOgorICAgICAgICAoUmVuZGVyTWV0ZXIpOgorCiAyMDEzLTA0LTI2ICBNYXJ0aW4g Um9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBSZW1vdmUgdGhlIHJl bWFpbmluZyBTa2lhICNpZmRlZnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJNZXRlci5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck1ldGVyLmgK aW5kZXggYzEyNjlkYi4uOTQyOGQ2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlck1ldGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck1l dGVyLmgKQEAgLTM4LDE1ICszOCwxNSBAQCBwdWJsaWM6CiAgICAgSFRNTE1ldGVyRWxlbWVudCog bWV0ZXJFbGVtZW50KCkgY29uc3Q7CiAgICAgdmlydHVhbCB2b2lkIHVwZGF0ZUZyb21FbGVtZW50 KCk7CiAKLXByaXZhdGU6ICAgIAorICAgIGRvdWJsZSB2YWx1ZVJhdGlvKCkgY29uc3Q7CisKK3By aXZhdGU6CiAgICAgdmlydHVhbCB2b2lkIHVwZGF0ZUxvZ2ljYWxXaWR0aCgpIE9WRVJSSURFOwog ICAgIHZpcnR1YWwgdm9pZCBjb21wdXRlTG9naWNhbEhlaWdodChMYXlvdXRVbml0IGxvZ2ljYWxI ZWlnaHQsIExheW91dFVuaXQgbG9naWNhbFRvcCwgTG9naWNhbEV4dGVudENvbXB1dGVkVmFsdWVz JikgY29uc3QgT1ZFUlJJREU7CiAKICAgICB2aXJ0dWFsIGNvbnN0IGNoYXIqIHJlbmRlck5hbWUo KSBjb25zdCB7IHJldHVybiAiUmVuZGVyTWV0ZXIiOyB9CiAgICAgdmlydHVhbCBib29sIGlzTWV0 ZXIoKSBjb25zdCB7IHJldHVybiB0cnVlOyB9CiAgICAgdmlydHVhbCBib29sIHJlcXVpcmVzRm9y Y2VkU3R5bGVSZWNhbGNQcm9wYWdhdGlvbigpIGNvbnN0IHsgcmV0dXJuIHRydWU7IH0KLQotICAg IGRvdWJsZSB2YWx1ZVJhdGlvKCkgY29uc3Q7CiB9OwogCiBpbmxpbmUgUmVuZGVyTWV0ZXIqIHRv UmVuZGVyTWV0ZXIoUmVuZGVyT2JqZWN0KiBvYmplY3QpCg== 199846 2013-04-26 11:15:55 -0700 2013-04-26 12:08:55 -0700 Change method visibility with fixed ChangeLog meter.diff text/plain 1636 daker.pinheiro ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3N2QxNTMzLi5mNDA4NWZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTMtMDQtMjYgIERha2VyIEZlcm5hbmRlcyBQaW5oZWlybyAgPGRha2VyLnBpbmhlaXJv QG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgQ2hhbmdlIFJlbmRlck1ldGVyOjp2YWx1ZVJhdGlv KCkgdmlzaWJpbGl0eSB0byBwdWJsaWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExNTI2NgorCisgICAgICAgIFRoaXMgZnVuY3Rpb24gaXMgY3VycmVu dGx5IHVudXNlZC4KKyAgICAgICAgSG93ZXZlciwgaXQgaXMgbmVjZXNzYXJ5IHRvIGltcGxlbWVu dCBhIFJlbmRlclRoZW1lIGNhcGFibGUgb2YgcmVuZGVyaW5nIE1ldGVyIGVsZW1lbnRzLgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0 cywgYmVjYXVzZSBubyBiZWhhdmlvdXIgaXMgY2hhbmdlZC4KKworICAgICAgICAqIHJlbmRlcmlu Zy9SZW5kZXJNZXRlci5oOgorICAgICAgICAoUmVuZGVyTWV0ZXIpOgorCiAyMDEzLTA0LTI2ICBN YXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBSZW1vdmUg dGhlIHJlbWFpbmluZyBTa2lhICNpZmRlZnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJNZXRlci5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck1l dGVyLmgKaW5kZXggYzEyNjlkYi4uOTQyOGQ2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlck1ldGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlck1ldGVyLmgKQEAgLTM4LDE1ICszOCwxNSBAQCBwdWJsaWM6CiAgICAgSFRNTE1ldGVyRWxl bWVudCogbWV0ZXJFbGVtZW50KCkgY29uc3Q7CiAgICAgdmlydHVhbCB2b2lkIHVwZGF0ZUZyb21F bGVtZW50KCk7CiAKLXByaXZhdGU6ICAgIAorICAgIGRvdWJsZSB2YWx1ZVJhdGlvKCkgY29uc3Q7 CisKK3ByaXZhdGU6CiAgICAgdmlydHVhbCB2b2lkIHVwZGF0ZUxvZ2ljYWxXaWR0aCgpIE9WRVJS SURFOwogICAgIHZpcnR1YWwgdm9pZCBjb21wdXRlTG9naWNhbEhlaWdodChMYXlvdXRVbml0IGxv Z2ljYWxIZWlnaHQsIExheW91dFVuaXQgbG9naWNhbFRvcCwgTG9naWNhbEV4dGVudENvbXB1dGVk VmFsdWVzJikgY29uc3QgT1ZFUlJJREU7CiAKICAgICB2aXJ0dWFsIGNvbnN0IGNoYXIqIHJlbmRl ck5hbWUoKSBjb25zdCB7IHJldHVybiAiUmVuZGVyTWV0ZXIiOyB9CiAgICAgdmlydHVhbCBib29s IGlzTWV0ZXIoKSBjb25zdCB7IHJldHVybiB0cnVlOyB9CiAgICAgdmlydHVhbCBib29sIHJlcXVp cmVzRm9yY2VkU3R5bGVSZWNhbGNQcm9wYWdhdGlvbigpIGNvbnN0IHsgcmV0dXJuIHRydWU7IH0K LQotICAgIGRvdWJsZSB2YWx1ZVJhdGlvKCkgY29uc3Q7CiB9OwogCiBpbmxpbmUgUmVuZGVyTWV0 ZXIqIHRvUmVuZGVyTWV0ZXIoUmVuZGVyT2JqZWN0KiBvYmplY3QpCg== 200025 2013-04-29 10:41:00 -0700 2013-04-29 13:15:12 -0700 Remove unused method RenderMeter::valueRatio() meter.diff text/plain 1829 daker.pinheiro ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmZGU1MTE5Li5mZTI3NGMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTMtMDQtMjkgIERha2VyIEZlcm5hbmRlcyBQaW5oZWlybyAgPGRha2VyLnBpbmhlaXJv QG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgUmVtb3ZlIHVudXNlZCBtZXRob2QgUmVuZGVyTWV0 ZXI6OnZhbHVlUmF0aW8oKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTE1MjY2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGhlIHJlbW92ZWQgbWV0aG9kIGlzIG5vdCB1c2VkIGFueXdoZXJlLgorICAgICAg ICBObyBuZXcgdGVzdHMgYXJlIHJlcXVpcmVkLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRl ck1ldGVyLmNwcDoKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTWV0ZXIuaDoKKyAgICAgICAg KFJlbmRlck1ldGVyKToKKwogMjAxMy0wNC0yOSAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBs ZS5jb20+CiAKICAgICAgICAgQWRkIGJyYW5jaC1wcmVkaWN0aW9uIGhpbnQgdG8gRkFTVF9SRVRV Uk5fSUZfTk9fRlJPTlRFTkRTLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlck1ldGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJNZXRlci5j cHAKaW5kZXggYjYwOTNlZS4uYTJlYTk2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlck1ldGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyTWV0ZXIuY3BwCkBAIC03MywxMSArNzMsNiBAQCB2b2lkIFJlbmRlck1ldGVyOjpjb21wdXRl TG9naWNhbEhlaWdodChMYXlvdXRVbml0IGxvZ2ljYWxIZWlnaHQsIExheW91dFVuaXQgbG9naQog ICAgIGNvbXB1dGVkVmFsdWVzLm1fZXh0ZW50ID0gaXNIb3Jpem9udGFsV3JpdGluZ01vZGUoKSA/ IGZyYW1lU2l6ZS5oZWlnaHQoKSA6IGZyYW1lU2l6ZS53aWR0aCgpOwogfQogCi1kb3VibGUgUmVu ZGVyTWV0ZXI6OnZhbHVlUmF0aW8oKSBjb25zdAotewotICAgIHJldHVybiBtZXRlckVsZW1lbnQo KS0+dmFsdWVSYXRpbygpOwotfQotCiB2b2lkIFJlbmRlck1ldGVyOjp1cGRhdGVGcm9tRWxlbWVu dCgpCiB7CiAgICAgcmVwYWludCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlck1ldGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTWV0ZXIu aAppbmRleCA5NDI4ZDZmLi5iYzA5ZDNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyTWV0ZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TWV0ZXIuaApAQCAtMzgsOCArMzgsNiBAQCBwdWJsaWM6CiAgICAgSFRNTE1ldGVyRWxlbWVudCog bWV0ZXJFbGVtZW50KCkgY29uc3Q7CiAgICAgdmlydHVhbCB2b2lkIHVwZGF0ZUZyb21FbGVtZW50 KCk7CiAKLSAgICBkb3VibGUgdmFsdWVSYXRpbygpIGNvbnN0OwotCiBwcml2YXRlOgogICAgIHZp cnR1YWwgdm9pZCB1cGRhdGVMb2dpY2FsV2lkdGgoKSBPVkVSUklERTsKICAgICB2aXJ0dWFsIHZv aWQgY29tcHV0ZUxvZ2ljYWxIZWlnaHQoTGF5b3V0VW5pdCBsb2dpY2FsSGVpZ2h0LCBMYXlvdXRV bml0IGxvZ2ljYWxUb3AsIExvZ2ljYWxFeHRlbnRDb21wdXRlZFZhbHVlcyYpIGNvbnN0IE9WRVJS SURFOwo=