115260 2013-04-26 07:57:39 -0700 Web Inspector: support frame instrumentation for coordinated graphics 2022-03-01 02:59:28 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 88225 1 noam rtakacs andersca cmarcelo commit-queue graouts hnandor joepeck kadam kling luiz ossy rtakacs sergio timothy zeno oldest_to_newest 881898 0 noam 2013-04-26 07:57:39 -0700 Currently frame instrumentation only works for Blackberry (and for Chromium in Blink) We need to support it in coordinated graphics for Qt/EFL, by calling the right functions from CoordinatedLayerTreeHost and enabling the flag. 891711 1 202413 rtakacs 2013-05-21 04:56:47 -0700 Created attachment 202413 patch Overrode supportsFrameInstrumentation in order to enable frame instrumentation on ports that use coordinated graphics. didBeginFrame() needs to be called to render bars. 891712 2 202413 noam 2013-05-21 05:00:04 -0700 Comment on attachment 202413 patch View in context: https://bugs.webkit.org/attachment.cgi?id=202413&action=review LGTM, but needs owner review as it touches common WebKit2 files. > Source/WebKit2/ChangeLog:9 > + when didBeginFrame() is called. you mean "by calling didBeginFrame()" 892403 3 202413 kling 2013-05-22 11:23:57 -0700 Comment on attachment 202413 patch o=me 892704 4 202650 rtakacs 2013-05-23 02:03:49 -0700 Created attachment 202650 patch 892714 5 kadam 2013-05-23 02:37:35 -0700 Landed: http://trac.webkit.org/changeset/150578 202413 2013-05-21 04:56:47 -0700 2013-05-23 02:03:49 -0700 patch 2013_05_21.diff text/plain 3471 rtakacs ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4YzgyNjE5Li4wYTEzOTY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTMtMDUtMjEgIFJvbGFuZCBUYWthY3MgIDxydGFrYWNzQGluZi51LXN6ZWdlZC5odT4K KworICAgICAgICBTdXBwb3J0IGZyYW1lIGluc3RydW1lbnRhdGlvbiBmb3IgY29vcmRpbmF0ZWQg Z3JhcGhpY3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExNTI2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEVuYWJsZWQgc3VwcG9ydHNGcmFtZUluc3RydW1lbnRhdGlvbiBvbiBwb3J0cyB0aGF0IHVzZSBj b29yZGluYXRlZCBncmFwaGljcworICAgICAgICB3aGVuIGRpZEJlZ2luRnJhbWUoKSBpcyBjYWxs ZWQuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkluc3BlY3RvckNs aWVudC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkluc3BlY3RvckNsaWVudDo6c3VwcG9ydHNG cmFtZUluc3RydW1lbnRhdGlvbik6CisgICAgICAgIChXZWJLaXQpOgorICAgICAgICAqIFdlYlBy b2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViSW5zcGVjdG9yQ2xpZW50Lmg6CisgICAgICAgIChXZWJJ bnNwZWN0b3JDbGllbnQpOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRl ZEdyYXBoaWNzL0Nvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdC5jcHA6CisgICAgICAgIChXZWJLaXQ6 OkNvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdDo6c3luY0Rpc3BsYXlTdGF0ZSk6CisKIDIwMTMtMDUt MjEgIE1pY2hhZWwgQnLDvG5pbmcgIDxtaWNoYWVsLmJydW5pbmdAZGlnaWEuY29tPgogCiAgICAg ICAgIFtRdF1bV0syXSBGaXggTW91bnRhaW4gTGlvbiBidWlsZHMgYWZ0ZXIgcjE1MDI3Ny4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViSW5z cGVjdG9yQ2xpZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBv cnQvV2ViSW5zcGVjdG9yQ2xpZW50LmNwcAppbmRleCAzMzZlYTk5Li4xMzFlNTJjIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkluc3BlY3Rv ckNsaWVudC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9y dC9XZWJJbnNwZWN0b3JDbGllbnQuY3BwCkBAIC0xMDYsNiArMTA2LDE0IEBAIGJvb2wgV2ViSW5z cGVjdG9yQ2xpZW50OjpzZW5kTWVzc2FnZVRvRnJvbnRlbmQoY29uc3QgU3RyaW5nJiBtZXNzYWdl KQogICAgIHJldHVybiBmYWxzZTsKIH0KIAorYm9vbCBXZWJJbnNwZWN0b3JDbGllbnQ6OnN1cHBv cnRzRnJhbWVJbnN0cnVtZW50YXRpb24oKQoreworI2lmIFVTRShDT09SRElOQVRFRF9HUkFQSElD UykKKyAgICByZXR1cm4gdHJ1ZTsKKyNlbmRpZgorICAgIHJldHVybiBmYWxzZTsKK30KKwogdm9p ZCBXZWJJbnNwZWN0b3JDbGllbnQ6OnBhZ2VPdmVybGF5RGVzdHJveWVkKFBhZ2VPdmVybGF5KikK IHsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBv cnQvV2ViSW5zcGVjdG9yQ2xpZW50LmggYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNv cmVTdXBwb3J0L1dlYkluc3BlY3RvckNsaWVudC5oCmluZGV4IDI5MjdhOGEuLjNlZTJlYTggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViSW5z cGVjdG9yQ2xpZW50LmgKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3Vw cG9ydC9XZWJJbnNwZWN0b3JDbGllbnQuaApAQCAtNjMsNiArNjMsOCBAQCBwcml2YXRlOgogCiAg ICAgdmlydHVhbCBib29sIHNlbmRNZXNzYWdlVG9Gcm9udGVuZChjb25zdCBTdHJpbmcmKSBPVkVS UklERTsKIAorICAgIHZpcnR1YWwgYm9vbCBzdXBwb3J0c0ZyYW1lSW5zdHJ1bWVudGF0aW9uKCk7 CisKICAgICAvLyBQYWdlT3ZlcmxheTo6Q2xpZW50CiAgICAgdmlydHVhbCB2b2lkIHBhZ2VPdmVy bGF5RGVzdHJveWVkKFBhZ2VPdmVybGF5KikgT1ZFUlJJREU7CiAgICAgdmlydHVhbCB2b2lkIHdp bGxNb3ZlVG9XZWJQYWdlKFBhZ2VPdmVybGF5KiwgV2ViUGFnZSopIE9WRVJSSURFOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhp Y3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdC5j cHAKaW5kZXggNmNjNDE0OC4uNTcyMDQ2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVI b3N0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0 ZWRHcmFwaGljcy9Db29yZGluYXRlZExheWVyVHJlZUhvc3QuY3BwCkBAIC00MSw2ICs0MSw3IEBA CiAjaW5jbHVkZSA8V2ViQ29yZS9GcmFtZS5oPgogI2luY2x1ZGUgPFdlYkNvcmUvRnJhbWVWaWV3 Lmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9HcmFwaGljc1N1cmZhY2UuaD4KKyNpbmNsdWRlIDxXZWJD b3JlL0luc3BlY3RvckNvbnRyb2xsZXIuaD4KICNpbmNsdWRlIDxXZWJDb3JlL1BhZ2UuaD4KICNp bmNsdWRlIDxXZWJDb3JlL1JlbmRlckxheWVyLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9SZW5kZXJM YXllckJhY2tpbmcuaD4KQEAgLTQzMCw2ICs0MzEsMTAgQEAgdm9pZCBDb29yZGluYXRlZExheWVy VHJlZUhvc3Q6OnBlcmZvcm1TY2hlZHVsZWRMYXllckZsdXNoKCkKIAogdm9pZCBDb29yZGluYXRl ZExheWVyVHJlZUhvc3Q6OnN5bmNEaXNwbGF5U3RhdGUoKQogeworI2lmIEVOQUJMRShJTlNQRUNU T1IpCisgICAgbV93ZWJQYWdlLT5jb3JlUGFnZSgpLT5pbnNwZWN0b3JDb250cm9sbGVyKCktPmRp ZEJlZ2luRnJhbWUoKTsKKyNlbmRpZgorCiAjaWYgRU5BQkxFKFJFUVVFU1RfQU5JTUFUSU9OX0ZS QU1FKSAmJiAhVVNFKFJFUVVFU1RfQU5JTUFUSU9OX0ZSQU1FX1RJTUVSKSAmJiAhVVNFKFJFUVVF U1RfQU5JTUFUSU9OX0ZSQU1FX0RJU1BMQVlfTU9OSVRPUikKICAgICAvLyBNYWtlIHN1cmUgdGhh dCBhbnkgcHJldmlvdXNseSByZWdpc3RlcmVkIGFuaW1hdGlvbiBjYWxsYmFja3MgYXJlIGJlaW5n IGV4ZWN1dGVkIGJlZm9yZSB3ZSBmbHVzaCB0aGUgbGF5ZXJzLgogICAgIG1fbGFzdEFuaW1hdGlv blNlcnZpY2VUaW1lID0gV1RGOjptb25vdG9uaWNhbGx5SW5jcmVhc2luZ1RpbWUoKTsK 202650 2013-05-23 02:03:49 -0700 2022-03-01 02:59:28 -0800 patch 2013_05_23.diff text/plain 3467 rtakacs ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4YzgyNjE5Li4wYTEzOTY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTMtMDUtMjEgIFJvbGFuZCBUYWthY3MgIDxydGFrYWNzQGluZi51LXN6ZWdlZC5odT4K KworICAgICAgICBTdXBwb3J0IGZyYW1lIGluc3RydW1lbnRhdGlvbiBmb3IgY29vcmRpbmF0ZWQg Z3JhcGhpY3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExNTI2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEVuYWJsZWQgc3VwcG9ydHNGcmFtZUluc3RydW1lbnRhdGlvbiBvbiBwb3J0cyB0aGF0IHVzZSBj b29yZGluYXRlZCBncmFwaGljcworICAgICAgICBieSBjYWxsaW5nIGRpZEJlZ2luRnJhbWUoKS4K KworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViSW5zcGVjdG9yQ2xpZW50 LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViSW5zcGVjdG9yQ2xpZW50OjpzdXBwb3J0c0ZyYW1l SW5zdHJ1bWVudGF0aW9uKToKKyAgICAgICAgKFdlYktpdCk6CisgICAgICAgICogV2ViUHJvY2Vz cy9XZWJDb3JlU3VwcG9ydC9XZWJJbnNwZWN0b3JDbGllbnQuaDoKKyAgICAgICAgKFdlYkluc3Bl Y3RvckNsaWVudCk6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3Jh cGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q29v cmRpbmF0ZWRMYXllclRyZWVIb3N0OjpzeW5jRGlzcGxheVN0YXRlKToKKwogMjAxMy0wNS0yMSAg TWljaGFlbCBCcsO8bmluZyAgPG1pY2hhZWwuYnJ1bmluZ0BkaWdpYS5jb20+CiAKICAgICAgICAg W1F0XVtXSzJdIEZpeCBNb3VudGFpbiBMaW9uIGJ1aWxkcyBhZnRlciByMTUwMjc3LgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJJbnNwZWN0 b3JDbGllbnQuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9X ZWJJbnNwZWN0b3JDbGllbnQuY3BwCmluZGV4IDMzNmVhOTkuLjEzMWU1MmMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViSW5zcGVjdG9yQ2xp ZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dl Ykluc3BlY3RvckNsaWVudC5jcHAKQEAgLTEwNiw2ICsxMDYsMTQgQEAgYm9vbCBXZWJJbnNwZWN0 b3JDbGllbnQ6OnNlbmRNZXNzYWdlVG9Gcm9udGVuZChjb25zdCBTdHJpbmcmIG1lc3NhZ2UpCiAg ICAgcmV0dXJuIGZhbHNlOwogfQogCitib29sIFdlYkluc3BlY3RvckNsaWVudDo6c3VwcG9ydHNG cmFtZUluc3RydW1lbnRhdGlvbigpCit7CisjaWYgVVNFKENPT1JESU5BVEVEX0dSQVBISUNTKQor ICAgIHJldHVybiB0cnVlOworI2VuZGlmCisgICAgcmV0dXJuIGZhbHNlOworfQorCiB2b2lkIFdl Ykluc3BlY3RvckNsaWVudDo6cGFnZU92ZXJsYXlEZXN0cm95ZWQoUGFnZU92ZXJsYXkqKQogewog fQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9X ZWJJbnNwZWN0b3JDbGllbnQuaCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1 cHBvcnQvV2ViSW5zcGVjdG9yQ2xpZW50LmgKaW5kZXggMjkyN2E4YS4uM2VlMmVhOCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJJbnNwZWN0 b3JDbGllbnQuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0 L1dlYkluc3BlY3RvckNsaWVudC5oCkBAIC02Myw2ICs2Myw4IEBAIHByaXZhdGU6CiAKICAgICB2 aXJ0dWFsIGJvb2wgc2VuZE1lc3NhZ2VUb0Zyb250ZW5kKGNvbnN0IFN0cmluZyYpIE9WRVJSSURF OwogCisgICAgdmlydHVhbCBib29sIHN1cHBvcnRzRnJhbWVJbnN0cnVtZW50YXRpb24oKTsKKwog ICAgIC8vIFBhZ2VPdmVybGF5OjpDbGllbnQKICAgICB2aXJ0dWFsIHZvaWQgcGFnZU92ZXJsYXlE ZXN0cm95ZWQoUGFnZU92ZXJsYXkqKSBPVkVSUklERTsKICAgICB2aXJ0dWFsIHZvaWQgd2lsbE1v dmVUb1dlYlBhZ2UoUGFnZU92ZXJsYXkqLCBXZWJQYWdlKikgT1ZFUlJJREU7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9D b29yZGluYXRlZExheWVyVHJlZUhvc3QuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmNwcApp bmRleCA2Y2M0MTQ4Li41NzIwNDZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZExheWVyVHJlZUhvc3Qu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdy YXBoaWNzL0Nvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdC5jcHAKQEAgLTQxLDYgKzQxLDcgQEAKICNp bmNsdWRlIDxXZWJDb3JlL0ZyYW1lLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9GcmFtZVZpZXcuaD4K ICNpbmNsdWRlIDxXZWJDb3JlL0dyYXBoaWNzU3VyZmFjZS5oPgorI2luY2x1ZGUgPFdlYkNvcmUv SW5zcGVjdG9yQ29udHJvbGxlci5oPgogI2luY2x1ZGUgPFdlYkNvcmUvUGFnZS5oPgogI2luY2x1 ZGUgPFdlYkNvcmUvUmVuZGVyTGF5ZXIuaD4KICNpbmNsdWRlIDxXZWJDb3JlL1JlbmRlckxheWVy QmFja2luZy5oPgpAQCAtNDMwLDYgKzQzMSwxMCBAQCB2b2lkIENvb3JkaW5hdGVkTGF5ZXJUcmVl SG9zdDo6cGVyZm9ybVNjaGVkdWxlZExheWVyRmx1c2goKQogCiB2b2lkIENvb3JkaW5hdGVkTGF5 ZXJUcmVlSG9zdDo6c3luY0Rpc3BsYXlTdGF0ZSgpCiB7CisjaWYgRU5BQkxFKElOU1BFQ1RPUikK KyAgICBtX3dlYlBhZ2UtPmNvcmVQYWdlKCktPmluc3BlY3RvckNvbnRyb2xsZXIoKS0+ZGlkQmVn aW5GcmFtZSgpOworI2VuZGlmCisKICNpZiBFTkFCTEUoUkVRVUVTVF9BTklNQVRJT05fRlJBTUUp ICYmICFVU0UoUkVRVUVTVF9BTklNQVRJT05fRlJBTUVfVElNRVIpICYmICFVU0UoUkVRVUVTVF9B TklNQVRJT05fRlJBTUVfRElTUExBWV9NT05JVE9SKQogICAgIC8vIE1ha2Ugc3VyZSB0aGF0IGFu eSBwcmV2aW91c2x5IHJlZ2lzdGVyZWQgYW5pbWF0aW9uIGNhbGxiYWNrcyBhcmUgYmVpbmcgZXhl Y3V0ZWQgYmVmb3JlIHdlIGZsdXNoIHRoZSBsYXllcnMuCiAgICAgbV9sYXN0QW5pbWF0aW9uU2Vy dmljZVRpbWUgPSBXVEY6Om1vbm90b25pY2FsbHlJbmNyZWFzaW5nVGltZSgpOwo=