115240 2013-04-26 03:37:14 -0700 [GTK] Compilation of ProcessLauncherGtk.cpp fails due to unresolved symbols 2013-04-27 09:46:20 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 elima webkit-unassigned commit-queue mrobinson walters xan.lopez oldest_to_newest 881797 0 elima 2013-04-26 03:37:14 -0700 Building WebKit Gtk port using build-webkit script fails in my system (up-to-date Debian Wheezy 64bits) with: ../../Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp: In member function 'void WebKit::ProcessLauncher::launchProcess()': ../../Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:77:20: error: 'AF_UNIX' was not declared in this scope ../../Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:77:29: error: 'SOCK_STREAM' was not declared in this scope ../../Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:77:52: error: 'socketpair' was not declared in this scope make[1]: *** [Source/WebKit2/UIProcess/Launcher/gtk/libwebkit2gtk_3_0_la-ProcessLauncherGtk.lo] Error 1 make[1]: *** Waiting for unfinished jobs.... make[1]: Leaving directory `/opt/jhbuild/gnome3/checkout/WebKit/WebKitBuild/Release' make: *** [all] Error 2 The error goes away by including "sys/socket.h". 881799 1 199810 elima 2013-04-26 03:52:11 -0700 Created attachment 199810 Includes "sys/socket.h" in ProcessLauncherGtk.cpp, if OS is Linux 881801 2 elima 2013-04-26 03:57:58 -0700 Adding xlopez and mrobinson to CC. 881924 3 199810 commit-queue 2013-04-26 09:15:03 -0700 Comment on attachment 199810 Includes "sys/socket.h" in ProcessLauncherGtk.cpp, if OS is Linux Clearing flags on attachment: 199810 Committed r149192: <http://trac.webkit.org/changeset/149192> 881925 4 commit-queue 2013-04-26 09:15:04 -0700 All reviewed patches have been landed. Closing bug. 882182 5 zan 2013-04-27 09:46:20 -0700 *** Bug 115306 has been marked as a duplicate of this bug. *** 199810 2013-04-26 03:52:11 -0700 2013-04-26 09:15:02 -0700 Includes "sys/socket.h" in ProcessLauncherGtk.cpp, if OS is Linux 0001-GTK-Compilation-of-ProcessLauncherGtk.cpp-fails-due-.patch text/plain 1653 elima RnJvbSBiYzhhMTkxZmUzNjAyMDdiODIyMGUwZDIwNjVmMzZlZTBiOTIwOTYyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBFZHVhcmRvIExpbWEgTWl0ZXYgPGVsaW1hQGlnYWxpYS5jb20+ CkRhdGU6IEZyaSwgMjYgQXByIDIwMTMgMTI6NDg6MTAgKzAyMDAKU3ViamVjdDogW1BBVENIXSBb R1RLXSBDb21waWxhdGlvbiBvZiBQcm9jZXNzTGF1bmNoZXJHdGsuY3BwIGZhaWxzIGR1ZSB0bwog dW5yZXNvbHZlZCBzeW1ib2xzCiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTE1MjQwCgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiogVUlQcm9jZXNzL0xhdW5j aGVyL2d0ay9Qcm9jZXNzTGF1bmNoZXJHdGsuY3BwOiBJbmNsdWRlcyBzeXMvc29ja2V0LmggaWYg T1MgaXMgTGludXgKLS0tCiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgfCAgICA5ICsrKysrKysrKwogU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0xhdW5jaGVyL2d0ay9Qcm9jZXNzTGF1bmNoZXJHdGsuY3BwIHwgICAgMSArCiAyIGZp bGVzIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMWM4ODQyYi4uMzJh YTY3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEzLTA0LTI2ICBFZHVhcmRvIExp bWEgTWl0ZXYgIDxlbGltYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIENvbXBpbGF0aW9u IG9mIFByb2Nlc3NMYXVuY2hlckd0ay5jcHAgZmFpbHMgZHVlIHRvIHVucmVzb2x2ZWQgc3ltYm9s cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1MjQw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvTGF1bmNoZXIvZ3RrL1Byb2Nlc3NMYXVuY2hlckd0ay5jcHA6IEluY2x1ZGVzIHN5cy9z b2NrZXQuaCBpZiBPUyBpcyBMaW51eAorCiAyMDEzLTA0LTI1ICBaYW4gRG9iZXJzZWsgIDx6ZG9i ZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBQbHVnaW4gcHJvY2VzcyBicm9rZW4g ZHVlIHRvIGEgbWlzc2luZyBzeW1ib2wKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9MYXVuY2hlci9ndGsvUHJvY2Vzc0xhdW5jaGVyR3RrLmNwcCBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9MYXVuY2hlci9ndGsvUHJvY2Vzc0xhdW5jaGVyR3RrLmNwcAppbmRleCBjODEz OGQ3Li5mNjVjN2VkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNo ZXIvZ3RrL1Byb2Nlc3NMYXVuY2hlckd0ay5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0xhdW5jaGVyL2d0ay9Qcm9jZXNzTGF1bmNoZXJHdGsuY3BwCkBAIC00Myw2ICs0Myw3IEBA CiAKICNpZiBPUyhMSU5VWCkKICNpbmNsdWRlIDxzeXMvcHJjdGwuaD4KKyNpbmNsdWRlIDxzeXMv c29ja2V0Lmg+CiAjZW5kaWYKIAogI2lmZGVmIFNPQ0tfU0VRUEFDS0VUCi0tIAoxLjcuMTAuNAoK