<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>115230</bug_id>
          
          <creation_ts>2013-04-26 00:30:53 -0700</creation_ts>
          <short_desc>[soup] The public WK header file should not include WKAPICast.h</short_desc>
          <delta_ts>2013-05-26 18:57:14 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit API</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Changhun Kang">chkang514</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>cgarcia</cc>
    
    <cc>chkang514</cc>
    
    <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>mrobinson</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>881733</commentid>
    <comment_count>0</comment_count>
    <who name="Changhun Kang">chkang514</who>
    <bug_when>2013-04-26 00:30:53 -0700</bug_when>
    <thetext>Don&apos;t include WKAPICast.h in a public WK header.

WKSoupRequestManager.h includes WKAPICast.h</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>881736</commentid>
    <comment_count>1</comment_count>
      <attachid>199793</attachid>
    <who name="Changhun Kang">chkang514</who>
    <bug_when>2013-04-26 00:40:02 -0700</bug_when>
    <thetext>Created attachment 199793
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>893851</commentid>
    <comment_count>2</comment_count>
      <attachid>199793</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-05-26 18:05:26 -0700</bug_when>
    <thetext>Comment on attachment 199793
Patch

Rejecting attachment 199793 from review queue.

temoochin@company100.net does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>893873</commentid>
    <comment_count>3</comment_count>
      <attachid>199793</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-05-26 18:57:12 -0700</bug_when>
    <thetext>Comment on attachment 199793
Patch

Clearing flags on attachment: 199793

Committed r150732: &lt;http://trac.webkit.org/changeset/150732&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>893874</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-05-26 18:57:14 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>199793</attachid>
            <date>2013-04-26 00:40:02 -0700</date>
            <delta_ts>2013-05-26 18:57:12 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-115230-20130426003920.patch</filename>
            <type>text/plain</type>
            <size>1864</size>
            <attacher name="Changhun Kang">chkang514</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5MTY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMWM4ODQyYjcxOWIzZGJi
Mzg3NzNhZjExOGE5ZWVjODlkM2E5NWM2OS4uZWM2NDVkZjYwMDAyYTM5YjM1ZmE1YjM2NzY5NTk1
OWRmODIzYzY0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA0LTI2ICBDaGFu
Z2h1biBLYW5nICA8dGVtb29jaGluQGNvbXBhbnkxMDAubmV0PgorCisgICAgICAgIFRoZSBwdWJs
aWMgV0sgaGVhZGVyIGZpbGUgc2hvdWxkIG5vdCBpbmNsdWRlIFdLQVBJQ2FzdC5oCisgICAgICAg
IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTUyMzAKKworICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPdGhlcndpc2UsIFdlYktp
dCBpbnRlcm5hbCBoZWFkZXJzIGFyZSBleHBvc2VkLgorICAgICAgICBObyBuZXcgdGVzdHMuIE5v
IGNoYW5nZSBpbiBiZWhhdmlvci4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0Mvc291cC9XS1Nv
dXBSZXF1ZXN0TWFuYWdlci5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9zb3VwL1dlYlNvdXBSZXF1
ZXN0TWFuYWdlckNsaWVudC5oOgorCiAyMDEzLTA0LTI1ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJz
ZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBQbHVnaW4gcHJvY2VzcyBicm9rZW4gZHVl
IHRvIGEgbWlzc2luZyBzeW1ib2wKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz
cy9BUEkvQy9zb3VwL1dLU291cFJlcXVlc3RNYW5hZ2VyLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy
b2Nlc3MvQVBJL0Mvc291cC9XS1NvdXBSZXF1ZXN0TWFuYWdlci5oCmluZGV4IDRkYmExMzkwODJm
MzcxMzk4Njc0YWUzZTkyOWI1NDhiMzZkYWMzN2IuLjY4OTJkZTRiZjZhZWI0YzQ5YTU2ZjRkZWRk
ZjU0YWM1OWQ2NmI2NzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv
Qy9zb3VwL1dLU291cFJlcXVlc3RNYW5hZ2VyLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j
ZXNzL0FQSS9DL3NvdXAvV0tTb3VwUmVxdWVzdE1hbmFnZXIuaApAQCAtMjYsNyArMjYsNiBAQAog
I2lmbmRlZiBXS1NvdXBSZXF1ZXN0TWFuYWdlcl9oCiAjZGVmaW5lIFdLU291cFJlcXVlc3RNYW5h
Z2VyX2gKIAotI2luY2x1ZGUgIldLQVBJQ2FzdC5oIgogI2luY2x1ZGUgPFdlYktpdDIvV0tCYXNl
Lmg+CiAKICNpZmRlZiBfX2NwbHVzcGx1cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ
cm9jZXNzL3NvdXAvV2ViU291cFJlcXVlc3RNYW5hZ2VyQ2xpZW50LmggYi9Tb3VyY2UvV2ViS2l0
Mi9VSVByb2Nlc3Mvc291cC9XZWJTb3VwUmVxdWVzdE1hbmFnZXJDbGllbnQuaAppbmRleCBlMjQ3
ZmVjZDdhNzZiNTg4NWU2NWUwOTk5ZWQ4NjczOTc4YjA2ZTAzLi42MGIzNDkzN2Y4ZTZiZjYzYmIz
Y2UwMzdkMzRmNjU0NTRhMjg3MDI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl
c3Mvc291cC9XZWJTb3VwUmVxdWVzdE1hbmFnZXJDbGllbnQuaAorKysgYi9Tb3VyY2UvV2ViS2l0
Mi9VSVByb2Nlc3Mvc291cC9XZWJTb3VwUmVxdWVzdE1hbmFnZXJDbGllbnQuaApAQCAtMjEsNiAr
MjEsNyBAQAogI2RlZmluZSBXZWJTb3VwUmVxdWVzdE1hbmFnZXJDbGllbnRfaAogCiAjaW5jbHVk
ZSAiQVBJQ2xpZW50LmgiCisjaW5jbHVkZSAiV0tBUElDYXN0LmgiCiAjaW5jbHVkZSAiV0tTb3Vw
UmVxdWVzdE1hbmFnZXIuaCIKIAogbmFtZXNwYWNlIFdlYktpdCB7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>