115229 2013-04-26 00:05:11 -0700 [sh4] JavaScriptCore JIT build is broken for sh4 arch since r149159 2013-04-26 02:35:35 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 jbriance webkit-unassigned commit-queue fpizlo mark.lam oliver oldest_to_newest 881726 0 jbriance 2013-04-26 00:05:11 -0700 See SH4 bot: http://build.webkit.org/builders/Qt%20Linux%20SH4%20Release/builds/24976 /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/jit/ThunkGenerators.cpp: In function 'JSC::MacroAssemblerCodeRef JSC::imulThunkGenerator(JSC::VM*)': /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/jit/ThunkGenerators.cpp:786:99: error: 'BranchIfTruncateSuccessful' is not a member of 'JSC::SpecializedThunkJIT' /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/jit/ThunkGenerators.cpp:795:99: error: 'BranchIfTruncateSuccessful' is not a member of 'JSC::SpecializedThunkJIT' make[3]: *** [.obj/release-shared/jit/ThunkGenerators.o] Error 1 make[3]: *** Waiting for unfinished jobs.... make[3]: Leaving directory `/local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/WebKitBuild/Release/Source/JavaScriptCore' I'll submit a patch soon 881745 1 199794 jbriance 2013-04-26 01:01:23 -0700 Created attachment 199794 Add BranchTruncateType enum in SH4 port I've declared the "enum BranchTruncateType" in MacroAssemblerSH4.h, like it is done in MacroAssemblerARM.h, MacroAssemblerARMv7.h, MacroAssemblerMIPS.h and MacroAssemblerX86Common.h Perhaps we could remove all these declarations from MacroAssemblerxxx.h and put it one single declaration in MacroAssembler.h ? 881782 2 199794 commit-queue 2013-04-26 02:35:34 -0700 Comment on attachment 199794 Add BranchTruncateType enum in SH4 port Clearing flags on attachment: 199794 Committed r149172: <http://trac.webkit.org/changeset/149172> 881783 3 commit-queue 2013-04-26 02:35:35 -0700 All reviewed patches have been landed. Closing bug. 199794 2013-04-26 01:01:23 -0700 2013-04-26 02:35:33 -0700 Add BranchTruncateType enum in SH4 port bug-115229.patch text/plain 2158 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ5MTcwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEzLTA0LTI2ICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VhdUBuZHMuY29tPgorCisg ICAgICAgIEZpeCBTSDQgYnVpbGQgYnJva2VuIHNpbmNlIHIxNDkxNTkuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTUyMjkKKworICAgICAgICBBZGQg QnJhbmNoVHJ1bmNhdGVUeXBlIGVudW0gaW4gU0g0IHBvcnQgYW5kIGhhbmRsZSBpdCBpbiBicmFu Y2hUcnVuY2F0ZURvdWJsZVRvSW50MzIuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJTSDQuaDoKKyAgICAg ICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJTSDQ6OmJyYW5jaFRydW5jYXRlRG91YmxlVG9JbnQzMik6 CisKIDIwMTMtMDQtMjUgIE1hcmsgSGFobmVuYmVyZyAgPG1oYWhuZW5iZXJnQGFwcGxlLmNvbT4K IAogICAgICAgICBTdXBlclJlZ2lvbiBkb2Vzbid0IGNhbGwgZGVhbGxvY2F0ZSgpIG9uIGl0cyBQ YWdlUmVzZXJ2YXRpb24KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFj cm9Bc3NlbWJsZXJTSDQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNz ZW1ibGVyL01hY3JvQXNzZW1ibGVyU0g0LmgJKHJldmlzaW9uIDE0OTE2OSkKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJTSDQuaAkod29ya2luZyBjb3B5 KQpAQCAtMTUxOCwxNiArMTUxOCwxNyBAQCBwdWJsaWM6CiAgICAgICAgIHJlbGVhc2VTY3JhdGNo KGFkZHJlc3NUZW1wUmVnaXN0ZXIpOwogICAgIH0KIAotICAgIEp1bXAgYnJhbmNoVHJ1bmNhdGVE b3VibGVUb0ludDMyKEZQUmVnaXN0ZXJJRCBzcmMsIFJlZ2lzdGVySUQgZGVzdCkKKyAgICBlbnVt IEJyYW5jaFRydW5jYXRlVHlwZSB7IEJyYW5jaElmVHJ1bmNhdGVGYWlsZWQsIEJyYW5jaElmVHJ1 bmNhdGVTdWNjZXNzZnVsIH07CisgICAgSnVtcCBicmFuY2hUcnVuY2F0ZURvdWJsZVRvSW50MzIo RlBSZWdpc3RlcklEIHNyYywgUmVnaXN0ZXJJRCBkZXN0LCBCcmFuY2hUcnVuY2F0ZVR5cGUgYnJh bmNoVHlwZSA9IEJyYW5jaElmVHJ1bmNhdGVGYWlsZWQpCiAgICAgewogICAgICAgICBtX2Fzc2Vt Ymxlci5mdHJjZHJtZnB1bChzcmMpOwogICAgICAgICBtX2Fzc2VtYmxlci5zdHNmcHVsUmVnKGRl c3QpOwogICAgICAgICBtX2Fzc2VtYmxlci5sb2FkQ29uc3RhbnQoMHg3ZmZmZmZmZiwgc2NyYXRj aFJlZzMpOwotICAgICAgICBtX2Fzc2VtYmxlci5jbXBsUmVnUmVnKGRlc3QsIHNjcmF0Y2hSZWcz LCBTSDRDb25kaXRpb24oRXF1YWwpKTsKKyAgICAgICAgbV9hc3NlbWJsZXIuY21wbFJlZ1JlZyhk ZXN0LCBzY3JhdGNoUmVnMywgU0g0Q29uZGl0aW9uKGJyYW5jaFR5cGUgPT0gQnJhbmNoSWZUcnVu Y2F0ZUZhaWxlZCA/IEVxdWFsIDogTm90RXF1YWwpKTsKICAgICAgICAgbV9hc3NlbWJsZXIuZW5z dXJlU3BhY2UobV9hc3NlbWJsZXIubWF4SW5zdHJ1Y3Rpb25TaXplICsgMTQsIHNpemVvZih1aW50 MzJfdCkpOwogICAgICAgICBtX2Fzc2VtYmxlci5icmFuY2goQlRfT1BDT0RFLCAyKTsKICAgICAg ICAgbV9hc3NlbWJsZXIuYWRkbEltbThyKDEsIHNjcmF0Y2hSZWczKTsKLSAgICAgICAgbV9hc3Nl bWJsZXIuY21wbFJlZ1JlZyhkZXN0LCBzY3JhdGNoUmVnMywgU0g0Q29uZGl0aW9uKEVxdWFsKSk7 CisgICAgICAgIG1fYXNzZW1ibGVyLmNtcGxSZWdSZWcoZGVzdCwgc2NyYXRjaFJlZzMsIFNINENv bmRpdGlvbihicmFuY2hUeXBlID09IEJyYW5jaElmVHJ1bmNhdGVGYWlsZWQgPyBFcXVhbCA6IE5v dEVxdWFsKSk7CiAgICAgICAgIHJldHVybiBicmFuY2hUcnVlKCk7CiAgICAgfQogCg==