115218 2013-04-25 20:19:12 -0700 Remove support for Chromium from build/update script 2013-04-25 21:49:27 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 seokju webkit-unassigned commit-queue oldest_to_newest 881663 0 seokju 2013-04-25 20:19:12 -0700 SSIA 881665 1 199775 seokju 2013-04-25 20:21:39 -0700 Created attachment 199775 Patch 881666 2 199775 gyuyoung.kim 2013-04-25 21:00:59 -0700 Comment on attachment 199775 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199775&action=review > Tools/Scripts/update-webkit:58 > 'gyp' => \$useGYP, Don't you need to remove 'gyp' as well ? As far as I know, gyp was for chromium 881667 3 seokju 2013-04-25 21:06:37 -0700 It seems that isAppleMacWebKit is using it. elsif (isAppleMacWebKit()) { my @local_options = @options; push @local_options, XcodeCoverageSupportOptions() if $coverageSupport && $project ne "ANGLE"; my $useGYPProject = $useGYP && ($project =~ "WebCore|JavaScriptCore"); my $projectPath = $useGYPProject ? "gyp/$project" : $project; $projectPath = $project =~ /gtest/ ? "xcode/gtest" : $project; $result = buildXCodeProject($projectPath, $clean, @local_options, @ARGV); } 881680 4 199775 commit-queue 2013-04-25 21:49:25 -0700 Comment on attachment 199775 Patch Clearing flags on attachment: 199775 Committed r149166: <http://trac.webkit.org/changeset/149166> 881681 5 commit-queue 2013-04-25 21:49:27 -0700 All reviewed patches have been landed. Closing bug. 199775 2013-04-25 20:21:39 -0700 2013-04-25 21:49:24 -0700 Patch bug-115218-20130426122059.patch text/plain 5537 seokju U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5MTY1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDZiN2IzNmMxYzNiN2IwMGIzMzU5YzRiNDViMGMxMmQw MGNmOWY1ZS4uZmVkNjFhZDQ3MzA0YTU4NmFjYWQyZmZjMzM1YzlhMDk5M2IxZGRhNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2 IEBACiAyMDEzLTA0LTI1ICBTZW9ranUgS3dvbiAgPHNlb2tqdS5rd29uQGdtYWlsLmNvbT4KIAor ICAgICAgICBSZW1vdmUgc3VwcG9ydCBmb3IgQ2hyb21pdW0gZnJvbSBidWlsZC91cGRhdGUgc2Ny aXB0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1 MjE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBT Y3JpcHRzL2J1aWxkLXdlYmtpdDoKKyAgICAgICAgKHdyaXRlQ29uZ3JhdHMpOgorICAgICAgICAq IFNjcmlwdHMvdXBkYXRlLXdlYmtpdDoKKworMjAxMy0wNC0yNSAgU2Vva2p1IEt3b24gIDxzZW9r anUua3dvbkBnbWFpbC5jb20+CisKICAgICAgICAgUmVtb3ZlIHN1cHBvcnQgZm9yIENocm9taXVt IGZyb20gYXBpLXRlc3QKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTExNTIxMQogCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdCBi L1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CmluZGV4IDllOTRkMmJkZTU5YzFkYTFhYjM3YTYx ZDBiNTA2OTRlOTRiZDVlN2UuLjU3MTliMDAwMTRjNTU3Y2Y1MzFkZmIxMTA2ZDQyNjdjYzA5NmRj M2IgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CisrKyBiL1Rvb2xzL1Nj cmlwdHMvYnVpbGQtd2Via2l0CkBAIC0xMTcsOCArMTE3LDYgQEAgVXNhZ2U6ICRwcm9ncmFtTmFt ZSBbb3B0aW9uc10gW29wdGlvbnMgdG8gcGFzcyB0byBidWlsZCBzeXN0ZW1dCiAgIC0tY292ZXJh Z2UgICAgICAgICAgICAgICAgICAgICAgICBFbmFibGUgQ29kZSBDb3ZlcmFnZSBzdXBwb3J0IChN YWMgb25seSkKIAogICAtLWJsYWNrYmVycnkgICAgICAgICAgICAgICAgICAgICAgQnVpbGQgdGhl IEJsYWNrQmVycnkgcG9ydCBvbiBNYWMvTGludXgKLSAgLS1jaHJvbWl1bSAgICAgICAgICAgICAg ICAgICAgICAgIEJ1aWxkIHRoZSBDaHJvbWl1bSBwb3J0IG9uIE1hYy9XaW4vTGludXgKLSAgLS1j aHJvbWl1bS1hbmRyb2lkICAgICAgICAgICAgICAgIEJ1aWxkIHRoZSBDaHJvbWl1bSBwb3J0IG9u IEFuZHJvaWQKICAgLS1lZmwgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEJ1aWxkIHRoZSBF RkwgcG9ydAogICAtLWd0ayAgICAgICAgICAgICAgICAgICAgICAgICAgICAgQnVpbGQgdGhlIEdU SysgcG9ydAogICAtLXF0ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgQnVpbGQgdGhlIFF0 IHBvcnQKQEAgLTI4MSwzMCArMjc5LDYgQEAgaWYgKGlzSW5zcGVjdG9yRnJvbnRlbmQoKSkgewog CiBteSAkcmVzdWx0ID0gMDsKIAotaWYgKGlzQ2hyb21pdW0oKSkgewotICAgICMgQ3VycmVudGx5 IGNocm9taXVtIGRvZXMgbm90IGhvbm91ciB0aGUgZmVhdHVyZXMgcGFzc2VkIHRvIGJ1aWxkLXdl YmtpdC4KLSAgICAjIFVudGlsIHRoaXMgaXMgc29sdmVkLCB3ZSBpc3N1ZSBhIHdhcm5pbmcgYWJv dXQgdGhhdC4KLSAgICBmb3JlYWNoIChAZmVhdHVyZXMpIHsKLSAgICAgICAgaWYgKCR7JF8tPnt2 YWx1ZX19IG5lICRfLT57ZGVmYXVsdH0pIHsKLSAgICAgICAgICAgIHByaW50ICJcbiI7Ci0gICAg ICAgICAgICBwcmludCAiPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT1cbiI7Ci0gICAgICAgICAgICBwcmludCAiIENocm9taXVtIGRvZXMg bm90IGhvbm9yIHRoZSBmZWF0dXJlcyBwYXNzZWQgdG8gYnVpbGQtd2Via2l0LlxuIjsKLSAgICAg ICAgICAgIHByaW50ICIgVGhlIHByZWZlcnJlZCB3YXkgaXMgdG8gc2V0IHVwIHlvdXIgb3ZlcnJp ZGVzIGluIH4vLmd5cC9pbmNsdWRlLmd5cGkuXG4iOwotICAgICAgICAgICAgcHJpbnQgIiBTZWUg aHR0cHM6Ly90cmFjLndlYmtpdC5vcmcvd2lraS9DaHJvbWl1bSNCdWlsZGluZ3dpdGhmZWF0dXJl ZGVmaW5lc1xuIjsKLSAgICAgICAgICAgIHByaW50ICIgb24gaG93IHRvIGRvIHRoYXQuXG4iOwot ICAgICAgICAgICAgcHJpbnQgIj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09XG4iOwotICAgICAgICAgICAgbGFzdDsKLSAgICAgICAgfQot ICAgIH0KLQotICAgIEBvcHRpb25zID0gQEFSR1Y7Ci0gICAgIyBDaHJvbWl1bSBkb2Vzbid0IGJ1 aWxkIGJ5IHByb2plY3QgZGlyZWN0b3JpZXMuCi0gICAgQHByb2plY3RzID0gKCk7Ci0gICAgcHVz aCBAb3B0aW9ucywgIi0tbWFrZWFyZ3M9IiAuICRtYWtlQXJncyBpZiAkbWFrZUFyZ3M7Ci0gICAg JHJlc3VsdCA9IGJ1aWxkQ2hyb21pdW0oJGNsZWFuLCBAb3B0aW9ucyk7Ci0gICAgZXhpdCBleGl0 U3RhdHVzKCRyZXN1bHQpIGlmIGV4aXRTdGF0dXMoJHJlc3VsdCk7Ci19Ci0KIGlmIChpc0VmbCgp KSB7CiAgICAgIyBCeSBkZWZhdWx0IHdlIGJ1aWxkIHVzaW5nIGFsbCBvZiB0aGUgYXZhaWxhYmxl IENQVXMuCiAgICAgJG1ha2VBcmdzIC49ICgkbWFrZUFyZ3MgPyAiICIgOiAiIikgLiAiLWoiIC4g bnVtYmVyT2ZDUFVzKCkgaWYgJG1ha2VBcmdzICF+IC8talxzKlxkKy87CkBAIC00MzgsOSArNDEy LDcgQEAgc3ViIHdyaXRlQ29uZ3JhdHMoKQogICAgIHByaW50ICJcbiI7CiAgICAgcHJpbnQgIj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09XG4iOwogICAgIHByaW50ICIgV2ViS2l0IGlzIG5vdyBidWlsdCAoJGJ1aWxkVGlt ZSkuIFxuIjsKLSAgICBpZiAoIWlzQ2hyb21pdW0oKSkgewotICAgICAgICBwcmludCAiIFRvIHJ1 biAkbGF1bmNoZXJOYW1lIHdpdGggdGhpcyBuZXdseS1idWlsdCBjb2RlLCB1c2UgdGhlXG4iOwot ICAgICAgICBwcmludCAiIFwiJGxhdW5jaGVyUGF0aFwiIHNjcmlwdC5cbiI7Ci0gICAgfQorICAg IHByaW50ICIgVG8gcnVuICRsYXVuY2hlck5hbWUgd2l0aCB0aGlzIG5ld2x5LWJ1aWx0IGNvZGUs IHVzZSB0aGVcbiI7CisgICAgcHJpbnQgIiBcIiRsYXVuY2hlclBhdGhcIiBzY3JpcHQuXG4iOwog ICAgIHByaW50ICI9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PVxuIjsKIH0KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMv dXBkYXRlLXdlYmtpdCBiL1Rvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdAppbmRleCBkMGQxYWZl ZGE2MDVhNzY0ZmZlODBhOTcxZWVhYmU4NWQ3ZmVjOGZjLi5iZGI5N2U2MmY0M2VhYjNlMWY0Njdh NmEyMWFmOThjNWM4ODEwMThiIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3VwZGF0ZS13ZWJr aXQKKysrIGIvVG9vbHMvU2NyaXB0cy91cGRhdGUtd2Via2l0CkBAIC00NiwxMSArNDYsNyBAQCBz dWIgcnVuR2l0VXBkYXRlKCk7CiBteSAkcXVpZXQgPSAnJzsKIG15ICRzaG93SGVscDsKIG15ICR1 c2VHWVAgPSAwOwotbXkgJHVzZU1ha2UgPSAwOwotbXkgJHVzZU5pbmphID0gLTE7ICMgLTE6IExl dCB1cGRhdGUtd2Via2l0LWNocm9taXVtIHBpY2sgdGhlIGRlZmF1bHQuCiAKLWRldGVybWluZUlz Q2hyb21pdW0oKTsKLWRldGVybWluZUlzQ2hyb21pdW1BbmRyb2lkKCk7CiBkZXRlcm1pbmVJc1F0 KCk7CiBkZXRlcm1pbmVJc1dpbkNhaXJvKCk7CiAKQEAgLTYwLDE3ICs1NiwxMSBAQCBteSAkZ2V0 T3B0aW9uc1Jlc3VsdCA9IEdldE9wdGlvbnMoCiAgICAgJ2h8aGVscCcgID0+IFwkc2hvd0hlbHAs CiAgICAgJ3F8cXVpZXQnID0+IFwkcXVpZXQsCiAgICAgJ2d5cCcgPT4gXCR1c2VHWVAsCi0gICAg J21ha2UnID0+IFwkdXNlTWFrZSwKLSAgICAnbmluamEhJyA9PiBcJHVzZU5pbmphLAogKTsgCiAK IGlmICghJGdldE9wdGlvbnNSZXN1bHQgfHwgJHNob3dIZWxwKSB7CiAgICAgcHJpbnQgU1RERVJS IDw8X19FTkRfXzsKIFVzYWdlOiBAe1sgYmFzZW5hbWUoJDApIF19IFtvcHRpb25zXQotICAtLWNo cm9taXVtICAgICAgICAgIGFsc28gdXBkYXRlIGRlcGVuZGVuY2llcyBvZiB0aGUgY2hyb21pdW0g cG9ydAotICAtLW1ha2UgICAgICAgICAgICAgIGdlbmVyYXRlIHRoZSBNYWtlZmlsZS1iYXNlZCBi dWlsZCBzeXN0ZW0gKENocm9taXVtIG9ubHkpCi0gIC0tW25vLV1uaW5qYSAgICAgICAgZ2VuZXJh dGUgdGhlIG5pbmphLWJhc2VkIGJ1aWxkIHN5c3RlbSAoQ2hyb21pdW0gb25seSkKLSAgLS1jaHJv bWl1bS1hbmRyb2lkICBhbHNvIHVwZGF0ZSBkZXBlbmRlbmNpZXMgb2YgdGhlIGNocm9taXVtIHBv cnQgZm9yIEFuZHJvaWQKICAgLWh8LS1oZWxwICAgICAgICAgICBzaG93IHRoZSBoZWxwIG1lc3Nh Z2UKICAgLXF8LS1xdWlldCAgICAgICAgICBwYXNzIC1xIHRvIHN2biB1cGRhdGUgZm9yIHF1aWV0 IHVwZGF0ZXMKICAgLS1neXAgICAgICAgICAgICAgICBnZW5lcmF0ZSBwcm9qZWN0IGZpbGVzIGZy b20gZ3lwIGFmdGVyIHVwZGF0ZQpAQCAtNzksMTAgKzY5LDYgQEAgX19FTkRfXwogICAgIGV4aXQg MTsKIH0KIAotaWYgKCR1c2VNYWtlKSB7Ci0gICAgJEVOVnsiR1lQX0dFTkVSQVRPUlMifSA9ICJt YWtlIjsKLX0KLQogbXkgQHN2bk9wdGlvbnMgPSAoKTsKIHB1c2ggQHN2bk9wdGlvbnMsICctcScg aWYgJHF1aWV0OwogCkBAIC05OCwxMyArODQsNiBAQCBpZiAoLWQgIi4uL0ludGVybmFsIikgewog ICAgIHByaW50ICJVcGRhdGluZyBJbnRlcm5hbFxuIiB1bmxlc3MgJHF1aWV0OwogICAgIHJ1blN2 blVwZGF0ZSgpIGlmIGlzU1ZORGlyZWN0b3J5KCIuIik7CiAgICAgcnVuR2l0VXBkYXRlKCkgaWYg aXNHaXREaXJlY3RvcnkoIi4iKTsKLX0gZWxzaWYgKGlzQ2hyb21pdW0oKSkgewotICAgIG15IEBj aHJvbWl1bVVwZGF0ZUFyZ3MgPSAoInBlcmwiLCAiVG9vbHMvU2NyaXB0cy91cGRhdGUtd2Via2l0 LWNocm9taXVtIik7Ci0gICAgcHVzaCBAY2hyb21pdW1VcGRhdGVBcmdzLCAiLS1jaHJvbWl1bS1h bmRyb2lkIiBpZiBpc0Nocm9taXVtQW5kcm9pZCgpOwotICAgIHB1c2ggQGNocm9taXVtVXBkYXRl QXJncywgIi0tZm9yY2UiIGlmIGZvcmNlQ2hyb21pdW1VcGRhdGUoKTsKLSAgICBwdXNoIEBjaHJv bWl1bVVwZGF0ZUFyZ3MsICItLW5pbmphIiBpZiAkdXNlTmluamEgPT0gMTsKLSAgICBwdXNoIEBj aHJvbWl1bVVwZGF0ZUFyZ3MsICItLW5vLW5pbmphIiBpZiAkdXNlTmluamEgPT0gMDsKLSAgICBz eXN0ZW0oQGNocm9taXVtVXBkYXRlQXJncykgPT0gMCBvciBkaWUgJCE7CiB9IGVsc2lmIChpc0Fw cGxlV2luV2ViS2l0KCkpIHsKICAgICBzeXN0ZW0oInBlcmwiLCAiVG9vbHMvU2NyaXB0cy91cGRh dGUtd2Via2l0LWF1eGlsaWFyeS1saWJzIikgPT0gMCBvciBkaWU7CiAgICAgaWYgKGlzV2luQ2Fp cm8oKSkgewo=