115215 2013-04-25 17:58:07 -0700 Use push and pop for iOS math function thunks 2013-04-29 16:53:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 115144 1 benjamin benjamin fpizlo msaboff oldest_to_newest 881638 0 benjamin 2013-04-25 17:58:07 -0700 Use push and pop for iOS math function thunks 881639 1 199770 benjamin 2013-04-25 18:00:36 -0700 Created attachment 199770 Patch 882242 2 199770 fpizlo 2013-04-27 15:17:00 -0700 Comment on attachment 199770 Patch Did you test that calling printf() or similar from jsRound() for example, and then calling Math.round(), works without crashing? 882243 3 benjamin 2013-04-27 15:20:10 -0700 (In reply to comment #2) > (From update of attachment 199770 [details]) > Did you test that calling printf() or similar from jsRound() for example, and then calling Math.round(), works without crashing? I'll try that on Monday. I am pretty sure of the alignment on 4 bytes because I already accidentally ran into that when I wrote TransformationMatrix's optimizations. I assumed the stack would be at least aligned to 8 bytes when writing the VFP code, and that happily crashed in the tests. 882244 4 199770 fpizlo 2013-04-27 15:21:08 -0700 Comment on attachment 199770 Patch Would be good to do that test before landing. Otherwise, r=me. 882827 5 benjamin 2013-04-29 16:49:50 -0700 (In reply to comment #4) > (From update of attachment 199770 [details]) > Would be good to do that test before landing. Otherwise, r=me. I just tried on an Apple A5, no problem with printf called from jsRound. 882830 6 199770 benjamin 2013-04-29 16:53:27 -0700 Comment on attachment 199770 Patch Clearing flags on attachment: 199770 Committed r149331: <http://trac.webkit.org/changeset/149331> 882831 7 benjamin 2013-04-29 16:53:29 -0700 All reviewed patches have been landed. Closing bug. 199770 2013-04-25 18:00:36 -0700 2013-04-29 16:53:27 -0700 Patch bug-115215-20130425175957.patch text/plain 1889 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5MTU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx YWJkYTM3YjA4NjBkNzU5ODc3OGNjNGMxZGRlMDIxZmM0MzhmY2Y3Li43MmUwMThjNDJhOGUzMzQ4 ZTJlOGFmNWI0Y2FjOTdlOTZiYzYyMTE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxMy0wNC0yNSAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KKworICAgICAgICBVc2UgcHVzaCBhbmQgcG9wIGZvciBpT1MgbWF0aCBmdW5jdGlvbiB0 aHVua3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx NTIxNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo ZSBpT1MgQUJJIGlzIGEgbGl0dGxlIGRpZmZlcmVudCB0aGFuIHJlZ3VsYXIgQVJNIEFCSSByZWdh cmRpbmcgc3RhY2sgYWxpZ25tZW50LgorICAgICAgICBUaGUgcmVxdWlyZW1lbnQgaXMgNCBieXRl czoKKyAgICAgICAgIlRoZSBBUk0gZW52aXJvbm1lbnQgdXNlcyBhIHN0YWNrIHRoYXTigJRhdCB0 aGUgcG9pbnQgb2YgZnVuY3Rpb24gY2FsbHPigJRpcyA0LWJ5dGUgYWxpZ25lZCwKKyAgICAgICAg IGdyb3dzIGRvd253YXJkLCBhbmQgY29udGFpbnMgbG9jYWwgdmFyaWFibGVzIGFuZCBhIGZ1bmN0 aW9u4oCZcyBwYXJhbWV0ZXJzLiIKKworICAgICAgICBTdWJzZXF1ZW50bHksIHdlIGNhbiBqdXN0 IHVzZSBwdXNoIGFuZCBwb3AgdG8gcHJlc2VydmUgdGhlIGxpbmsgcmVnaXN0ZXIuCisKKyAgICAg ICAgKiBqaXQvVGh1bmtHZW5lcmF0b3JzLmNwcDoKKwogMjAxMy0wNC0yNSAgRmlsaXAgUGl6bG8g IDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIFByZWNpc2VKdW1wVGFyZ2V0cyBzaG91bGQg dHJlYXQgbG9vcF9oaW50IGFzIGEganVtcCB0YXJnZXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9qaXQvVGh1bmtHZW5lcmF0b3JzLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9qaXQvVGh1bmtHZW5lcmF0b3JzLmNwcAppbmRleCA4NDkwZmQ3OWQxYjIxZTcxZmFjNzE4YzYz MjNiYWM1MzNiMmJmMzZjLi5mNDg1MDUzMzIwMzA1YWQ2MmI2ZTdjZjU2NjljNGZkOTEzZWEzYjk0 IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1RodW5rR2VuZXJhdG9ycy5j cHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9UaHVua0dlbmVyYXRvcnMuY3BwCkBA IC01NTUsMTMgKzU1NSwxMSBAQCBkb3VibGUganNSb3VuZChkb3VibGUgZCkKICAgICAgICAgIi50 aHVtYlxuIiBcCiAgICAgICAgICIudGh1bWJfZnVuYyAiIFRIVU1CX0ZVTkNfUEFSQU0oZnVuY3Rp b24jI1RodW5rKSAiXG4iIFwKICAgICAgICAgU1lNQk9MX1NUUklORyhmdW5jdGlvbiMjVGh1bmsp ICI6IiAiXG4iIFwKLSAgICAgICAgInN1YiBzcCwgc3AsICMxNlxuIiBcCi0gICAgICAgICJzdHIg bHIsIFtzcCwgIzBdXG4iIFwKKyAgICAgICAgInB1c2gge2xyfVxuIiBcCiAgICAgICAgICJ2bW92 IHIwLCByMSwgZDBcbiIgXAogICAgICAgICAiYmx4ICIgR0xPQkFMX1JFRkVSRU5DRShmdW5jdGlv bikgIlxuIiBcCiAgICAgICAgICJ2bW92IGQwLCByMCwgcjFcbiIgXAotICAgICAgICAibGRyIGxy LCBbc3AsICMwXVxuIiBcCi0gICAgICAgICJhZGQgc3AsIHNwLCAjMTZcbiIgXAorICAgICAgICAi cG9wIHtscn1cbiIgXAogICAgICAgICAiYnggbHJcbiIgXAogICAgICk7IFwKICAgICBleHRlcm4g IkMiIHsgXAo=