115208 2013-04-25 15:18:03 -0700 SuperRegion doesn't call deallocate() on its PageReservation 2013-04-25 23:17:32 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 115227 1 mhahnenberg mhahnenberg commit-queue oldest_to_newest 881580 0 mhahnenberg 2013-04-25 15:18:03 -0700 It should. This doesn't cause us to leak physical memory, but it does cause us to leak virtual address space (and probably mach ports), which is also bad :-( FixedVMPoolExecutableAllocator also has this bug, but it doesn't matter much because there's only one instance of that class throughout the entire lifetime of the process, whereas each VM has its own SuperRegion. 881589 1 199759 mhahnenberg 2013-04-25 15:29:09 -0700 Created attachment 199759 Patch 881590 2 199760 mhahnenberg 2013-04-25 15:30:31 -0700 Created attachment 199760 Patch 881622 3 199760 ggaren 2013-04-25 17:22:49 -0700 Comment on attachment 199760 Patch r=me 881658 4 199760 commit-queue 2013-04-25 19:46:22 -0700 Comment on attachment 199760 Patch Clearing flags on attachment: 199760 Committed r149165: <http://trac.webkit.org/changeset/149165> 881659 5 commit-queue 2013-04-25 19:46:24 -0700 All reviewed patches have been landed. Closing bug. 881662 6 mhahnenberg 2013-04-25 20:18:11 -0700 <rdar://problem/13745392> 199759 2013-04-25 15:29:09 -0700 2013-04-25 15:30:28 -0700 Patch bug-115208-20130425152839.patch text/plain 3238 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ5MTQ4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDEzLTA0LTI1ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgU3VwZXJSZWdpb24gZG9lc24ndCBjYWxsIGRlYWxsb2NhdGUoKSBvbiBpdHMgUGFn ZVJlc2VydmF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTUyMDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBJdCBzaG91bGQuIFRoaXMgZG9lc24ndCBjYXVzZSB1cyB0byBsZWFrIHBoeXNpY2FsIG1l bW9yeSwgYnV0IGl0IGRvZXMgY2F1c2UgdXMgdG8gbGVhayB2aXJ0dWFsIAorICAgICAgICBhZGRy ZXNzIHNwYWNlIChhbmQgcHJvYmFibHkgbWFjaCBwb3J0cyksIHdoaWNoIGlzIGFsc28gYmFkIDot KCBGaXhlZFZNUG9vbEV4ZWN1dGFibGVBbGxvY2F0b3IgCisgICAgICAgIGFsc28gaGFzIHRoaXMg YnVnLCBidXQgaXQgZG9lc24ndCBtYXR0ZXIgbXVjaCBiZWNhdXNlIHRoZXJlJ3Mgb25seSBvbmUg aW5zdGFuY2Ugb2YgdGhhdCBjbGFzcyAKKyAgICAgICAgdGhyb3VnaG91dCB0aGUgZW50aXJlIGxp ZmV0aW1lIG9mIHRoZSBwcm9jZXNzLCB3aGVyZWFzIGVhY2ggVk0gaGFzIGl0cyBvd24gU3VwZXJS ZWdpb24uIAorCisgICAgICAgICogaGVhcC9TdXBlclJlZ2lvbi5jcHA6CisgICAgICAgIChKU0M6 OlN1cGVyUmVnaW9uOjp+U3VwZXJSZWdpb24pOgorICAgICAgICAqIGhlYXAvU3VwZXJSZWdpb24u aDoKKyAgICAgICAgKFN1cGVyUmVnaW9uKToKKyAgICAgICAgKiBqaXQvRXhlY3V0YWJsZUFsbG9j YXRvckZpeGVkVk1Qb29sLmNwcDoKKyAgICAgICAgKEZpeGVkVk1Qb29sRXhlY3V0YWJsZUFsbG9j YXRvcik6CisgICAgICAgIChKU0M6OkZpeGVkVk1Qb29sRXhlY3V0YWJsZUFsbG9jYXRvcjo6fkZp eGVkVk1Qb29sRXhlY3V0YWJsZUFsbG9jYXRvcik6CisKIDIwMTMtMDQtMjUgIE9saXZlciBIdW50 ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBTdGFjayBndWFyZHMgYXJlIHRvbyBjb25z ZXJ2YXRpdmUKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL1N1cGVyUmVnaW9uLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9TdXBlclJlZ2lvbi5j cHAJKHJldmlzaW9uIDE0OTEzMykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL1N1cGVy UmVnaW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjcsNiArMjcsNyBAQAogI2luY2x1ZGUgIlN1 cGVyUmVnaW9uLmgiCiAKICNpbmNsdWRlICJSZWdpb24uaCIKKyNpbmNsdWRlIDx3dGYvRGF0YUxv Zy5oPgogCiBuYW1lc3BhY2UgSlNDIHsKIApAQCAtNDcsNiArNDgsMTEgQEAgU3VwZXJSZWdpb246 OlN1cGVyUmVnaW9uKCkKICNlbmRpZgogfQogCitTdXBlclJlZ2lvbjo6flN1cGVyUmVnaW9uKCkK K3sKKyAgICBtX3Jlc2VydmF0aW9uLmRlYWxsb2NhdGUoKTsKK30KKwogdm9pZCogU3VwZXJSZWdp b246OmdldEFsaWduZWRCYXNlKFBhZ2VSZXNlcnZhdGlvbiYgcmVzZXJ2YXRpb24pCiB7CiAgICAg Zm9yIChjaGFyKiBjdXJyZW50ID0gc3RhdGljX2Nhc3Q8Y2hhcio+KHJlc2VydmF0aW9uLmJhc2Uo KSk7IGN1cnJlbnQgPCBzdGF0aWNfY2FzdDxjaGFyKj4ocmVzZXJ2YXRpb24uYmFzZSgpKSArIFJl Z2lvbjo6c19yZWdpb25TaXplOyBjdXJyZW50ICs9IHBhZ2VTaXplKCkpIHsKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9oZWFwL1N1cGVyUmVnaW9uLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL2hlYXAvU3VwZXJSZWdpb24uaAkocmV2aXNpb24gMTQ5MTMzKQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvU3VwZXJSZWdpb24uaAkod29ya2luZyBjb3B5KQpA QCAtMzcsNiArMzcsNyBAQCBjbGFzcyBWTTsKIGNsYXNzIFN1cGVyUmVnaW9uIDogcHVibGljIFdU Rjo6TWV0YUFsbG9jYXRvciB7CiBwdWJsaWM6CiAgICAgU3VwZXJSZWdpb24oKTsKKyAgICB2aXJ0 dWFsIH5TdXBlclJlZ2lvbigpOwogCiBwcm90ZWN0ZWQ6CiAgICAgdmlydHVhbCB2b2lkKiBhbGxv Y2F0ZU5ld1NwYWNlKHNpemVfdCYpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9F eGVjdXRhYmxlQWxsb2NhdG9yRml4ZWRWTVBvb2wuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRvckZpeGVkVk1Qb29sLmNwcAkocmV2 aXNpb24gMTQ5MTMzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxs b2NhdG9yRml4ZWRWTVBvb2wuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03Miw2ICs3Miw4IEBAIHB1 YmxpYzoKICAgICAgICAgICAgIHN0YXJ0T2ZGaXhlZEV4ZWN1dGFibGVNZW1vcnlQb29sID0gcmVp bnRlcnByZXRfY2FzdDx1aW50cHRyX3Q+KG1fcmVzZXJ2YXRpb24uYmFzZSgpKTsKICAgICAgICAg fQogICAgIH0KKworICAgIHZpcnR1YWwgfkZpeGVkVk1Qb29sRXhlY3V0YWJsZUFsbG9jYXRvcigp OwogICAgIAogcHJvdGVjdGVkOgogICAgIHZpcnR1YWwgdm9pZCogYWxsb2NhdGVOZXdTcGFjZShz aXplX3QmKQpAQCAtMTI5LDYgKzEzMSwxMSBAQCBFeGVjdXRhYmxlQWxsb2NhdG9yOjp+RXhlY3V0 YWJsZUFsbG9jYXRvCiB7CiB9CiAKK0ZpeGVkVk1Qb29sRXhlY3V0YWJsZUFsbG9jYXRvcjo6fkZp eGVkVk1Qb29sRXhlY3V0YWJsZUFsbG9jYXRvcigpCit7CisgICAgbV9yZXNlcnZhdGlvbi5kZWFs bG9jYXRlKCk7Cit9CisKIGJvb2wgRXhlY3V0YWJsZUFsbG9jYXRvcjo6aXNWYWxpZCgpIGNvbnN0 CiB7CiAgICAgcmV0dXJuICEhYWxsb2NhdG9yLT5ieXRlc1Jlc2VydmVkKCk7Cg== 199760 2013-04-25 15:30:31 -0700 2013-04-25 19:46:21 -0700 Patch bug-115208-20130425153001.patch text/plain 3124 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ5MTQ4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDEzLTA0LTI1ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgU3VwZXJSZWdpb24gZG9lc24ndCBjYWxsIGRlYWxsb2NhdGUoKSBvbiBpdHMgUGFn ZVJlc2VydmF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTUyMDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBJdCBzaG91bGQuIFRoaXMgZG9lc24ndCBjYXVzZSB1cyB0byBsZWFrIHBoeXNpY2FsIG1l bW9yeSwgYnV0IGl0IGRvZXMgY2F1c2UgdXMgdG8gbGVhayB2aXJ0dWFsIAorICAgICAgICBhZGRy ZXNzIHNwYWNlIChhbmQgcHJvYmFibHkgbWFjaCBwb3J0cyksIHdoaWNoIGlzIGFsc28gYmFkIDot KCBGaXhlZFZNUG9vbEV4ZWN1dGFibGVBbGxvY2F0b3IgCisgICAgICAgIGFsc28gaGFzIHRoaXMg YnVnLCBidXQgaXQgZG9lc24ndCBtYXR0ZXIgbXVjaCBiZWNhdXNlIHRoZXJlJ3Mgb25seSBvbmUg aW5zdGFuY2Ugb2YgdGhhdCBjbGFzcyAKKyAgICAgICAgdGhyb3VnaG91dCB0aGUgZW50aXJlIGxp ZmV0aW1lIG9mIHRoZSBwcm9jZXNzLCB3aGVyZWFzIGVhY2ggVk0gaGFzIGl0cyBvd24gU3VwZXJS ZWdpb24uIAorCisgICAgICAgICogaGVhcC9TdXBlclJlZ2lvbi5jcHA6CisgICAgICAgIChKU0M6 OlN1cGVyUmVnaW9uOjp+U3VwZXJSZWdpb24pOgorICAgICAgICAqIGhlYXAvU3VwZXJSZWdpb24u aDoKKyAgICAgICAgKFN1cGVyUmVnaW9uKToKKyAgICAgICAgKiBqaXQvRXhlY3V0YWJsZUFsbG9j YXRvckZpeGVkVk1Qb29sLmNwcDoKKyAgICAgICAgKEZpeGVkVk1Qb29sRXhlY3V0YWJsZUFsbG9j YXRvcik6CisgICAgICAgIChKU0M6OkZpeGVkVk1Qb29sRXhlY3V0YWJsZUFsbG9jYXRvcjo6fkZp eGVkVk1Qb29sRXhlY3V0YWJsZUFsbG9jYXRvcik6CisKIDIwMTMtMDQtMjUgIE9saXZlciBIdW50 ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBTdGFjayBndWFyZHMgYXJlIHRvbyBjb25z ZXJ2YXRpdmUKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL1N1cGVyUmVnaW9uLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9TdXBlclJlZ2lvbi5j cHAJKHJldmlzaW9uIDE0OTEzMykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL1N1cGVy UmVnaW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDcsNiArNDcsMTEgQEAgU3VwZXJSZWdpb246 OlN1cGVyUmVnaW9uKCkKICNlbmRpZgogfQogCitTdXBlclJlZ2lvbjo6flN1cGVyUmVnaW9uKCkK K3sKKyAgICBtX3Jlc2VydmF0aW9uLmRlYWxsb2NhdGUoKTsKK30KKwogdm9pZCogU3VwZXJSZWdp b246OmdldEFsaWduZWRCYXNlKFBhZ2VSZXNlcnZhdGlvbiYgcmVzZXJ2YXRpb24pCiB7CiAgICAg Zm9yIChjaGFyKiBjdXJyZW50ID0gc3RhdGljX2Nhc3Q8Y2hhcio+KHJlc2VydmF0aW9uLmJhc2Uo KSk7IGN1cnJlbnQgPCBzdGF0aWNfY2FzdDxjaGFyKj4ocmVzZXJ2YXRpb24uYmFzZSgpKSArIFJl Z2lvbjo6c19yZWdpb25TaXplOyBjdXJyZW50ICs9IHBhZ2VTaXplKCkpIHsKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9oZWFwL1N1cGVyUmVnaW9uLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL2hlYXAvU3VwZXJSZWdpb24uaAkocmV2aXNpb24gMTQ5MTMzKQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvU3VwZXJSZWdpb24uaAkod29ya2luZyBjb3B5KQpA QCAtMzcsNiArMzcsNyBAQCBjbGFzcyBWTTsKIGNsYXNzIFN1cGVyUmVnaW9uIDogcHVibGljIFdU Rjo6TWV0YUFsbG9jYXRvciB7CiBwdWJsaWM6CiAgICAgU3VwZXJSZWdpb24oKTsKKyAgICB2aXJ0 dWFsIH5TdXBlclJlZ2lvbigpOwogCiBwcm90ZWN0ZWQ6CiAgICAgdmlydHVhbCB2b2lkKiBhbGxv Y2F0ZU5ld1NwYWNlKHNpemVfdCYpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9F eGVjdXRhYmxlQWxsb2NhdG9yRml4ZWRWTVBvb2wuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRvckZpeGVkVk1Qb29sLmNwcAkocmV2 aXNpb24gMTQ5MTMzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxs b2NhdG9yRml4ZWRWTVBvb2wuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03Miw2ICs3Miw4IEBAIHB1 YmxpYzoKICAgICAgICAgICAgIHN0YXJ0T2ZGaXhlZEV4ZWN1dGFibGVNZW1vcnlQb29sID0gcmVp bnRlcnByZXRfY2FzdDx1aW50cHRyX3Q+KG1fcmVzZXJ2YXRpb24uYmFzZSgpKTsKICAgICAgICAg fQogICAgIH0KKworICAgIHZpcnR1YWwgfkZpeGVkVk1Qb29sRXhlY3V0YWJsZUFsbG9jYXRvcigp OwogICAgIAogcHJvdGVjdGVkOgogICAgIHZpcnR1YWwgdm9pZCogYWxsb2NhdGVOZXdTcGFjZShz aXplX3QmKQpAQCAtMTI5LDYgKzEzMSwxMSBAQCBFeGVjdXRhYmxlQWxsb2NhdG9yOjp+RXhlY3V0 YWJsZUFsbG9jYXRvCiB7CiB9CiAKK0ZpeGVkVk1Qb29sRXhlY3V0YWJsZUFsbG9jYXRvcjo6fkZp eGVkVk1Qb29sRXhlY3V0YWJsZUFsbG9jYXRvcigpCit7CisgICAgbV9yZXNlcnZhdGlvbi5kZWFs bG9jYXRlKCk7Cit9CisKIGJvb2wgRXhlY3V0YWJsZUFsbG9jYXRvcjo6aXNWYWxpZCgpIGNvbnN0 CiB7CiAgICAgcmV0dXJuICEhYWxsb2NhdG9yLT5ieXRlc1Jlc2VydmVkKCk7Cg==