115197 2013-04-25 12:39:08 -0700 [BlackBerry] Selection overlay on non-composited iframes are incorrectly positioned. 2013-04-25 14:38:34 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 anlo anlo anilsson cgarcia commit-queue rwlbuis xan.lopez oldest_to_newest 881503 0 anlo 2013-04-25 12:39:08 -0700 Selection overlay on non-composited iframes are incorrectly positioned when painted. 881508 1 199740 anlo 2013-04-25 12:44:41 -0700 Created attachment 199740 Patch 881517 2 anilsson 2013-04-25 12:55:33 -0700 LGTM, same strategy as used in SelectionHandler::regionForTextQuads which has been working well for a long time now =) 881546 3 199740 rwlbuis 2013-04-25 13:54:02 -0700 Comment on attachment 199740 Patch LGTM. 881565 4 199740 commit-queue 2013-04-25 14:38:32 -0700 Comment on attachment 199740 Patch Clearing flags on attachment: 199740 Committed r149145: <http://trac.webkit.org/changeset/149145> 881566 5 commit-queue 2013-04-25 14:38:34 -0700 All reviewed patches have been landed. Closing bug. 199740 2013-04-25 12:44:41 -0700 2013-04-25 14:38:32 -0700 Patch bug-115197-20130425154442.patch text/plain 2273 anlo U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4OTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAzZmY3OTU2YjNkZDI1ZjkzMzI5YWYyN2UxZjU3MmMwNDEyNjMxMGVhLi5kY2IwMGZhNDJi Y2QwODYwOTBiODQ1N2I3OGE4ZDdhMjhjZTBhM2JkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMy0wNC0yNSAgQW5kcmV3IExvICA8YW5sb0ByaW0u Y29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBTZWxlY3Rpb24gb3ZlcmxheSBvbiBub24tY29t cG9zaXRlZCBpZnJhbWVzIGFyZSBpbmNvcnJlY3RseSBwb3NpdGlvbmVkLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1MTk3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiBkcmF3aW5nIHRoZSBzZWxl Y3Rpb24gb3ZlcmxheSwgdGhlIHJlY3RzIHRvCisgICAgICAgIHBhaW50IHdoZW4gc2VsZWN0aW5n IHRleHQgb24gbm9uLWNvbXBvc2l0ZWQgc3ViLWZyYW1lcworICAgICAgICBuZWVkIHRvIGJlIGFk anVzdGVkIGJ5IHRoZSBmcmFtZSBwb3NpdGlvbi4KKworICAgICAgICAqIFdlYktpdFN1cHBvcnQv U2VsZWN0aW9uT3ZlcmxheS5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OlNlbGVj dGlvbk92ZXJsYXk6OnBhaW50Q29udGVudHMpOgorCiAyMDEzLTA0LTIyICBYYW4gTG9wZXogIDx4 bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gQVNTRVJUIGluIEZyYW1l TG9hZGVyQ2xpZW50Ojpjb252ZXJ0TWFpblJlc291cmNlTG9hZFRvRG93bmxvYWQKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbk92ZXJs YXkuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvU2VsZWN0aW9u T3ZlcmxheS5jcHAKaW5kZXggMmI1NjFhODUwZjNkNWNmMWFmMjM0ODUyNDllZGRiODIyNTYzMzBl OS4uNWY0YTEwYjY1ZDlkYTVkYTkwZWQyNGE5NWJlNzdjMDlmNmZlOWZkNCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvU2VsZWN0aW9uT3ZlcmxheS5j cHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvU2VsZWN0aW9u T3ZlcmxheS5jcHAKQEAgLTIyLDExICsyMiwxMyBAQAogCiAjaW5jbHVkZSAiU2VsZWN0aW9uT3Zl cmxheS5oIgogCisjaW5jbHVkZSAiRnJhbWUuaCIKICNpbmNsdWRlICJHcmFwaGljc0NvbnRleHQu aCIKICNpbmNsdWRlICJMYXllck1lc3NhZ2UuaCIKICNpbmNsdWRlICJMYXllcldlYktpdFRocmVh ZC5oIgogI2luY2x1ZGUgIlBhdGguaCIKICNpbmNsdWRlICJSZW5kZXJUaGVtZS5oIgorI2luY2x1 ZGUgIlJlbmRlclZpZXcuaCIKICNpbmNsdWRlICJXZWJQYWdlX3AuaCIKIAogI2luY2x1ZGUgPEJs YWNrQmVycnlQbGF0Zm9ybU1lc3NhZ2VDbGllbnQuaD4KQEAgLTExMSw2ICsxMTMsMTMgQEAgdm9p ZCBTZWxlY3Rpb25PdmVybGF5OjpwYWludENvbnRlbnRzKGNvbnN0IEdyYXBoaWNzTGF5ZXIqIGxh eWVyLCBHcmFwaGljc0NvbnRleHQKIAogICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBxdWFk cy5zaXplKCk7ICsraSkgewogICAgICAgICBGbG9hdFJlY3QgcmVjdFRvUGFpbnQgPSBxdWFkc1tp XS5ib3VuZGluZ0JveCgpOworCisgICAgICAgIC8vIFNlbGVjdGlvbiBvbiBub24tY29tcG9zaXRl ZCBzdWItZnJhbWVzIG5lZWQgdG8gYmUgYWRqdXN0ZWQuCisgICAgICAgIGlmICghbV9wYWdlLT5m b2N1c2VkT3JNYWluRnJhbWUoKS0+Y29udGVudFJlbmRlcmVyKCktPmlzQ29tcG9zaXRlZCgpKSB7 CisgICAgICAgICAgICBXZWJDb3JlOjpJbnRQb2ludCBmcmFtZVBvc2l0aW9uID0gbV9wYWdlLT5m cmFtZU9mZnNldChtX3BhZ2UtPmZvY3VzZWRPck1haW5GcmFtZSgpKTsKKyAgICAgICAgICAgIHJl Y3RUb1BhaW50Lm1vdmUoZnJhbWVQb3NpdGlvbi54KCksIGZyYW1lUG9zaXRpb24ueSgpKTsKKyAg ICAgICAgfQorCiAgICAgICAgIHJlY3RUb1BhaW50LmludGVyc2VjdChjbGlwKTsKICAgICAgICAg aWYgKHJlY3RUb1BhaW50LmlzRW1wdHkoKSkKICAgICAgICAgICAgIGNvbnRpbnVlOwo=