115193 2013-04-25 12:12:05 -0700 Glyphs may fail to render when using SVG font 2013-04-25 14:28:45 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 graouts webkit-unassigned commit-queue ddkilzer enrica graouts mitz thorton webkit-bug-importer oldest_to_newest 881484 0 graouts 2013-04-25 12:12:05 -0700 In certain circumstances, glyphs fail to render when using SVG fonts as the GlyphBuffer gets incorrect data when running through SimpleFontData::applyTransforms(). This method ought not be ran for SVG fonts. 881488 1 graouts 2013-04-25 12:12:29 -0700 <rdar://problem/12893178> 881492 2 199736 graouts 2013-04-25 12:24:51 -0700 Created attachment 199736 Patch 881510 3 199736 simon.fraser 2013-04-25 12:49:53 -0700 Comment on attachment 199736 Patch There should be a way to make a layout test for this, no? 881512 4 graouts 2013-04-25 12:51:31 -0700 (In reply to comment #3) > (From update of attachment 199736 [details]) > There should be a way to make a layout test for this, no? I couldn't manage to make a test case that'd reproduce the issue with a free SVG font. 881516 5 thorton 2013-04-25 12:54:00 -0700 (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 199736 [details] [details]) > > There should be a way to make a layout test for this, no? > > I couldn't manage to make a test case that'd reproduce the issue with a free SVG font. Can't you just make one that causes trouble? They're not too hard to make (and we have some small examples in the SVG layout tests). 881561 6 199736 commit-queue 2013-04-25 14:28:43 -0700 Comment on attachment 199736 Patch Clearing flags on attachment: 199736 Committed r149144: <http://trac.webkit.org/changeset/149144> 881562 7 commit-queue 2013-04-25 14:28:45 -0700 All reviewed patches have been landed. Closing bug. 199736 2013-04-25 12:24:51 -0700 2013-04-25 14:28:43 -0700 Patch patch.patch text/plain 1744 graouts ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1YTgwNDc0Li43MjQ3MDdlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTMtMDQtMjUgIEFudG9pbmUgUXVpbnQgIDxncmFvdXRzQGFwcGxlLmNvbT4KKworICAg ICAgICBHbHlwaHMgbWF5IGZhaWwgdG8gcmVuZGVyIHdoZW4gdXNpbmcgU1ZHIGZvbnQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNTE5MworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENhbGxpbmcgU2ltcGxl Rm9udERhdGE6OmFwcGx5VHJhbnNmb3JtcygpIHdoZW4gdGhlIGZvbnQgdXNlZCBpcworICAgICAg ICBhbiBTVkcgZm9udCBtYWtlcyBsaXR0bGUgc2Vuc2Ugc2luY2UgQ29yZSBUZXh0IGRvZXNu4oCZ dCBrbm93IG9yCisgICAgICAgIHVuZGVyc3RhbmQgU1ZHIGZvbnRzIGFuZCB3b3VsZCBiZSBwYXNz ZWQgc29tZSBvdGhlciwgdW5yZWxhdGVkCisgICAgICAgIHBsYXRmb3JtIGZvbnQuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9TaW1wbGVGb250RGF0YS5oOgorICAgICAgICAoV2ViQ29y ZTo6U2ltcGxlRm9udERhdGE6OmFwcGx5VHJhbnNmb3Jtcyk6CisKIDIwMTMtMDQtMjUgIFJhcGhh ZWwgS3VibyBkYSBDb3N0YSAgPHJhcGhhZWwua3Viby5kYS5jb3N0YUBpbnRlbC5jb20+CiAKICAg ICAgICAgUkVHUkVTU0lPTihyMTQ4NzU4KTogUmVtb3ZlIFdURkxvZ0Fsd2F5cyBjYWxsIGZyb20g SWNvbkxvYWRlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L1NpbXBsZUZvbnREYXRhLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9TaW1w bGVGb250RGF0YS5oCmluZGV4IGFlYmU2M2MuLjk0ZTg4Y2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1NpbXBsZUZvbnREYXRhLmgKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvU2ltcGxlRm9udERhdGEuaApAQCAtMTk5LDYgKzE5OSw4 IEBAIHB1YmxpYzoKIAogICAgIGJvb2wgYXBwbHlUcmFuc2Zvcm1zKEdseXBoQnVmZmVyR2x5cGgq IGdseXBocywgR2x5cGhCdWZmZXJBZHZhbmNlKiBhZHZhbmNlcywgc2l6ZV90IGdseXBoQ291bnQs IFR5cGVzZXR0aW5nRmVhdHVyZXMgdHlwZXNldHRpbmdGZWF0dXJlcykgY29uc3QKICAgICB7Cisg ICAgICAgIGlmIChpc1NWR0ZvbnQoKSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICNpZiBQ TEFURk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPiAxMDgwCiAg ICAgICAgIHdrQ1RGb250VHJhbnNmb3JtT3B0aW9ucyBvcHRpb25zID0gKHR5cGVzZXR0aW5nRmVh dHVyZXMgJiBLZXJuaW5nID8gd2tDVEZvbnRUcmFuc2Zvcm1BcHBseVBvc2l0aW9uaW5nIDogMCkg fCAodHlwZXNldHRpbmdGZWF0dXJlcyAmIExpZ2F0dXJlcyA/IHdrQ1RGb250VHJhbnNmb3JtQXBw bHlTaGFwaW5nIDogMCk7CiAgICAgICAgIHJldHVybiB3a0NURm9udFRyYW5zZm9ybUdseXBocyht X3BsYXRmb3JtRGF0YS5jdEZvbnQoKSwgZ2x5cGhzLCByZWludGVycHJldF9jYXN0PENHU2l6ZSo+ KGFkdmFuY2VzKSwgZ2x5cGhDb3VudCwgb3B0aW9ucyk7Cg==