115190 2013-04-25 11:26:55 -0700 JSC: Fix interpreter misbehavior in builds with JIT disabled 2013-04-25 12:53:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 nick.diego webkit-unassigned commit-queue sergio oldest_to_newest 881386 0 nick.diego 2013-04-25 11:26:55 -0700 JSC: Fix interpreter misbehavior in builds with JIT disabled 881394 1 199696 nick.diego 2013-04-25 11:31:16 -0700 Created attachment 199696 Patch JSC: Fix interpreter misbehavior in builds with JIT disabled 881399 2 199696 oliver 2013-04-25 11:36:46 -0700 Comment on attachment 199696 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199696&action=review > Source/JavaScriptCore/interpreter/Interpreter.cpp:573 > -#if ENABLE(JIT) > +#if ENABLE(JIT) || ENABLE(LLINT) Just remove this, and the #else return 0 bit 881476 3 199729 nick.diego 2013-04-25 12:00:37 -0700 Created attachment 199729 Patch Addressed oliver's request 881513 4 199729 commit-queue 2013-04-25 12:53:47 -0700 Comment on attachment 199729 Patch Clearing flags on attachment: 199729 Committed r149134: <http://trac.webkit.org/changeset/149134> 881514 5 commit-queue 2013-04-25 12:53:49 -0700 All reviewed patches have been landed. Closing bug. 199696 2013-04-25 11:31:16 -0700 2013-04-25 12:00:27 -0700 Patch bug-115190-20130425144024.patch text/plain 2038 nick.diego U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5MTIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx ZmZjNjNkMGI0ZmU0NjI1YWI4ZjNkMmNhOTlhYWM1NGNiOWU4MDA2Li4yNmY4YzdhMWVmMGRkNzM4 YTkzOTlhMmJmODIyN2NjZDU5MDA4ZGVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNSBAQAorMjAxMy0wNC0yNSAgTmljayBEaWVnbyBZYW1hbmUgIDxuaWNrLnlhbWFuZUBv cGVuYm9zc2Eub3JnPgorCisgICAgICAgIEpTQzogRml4IGludGVycHJldGVyIG1pc2JlaGF2aW9y IGluIGJ1aWxkcyB3aXRoIEpJVCBkaXNhYmxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1MTkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQ29tbWl0IGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdl c2V0LzE0Nzg1OCBtb2RpZmllZAorICAgICAgICBzb21lIGRldGFpbHMgb24gaG93IEpTIHN0YWNr IHRyYWNlcyBhcmUgYnVpbHQuIFRoZSBtZXRob2QKKyAgICAgICAgImdldExpbmVOdW1iZXJGb3JD YWxsRnJhbWUiLCByZW5hbWVkIGluIHRoYXQgY2hhbmdlc2V0IHRvCisgICAgICAgICJnZXRCeXRl Y29kZU9mZnNldEZvckNhbGxGcmFtZSIgaXMgYWx3YXlzIHJldHVybmluZyBgMCcgd2hlbgorICAg ICAgICBKSVQgaXMgZGlzYWJsZWQKKworICAgICAgICBIb3cgdG8gcmVwcm9kdWNlOgorICAgICAg ICAgLSBCdWlsZCB3ZWJraXQgd2l0aCBKSVQgZGlzYWJsZWQKKyAgICAgICAgIC0gT3BlbiBNaW5p QnJvd3NlciwgZm9yIGV4YW1wbGUsIHdpdGggaHR0cDovL2dvb2dsZS5jb20KKyAgICAgICAgIC0g SW4gYSBkZWJ1ZyBidWlsZCwgV2ViUHJvY2VzcyB3aWxsIGhpdCB0aGUgZm9sbG93aW5nIEFTU0VS VDoKKyAgICAgICAgICAgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1VubGlua2VkQ29k ZUJsb2NrLmNwcDoyNzkgQVNTRVJUKGxvdyk7CisKKyAgICAgICAgKiBpbnRlcnByZXRlci9JbnRl cnByZXRlci5jcHA6CisgICAgICAgIChKU0M6OmdldEJ5dGVjb2RlT2Zmc2V0Rm9yQ2FsbEZyYW1l KToKKwogMjAxMy0wNC0yNSAgSnVsaWVuIEJyaWFuY2VhdSAgPGpicmlhbmNlYXVAbmRzLmNvbT4K IAogICAgICAgICBSRUdSRVNTSU9OKHIxMzc5OTQpOiBSYW5kb20gY3Jhc2hlcyBvY2N1ciB3aXRo IFNINCBKU0MuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIv SW50ZXJwcmV0ZXIuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0ludGVy cHJldGVyLmNwcAppbmRleCBkZjM4OTczZDRhNjNkZjdkNDljNWJiOWNiNjVhZDk3YWEyNGZkZDZk Li45YjkyZTgwYTQ5MzgxNGJjOTA2OThkMDM2NzExNjM1MDI4ZGUyNDA0IDEwMDY0NAotLS0gYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3BwCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9JbnRlcnByZXRlci5jcHAKQEAgLTU3MCw3 ICs1NzAsNyBAQCBzdGF0aWMgdW5zaWduZWQgZ2V0Qnl0ZWNvZGVPZmZzZXRGb3JDYWxsRnJhbWUo Q2FsbEZyYW1lKiBjYWxsRnJhbWUpCiAgICAgQ29kZUJsb2NrKiBjb2RlQmxvY2sgPSBjYWxsRnJh bWUtPmNvZGVCbG9jaygpOwogICAgIGlmICghY29kZUJsb2NrKQogICAgICAgICByZXR1cm4gMDsK LSNpZiBFTkFCTEUoSklUKQorI2lmIEVOQUJMRShKSVQpIHx8IEVOQUJMRShMTElOVCkKICNpZiBF TkFCTEUoREZHX0pJVCkKICAgICBpZiAoY29kZUJsb2NrLT5nZXRKSVRUeXBlKCkgPT0gSklUQ29k ZTo6REZHSklUKQogICAgICAgICByZXR1cm4gY29kZUJsb2NrLT5jb2RlT3JpZ2luKGNhbGxGcmFt ZS0+Y29kZU9yaWdpbkluZGV4Rm9yREZHKCkpLmJ5dGVjb2RlSW5kZXg7Cg== 199729 2013-04-25 12:00:37 -0700 2013-04-25 12:53:47 -0700 Patch bug-115190-20130425150941.patch text/plain 2212 nick.diego U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5MTIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx ZmZjNjNkMGI0ZmU0NjI1YWI4ZjNkMmNhOTlhYWM1NGNiOWU4MDA2Li4yNmY4YzdhMWVmMGRkNzM4 YTkzOTlhMmJmODIyN2NjZDU5MDA4ZGVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNSBAQAorMjAxMy0wNC0yNSAgTmljayBEaWVnbyBZYW1hbmUgIDxuaWNrLnlhbWFuZUBv cGVuYm9zc2Eub3JnPgorCisgICAgICAgIEpTQzogRml4IGludGVycHJldGVyIG1pc2JlaGF2aW9y IGluIGJ1aWxkcyB3aXRoIEpJVCBkaXNhYmxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1MTkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQ29tbWl0IGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdl c2V0LzE0Nzg1OCBtb2RpZmllZAorICAgICAgICBzb21lIGRldGFpbHMgb24gaG93IEpTIHN0YWNr IHRyYWNlcyBhcmUgYnVpbHQuIFRoZSBtZXRob2QKKyAgICAgICAgImdldExpbmVOdW1iZXJGb3JD YWxsRnJhbWUiLCByZW5hbWVkIGluIHRoYXQgY2hhbmdlc2V0IHRvCisgICAgICAgICJnZXRCeXRl Y29kZU9mZnNldEZvckNhbGxGcmFtZSIgaXMgYWx3YXlzIHJldHVybmluZyBgMCcgd2hlbgorICAg ICAgICBKSVQgaXMgZGlzYWJsZWQKKworICAgICAgICBIb3cgdG8gcmVwcm9kdWNlOgorICAgICAg ICAgLSBCdWlsZCB3ZWJraXQgd2l0aCBKSVQgZGlzYWJsZWQKKyAgICAgICAgIC0gT3BlbiBNaW5p QnJvd3NlciwgZm9yIGV4YW1wbGUsIHdpdGggaHR0cDovL2dvb2dsZS5jb20KKyAgICAgICAgIC0g SW4gYSBkZWJ1ZyBidWlsZCwgV2ViUHJvY2VzcyB3aWxsIGhpdCB0aGUgZm9sbG93aW5nIEFTU0VS VDoKKyAgICAgICAgICAgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1VubGlua2VkQ29k ZUJsb2NrLmNwcDoyNzkgQVNTRVJUKGxvdyk7CisKKyAgICAgICAgKiBpbnRlcnByZXRlci9JbnRl cnByZXRlci5jcHA6CisgICAgICAgIChKU0M6OmdldEJ5dGVjb2RlT2Zmc2V0Rm9yQ2FsbEZyYW1l KToKKwogMjAxMy0wNC0yNSAgSnVsaWVuIEJyaWFuY2VhdSAgPGpicmlhbmNlYXVAbmRzLmNvbT4K IAogICAgICAgICBSRUdSRVNTSU9OKHIxMzc5OTQpOiBSYW5kb20gY3Jhc2hlcyBvY2N1ciB3aXRo IFNINCBKU0MuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIv SW50ZXJwcmV0ZXIuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0ludGVy cHJldGVyLmNwcAppbmRleCBkZjM4OTczZDRhNjNkZjdkNDljNWJiOWNiNjVhZDk3YWEyNGZkZDZk Li5hYzNjZmJlZDhiNzg5OGQ4YmU3ZTM4NDZlM2NmYTQ0Njg4NjFhYjM5IDEwMDY0NAotLS0gYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3BwCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9JbnRlcnByZXRlci5jcHAKQEAgLTU3MCwx NSArNTcwLDExIEBAIHN0YXRpYyB1bnNpZ25lZCBnZXRCeXRlY29kZU9mZnNldEZvckNhbGxGcmFt ZShDYWxsRnJhbWUqIGNhbGxGcmFtZSkKICAgICBDb2RlQmxvY2sqIGNvZGVCbG9jayA9IGNhbGxG cmFtZS0+Y29kZUJsb2NrKCk7CiAgICAgaWYgKCFjb2RlQmxvY2spCiAgICAgICAgIHJldHVybiAw OwotI2lmIEVOQUJMRShKSVQpCiAjaWYgRU5BQkxFKERGR19KSVQpCiAgICAgaWYgKGNvZGVCbG9j ay0+Z2V0SklUVHlwZSgpID09IEpJVENvZGU6OkRGR0pJVCkKICAgICAgICAgcmV0dXJuIGNvZGVC bG9jay0+Y29kZU9yaWdpbihjYWxsRnJhbWUtPmNvZGVPcmlnaW5JbmRleEZvckRGRygpKS5ieXRl Y29kZUluZGV4OwogI2VuZGlmCiAgICAgcmV0dXJuIGNhbGxGcmFtZS0+Ynl0ZWNvZGVPZmZzZXRG b3JOb25ERkdDb2RlKCk7Ci0jZWxzZQotICAgIHJldHVybiAwOwotI2VuZGlmCiB9CiAKIHN0YXRp YyBDYWxsRnJhbWUqIGdldENhbGxlckluZm8oVk0qIHZtLCBDYWxsRnJhbWUqIGNhbGxGcmFtZSwg dW5zaWduZWQmIGJ5dGVjb2RlT2Zmc2V0LCBDb2RlQmxvY2sqJiBjYWxsZXIpCg==