11519 2006-11-04 12:58:33 -0800 REGRESSION: Disabled file upload control doesn't have disabled appearance, failing fast/forms/file-input-disabled.html 2006-12-19 06:31:03 -0800 1 1 1 Unclassified WebKit Forms 420+ Mac OS X 10.4 RESOLVED FIXED LayoutTestFailure, Regression P1 Normal --- 1 mitz webkit-unassigned aroben mrowe oldest_to_newest 46790 0 mitz 2006-11-04 12:58:33 -0800 Mac-themed file upload controls that are disabled should have the disabled appearance and not highlight on mousedown. See fast/forms/file-input-disabled.html. 45380 1 11568 rwlbuis 2006-11-18 14:51:21 -0800 Created attachment 11568 First attempt The patch does a little more than fixing the problem. I expect the 3 other state values to cause problems too, that is why I include them in this patch. I'd like to discuss whether this is the right approach, whether we need more testcases for the other 3 state values or whether existing testcases cover it. Cheers, Rob. 44894 2 11568 mjs 2006-11-19 21:54:54 -0800 Comment on attachment 11568 First attempt The ChangeLog has a conflict marker left in it: +>>>>>>> .r17847 I'm not sure the changes besides disabled are well enough covered by tests. 44933 3 11588 rwlbuis 2006-11-20 12:51:45 -0800 Created attachment 11588 Improved patch With hindsight, dealing with checked property for file input makes no sense at all. The file input also does not seem to react to setting active/select(). Finally it is not needed to set the focus property, I tested it and it seems to work on ToT. So really I think I was trying to do too much and just dealing with disabled is all that is needed. Cheers, Rob. 44950 4 11588 mjs 2006-11-21 01:07:05 -0800 Comment on attachment 11588 Improved patch r=me 44959 5 mrowe 2006-11-21 04:09:50 -0800 Landed by Rob in 17867. 41196 6 mitz 2006-12-19 06:31:03 -0800 The patch left the button text black (not grayed out as it should be). Filed bug 11874 on that. 11568 2006-11-18 14:51:21 -0800 2006-11-20 12:51:45 -0800 First attempt 11519.diff text/plain 2467 rwlbuis SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxNzg0NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDYtMTEtMTggIFJvYiBCdWlzICA8YnVpc0BrZGUub3JnPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHA6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNTE5CisgICAgICAgIFJFR1JFU1NJT046IERp c2FibGVkIGZpbGUgdXBsb2FkIGNvbnRyb2wgZG9lc24ndCBoYXZlIGRpc2FibGVkIGFwcGVhcmFu Y2UsIGZhaWxpbmcgZmFzdC9mb3Jtcy9maWxlLWlucHV0LWRpc2FibGVkLmh0bWwKKworICAgICAg ICBUcmFuc3BvcnQgc3RhdGUgcHJvcGVydGllcyB0byB0aGUgc2hhZG93IGRvbS9yZW5kZXIgb2Jq ZWN0LgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckZpbGVVcGxvYWRDb250cm9sLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckZpbGVVcGxvYWRDb250cm9sOjp1cGRhdGVGcm9tRWxl bWVudCk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lLmg6CisKIDIwMDYtMTEtMTgg IERvbiBHaWJzb24gIDxkZ2lic29uNzdAZ21haWwuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IFNhbSBXZWluaWcuCkBAIC0xMjAsNiArMTMzLDcgQEAKICAgICAgICAgKFdlYkNvcmU6OkZyYW1l TG9hZGVyQ2xpZW50V2luOjpzZXRUaXRsZSk6CiAgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRl ckNsaWVudFdpbjo6dXNlckFnZW50KToKIAorPj4+Pj4+PiAucjE3ODQ3CiAyMDA2LTExLTE4ICBB bGV4ZXkgUHJvc2t1cnlha292ICA8YXBAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBSb2IgKHlheSEpLgpJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmlsZVVwbG9hZENv bnRyb2wuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZpbGVVcGxv YWRDb250cm9sLmNwcAkocmV2aXNpb24gMTc4NDcpCisrKyBXZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJGaWxlVXBsb2FkQ29udHJvbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExNiw2ICsxMTYsMTAg QEAgdm9pZCBSZW5kZXJGaWxlVXBsb2FkQ29udHJvbDo6dXBkYXRlRnJvbQogICAgICAgICAKICAg ICAgICAgYWRkQ2hpbGQobV9idXR0b24tPnJlbmRlcmVyKCkpOwogICAgIH0KKyAgICBtX2J1dHRv bi0+c2V0RGlzYWJsZWQoIXRoZW1lKCktPmlzRW5hYmxlZCh0aGlzKSk7CisgICAgbV9idXR0b24t PnNldENoZWNrZWQodGhlbWUoKS0+aXNDaGVja2VkKHRoaXMpKTsKKyAgICBtX2J1dHRvbi0+c2V0 Rm9jdXModGhlbWUoKS0+aXNGb2N1c2VkKHRoaXMpKTsKKyAgICBtX2J1dHRvbi0+c2V0QWN0aXZl KHRoZW1lKCktPmlzUHJlc3NlZCh0aGlzKSk7CiB9CiAKIGludCBSZW5kZXJGaWxlVXBsb2FkQ29u dHJvbDo6bWF4RmlsZW5hbWVXaWR0aCgpCkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJU aGVtZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lLmgJKHJl dmlzaW9uIDE3ODQ3KQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWUuaAkod29ya2lu ZyBjb3B5KQpAQCAtMTE1LDcgKzExNSw2IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgdm9pZCBh ZGp1c3RTbGlkZXJUaHVtYlNpemUoUmVuZGVyT2JqZWN0KikgY29uc3Q7CiAKLXByb3RlY3RlZDoK ICAgICAvLyBNZXRob2RzIGZvciBzdGF0ZSBxdWVyeWluZwogICAgIGJvb2wgaXNDaGVja2VkKGNv bnN0IFJlbmRlck9iamVjdCopIGNvbnN0OwogICAgIGJvb2wgaXNJbmRldGVybWluYXRlKGNvbnN0 IFJlbmRlck9iamVjdCopIGNvbnN0OwpAQCAtMTI1LDYgKzEyNCw3IEBAIHByb3RlY3RlZDoKICAg ICBib29sIGlzSG92ZXJlZChjb25zdCBSZW5kZXJPYmplY3QqKSBjb25zdDsKICAgICBib29sIGlz UmVhZE9ubHlDb250cm9sKGNvbnN0IFJlbmRlck9iamVjdCopIGNvbnN0OwogCitwcm90ZWN0ZWQ6 CiAgICAgLy8gTWV0aG9kcyBmb3IgZWFjaCBhcHBlYXJhbmNlIHZhbHVlLgogICAgIHZpcnR1YWwg dm9pZCBhZGp1c3RDaGVja2JveFN0eWxlKENTU1N0eWxlU2VsZWN0b3IqLCBSZW5kZXJTdHlsZSos IEVsZW1lbnQqKSBjb25zdDsKICAgICB2aXJ0dWFsIGJvb2wgcGFpbnRDaGVja2JveChSZW5kZXJP YmplY3QqLCBjb25zdCBSZW5kZXJPYmplY3Q6OlBhaW50SW5mbyYsIGNvbnN0IEludFJlY3QmKSB7 IHJldHVybiB0cnVlOyB9Cg== 11588 2006-11-20 12:51:45 -0800 2006-11-21 01:07:05 -0800 Improved patch 11519-2.diff text/plain 2060 rwlbuis SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxNzg2MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDYtMTEtMjAgIFJvYiBCdWlzICA8YnVpc0BrZGUub3JnPgorCisg ICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNTE5CisgICAg ICAgIFJFR1JFU1NJT046IERpc2FibGVkIGZpbGUgdXBsb2FkIGNvbnRyb2wgZG9lc24ndCBoYXZl IGRpc2FibGVkIGFwcGVhcmFuY2UsIGZhaWxpbmcgZmFzdC9mb3Jtcy9maWxlLWlucHV0LWRpc2Fi bGVkLmh0bWwKKworICAgICAgICBUcmFuc3BvcnQgZGlzYWJsZWQgc3RhdGUgZnJvbSBET00gZWxl bWVudCB0byB0aGUgc2hhZG93CisgICAgICAgIERPTS9yZW5kZXIgb2JqZWN0LgorCisgICAgICAg ICogcmVuZGVyaW5nL1JlbmRlckZpbGVVcGxvYWRDb250cm9sLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlckZpbGVVcGxvYWRDb250cm9sOjp1cGRhdGVGcm9tRWxlbWVudCk6CisgICAgICAg ICogcmVuZGVyaW5nL1JlbmRlclRoZW1lLmg6CisKIDIwMDYtMTEtMjAgIFNhbXVlbCBXZWluaWcg IDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbGV4ZXkuCkluZGV4OiBX ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGaWxlVXBsb2FkQ29udHJvbC5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmlsZVVwbG9hZENvbnRyb2wuY3BwCShyZXZpc2lv biAxNzg1OSkKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZpbGVVcGxvYWRDb250cm9sLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTE2LDYgKzExNiw3IEBAIHZvaWQgUmVuZGVyRmlsZVVwbG9h ZENvbnRyb2w6OnVwZGF0ZUZyb20KICAgICAgICAgCiAgICAgICAgIGFkZENoaWxkKG1fYnV0dG9u LT5yZW5kZXJlcigpKTsKICAgICB9CisgICAgbV9idXR0b24tPnNldERpc2FibGVkKCF0aGVtZSgp LT5pc0VuYWJsZWQodGhpcykpOwogfQogCiBpbnQgUmVuZGVyRmlsZVVwbG9hZENvbnRyb2w6Om1h eEZpbGVuYW1lV2lkdGgoKQpJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWUuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZS5oCShyZXZpc2lvbiAx Nzg1OSkKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lLmgJKHdvcmtpbmcgY29weSkK QEAgLTExNSw3ICsxMTUsNiBAQCBwdWJsaWM6CiAKICAgICB2aXJ0dWFsIHZvaWQgYWRqdXN0U2xp ZGVyVGh1bWJTaXplKFJlbmRlck9iamVjdCopIGNvbnN0OwogCi1wcm90ZWN0ZWQ6CiAgICAgLy8g TWV0aG9kcyBmb3Igc3RhdGUgcXVlcnlpbmcKICAgICBib29sIGlzQ2hlY2tlZChjb25zdCBSZW5k ZXJPYmplY3QqKSBjb25zdDsKICAgICBib29sIGlzSW5kZXRlcm1pbmF0ZShjb25zdCBSZW5kZXJP YmplY3QqKSBjb25zdDsKQEAgLTEyNSw2ICsxMjQsNyBAQCBwcm90ZWN0ZWQ6CiAgICAgYm9vbCBp c0hvdmVyZWQoY29uc3QgUmVuZGVyT2JqZWN0KikgY29uc3Q7CiAgICAgYm9vbCBpc1JlYWRPbmx5 Q29udHJvbChjb25zdCBSZW5kZXJPYmplY3QqKSBjb25zdDsKIAorcHJvdGVjdGVkOgogICAgIC8v IE1ldGhvZHMgZm9yIGVhY2ggYXBwZWFyYW5jZSB2YWx1ZS4KICAgICB2aXJ0dWFsIHZvaWQgYWRq dXN0Q2hlY2tib3hTdHlsZShDU1NTdHlsZVNlbGVjdG9yKiwgUmVuZGVyU3R5bGUqLCBFbGVtZW50 KikgY29uc3Q7CiAgICAgdmlydHVhbCBib29sIHBhaW50Q2hlY2tib3goUmVuZGVyT2JqZWN0Kiwg Y29uc3QgUmVuZGVyT2JqZWN0OjpQYWludEluZm8mLCBjb25zdCBJbnRSZWN0JikgeyByZXR1cm4g dHJ1ZTsgfQo=