115189 2013-04-25 11:22:10 -0700 [BlackBerry] Enable balanced page group load deferrer behaviour. 2013-04-25 12:55:53 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 1 mlattanzio mlattanzio commit-queue joenotcharles oldest_to_newest 881382 0 mlattanzio 2013-04-25 11:22:10 -0700 Every port uses PageGroupLoadDeferrer wrapper objects, as do we. We should therefore enable the balanced page group load deferrer behavior so they can be safely nested. 881388 1 199695 mlattanzio 2013-04-25 11:28:05 -0700 Created attachment 199695 Patch 881400 2 199695 rwlbuis 2013-04-25 11:36:59 -0700 Comment on attachment 199695 Patch Ok. 881401 3 199695 commit-queue 2013-04-25 11:39:27 -0700 Comment on attachment 199695 Patch Rejecting attachment 199695 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 199695, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: Rob Buis']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebKit/blackberry/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/blackberry/Api/WebPage.cpp Hunk #1 FAILED at 631. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/blackberry/Api/WebPage.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Rob Buis']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/11340 881404 4 joenotcharles 2013-04-25 11:41:53 -0700 I've done an audit to prove that this use is safe. Unlike other ports we don't expose the setWantsBalancedSetDefersLoadingBehavior in the platform API, and we don't expose any access to setDefersLoading except for a wrapper for PageGroupLoadDeferrer, which is meant to be created on the stack and calls setDefersLoading in the constructor and destructor, keeping the calls balanced. So we definitely do not have any unbalanced calls to setDefersLoading. And since we assumed PageGroupLoadDeferrers could be nested, and make heavy use of them, it's unsafe to NOT set wantsBalancedSetDefersLoadingBehavior. 881431 5 joenotcharles 2013-04-25 11:45:05 -0700 (In reply to comment #3) > (From update of attachment 199695 [details]) > patching file Source/WebKit/blackberry/Api/WebPage.cpp > Hunk #1 FAILED at 631. > 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/blackberry/Api/WebPage.cpp.rej Oops, this was based on the internal branch and not the upstream branch and I guess it's diverged. We'll need to make the change in the internal and svn/master branches simultaneously, and merge them at the next rebase. (Hopefully the rest of the local changes will be upstreamed by then.) Leaving this open until there's time to do that. 881468 6 199727 mlattanzio 2013-04-25 11:54:17 -0700 Created attachment 199727 Patch 881518 7 199727 commit-queue 2013-04-25 12:55:52 -0700 Comment on attachment 199727 Patch Clearing flags on attachment: 199727 Committed r149135: <http://trac.webkit.org/changeset/149135> 881519 8 commit-queue 2013-04-25 12:55:53 -0700 All reviewed patches have been landed. Closing bug. 199695 2013-04-25 11:28:05 -0700 2013-04-25 11:54:14 -0700 Patch bug-115189-20130425142933.patch text/plain 1800 mlattanzio U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4ODg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA0MjdiNDc1ZDZmNTU0ZTIzNThhM2MzZDk4YzVjYmFmM2UwNmEwMWU1Li4wMzhjYWY4ZTBl MmMzNTBlNDg2M2FhMTEwZDhiNWE3MDkwZmU5YjNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMy0wNC0yNSAgTWlrZSBMYXR0YW56aW8gIDxtbGF0 dGFuemlvQGJsYWNrYmVycnkuY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBFbmFibGUgYmFs YW5jZWQgcGFnZSBncm91cCBsb2FkIGRlZmVycmVyIGJlaGF2aW91ci4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNTE4OQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFByZXZlbnQgYSBwb3NzaWJsZSBkZWFk bG9jayBieSBlbmFibGluZyBiYWxhbmNlZCBkZWZlcnJlcnMuCisgICAgICAgIEludGVybmFsbHkg cmV2aWV3ZWQgYnk6IEpvZSBNYXNvbgorICAgICAgICBQUiAzMjk5ODYKKworICAgICAgICAqIEFw aS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6V2ViUGFnZVByaXZh dGU6OmluaXQpOgorCiAyMDEzLTA0LTIyICBPdHRvIERlcmVrIENoZXVuZyAgPG90Y2hldW5nQHJp bS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIFVwZGF0ZSBCYXR0ZXJ5Q2xpZW50QmxhY2tC ZXJyeSB0byB1c2Ugb3VyIHBvcnQncyBuZXcgbGlzdGVuZXIgaW50ZXJmYWNlCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwIGIvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAppbmRleCAwY2U5MzhjNThlYmU1MjFmZjAwYjRi MDM1YWNkNjAzNzkxNWFmNmIwLi42OGY1NzFhYzgxNjQ2N2U5MWYzMDU5YjgxNTNkMThjMzM5YTFl MjJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKQEAgLTYzMSw2 ICs2MzEsNyBAQCB2b2lkIFdlYlBhZ2VQcml2YXRlOjppbml0KGNvbnN0IEJsYWNrQmVycnk6OlBs YXRmb3JtOjpTdHJpbmcmIHBhZ2VHcm91cE5hbWUpCiAgICAgbV9wYWdlLT5zZXR0aW5ncygpLT5z ZXRTaG91bGRVc2VDcm9zc09yaWdpblByb3RvY29sQ2hlY2soIW1fd2ViU2V0dGluZ3MtPmFsbG93 Q3Jvc3NTaXRlUmVxdWVzdHMoKSk7CiAgICAgbV9wYWdlLT5zZXR0aW5ncygpLT5zZXRXZWJTZWN1 cml0eUVuYWJsZWQoIW1fd2ViU2V0dGluZ3MtPmFsbG93Q3Jvc3NTaXRlUmVxdWVzdHMoKSk7CiAg ICAgbV9wYWdlLT5zZXR0aW5ncygpLT5zZXRTY3JvbGxpbmdDb29yZGluYXRvckVuYWJsZWQodHJ1 ZSk7CisgICAgbV9wYWdlLT5zZXR0aW5ncygpLT5zZXRXYW50c0JhbGFuY2VkU2V0RGVmZXJzTG9h ZGluZ0JlaGF2aW9yKHRydWUpOwogCiAgICAgbV9iYWNraW5nU3RvcmVDbGllbnQgPSBCYWNraW5n U3RvcmVDbGllbnQ6OmNyZWF0ZShtX21haW5GcmFtZSwgLyogcGFyZW50IGZyYW1lICovIDAsIG1f d2ViUGFnZSk7CiAgICAgLy8gVGhlIGRpcmVjdCBhY2Nlc3MgdG8gQmFja2luZ1N0b3JlIGlzIGxl ZnQgaGVyZSBmb3IgY29udmVuaWVuY2Ugc2luY2UgaXQK 199727 2013-04-25 11:54:17 -0700 2013-04-25 12:55:52 -0700 Patch bug-115189-20130425145544.patch text/plain 1738 mlattanzio U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5MTI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA4MWQ2ZmM1YmRiODRiNmU4Y2Y4YmVlZDlhMGE3NWMwMzJlN2I0MjBmLi44YjU4NzcwZGJm ZDA0ZDNiNDQzOGJkYjBjMjQ3NDViMDZkODQ5OWIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMy0wNC0yNSAgTWlrZSBMYXR0YW56aW8gIDxtbGF0 dGFuemlvQGJsYWNrYmVycnkuY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBFbmFibGUgYmFs YW5jZWQgcGFnZSBncm91cCBsb2FkIGRlZmVycmVyIGJlaGF2aW91ci4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNTE4OQorCisgICAgICAgIFJldmll d2VkIGJ5IFJvYiBCdWlzLgorCisgICAgICAgIFByZXZlbnQgYSBwb3NzaWJsZSBkZWFkbG9jayBi eSBlbmFibGluZyBiYWxhbmNlZCBkZWZlcnJlcnMuCisgICAgICAgIEludGVybmFsbHkgcmV2aWV3 ZWQgYnk6IEpvZSBNYXNvbgorICAgICAgICBQUiAzMjk5ODYKKworICAgICAgICAqIEFwaS9XZWJQ YWdlLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6V2ViUGFnZVByaXZhdGU6Omlu aXQpOgorCiAyMDEzLTA0LTI1ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+ CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogQ29uc29sZU1lc3NhZ2Ugc2hvdWxkIGluY2x1ZGUg bGluZSBhbmQgY29sdW1uIG51bWJlciB3aGVyZSBwb3NzaWJsZQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9BcGkvV2ViUGFnZS5jcHAKaW5kZXggNzExN2I0YTAwNzdmZjdiODE3ZjAzYzI5OWM0MGE3 NTQ4OTE5OGIwNC4uMzRmM2NhNTNlZDVhN2VmYjZjNzFhYjE0ZDc1MTNhOGQxM2IwZDIzYSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAorKysgYi9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCkBAIC02MjUsNiArNjI1LDcg QEAgdm9pZCBXZWJQYWdlUHJpdmF0ZTo6aW5pdChjb25zdCBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6 U3RyaW5nJiBwYWdlR3JvdXBOYW1lKQogICAgIG1fcGFnZS0+c2V0dGluZ3MoKS0+c2V0QWxsb3dV bml2ZXJzYWxBY2Nlc3NGcm9tRmlsZVVSTHMoZmFsc2UpOwogICAgIG1fcGFnZS0+c2V0dGluZ3Mo KS0+c2V0QWxsb3dGaWxlQWNjZXNzRnJvbUZpbGVVUkxzKGZhbHNlKTsKICAgICBtX3BhZ2UtPnNl dHRpbmdzKCktPnNldEZpeGVkUG9zaXRpb25DcmVhdGVzU3RhY2tpbmdDb250ZXh0KHRydWUpOwor ICAgIG1fcGFnZS0+c2V0dGluZ3MoKS0+c2V0V2FudHNCYWxhbmNlZFNldERlZmVyc0xvYWRpbmdC ZWhhdmlvcih0cnVlKTsKIAogICAgIG1fYmFja2luZ1N0b3JlQ2xpZW50ID0gQmFja2luZ1N0b3Jl Q2xpZW50OjpjcmVhdGUobV9tYWluRnJhbWUsIC8qIHBhcmVudCBmcmFtZSAqLyAwLCBtX3dlYlBh Z2UpOwogICAgIC8vIFRoZSBkaXJlY3QgYWNjZXNzIHRvIEJhY2tpbmdTdG9yZSBpcyBsZWZ0IGhl cmUgZm9yIGNvbnZlbmllbmNlIHNpbmNlIGl0Cg==