115176 2013-04-25 06:42:11 -0700 Web Inspector: Crash due to null items from getDOMStorageItems 2013-04-26 11:56:36 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kpiascik kpiascik commit-queue joepeck kpiascik oldest_to_newest 881227 0 kpiascik 2013-04-25 06:42:11 -0700 Web Inspector: Crash due to null items from getDOMStorageItems 881240 1 kpiascik 2013-04-25 07:22:47 -0700 This asserts in DEBUG builds as well 0x7cb22ec4 in WebCore::InspectorObjectBase::setValue (this=0x774bfcf8, name=..., value=...) at /home/kpiascik/dev/webkit/Source/WebCore/inspector/InspectorValues.h:336 336 ASSERT(value); (gdb) bt #0 0x7cb22ec4 in WebCore::InspectorObjectBase::setValue (this=0x774bfcf8, name=..., value=...) at /home/kpiascik/dev/webkit/Source/WebCore/inspector/InspectorValues.h:336 #1 0x7d8e37f8 in WebCore::InspectorBackendDispatcherImpl::DOMStorage_getDOMStorageItems (this=0x7a046518, callId=62, requestMessageObject=0x7760f0e0) at /home/kpiascik/dev/webkit/WebKitBuild/armle-v7/Debug/DerivedSources/WebCore/InspectorBackendDispatcher.cpp:2555 #2 0x7d8fb6cc in WebCore::InspectorBackendDispatcherImpl::dispatch (this=0x7a046518, message=...) at /home/kpiascik/dev/webkit/WebKitBuild/armle-v7/Debug/DerivedSources/WebCore/InspectorBackendDispatcher.cpp:6650 #3 0x7cba44ec in WebCore::InspectorController::dispatchMessageFromFrontend (this=0x799c8b48, message=...) at /home/kpiascik/dev/webkit/Source/WebCore/inspector/InspectorController.cpp:360 (gdb) up #1 0x7d8e37f8 in WebCore::InspectorBackendDispatcherImpl::DOMStorage_getDOMStorageItems (this=0x7a046518, callId=62, requestMessageObject=0x7760f0e0) at /home/kpiascik/dev/webkit/WebKitBuild/armle-v7/Debug/DerivedSources/WebCore/InspectorBackendDispatcher.cpp:2555 2555 result->setValue("entries", out_entries); (gdb) p out_entries $1 = {m_ptr = 0x0} 881846 2 199821 kpiascik 2013-04-26 06:11:15 -0700 Created attachment 199821 Patch 881967 3 199821 joepeck 2013-04-26 11:13:08 -0700 Comment on attachment 199821 Patch Nice, good test. 881984 4 199821 commit-queue 2013-04-26 11:56:34 -0700 Comment on attachment 199821 Patch Clearing flags on attachment: 199821 Committed r149200: <http://trac.webkit.org/changeset/149200> 881985 5 commit-queue 2013-04-26 11:56:36 -0700 All reviewed patches have been landed. Closing bug. 199821 2013-04-26 06:11:15 -0700 2013-04-26 11:56:34 -0700 Patch bug-115176-20130426090952.patch text/plain 5923 kpiascik U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4ODgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODgzZmIzZmIyOTQ0OWMy YTFiYmYwNWIwODMwOTMzMjczMDc2YTdiNS4uZDljYmQzYTIwYjBiZGRjMzk4NjUxNGI5NDk5ZGI5 MDczZDMwNDY2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTA0LTI1ICBLb25y YWQgUGlhc2NpayAgPGtwaWFzY2lrQGJsYWNrYmVycnkuY29tPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IENyYXNoIGR1ZSB0byBudWxsIGl0ZW1zIGZyb20gZ2V0RE9NU3RvcmFnZUl0ZW1zCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTUxNzYKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBmaW5kU3RvcmFn ZUFyZWEgd2FzIHJldHVybmluZyBhIG51bGwgc3RvcmFnZUFyZWEgY2F1c2luZyB0aGUgaXRlbXMK KyAgICAgICAgaW5wdXQgcGFyYW1hdGVyIHRvIG5vdCBiZSBzZXQuICBUaGlzIHdhcyBoYXBwZW5p bmcgd2l0aG91dCBhbnkgZXJyb3IKKyAgICAgICAgYmVpbmcgc2V0IGF0IGFsbC4gIFNldCBhbiBl cnJvciB0byBwcmV2ZW50IGEgY3Jhc2ggd2hlbiB3ZSB0cnkgdG8KKyAgICAgICAgY29udmVydCB0 aGUgcmVzdWx0IHRvIGEgSlNPTiBzdHJpbmcuCisKKyAgICAgICAgQWRkZWQgdGVzdHMgdG8gY2hl Y2sgaWYgc2Vzc2lvbiBhbmQgbG9jYWwgc3RvcmFnZSBhcmUgZW1wdHkgdGhhdAorICAgICAgICB0 aGV5IGFyZSBzdGlsbCBmdW5jdGlvbmFsLgorCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3Rv ckRPTVN0b3JhZ2VBZ2VudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JET01TdG9y YWdlQWdlbnQ6OmdldERPTVN0b3JhZ2VJdGVtcyk6CisKIDIwMTMtMDQtMjIgIE1pa2UgRmVudG9u ICA8bWlmZW50b25AcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gQWRkIGFkZGl0aW9u YWwgZGF0YWxpc3Qgc3VwcG9ydC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9JbnNwZWN0b3JET01TdG9yYWdlQWdlbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L0luc3BlY3RvckRPTVN0b3JhZ2VBZ2VudC5jcHAKaW5kZXggYjNlMGUxNmNlZTI4MjBjYzYwNzgx MzM0YjBmZjkwOTg3YWU4MGFkNi4uMjllZjNlYzYxMjc2YzFjZDFjY2Q2OGYzOTJjZDQ5YjZmODEy OGU1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTVN0 b3JhZ2VBZ2VudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRP TVN0b3JhZ2VBZ2VudC5jcHAKQEAgLTEyMCw4ICsxMjAsMTEgQEAgdm9pZCBJbnNwZWN0b3JET01T dG9yYWdlQWdlbnQ6OmdldERPTVN0b3JhZ2VJdGVtcyhFcnJvclN0cmluZyogZXJyb3JTdHJpbmcs IGNvbnMKIHsKICAgICBGcmFtZSogZnJhbWU7CiAgICAgUmVmUHRyPFN0b3JhZ2VBcmVhPiBzdG9y YWdlQXJlYSA9IGZpbmRTdG9yYWdlQXJlYShlcnJvclN0cmluZywgc3RvcmFnZUlkLCBmcmFtZSk7 Ci0gICAgaWYgKCFzdG9yYWdlQXJlYSkKKyAgICBpZiAoIXN0b3JhZ2VBcmVhKSB7CisgICAgICAg IGlmIChlcnJvclN0cmluZykKKyAgICAgICAgICAgICplcnJvclN0cmluZyA9ICJObyBTdG9yYWdl QXJlYSBmb3IgZ2l2ZW4gc3RvcmFnZUlkIjsKICAgICAgICAgcmV0dXJuOworICAgIH0KIAogICAg IFJlZlB0cjxUeXBlQnVpbGRlcjo6QXJyYXk8VHlwZUJ1aWxkZXI6OkFycmF5PFN0cmluZz4gPiA+ IHN0b3JhZ2VJdGVtcyA9IFR5cGVCdWlsZGVyOjpBcnJheTxUeXBlQnVpbGRlcjo6QXJyYXk8U3Ry aW5nPiA+OjpjcmVhdGUoKTsKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDg0Zjg5MmI1NmI0ZDIwNDMwMTg2YTgxMDg4NTgx MzJmZjBjMTk1ODMuLjA1Y2MyNTk5MTBiNjkxMWJmZWIzMzAxNDViMWMzZjlmZjIxOTNmYzAgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMy0wNC0yNiAgS29ucmFkIFBpYXNjaWsgIDxrcGlhc2Np a0BibGFja2JlcnJ5LmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBDcmFzaCBkdWUgdG8g bnVsbCBpdGVtcyBmcm9tIGdldERPTVN0b3JhZ2VJdGVtcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1MTc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdHMgdG8gY2hlY2sgdGhhdCBpZiBsb2NhbCBh bmQgc2Vzc2lvbiBzdG9yYWdlIGFyZSBlbXB0eQorICAgICAgICB0aGF0IHRoZXkgc3RpbGwgd29y ayBjb3JlcmN0bHkuCisKKyAgICAgICAgKiBpbnNwZWN0b3Ivc3RvcmFnZS1wYW5lbC1kb20tc3Rv cmFnZS1lbXB0eS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGluc3BlY3Rvci9zdG9y YWdlLXBhbmVsLWRvbS1zdG9yYWdlLWVtcHR5Lmh0bWw6IEFkZGVkLgorCiAyMDEzLTA0LTIyICBN aWtlIEZlbnRvbiAgPG1pZmVudG9uQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIEFk ZCBhZGRpdGlvbmFsIGRhdGFsaXN0IHN1cHBvcnQuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9p bnNwZWN0b3Ivc3RvcmFnZS1wYW5lbC1kb20tc3RvcmFnZS1lbXB0eS1leHBlY3RlZC50eHQgYi9M YXlvdXRUZXN0cy9pbnNwZWN0b3Ivc3RvcmFnZS1wYW5lbC1kb20tc3RvcmFnZS1lbXB0eS1leHBl Y3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uOWJjYjk1MjExY2E0OGQ1MWQwNWFkN2E3Njc3MGQ3ZmM3NGY2 MDliYgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9zdG9yYWdlLXBh bmVsLWRvbS1zdG9yYWdlLWVtcHR5LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDExIEBACitUZXN0 IHRoYXQgc3RvcmFnZSBwYW5lbCBpcyBwcmVzZW50IGFuZCB0aGF0IGl0IGNvbnRhaW5zIG5vIGRh dGEgZm9yIGxvY2FsIGFuZCBzZXNzaW9uIERPTSBzdG9yYWdlcy4KKworUG9wdWxhdGVkIGxvY2Fs IGFuZCBzZXNzaW9uIHN0b3JhZ2UKK0RpZCBzaG93OiBMb2NhbCBzdG9yYWdlCitEaWQgc2hvdzog U2Vzc2lvbiBzdG9yYWdlCitMb2NhbCBzdG9yYWdlIGNvbnRlbnQ6IAorS2V5VmFsdWUgcGFpcnM6 IAorU2Vzc2lvbiBzdG9yYWdlIGNvbnRlbnQ6IAorS2V5VmFsdWUgcGFpcnM6IAorRE9ORQorCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3Ivc3RvcmFnZS1wYW5lbC1kb20tc3RvcmFn ZS1lbXB0eS5odG1sIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3N0b3JhZ2UtcGFuZWwtZG9tLXN0 b3JhZ2UtZW1wdHkuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4wNGI3ZjI2MjNlMGYwMjNhNTZjY2U4YzNiM2Jh ZDU2NjQzYmUwNDVmCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3N0 b3JhZ2UtcGFuZWwtZG9tLXN0b3JhZ2UtZW1wdHkuaHRtbApAQCAtMCwwICsxLDcwIEBACis8aHRt bD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uL2h0dHAvdGVzdHMvaW5zcGVjdG9yL2luc3BlY3Rv ci10ZXN0LmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+CisKK2Z1bmN0aW9uIGNsZWFyRE9NU3RvcmFn ZSgpCit7CisgICAgbG9jYWxTdG9yYWdlLmNsZWFyKCk7CisgICAgc2Vzc2lvblN0b3JhZ2UuY2xl YXIoKTsKK30KKworZnVuY3Rpb24gdGVzdCgpCit7CisgICAgV2ViSW5zcGVjdG9yLnNob3dQYW5l bCgicmVzb3VyY2VzIik7CisKKyAgICBJbnNwZWN0b3JUZXN0LmV2YWx1YXRlSW5QYWdlKCJjbGVh ckRPTVN0b3JhZ2UoKSIsIGZ1bmN0aW9uKHJlc3VsdCkgeworICAgICAgICBJbnNwZWN0b3JUZXN0 LmFkZFJlc3VsdCgiUG9wdWxhdGVkIGxvY2FsIGFuZCBzZXNzaW9uIHN0b3JhZ2UiKTsKKyAgICB9 KTsKKyAgICBmdW5jdGlvbiBuYW1lKHN0b3JhZ2UpCisgICAgeworICAgICAgICByZXR1cm4gc3Rv cmFnZS5pc0xvY2FsU3RvcmFnZSA/ICJMb2NhbCBzdG9yYWdlIiA6ICJTZXNzaW9uIHN0b3JhZ2Ui OworICAgIH0KKworICAgIGZ1bmN0aW9uIGR1bXBEYXRhR3JpZENvbnRlbnQoZGF0YUdyaWQpCisg ICAgeworICAgICAgICB2YXIgbm9kZXMgPSBkYXRhR3JpZC5yb290Tm9kZSgpLmNoaWxkcmVuOwor ICAgICAgICB2YXIgcm93cyA9IFtdOworICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IG5vZGVz Lmxlbmd0aDsgKytpKSB7CisgICAgICAgICAgICB2YXIgbm9kZSA9IG5vZGVzW2ldOworICAgICAg ICAgICAgcm93cy5wdXNoKG5vZGUuX2RhdGEua2V5ICsgbm9kZS5fZGF0YS52YWx1ZSk7CisgICAg ICAgIH0KKyAgICAgICAgcm93cy5zb3J0KCk7CisgICAgICAgIEluc3BlY3RvclRlc3QuYWRkUmVz dWx0KCJLZXlWYWx1ZSBwYWlyczogIiArIHJvd3Muam9pbignJykpOworICAgIH0KKworICAgIElu c3BlY3RvclRlc3QucnVuQWZ0ZXJQZW5kaW5nRGlzcGF0Y2hlcyhmdW5jdGlvbigpIHsKKyAgICAg ICAgdmFyIHN0b3JhZ2VzID0gV2ViSW5zcGVjdG9yLmRvbVN0b3JhZ2VNb2RlbC5zdG9yYWdlcygp OworICAgICAgICBpZiAoc3RvcmFnZXMpIHsKKyAgICAgICAgICAgIGZvciAodmFyIGkgPSAwOyBp IDwgc3RvcmFnZXMubGVuZ3RoOyBpKyspIHsKKyAgICAgICAgICAgICAgICB2YXIgc3RvcmFnZSA9 IHN0b3JhZ2VzW2ldOworICAgICAgICAgICAgICAgIFdlYkluc3BlY3Rvci5wYW5lbHMucmVzb3Vy Y2VzLl9zaG93RE9NU3RvcmFnZShzdG9yYWdlKTsKKyAgICAgICAgICAgICAgICBJbnNwZWN0b3JU ZXN0LmFkZFJlc3VsdCgiRGlkIHNob3c6ICIgKyBuYW1lKHN0b3JhZ2UpKTsKKyAgICAgICAgICAg IH0KKyAgICAgICAgfSBlbHNlCisgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmFkZFJlc3VsdCgi RkFJTDogbm8gRE9NIHN0b3JhZ2VzIGZvdW5kLiIpOworCisgICAgICAgIEluc3BlY3RvclRlc3Qu cnVuQWZ0ZXJQZW5kaW5nRGlzcGF0Y2hlcyhmdW5jdGlvbigpIHsKKyAgICAgICAgICAgIHZhciBz dG9yYWdlcyA9IFdlYkluc3BlY3Rvci5kb21TdG9yYWdlTW9kZWwuc3RvcmFnZXMoKTsKKyAgICAg ICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgc3RvcmFnZXMubGVuZ3RoOyBpKyspIHsKKyAgICAg ICAgICAgICAgICB2YXIgc3RvcmFnZSA9IHN0b3JhZ2VzW2ldOworICAgICAgICAgICAgICAgIElu c3BlY3RvclRlc3QuYWRkUmVzdWx0KG5hbWUoc3RvcmFnZSkgKyAiIGNvbnRlbnQ6ICIpOworICAg ICAgICAgICAgICAgIHZhciB2aWV3ID0gV2ViSW5zcGVjdG9yLnBhbmVscy5yZXNvdXJjZXMuX2Rv bVN0b3JhZ2VWaWV3cy5nZXQoc3RvcmFnZSk7CisgICAgICAgICAgICAgICAgZHVtcERhdGFHcmlk Q29udGVudCh2aWV3Ll9kYXRhR3JpZCk7CisgICAgICAgICAgICB9CisgICAgICAgICAgICBJbnNw ZWN0b3JUZXN0LmFkZFJlc3VsdCgiRE9ORSIpOworICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5j b21wbGV0ZVRlc3QoKTsKKyAgICAgICAgfSk7CisgICAgfSk7Cit9CisKKzwvc2NyaXB0PgorPC9o ZWFkPgorCis8Ym9keSBvbmxvYWQ9InJ1blRlc3QoKSI+Cis8cD4KK1Rlc3QgdGhhdCBzdG9yYWdl IHBhbmVsIGlzIHByZXNlbnQgYW5kIHRoYXQgaXQgY29udGFpbnMgbm8gZGF0YSBmb3IgbG9jYWwg YW5kIHNlc3Npb24gRE9NIHN0b3JhZ2VzLgorPC9wPgorCis8L2JvZHk+Cis8L2h0bWw+Cg==