115168 2013-04-25 03:27:45 -0700 Build fix for WinCE after r148888 and r149097 2013-04-29 08:21:34 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 1 paroga paroga benjamin cmarcelo commit-queue oldest_to_newest 881186 0 paroga 2013-04-25 03:27:45 -0700 Build fix for WinCE after r148888 and r149097 881188 1 199648 paroga 2013-04-25 04:12:22 -0700 Created attachment 199648 Patch 881190 2 commit-queue 2013-04-25 04:14:56 -0700 Attachment 199648 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/MathExtras.h']" exit_code: 1 Source/WTF/wtf/MathExtras.h:216: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 882545 3 199648 andersca 2013-04-29 07:13:05 -0700 Comment on attachment 199648 Patch Eww, but OK. 882592 4 199648 commit-queue 2013-04-29 08:21:32 -0700 Comment on attachment 199648 Patch Clearing flags on attachment: 199648 Committed r149285: <http://trac.webkit.org/changeset/149285> 882593 5 commit-queue 2013-04-29 08:21:34 -0700 All reviewed patches have been landed. Closing bug. 199648 2013-04-25 04:12:22 -0700 2013-04-29 08:21:32 -0700 Patch bug-115168.patch text/plain 2396 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggOTRhMjZmNy4uYjk1ZjViYSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMiBAQAogMjAxMy0wNC0yNSAg UGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KIAorICAgICAgICBCdWlsZCBm aXggZm9yIFdpbkNFIGFmdGVyIHIxNDg4ODggYW5kIHIxNDkwOTcKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNTE2OAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gdXNpbmcgY29tcGlsZXIgaW50cmlu c2ljcyBvbiBXaW5kb3dzIENFIHRoZSBjb21waWxlciBjb21wbGFpbnMKKyAgICAgICAgYWJvdXQg d3JvbmcgbGlua2FnZSBzcGVjaWZpY2F0aW9uIG9mIHJlcGxhY2VkIENSVCBmdW5jdGlvbnMgZGVm aW5lZAorICAgICAgICBpbiBtYXRoLmguIFRoaXMgaXMgYmVjYXVzZSB0aGUgY29tcGlsZXIgaGFz IGludHJpbnNpY3MgZm9yIHRoaXMKKyAgICAgICAgZnVuY3Rpb25zIGRlZmluZWQsIGFuZCByZXF1 aXJlcyB0aGVtIHRvIGhhdmUgZXh0ZXJuICJDIiBsaW5rYWdlLgorCisgICAgICAgICogd3RmL01h dGhFeHRyYXMuaDoKKyAgICAgICAgKHd0Zl9hdGFuMik6IEFkZGVkIGV4dGVybiAiQyIgdG8gZnVu Y3Rpb24gc2lnbmF0dXJlLgorICAgICAgICAod3RmX2Ztb2QpOiBEaXR0by4KKyAgICAgICAgKHd0 Zl9wb3cpOiBEaXR0by4KKworMjAxMy0wNC0yNSAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FA d2Via2l0Lm9yZz4KKwogICAgICAgICBVbnJldmlld2VkIFdpbkNFIGJ1aWxkIGZpeCBhZnRlciBy MTQ4ODg4LgogCiAgICAgICAgICogd3RmL0F0b21pY3MuaDogV2luQ0UgdmVyc2lvbiBvZiBpbnRy aW4uaCBpcyBjYWxsZWQgY21uaW50cmluLmguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9N YXRoRXh0cmFzLmggYi9Tb3VyY2UvV1RGL3d0Zi9NYXRoRXh0cmFzLmgKaW5kZXggYjcwZTQ2OC4u ZGJkZWViMSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvTWF0aEV4dHJhcy5oCisrKyBiL1Nv dXJjZS9XVEYvd3RmL01hdGhFeHRyYXMuaApAQCAtMTg3LDcgKzE4Nyw3IEBAIGlubGluZSBmbG9h dCBuZXh0YWZ0ZXJmKGZsb2F0IHgsIGZsb2F0IHkpIHsgcmV0dXJuIHggPiB5ID8geCAtIEZMVF9F UFNJTE9OIDogeCArCiBpbmxpbmUgZG91YmxlIGNvcHlzaWduKGRvdWJsZSB4LCBkb3VibGUgeSkg eyByZXR1cm4gX2NvcHlzaWduKHgsIHkpOyB9CiAKIC8vIFdvcmsgYXJvdW5kIGEgYnVnIGluIFdp biwgd2hlcmUgYXRhbjIoKy1pbmZpbml0eSwgKy1pbmZpbml0eSkgeWllbGRzIE5hTiBpbnN0ZWFk IG9mIHNwZWNpZmljIHZhbHVlcy4KLWlubGluZSBkb3VibGUgd3RmX2F0YW4yKGRvdWJsZSB4LCBk b3VibGUgeSkKK2V4dGVybiAiQyIgaW5saW5lIGRvdWJsZSB3dGZfYXRhbjIoZG91YmxlIHgsIGRv dWJsZSB5KQogewogICAgIGRvdWJsZSBwb3NJbmYgPSBzdGQ6Om51bWVyaWNfbGltaXRzPGRvdWJs ZT46OmluZmluaXR5KCk7CiAgICAgZG91YmxlIG5lZ0luZiA9IC1zdGQ6Om51bWVyaWNfbGltaXRz PGRvdWJsZT46OmluZmluaXR5KCk7CkBAIC0yMTAsMTAgKzIxMCwxMCBAQCBpbmxpbmUgZG91Ymxl IHd0Zl9hdGFuMihkb3VibGUgeCwgZG91YmxlIHkpCiB9CiAKIC8vIFdvcmsgYXJvdW5kIGEgYnVn IGluIHRoZSBNaWNyb3NvZnQgQ1JULCB3aGVyZSBmbW9kKHgsICstaW5maW5pdHkpIHlpZWxkcyBO YU4gaW5zdGVhZCBvZiB4LgotaW5saW5lIGRvdWJsZSB3dGZfZm1vZChkb3VibGUgeCwgZG91Ymxl IHkpIHsgcmV0dXJuICghc3RkOjppc2luZih4KSAmJiBzdGQ6OmlzaW5mKHkpKSA/IHggOiBmbW9k KHgsIHkpOyB9CitleHRlcm4gIkMiIGlubGluZSBkb3VibGUgd3RmX2Ztb2QoZG91YmxlIHgsIGRv dWJsZSB5KSB7IHJldHVybiAoIXN0ZDo6aXNpbmYoeCkgJiYgc3RkOjppc2luZih5KSkgPyB4IDog Zm1vZCh4LCB5KTsgfQogCiAvLyBXb3JrIGFyb3VuZCBhIGJ1ZyBpbiB0aGUgTWljcm9zb2Z0IENS VCwgd2hlcmUgcG93KE5hTiwgMCkgeWllbGRzIE5hTiBpbnN0ZWFkIG9mIDEuCi1pbmxpbmUgZG91 YmxlIHd0Zl9wb3coZG91YmxlIHgsIGRvdWJsZSB5KSB7IHJldHVybiB5ID09IDAgPyAxIDogcG93 KHgsIHkpOyB9CitleHRlcm4gIkMiIGlubGluZSBkb3VibGUgd3RmX3Bvdyhkb3VibGUgeCwgZG91 YmxlIHkpIHsgcmV0dXJuIHkgPT0gMCA/IDEgOiBwb3coeCwgeSk7IH0KIAogI2RlZmluZSBhdGFu Mih4LCB5KSB3dGZfYXRhbjIoeCwgeSkKICNkZWZpbmUgZm1vZCh4LCB5KSB3dGZfZm1vZCh4LCB5 KQo=