115167 2013-04-25 03:24:52 -0700 REGRESSION(r137994): Random crashes in Yarr JIT for SH4 arch 2013-04-25 09:17:42 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 jbriance webkit-unassigned commit-queue fpizlo hausmann mark.lam oliver zherczeg oldest_to_newest 881185 0 jbriance 2013-04-25 03:24:52 -0700 Random crashes seen when using SH4 RegExp JIT. These crashes "disappear" if "JSC_useRegExpJIT=false" environment variable is set. Unit test to reproduce: $ ./jsc -s Source/JavaScriptCore/tests/mozilla/ecma_3/shell.js -s Source/JavaScriptCore/tests/mozilla/ecma_3/RegExp/shell.js /usr/WebKit-jsc/jsctest/ecma_3/RegExp/perlstress-001.js According to http://trac.webkit.org/changeset/144170 and http://trac.webkit.org/changeset/145194, I also suspect that SH4 cacheFlush() should also be aligned on page size (or function receives incorrect values from caller). 881187 1 jbriance 2013-04-25 03:29:16 -0700 I forgot to mention that if I revert r137994, issue is "solved". 881241 2 199659 jbriance 2013-04-25 07:30:08 -0700 Created attachment 199659 Flush each page separately in cacheFlush function for SH4 arch 881293 3 199659 commit-queue 2013-04-25 09:17:40 -0700 Comment on attachment 199659 Flush each page separately in cacheFlush function for SH4 arch Clearing flags on attachment: 199659 Committed r149114: <http://trac.webkit.org/changeset/149114> 881294 4 commit-queue 2013-04-25 09:17:42 -0700 All reviewed patches have been landed. Closing bug. 199659 2013-04-25 07:30:08 -0700 2013-04-25 09:17:40 -0700 Flush each page separately in cacheFlush function for SH4 arch bug-115167.patch text/plain 2500 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ5MTA4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDEzLTA0LTI1ICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VhdUBuZHMuY29tPgorCisg ICAgICAgIFJFR1JFU1NJT04ocjEzNzk5NCk6IFJhbmRvbSBjcmFzaGVzIG9jY3VyIHdpdGggU0g0 IEpTQy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx NTE2Ny4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBT aW5jZSByMTM3OTk0LCB1bmNvbW1pdGVkIHBhZ2VzIGNvdWxkIGJlIGluc2lkZSB0aGUgYXJlYSBv ZiBtZW1vcnkgaW4KKyAgICAgICAgcGFyYW1ldGVyIG9mIHRoZSBjYWNoZUZsdXNoIGZ1bmN0aW9u LiBUaGF0J3Mgd2h5IHdlIGhhdmUgdG8gZmx1c2ggZWFjaAorICAgICAgICBwYWdlIHNlcGFyYXRl bHkgdG8gYXZvaWQgYSBmYWlsIG9mIHRoZSB3aG9sZSBmbHVzaCwgaWYgYW4gdW5jb21taXRlZCBw YWdlCisgICAgICAgIGlzIGluIHRoZSBhcmVhLgorCisgICAgICAgIFRoaXMgcGF0Y2ggaXMgdmVy eSBzaW1pbGFyIHRvIGNoYW5nZXNldCAxNDUxOTQgbWFkZSBmb3IgQVJNdjcgYXJjaGl0ZWN0dXJl LAorICAgICAgICBzZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx MTQ0MSBmb3IgZnVydGhlciBpbmZvcm1hdGlvbi4KKworICAgICAgICAqIGFzc2VtYmxlci9TSDRB c3NlbWJsZXIuaDoKKyAgICAgICAgKEpTQzo6U0g0QXNzZW1ibGVyOjpjYWNoZUZsdXNoKToKKwog MjAxMy0wNC0yNCAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRk IHdhdGNoZG9nIHRpbWVyIHBvbGxpbmcgZm9yIHRoZSBERkcuCkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvYXNzZW1ibGVyL1NINEFzc2VtYmxlci5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvU0g0QXNzZW1ibGVyLmgJKHJldmlzaW9uIDE0OTA5NSkK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvU0g0QXNzZW1ibGVyLmgJKHdvcmtp bmcgY29weSkKQEAgLTE1ODMsMTIgKzE1ODMsMjAgQEAgcHVibGljOgogCiAgICAgc3RhdGljIHZv aWQgY2FjaGVGbHVzaCh2b2lkKiBjb2RlLCBzaXplX3Qgc2l6ZSkKICAgICB7Ci0jaWYgIU9TKExJ TlVYKQotI2Vycm9yICJUaGUgY2FjaGVGbHVzaCBzdXBwb3J0IGlzIG1pc3Npbmcgb24gdGhpcyBw bGF0Zm9ybS4iCi0jZWxpZiBkZWZpbmVkIENBQ0hFRkxVU0hfRF9MMgotICAgICAgICBzeXNjYWxs KF9fTlJfY2FjaGVmbHVzaCwgcmVpbnRlcnByZXRfY2FzdDx1bnNpZ25lZD4oY29kZSksIHNpemUs IENBQ0hFRkxVU0hfRF9XQiB8IENBQ0hFRkxVU0hfSSB8IENBQ0hFRkxVU0hfRF9MMik7CisjaWYg T1MoTElOVVgpCisgICAgICAgIC8vIEZsdXNoIGVhY2ggcGFnZSBzZXBhcmF0ZWx5LCBvdGhlcndp c2UgdGhlIHdob2xlIGZsdXNoIHdpbGwgZmFpbCBpZiBhbiB1bmNvbW1pdGVkIHBhZ2UgaXMgaW4g dGhlIGFyZWEuCisgICAgICAgIHVuc2lnbmVkIGN1cnJlbnRQYWdlID0gcmVpbnRlcnByZXRfY2Fz dDx1bnNpZ25lZD4oY29kZSkgJiB+KHBhZ2VTaXplKCkgLSAxKTsKKyAgICAgICAgdW5zaWduZWQg bGFzdFBhZ2UgPSAocmVpbnRlcnByZXRfY2FzdDx1bnNpZ25lZD4oY29kZSkgKyBzaXplKSAmIH4o cGFnZVNpemUoKSAtIDEpOworICAgICAgICBkbyB7CisjaWYgZGVmaW5lZCBDQUNIRUZMVVNIX0Rf TDIKKyAgICAgICAgICAgIHN5c2NhbGwoX19OUl9jYWNoZWZsdXNoLCBjdXJyZW50UGFnZSwgcGFn ZVNpemUoKSwgQ0FDSEVGTFVTSF9EX1dCIHwgQ0FDSEVGTFVTSF9JIHwgQ0FDSEVGTFVTSF9EX0wy KTsKKyNlbHNlCisgICAgICAgICAgICBzeXNjYWxsKF9fTlJfY2FjaGVmbHVzaCwgY3VycmVudFBh Z2UsIHBhZ2VTaXplKCksIENBQ0hFRkxVU0hfRF9XQiB8IENBQ0hFRkxVU0hfSSk7CisjZW5kaWYK KyAgICAgICAgICAgIGN1cnJlbnRQYWdlICs9IHBhZ2VTaXplKCk7CisgICAgICAgIH0gd2hpbGUg KGxhc3RQYWdlID49IGN1cnJlbnRQYWdlKTsKICNlbHNlCi0gICAgICAgIHN5c2NhbGwoX19OUl9j YWNoZWZsdXNoLCByZWludGVycHJldF9jYXN0PHVuc2lnbmVkPihjb2RlKSwgc2l6ZSwgQ0FDSEVG TFVTSF9EX1dCIHwgQ0FDSEVGTFVTSF9JKTsKKyNlcnJvciAiVGhlIGNhY2hlRmx1c2ggc3VwcG9y dCBpcyBtaXNzaW5nIG9uIHRoaXMgcGxhdGZvcm0uIgogI2VuZGlmCiAgICAgfQogCg==