115163 2013-04-25 01:49:15 -0700 [GTK] Tools/gtk/install-dependencies is missing the ragel dependency 2013-04-25 07:18:36 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 xcastanho webkit-unassigned aperez cgarcia commit-queue mrobinson pnormand rego xan.lopez oldest_to_newest 881148 0 xcastanho 2013-04-25 01:49:15 -0700 harfbuzz requires ragel package to be installed. 881164 1 199640 xcastanho 2013-04-25 02:21:55 -0700 Created attachment 199640 Patch 881167 2 199640 xan.lopez 2013-04-25 02:36:33 -0700 Comment on attachment 199640 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199640&action=review Maybe correct the name in the ChangeLog? A good way to learn about annoying reviewers ;) > Tools/ChangeLog:9 > + which is expected when building hardbuff Not very important, but the name is "harfbuzz". 881172 3 aperez 2013-04-25 02:45:17 -0700 Informally reviewing... There is another small typo in the ChangeLog, please change “scrtip” to “script”. It would be nice to fix it when you edit the ChangeLog with Xan's comment. Apart from that, looks fine. 881174 4 199644 xcastanho 2013-04-25 02:49:09 -0700 Created attachment 199644 Patch 881183 5 199644 xan.lopez 2013-04-25 03:06:51 -0700 Comment on attachment 199644 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199644&action=review > Tools/ChangeLog:9 > + which is expected when building HarfBuff. Still wrong :D! See http://www.freedesktop.org/wiki/Software/HarfBuzz 881191 6 199650 xcastanho 2013-04-25 04:26:16 -0700 Created attachment 199650 Patch 881237 7 199650 commit-queue 2013-04-25 07:18:34 -0700 Comment on attachment 199650 Patch Clearing flags on attachment: 199650 Committed r149109: <http://trac.webkit.org/changeset/149109> 881238 8 commit-queue 2013-04-25 07:18:36 -0700 All reviewed patches have been landed. Closing bug. 199640 2013-04-25 02:21:55 -0700 2013-04-25 02:49:03 -0700 Patch bug-115163-20130425112116.patch text/plain 1498 xcastanho U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5MDk1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOGY4NzQ5OTljYTBjNjQ4YTZjOGE2NzJjNDQyYTZiZWY2 Y2ZmY2FhMS4uNWU4NmY4MWI3ZGE5OGViZTMyMTY5OTFhOTM3NjZiMGRjZDJmNGJkNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDExLTA0LTI1ICBYYXZpZXIgQ2FzdGFubyAgPHhjYXN0YW5ob0BpZ2FsaWEuY29tPgor CisgICAgICAgIFtHVEtdIFRvb2xzL2d0ay9pbnN0YWxsLWRlcGVuZGVuY2llcyBhZGRlZCByYWdl bCBkZXBlbmRlbmN5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTUxNjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGUgaW5zdGFsbC1kZXBlbmRlbmNpZXMgc2NydGlwIHdhcyBtaXNzaW5nIGEgZGVwZW5k ZW5jeSBvbiByYWdlbAorICAgICAgICB3aGljaCBpcyBleHBlY3RlZCB3aGVuIGJ1aWxkaW5nIGhh cmRidWZmCisKKyAgICAgICAgKiBndGsvaW5zdGFsbC1kZXBlbmRlbmNpZXM6IEFkZGVkIGEgZGVw ZW5kZW5jeSBvbiByYWdlbCBmb3IgYm90aAorICAgICAgICBhcHQgYW5kIHl1bS4KKwogMjAxMy0w NC0yNCAgU2Vva2p1IEt3b24gIDxzZW9ranUua3dvbkBnbWFpbC5jb20+CiAKICAgICAgICAgUmVt b3ZlIGNoZWNraW5nIGNocm9taXVtIGZyb20gcnVuLXdlYmtpdC10ZXN0cwpkaWZmIC0tZ2l0IGEv VG9vbHMvZ3RrL2luc3RhbGwtZGVwZW5kZW5jaWVzIGIvVG9vbHMvZ3RrL2luc3RhbGwtZGVwZW5k ZW5jaWVzCmluZGV4IGE3MjNiOGZmYjFlNmJjNGQyMjZmNmMwY2EzMmU5NWQ2MjhmYzlhY2EuLjBl NmQ4Y2E3NmQ0OTQzY2EwZWMwMGY0ZDRhMGUwNzUyMjdkNjQyZmEgMTAwNzU1Ci0tLSBhL1Rvb2xz L2d0ay9pbnN0YWxsLWRlcGVuZGVuY2llcworKysgYi9Ub29scy9ndGsvaW5zdGFsbC1kZXBlbmRl bmNpZXMKQEAgLTk4LDcgKzk4LDggQEAgZnVuY3Rpb24gaW5zdGFsbERlcGVuZGVuY2llc1dpdGhB cHQgewogICAgICAgICBsaWJncGctZXJyb3ItZGV2IFwKICAgICAgICAgbGlicDExLWtpdC1kZXYg XAogICAgICAgICBsaWJ0aWZmNC1kZXYgXAotICAgICAgICBsaWJjcm9jbzMtZGV2CisgICAgICAg IGxpYmNyb2NvMy1kZXYgXAorICAgICAgICByYWdlbAogfQogCiBmdW5jdGlvbiBpbnN0YWxsRGVw ZW5kZW5jaWVzV2l0aFl1bSB7CkBAIC0xNjIsNyArMTYzLDggQEAgZnVuY3Rpb24gaW5zdGFsbERl cGVuZGVuY2llc1dpdGhZdW0gewogICAgICAgICBsaWJwMTEtZGV2ZWwgXAogICAgICAgICBsaWJ0 aWZmLWRldmVsIFwKICAgICAgICAgbGliY3JvY28tZGV2ZWwgXAotICAgICAgICBtZXNhLWxpYkVH TC1kZXZlbAorICAgICAgICBtZXNhLWxpYkVHTC1kZXZlbCBcCisgICAgICAgIHJhZ2VsCiB9CiAK IGNoZWNrSW5zdGFsbGVyCg== 199644 2013-04-25 02:49:09 -0700 2013-04-25 04:26:09 -0700 Patch bug-115163-20130425114830.patch text/plain 1499 xcastanho U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5MDk1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOGY4NzQ5OTljYTBjNjQ4YTZjOGE2NzJjNDQyYTZiZWY2 Y2ZmY2FhMS4uODQ0YmRiOTk2NWYxMzg4N2EzNmQzMDk3MGYxNDI0ZTA5ZDM3MjUxZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDExLTA0LTI1ICBYYXZpZXIgQ2FzdGFubyAgPHhjYXN0YW5ob0BpZ2FsaWEuY29tPgor CisgICAgICAgIFtHVEtdIFRvb2xzL2d0ay9pbnN0YWxsLWRlcGVuZGVuY2llcyBhZGRlZCByYWdl bCBkZXBlbmRlbmN5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTUxNjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGUgaW5zdGFsbC1kZXBlbmRlbmNpZXMgc2NyaXB0IHdhcyBtaXNzaW5nIGEgZGVwZW5k ZW5jeSBvbiByYWdlbAorICAgICAgICB3aGljaCBpcyBleHBlY3RlZCB3aGVuIGJ1aWxkaW5nIEhh cmZCdWZmLgorCisgICAgICAgICogZ3RrL2luc3RhbGwtZGVwZW5kZW5jaWVzOiBBZGRlZCBhIGRl cGVuZGVuY3kgb24gcmFnZWwgZm9yIGJvdGgKKyAgICAgICAgYXB0IGFuZCB5dW0uCisKIDIwMTMt MDQtMjQgIFNlb2tqdSBLd29uICA8c2Vva2p1Lmt3b25AZ21haWwuY29tPgogCiAgICAgICAgIFJl bW92ZSBjaGVja2luZyBjaHJvbWl1bSBmcm9tIHJ1bi13ZWJraXQtdGVzdHMKZGlmZiAtLWdpdCBh L1Rvb2xzL2d0ay9pbnN0YWxsLWRlcGVuZGVuY2llcyBiL1Rvb2xzL2d0ay9pbnN0YWxsLWRlcGVu ZGVuY2llcwppbmRleCBhNzIzYjhmZmIxZTZiYzRkMjI2ZjZjMGNhMzJlOTVkNjI4ZmM5YWNhLi4w ZTZkOGNhNzZkNDk0M2NhMGVjMDBmNGQ0YTBlMDc1MjI3ZDY0MmZhIDEwMDc1NQotLS0gYS9Ub29s cy9ndGsvaW5zdGFsbC1kZXBlbmRlbmNpZXMKKysrIGIvVG9vbHMvZ3RrL2luc3RhbGwtZGVwZW5k ZW5jaWVzCkBAIC05OCw3ICs5OCw4IEBAIGZ1bmN0aW9uIGluc3RhbGxEZXBlbmRlbmNpZXNXaXRo QXB0IHsKICAgICAgICAgbGliZ3BnLWVycm9yLWRldiBcCiAgICAgICAgIGxpYnAxMS1raXQtZGV2 IFwKICAgICAgICAgbGlidGlmZjQtZGV2IFwKLSAgICAgICAgbGliY3JvY28zLWRldgorICAgICAg ICBsaWJjcm9jbzMtZGV2IFwKKyAgICAgICAgcmFnZWwKIH0KIAogZnVuY3Rpb24gaW5zdGFsbERl cGVuZGVuY2llc1dpdGhZdW0gewpAQCAtMTYyLDcgKzE2Myw4IEBAIGZ1bmN0aW9uIGluc3RhbGxE ZXBlbmRlbmNpZXNXaXRoWXVtIHsKICAgICAgICAgbGlicDExLWRldmVsIFwKICAgICAgICAgbGli dGlmZi1kZXZlbCBcCiAgICAgICAgIGxpYmNyb2NvLWRldmVsIFwKLSAgICAgICAgbWVzYS1saWJF R0wtZGV2ZWwKKyAgICAgICAgbWVzYS1saWJFR0wtZGV2ZWwgXAorICAgICAgICByYWdlbAogfQog CiBjaGVja0luc3RhbGxlcgo= 199650 2013-04-25 04:26:16 -0700 2013-04-25 07:18:34 -0700 Patch bug-115163-20130425132537.patch text/plain 1499 xcastanho U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5MDk1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOGY4NzQ5OTljYTBjNjQ4YTZjOGE2NzJjNDQyYTZiZWY2 Y2ZmY2FhMS4uN2NiMzhmNzFhYmMyMzRmNDBmZTlmZjA1YmJkOGRhZDQ4YTFkZDRmYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDExLTA0LTI1ICBYYXZpZXIgQ2FzdGFubyAgPHhjYXN0YW5ob0BpZ2FsaWEuY29tPgor CisgICAgICAgIFtHVEtdIFRvb2xzL2d0ay9pbnN0YWxsLWRlcGVuZGVuY2llcyBhZGRlZCByYWdl bCBkZXBlbmRlbmN5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTUxNjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGUgaW5zdGFsbC1kZXBlbmRlbmNpZXMgc2NyaXB0IHdhcyBtaXNzaW5nIGEgZGVwZW5k ZW5jeSBvbiByYWdlbAorICAgICAgICB3aGljaCBpcyBleHBlY3RlZCB3aGVuIGJ1aWxkaW5nIEhh cmZCdXp6LgorCisgICAgICAgICogZ3RrL2luc3RhbGwtZGVwZW5kZW5jaWVzOiBBZGRlZCBhIGRl cGVuZGVuY3kgb24gcmFnZWwgZm9yIGJvdGgKKyAgICAgICAgYXB0IGFuZCB5dW0uCisKIDIwMTMt MDQtMjQgIFNlb2tqdSBLd29uICA8c2Vva2p1Lmt3b25AZ21haWwuY29tPgogCiAgICAgICAgIFJl bW92ZSBjaGVja2luZyBjaHJvbWl1bSBmcm9tIHJ1bi13ZWJraXQtdGVzdHMKZGlmZiAtLWdpdCBh L1Rvb2xzL2d0ay9pbnN0YWxsLWRlcGVuZGVuY2llcyBiL1Rvb2xzL2d0ay9pbnN0YWxsLWRlcGVu ZGVuY2llcwppbmRleCBhNzIzYjhmZmIxZTZiYzRkMjI2ZjZjMGNhMzJlOTVkNjI4ZmM5YWNhLi4w ZTZkOGNhNzZkNDk0M2NhMGVjMDBmNGQ0YTBlMDc1MjI3ZDY0MmZhIDEwMDc1NQotLS0gYS9Ub29s cy9ndGsvaW5zdGFsbC1kZXBlbmRlbmNpZXMKKysrIGIvVG9vbHMvZ3RrL2luc3RhbGwtZGVwZW5k ZW5jaWVzCkBAIC05OCw3ICs5OCw4IEBAIGZ1bmN0aW9uIGluc3RhbGxEZXBlbmRlbmNpZXNXaXRo QXB0IHsKICAgICAgICAgbGliZ3BnLWVycm9yLWRldiBcCiAgICAgICAgIGxpYnAxMS1raXQtZGV2 IFwKICAgICAgICAgbGlidGlmZjQtZGV2IFwKLSAgICAgICAgbGliY3JvY28zLWRldgorICAgICAg ICBsaWJjcm9jbzMtZGV2IFwKKyAgICAgICAgcmFnZWwKIH0KIAogZnVuY3Rpb24gaW5zdGFsbERl cGVuZGVuY2llc1dpdGhZdW0gewpAQCAtMTYyLDcgKzE2Myw4IEBAIGZ1bmN0aW9uIGluc3RhbGxE ZXBlbmRlbmNpZXNXaXRoWXVtIHsKICAgICAgICAgbGlicDExLWRldmVsIFwKICAgICAgICAgbGli dGlmZi1kZXZlbCBcCiAgICAgICAgIGxpYmNyb2NvLWRldmVsIFwKLSAgICAgICAgbWVzYS1saWJF R0wtZGV2ZWwKKyAgICAgICAgbWVzYS1saWJFR0wtZGV2ZWwgXAorICAgICAgICByYWdlbAogfQog CiBjaGVja0luc3RhbGxlcgo=