115158 2013-04-25 01:04:40 -0700 Account for CTM scale when deciding the image resampling algorithm. 2022-10-31 14:52:05 -0700 1 1 1 Unclassified WebKit Images 528+ (Nightly build) Unspecified Unspecified NEW BlinkMergeCandidate P2 Normal --- 1 rniwa webkit-unassigned ahmad.saleem792 ap benjamin bfulgham dino simon.fraser zalan oldest_to_newest 881129 0 rniwa 2013-04-25 01:04:40 -0700 We might want to consider merging: https://chromium.googlesource.com/chromium/blink/+/b772b4d7c24b66bebba703fd2ef89fbe73ea1935 Account for CTM scale when deciding the image resampling algorithm. ImageQualityController considers the image size and layout size when computing which resampling algorithm to use, but did not account for the current transform. This was noticable as 'bouncing' when scaling an image direclty with a transform. This patch incorporates the context's CTM (which includes scale but not zoom) into the resampling calculation. Because the ImageQualityController runs on a 500ms timer, a manual test has been added. 1892784 1 ahmad.saleem792 2022-08-21 05:14:46 -0700 Not removed: https://github.com/WebKit/WebKit/blob/786e7036ff95fecccbd5ec1aae8a39a523227f1e/Source/WebCore/rendering/ImageQualityController.cpp#L125 to Line 127. _____ Added these two lines (155 & 156): https://github.com/WebKit/WebKit/blob/786e7036ff95fecccbd5ec1aae8a39a523227f1e/Source/WebCore/rendering/ImageQualityController.cpp#L155 _____ LayoutSize not detailed and also not updated below: https://github.com/WebKit/WebKit/blob/786e7036ff95fecccbd5ec1aae8a39a523227f1e/Source/WebCore/rendering/ImageQualityController.cpp#L172 _______ Above are some examples, which indicates that it might be added in some shape or form but not completely.. Appreciate if someone can confirm. Thanks! 1909430 2 ahmad.saleem792 2022-10-31 14:52:05 -0700 I tried it with following: https://github.com/WebKit/WebKit/pull/5111 but it seems that this optimisation was removed in follow-up: https://src.chromium.org/viewvc/blink?revision=194338&view=revision I am going to close by PR despite review from Said because it is leading to build failures as well. Thanks!