115157 2013-04-25 00:59:41 -0700 Reducing CSS code duplication in declaration list error recovery 2013-05-25 01:29:35 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate P2 Normal --- 115159 113401 1 rniwa svillar darin glenn kling koivisto svillar oldest_to_newest 881128 0 rniwa 2013-04-25 00:59:41 -0700 We might want to consider importing https://chromium.googlesource.com/chromium/blink/+/7e63c2b023715d1cdf2a283d0057eb41da144876 Reducing CSS code duplication in declaration list error recovery. 893297 1 202817 svillar 2013-05-24 07:25:37 -0700 Created attachment 202817 Patch 893299 2 202817 svillar 2013-05-24 07:27:00 -0700 Comment on attachment 202817 Patch Removing the r? flag in order not to send this to the EWS as the patch does not apply without the patch for bug 115159 893580 3 202817 svillar 2013-05-25 01:07:11 -0700 Comment on attachment 202817 Patch Setting this for review now that 115159 landed 893581 4 202817 kling 2013-05-25 01:27:20 -0700 Comment on attachment 202817 Patch r=me. Happy to see this monster shrink a bit. 893583 5 202817 svillar 2013-05-25 01:29:28 -0700 Comment on attachment 202817 Patch Clearing flags on attachment: 202817 Committed r150682: <http://trac.webkit.org/changeset/150682> 893584 6 svillar 2013-05-25 01:29:35 -0700 All reviewed patches have been landed. Closing bug. 202817 2013-05-24 07:25:37 -0700 2013-05-25 01:29:28 -0700 Patch bug-115157-20130524162420.patch text/plain 3133 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwNTg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDY5ZGNmZTU2YzdiNWYy MTE2MzRkZTRiNzM0ODlmMjk1MWE2YmE2MS4uMTE0ZWZhZmE3YjYxYzMzYjJmMWVhMjNhMWM2MjBk NmY2M2FkNzYzZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA1LTI0ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFJlZHVjaW5n IENTUyBjb2RlIGR1cGxpY2F0aW9uIGluIGRlY2xhcmF0aW9uIGxpc3QgZXJyb3IgcmVjb3ZlcnkK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNTE1Nwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZyb20gQmxp bmsgcjE0ODk3NCBieSA8c2VyeWFAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlZmFjdG9yICJp bnZhbGlkX2Jsb2NrX2xpc3QgZXJyb3IgfCAvKiBlbXB0eSAqLyIgaW4gYSBuZXcKKyAgICAgICAg ZGVjbF9saXN0X3JlY292ZXJ5IHJ1bGUgdGhhdCBhbGxvd3MgdG8gcmVtb3ZlIDQgcmVkdW5kYW50 IHJ1bGVzLgorCisgICAgICAgIE5vIG5ldyB0ZXN0IHJlcXVpcmVkIGFzIHdlJ3JlIGp1c3QgcmVm YWN0b3JpbmcgY29kZSwgbm8gbmV3IGJlaGF2aW91ci4KKworICAgICAgICAqIGNzcy9DU1NHcmFt bWFyLnkuaW46CisKIDIwMTMtMDUtMjMgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGln YWxpYS5jb20+CiAKICAgICAgICAgRml4aW5nIGludmFsaWQgYmxvY2sgcmVjb3ZlcnkgaW4gc29t ZSBkZWNsYXJhdGlvbiBsaXN0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0dy YW1tYXIueS5pbiBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NHcmFtbWFyLnkuaW4KaW5kZXggZGY2 YTJjNjQ4NWZmNGFiYWJlOWFlYmQ0YzJmM2ZlZjNiMmI2YjU0ZC4uYTIxMjQ5MjMwZjI1ZjYxNTM3 MGI0YjhkNWFkODBjN2Q1ZmMzNmZkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NT U0dyYW1tYXIueS5pbgorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTR3JhbW1hci55LmluCkBA IC0xNTMyLDE5ICsxNTMyLDExIEBAIGRlY2xhcmF0aW9uX2xpc3Q6CiAgICAgfCBkZWNsX2xpc3Qg ewogICAgICAgICAkJCA9ICQxOwogICAgIH0KLSAgICB8IGVycm9ycyBpbnZhbGlkX2Jsb2NrX2xp c3QgZXJyb3IgeworICAgIHwgZXJyb3JzIGRlY2xfbGlzdF9yZWNvdmVyeSB7CiAgICAgICAgIHBh cnNlci0+c3ludGF4RXJyb3IoJDEsIENTU1BhcnNlcjo6UHJvcGVydHlEZWNsYXJhdGlvbkVycm9y KTsKICAgICAgICAgJCQgPSBmYWxzZTsKICAgICB9Ci0gICAgfCBlcnJvcnMgewotICAgICAgICBw YXJzZXItPnN5bnRheEVycm9yKCQxLCBDU1NQYXJzZXI6OlByb3BlcnR5RGVjbGFyYXRpb25FcnJv cik7Ci0gICAgICAgICQkID0gZmFsc2U7Ci0gICAgfQotICAgIHwgZGVjbF9saXN0IGVycm9ycyB7 Ci0gICAgICAgIHBhcnNlci0+c3ludGF4RXJyb3IoJDIsIENTU1BhcnNlcjo6UHJvcGVydHlEZWNs YXJhdGlvbkVycm9yKTsKLSAgICAgICAgJCQgPSAkMTsKLSAgICB9Ci0gICAgfCBkZWNsX2xpc3Qg ZXJyb3JzIGludmFsaWRfYmxvY2tfbGlzdCBlcnJvciB7CisgICAgfCBkZWNsX2xpc3QgZXJyb3Jz IGRlY2xfbGlzdF9yZWNvdmVyeSB7CiAgICAgICAgIHBhcnNlci0+c3ludGF4RXJyb3IoJDIsIENT U1BhcnNlcjo6UHJvcGVydHlEZWNsYXJhdGlvbkVycm9yKTsKICAgICAgICAgJCQgPSAkMTsKICAg ICB9CkBAIC0xNTYzLDMzICsxNTU1LDI5IEBAIGRlY2xfbGlzdDoKICAgICAgICAgcGFyc2VyLT5z eW50YXhFcnJvcigkMik7CiAgICAgICAgICQkID0gZmFsc2U7CiAgICAgfQotICAgIHwgZXJyb3Jz ICc7JyBtYXliZV9zcGFjZSB7CisgICAgfCBlcnJvcnMgZGVjbF9saXN0X3JlY292ZXJ5ICc7JyBt YXliZV9zcGFjZSB7CiAgICAgICAgIHBhcnNlci0+c3ludGF4RXJyb3IoJDEsIENTU1BhcnNlcjo6 UHJvcGVydHlEZWNsYXJhdGlvbkVycm9yKTsKICAgICAgICAgcGFyc2VyLT5tYXJrUHJvcGVydHlT dGFydCgpOwogICAgICAgICAkJCA9IGZhbHNlOwogICAgIH0KLSAgICB8IGVycm9ycyBpbnZhbGlk X2Jsb2NrX2xpc3QgZXJyb3IgJzsnIG1heWJlX3NwYWNlIHsKLSAgICAgICAgcGFyc2VyLT5zeW50 YXhFcnJvcigkMSwgQ1NTUGFyc2VyOjpQcm9wZXJ0eURlY2xhcmF0aW9uRXJyb3IpOwotICAgICAg ICAkJCA9IGZhbHNlOwotICAgIH0KICAgICB8IGRlY2xfbGlzdCBkZWNsYXJhdGlvbiAnOycgbWF5 YmVfc3BhY2UgewogICAgICAgICBwYXJzZXItPm1hcmtQcm9wZXJ0eVN0YXJ0KCk7CiAgICAgICAg ICQkID0gJDE7CiAgICAgICAgIGlmICgkMikKICAgICAgICAgICAgICQkID0gJDI7CiAgICAgfQot ICAgIHwgZGVjbF9saXN0IGVycm9ycyAnOycgbWF5YmVfc3BhY2UgewotICAgICAgICBwYXJzZXIt PnN5bnRheEVycm9yKCQyLCBDU1NQYXJzZXI6OlByb3BlcnR5RGVjbGFyYXRpb25FcnJvcik7Ci0g ICAgICAgIHBhcnNlci0+bWFya1Byb3BlcnR5U3RhcnQoKTsKLSAgICAgICAgJCQgPSAkMTsKLSAg ICB9Ci0gICAgfCBkZWNsX2xpc3QgZXJyb3JzIGludmFsaWRfYmxvY2tfbGlzdCBlcnJvciAnOycg bWF5YmVfc3BhY2UgeworICAgIHwgZGVjbF9saXN0IGVycm9ycyBkZWNsX2xpc3RfcmVjb3Zlcnkg JzsnIG1heWJlX3NwYWNlIHsKICAgICAgICAgcGFyc2VyLT5zeW50YXhFcnJvcigkMiwgQ1NTUGFy c2VyOjpQcm9wZXJ0eURlY2xhcmF0aW9uRXJyb3IpOwogICAgICAgICBwYXJzZXItPm1hcmtQcm9w ZXJ0eVN0YXJ0KCk7CiAgICAgICAgICQkID0gJDE7CiAgICAgfQogICAgIDsKIAorZGVjbF9saXN0 X3JlY292ZXJ5OgorICAgIGludmFsaWRfYmxvY2tfbGlzdCBlcnJvcgorICAgIHwgLyogZW1wdHkg Ki8KKyAgICA7CisKIGRlY2xhcmF0aW9uOgogICAgIFZBUl9ERUZJTklUSU9OIG1heWJlX3NwYWNl ICc6JyBtYXliZV9zcGFjZSBleHByIHByaW8gewogI2lmIEVOQUJMRV9DU1NfVkFSSUFCTEVTCg==