<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>115140</bug_id>
          
          <creation_ts>2013-04-24 16:25:10 -0700</creation_ts>
          <short_desc>Implementors of CachedResource subclasses should be forced to decide if encoded data can be replaced</short_desc>
          <delta_ts>2013-04-24 17:16:38 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Brady Eidson">beidson</reporter>
          <assigned_to name="Brady Eidson">beidson</assigned_to>
          <cc>bdakin</cc>
    
    <cc>commit-queue</cc>
    
    <cc>gtk-ews</cc>
    
    <cc>japhet</cc>
    
    <cc>webkit-ews</cc>
    
    <cc>xan.lopez</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>880868</commentid>
    <comment_count>0</comment_count>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2013-04-24 16:25:10 -0700</bug_when>
    <thetext>Implementors of CachedResource subclasses should be forced to decide if encoded data can be replaced

Came out of discussion in https://bugs.webkit.org/show_bug.cgi?id=115131</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>880869</commentid>
    <comment_count>1</comment_count>
      <attachid>199534</attachid>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2013-04-24 16:27:55 -0700</bug_when>
    <thetext>Created attachment 199534
Patch v1</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>880873</commentid>
    <comment_count>2</comment_count>
      <attachid>199534</attachid>
    <who name="Early Warning System Bot">webkit-ews</who>
    <bug_when>2013-04-24 16:32:28 -0700</bug_when>
    <thetext>Comment on attachment 199534
Patch v1

Attachment 199534 did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/178193</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>880874</commentid>
    <comment_count>3</comment_count>
      <attachid>199534</attachid>
    <who name="Early Warning System Bot">webkit-ews</who>
    <bug_when>2013-04-24 16:34:09 -0700</bug_when>
    <thetext>Comment on attachment 199534
Patch v1

Attachment 199534 did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/96958</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>880875</commentid>
    <comment_count>4</comment_count>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2013-04-24 16:35:49 -0700</bug_when>
    <thetext>Oh boy, somebody creates CachedResources directly...  that&apos;s bogus.  *sigh*</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>880876</commentid>
    <comment_count>5</comment_count>
      <attachid>199534</attachid>
    <who name="kov&apos;s GTK+ EWS bot">gtk-ews</who>
    <bug_when>2013-04-24 16:36:24 -0700</bug_when>
    <thetext>Comment on attachment 199534
Patch v1

Attachment 199534 did not pass gtk-wk2-ews (gtk-wk2):
Output: http://webkit-queues.appspot.com/results/206125</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>880877</commentid>
    <comment_count>6</comment_count>
      <attachid>199535</attachid>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2013-04-24 16:38:26 -0700</bug_when>
    <thetext>Created attachment 199535
Patch v2</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>880889</commentid>
    <comment_count>7</comment_count>
      <attachid>199535</attachid>
    <who name="Beth Dakin">bdakin</who>
    <bug_when>2013-04-24 17:13:06 -0700</bug_when>
    <thetext>Comment on attachment 199535
Patch v2

This patch looks good, but I am not sure about the name mayTryReplaceEncodedData(). &quot;try replace&quot; just sounds awkward. mayTryToReplaceEncodedData()?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>880890</commentid>
    <comment_count>8</comment_count>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2013-04-24 17:15:00 -0700</bug_when>
    <thetext>(In reply to comment #7)
&gt; (From update of attachment 199535 [details])
&gt; This patch looks good, but I am not sure about the name mayTryReplaceEncodedData(). &quot;try replace&quot; just sounds awkward. mayTryToReplaceEncodedData()?

The wording is symmetrical with the call that this method enables, which is &quot;tryReplaceEncodedData()&quot;

If I recall, there was a small bit of debate on that naming a month ago, but it&apos;s what we stuck with.  =/

Thanks for the review!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>880893</commentid>
    <comment_count>9</comment_count>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2013-04-24 17:16:38 -0700</bug_when>
    <thetext>http://trac.webkit.org/changeset/149079</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>199534</attachid>
            <date>2013-04-24 16:27:55 -0700</date>
            <delta_ts>2013-04-24 16:38:26 -0700</delta_ts>
            <desc>Patch v1</desc>
            <filename>patch</filename>
            <type>text/plain</type>
            <size>6104</size>
            <attacher name="Brady Eidson">beidson</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCBjY2IwYmY0Li5kNDFjZTcwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjcg
QEAKIDIwMTMtMDQtMjQgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCisgICAg
ICAgIEltcGxlbWVudG9ycyBvZiBDYWNoZWRSZXNvdXJjZSBzdWJjbGFzc2VzIHNob3VsZCBiZSBm
b3JjZWQgdG8gZGVjaWRlIGlmIGVuY29kZWQgZGF0YSBjYW4gYmUgcmVwbGFjZWQuCisgICAgICAg
IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTUxNDAKKworICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKE5v
IGJlaGF2aW9yIGNoYW5nZSkuCisKKyAgICAgICAgVGhpcyBtYWtlcyBtYXlUcnlSZXBsYWNlRW5j
b2RlZERhdGEoKSBwdXJlIHZpcnR1YWwgaW4gQ2FjaGVkUmVzb3VyY2UsIGFuZCBnaXZlcyBpdCBk
ZWZhdWx0IGJlaGF2aW9yCisgICAgICAgIGluIGFsbCBDYWNoZWRSZXNvdXJjZSBzdWJjbGFzc2Vz
IGJlc2lkZXMgQ2FjaGVkRm9udCAod2hpY2ggYWxyZWFkeSBoYXMgYW4gaW1wbGVtZW50YXRpb24p
LgorCisgICAgICAgICogbG9hZGVyL2NhY2hlL0NhY2hlZENTU1N0eWxlU2hlZXQuaDoKKyAgICAg
ICAgKiBsb2FkZXIvY2FjaGUvQ2FjaGVkSW1hZ2UuaDoKKyAgICAgICAgKiBsb2FkZXIvY2FjaGUv
Q2FjaGVkUmF3UmVzb3VyY2UuaDoKKyAgICAgICAgKiBsb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3Vy
Y2UuaDoKKyAgICAgICAgKiBsb2FkZXIvY2FjaGUvQ2FjaGVkU1ZHRG9jdW1lbnQuaDoKKyAgICAg
ICAgKiBsb2FkZXIvY2FjaGUvQ2FjaGVkU2NyaXB0Lmg6CisgICAgICAgICogbG9hZGVyL2NhY2hl
L0NhY2hlZFNoYWRlci5oOgorICAgICAgICAqIGxvYWRlci9jYWNoZS9DYWNoZWRUZXh0VHJhY2su
aDoKKyAgICAgICAgKiBsb2FkZXIvY2FjaGUvQ2FjaGVkWFNMU3R5bGVTaGVldC5oOgorCisyMDEz
LTA0LTI0ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKwogICAgICAgICBPbmNl
IGEgY3VzdG9tIGZvbnQgaXMgY2FjaGVkIHRvIGRpc2ssIGl0IHN0YXJ0cyBmYWlsaW5nIHRvIHJl
bmRlciB1bnRpbCB0aGUgcGFnZSBpcyByZWZyZXNoZWQuCiAgICAgICAgIDxyZGFyOi8vcHJvYmxl
bS8xMzYyMjk5OD4gYW5kIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x
MTUxMzEKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZENT
U1N0eWxlU2hlZXQuaCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRDU1NTdHls
ZVNoZWV0LmgKaW5kZXggYWMyYjc2NC4uZTRiYjk3ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv
cmUvbG9hZGVyL2NhY2hlL0NhY2hlZENTU1N0eWxlU2hlZXQuaAorKysgYi9Tb3VyY2UvV2ViQ29y
ZS9sb2FkZXIvY2FjaGUvQ2FjaGVkQ1NTU3R5bGVTaGVldC5oCkBAIC01Niw2ICs1Niw3IEBAIG5h
bWVzcGFjZSBXZWJDb3JlIHsKICAgICBwcml2YXRlOgogICAgICAgICBib29sIGNhblVzZVNoZWV0
KGJvb2wgZW5mb3JjZU1JTUVUeXBlLCBib29sKiBoYXNWYWxpZE1JTUVUeXBlKSBjb25zdDsKICAg
ICAgICAgdmlydHVhbCBQdXJnZVByaW9yaXR5IHB1cmdlUHJpb3JpdHkoKSBjb25zdCB7IHJldHVy
biBQdXJnZUxhc3Q7IH0KKyAgICAgICAgdmlydHVhbCBib29sIG1heVRyeVJlcGxhY2VFbmNvZGVk
RGF0YSgpIGNvbnN0IE9WRVJSSURFIHsgcmV0dXJuIHRydWU7IH0KIAogICAgIHByb3RlY3RlZDoK
ICAgICAgICAgdmlydHVhbCB2b2lkIGNoZWNrTm90aWZ5KCk7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv
V2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkSW1hZ2UuaCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRl
ci9jYWNoZS9DYWNoZWRJbWFnZS5oCmluZGV4IGFmYWFkNGMuLjAwZjkwNjcgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRJbWFnZS5oCisrKyBiL1NvdXJjZS9X
ZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRJbWFnZS5oCkBAIC0xMDgsNiArMTA4LDcgQEAgcHJp
dmF0ZToKICAgICB2b2lkIGNoZWNrU2hvdWxkUGFpbnRCcm9rZW5JbWFnZSgpOwogCiAgICAgdmly
dHVhbCB2b2lkIHN3aXRjaENsaWVudHNUb1JldmFsaWRhdGVkUmVzb3VyY2UoKSBPVkVSUklERTsK
KyAgICB2aXJ0dWFsIGJvb2wgbWF5VHJ5UmVwbGFjZUVuY29kZWREYXRhKCkgY29uc3QgT1ZFUlJJ
REUgeyByZXR1cm4gdHJ1ZTsgfQogCiAgICAgdHlwZWRlZiBwYWlyPEludFNpemUsIGZsb2F0PiBT
aXplQW5kWm9vbTsKICAgICB0eXBlZGVmIEhhc2hNYXA8Y29uc3QgQ2FjaGVkSW1hZ2VDbGllbnQq
LCBTaXplQW5kWm9vbT4gQ29udGFpbmVyU2l6ZVJlcXVlc3RzOwpkaWZmIC0tZ2l0IGEvU291cmNl
L1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJhd1Jlc291cmNlLmggYi9Tb3VyY2UvV2ViQ29y
ZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmF3UmVzb3VyY2UuaAppbmRleCAxNjA0NmU3Li5hZTA1MzRm
IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmF3UmVzb3Vy
Y2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmF3UmVzb3VyY2Uu
aApAQCAtNjEsNiArNjEsNyBAQCBwcml2YXRlOgogICAgIHZpcnR1YWwgdm9pZCBkaWRTZW5kRGF0
YSh1bnNpZ25lZCBsb25nIGxvbmcgYnl0ZXNTZW50LCB1bnNpZ25lZCBsb25nIGxvbmcgdG90YWxC
eXRlc1RvQmVTZW50KTsKIAogICAgIHZpcnR1YWwgdm9pZCBzd2l0Y2hDbGllbnRzVG9SZXZhbGlk
YXRlZFJlc291cmNlKCkgT1ZFUlJJREU7CisgICAgdmlydHVhbCBib29sIG1heVRyeVJlcGxhY2VF
bmNvZGVkRGF0YSgpIGNvbnN0IE9WRVJSSURFIHsgcmV0dXJuIHRydWU7IH0KIAogICAgIHVuc2ln
bmVkIGxvbmcgbV9pZGVudGlmaWVyOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2Fk
ZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2UuaCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9D
YWNoZWRSZXNvdXJjZS5oCmluZGV4IDUwY2QyZjAuLjg2NmQ1ZDggMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZS5oCisrKyBiL1NvdXJjZS9XZWJD
b3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZS5oCkBAIC0yOTYsNyArMjk2LDcgQEAgcHJp
dmF0ZToKICAgICB2b2lkIGRlY29kZWREYXRhRGVsZXRpb25UaW1lckZpcmVkKFRpbWVyPENhY2hl
ZFJlc291cmNlPiopOwogCiAgICAgdmlydHVhbCBQdXJnZVByaW9yaXR5IHB1cmdlUHJpb3JpdHko
KSBjb25zdCB7IHJldHVybiBQdXJnZURlZmF1bHQ7IH0KLSAgICB2aXJ0dWFsIGJvb2wgbWF5VHJ5
UmVwbGFjZUVuY29kZWREYXRhKCkgY29uc3QgeyByZXR1cm4gdHJ1ZTsgfQorICAgIHZpcnR1YWwg
Ym9vbCBtYXlUcnlSZXBsYWNlRW5jb2RlZERhdGEoKSBjb25zdCA9IDA7CiAKICAgICBkb3VibGUg
Y3VycmVudEFnZSgpIGNvbnN0OwogICAgIGRvdWJsZSBmcmVzaG5lc3NMaWZldGltZSgpIGNvbnN0
OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFNWR0RvY3Vt
ZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkU1ZHRG9jdW1lbnQuaApp
bmRleCAyNjUxN2FlLi45OWZiOGNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIv
Y2FjaGUvQ2FjaGVkU1ZHRG9jdW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2Fj
aGUvQ2FjaGVkU1ZHRG9jdW1lbnQuaApAQCAtNDUsNiArNDUsOSBAQCBwdWJsaWM6CiBwcm90ZWN0
ZWQ6CiAgICAgUmVmUHRyPFNWR0RvY3VtZW50PiBtX2RvY3VtZW50OwogICAgIFJlZlB0cjxUZXh0
UmVzb3VyY2VEZWNvZGVyPiBtX2RlY29kZXI7CisKK3ByaXZhdGU6CisgICAgdmlydHVhbCBib29s
IG1heVRyeVJlcGxhY2VFbmNvZGVkRGF0YSgpIGNvbnN0IE9WRVJSSURFIHsgcmV0dXJuIHRydWU7
IH0KIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD
b3JlL2xvYWRlci9jYWNoZS9DYWNoZWRTY3JpcHQuaCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9j
YWNoZS9DYWNoZWRTY3JpcHQuaAppbmRleCA0MjljNDM1Li41YTIzODE2IDEwMDY0NAotLS0gYS9T
b3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkU2NyaXB0LmgKKysrIGIvU291cmNlL1dl
YkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFNjcmlwdC5oCkBAIC01Miw2ICs1Miw3IEBAIG5hbWVz
cGFjZSBXZWJDb3JlIHsKIAogICAgIHByaXZhdGU6CiAgICAgICAgIHZpcnR1YWwgUHVyZ2VQcmlv
cml0eSBwdXJnZVByaW9yaXR5KCkgY29uc3QgeyByZXR1cm4gUHVyZ2VMYXN0OyB9CisgICAgICAg
IHZpcnR1YWwgYm9vbCBtYXlUcnlSZXBsYWNlRW5jb2RlZERhdGEoKSBjb25zdCBPVkVSUklERSB7
IHJldHVybiB0cnVlOyB9CiAKICAgICAgICAgU3RyaW5nIG1fc2NyaXB0OwogICAgICAgICBSZWZQ
dHI8VGV4dFJlc291cmNlRGVjb2Rlcj4gbV9kZWNvZGVyOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl
YkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFNoYWRlci5oIGIvU291cmNlL1dlYkNvcmUvbG9hZGVy
L2NhY2hlL0NhY2hlZFNoYWRlci5oCmluZGV4IGQ1NzczNTcuLjExYjkxODAgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRTaGFkZXIuaAorKysgYi9Tb3VyY2Uv
V2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkU2hhZGVyLmgKQEAgLTQ3LDYgKzQ3LDggQEAgcHVi
bGljOgogICAgIHZvaWQgZGF0YShQYXNzUmVmUHRyPFJlc291cmNlQnVmZmVyPiwgYm9vbCBhbGxE
YXRhUmVjZWl2ZWQpOwogCiBwcml2YXRlOgorICAgIHZpcnR1YWwgYm9vbCBtYXlUcnlSZXBsYWNl
RW5jb2RlZERhdGEoKSBjb25zdCBPVkVSUklERSB7IHJldHVybiB0cnVlOyB9CisKICAgICBSZWZQ
dHI8VGV4dFJlc291cmNlRGVjb2Rlcj4gbV9kZWNvZGVyOwogICAgIFN0cmluZyBtX3NoYWRlclN0
cmluZzsKIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVk
VGV4dFRyYWNrLmggYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkVGV4dFRyYWNr
LmgKaW5kZXggMmJjNjBkMC4uNzhjNmM5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9h
ZGVyL2NhY2hlL0NhY2hlZFRleHRUcmFjay5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9j
YWNoZS9DYWNoZWRUZXh0VHJhY2suaApAQCAtMzksNiArMzksOSBAQCBwdWJsaWM6CiAgICAgdmly
dHVhbCB+Q2FjaGVkVGV4dFRyYWNrKCk7CiAKICAgICB2aXJ0dWFsIHZvaWQgZGF0YShQYXNzUmVm
UHRyPFJlc291cmNlQnVmZmVyPiBkYXRhLCBib29sIGFsbERhdGFSZWNlaXZlZCk7CisKK3ByaXZh
dGU6CisgICAgdmlydHVhbCBib29sIG1heVRyeVJlcGxhY2VFbmNvZGVkRGF0YSgpIGNvbnN0IE9W
RVJSSURFIHsgcmV0dXJuIHRydWU7IH0KIH07CiAKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD
b3JlL2xvYWRlci9jYWNoZS9DYWNoZWRYU0xTdHlsZVNoZWV0LmggYi9Tb3VyY2UvV2ViQ29yZS9s
b2FkZXIvY2FjaGUvQ2FjaGVkWFNMU3R5bGVTaGVldC5oCmluZGV4IDdiZjdkMDguLmRmNmQ5MGYg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRYU0xTdHlsZVNo
ZWV0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFhTTFN0eWxlU2hl
ZXQuaApAQCAtNTIsNiArNTIsOSBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAgICAgICAgU3Ry
aW5nIG1fc2hlZXQ7CiAgICAgICAgIFJlZlB0cjxUZXh0UmVzb3VyY2VEZWNvZGVyPiBtX2RlY29k
ZXI7CisKKyAgICBwcml2YXRlOgorICAgICAgICB2aXJ0dWFsIGJvb2wgbWF5VHJ5UmVwbGFjZUVu
Y29kZWREYXRhKCkgY29uc3QgT1ZFUlJJREUgeyByZXR1cm4gdHJ1ZTsgfQogICAgIH07CiAKICNl
bmRpZgo=
</data>
<flag name="commit-queue"
          id="221058"
          type_id="3"
          status="-"
          setter="webkit-ews"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>199535</attachid>
            <date>2013-04-24 16:38:26 -0700</date>
            <delta_ts>2013-04-24 17:13:06 -0700</delta_ts>
            <desc>Patch v2</desc>
            <filename>patch</filename>
            <type>text/plain</type>
            <size>6109</size>
            <attacher name="Brady Eidson">beidson</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCBjY2IwYmY0Li43ZjU5ZmVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjcg
QEAKIDIwMTMtMDQtMjQgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCisgICAg
ICAgIEltcGxlbWVudG9ycyBvZiBDYWNoZWRSZXNvdXJjZSBzdWJjbGFzc2VzIHNob3VsZCBiZSBm
b3JjZWQgdG8gZGVjaWRlIGlmIGVuY29kZWQgZGF0YSBjYW4gYmUgcmVwbGFjZWQuCisgICAgICAg
IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTUxNDAKKworICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKE5v
IGJlaGF2aW9yIGNoYW5nZSkuCisKKyAgICAgICAgVGhpcyBtYWtlcyBtYXlUcnlSZXBsYWNlRW5j
b2RlZERhdGEoKSByZXR1cm4gZmFsc2UgaW4gQ2FjaGVkUmVzb3VyY2UsIGJ1dCBvdmVycmlkZXMg
dG8gdHJ1ZQorICAgICAgICBpbiBhbGwgQ2FjaGVkUmVzb3VyY2Ugc3ViY2xhc3NlcyBiZXNpZGVz
IENhY2hlZEZvbnQgKHdoaWNoIGFscmVhZHkgaGFzIGFuIGltcGxlbWVudGF0aW9uKS4KKworICAg
ICAgICAqIGxvYWRlci9jYWNoZS9DYWNoZWRDU1NTdHlsZVNoZWV0Lmg6CisgICAgICAgICogbG9h
ZGVyL2NhY2hlL0NhY2hlZEltYWdlLmg6CisgICAgICAgICogbG9hZGVyL2NhY2hlL0NhY2hlZFJh
d1Jlc291cmNlLmg6CisgICAgICAgICogbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmg6Cisg
ICAgICAgICogbG9hZGVyL2NhY2hlL0NhY2hlZFNWR0RvY3VtZW50Lmg6CisgICAgICAgICogbG9h
ZGVyL2NhY2hlL0NhY2hlZFNjcmlwdC5oOgorICAgICAgICAqIGxvYWRlci9jYWNoZS9DYWNoZWRT
aGFkZXIuaDoKKyAgICAgICAgKiBsb2FkZXIvY2FjaGUvQ2FjaGVkVGV4dFRyYWNrLmg6CisgICAg
ICAgICogbG9hZGVyL2NhY2hlL0NhY2hlZFhTTFN0eWxlU2hlZXQuaDoKKworMjAxMy0wNC0yNCAg
QnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CisKICAgICAgICAgT25jZSBhIGN1c3Rv
bSBmb250IGlzIGNhY2hlZCB0byBkaXNrLCBpdCBzdGFydHMgZmFpbGluZyB0byByZW5kZXIgdW50
aWwgdGhlIHBhZ2UgaXMgcmVmcmVzaGVkLgogICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTM2MjI5
OTg+IGFuZCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1MTMxCiAK
ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRDU1NTdHlsZVNo
ZWV0LmggYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkQ1NTU3R5bGVTaGVldC5o
CmluZGV4IGFjMmI3NjQuLmU0YmI5N2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRl
ci9jYWNoZS9DYWNoZWRDU1NTdHlsZVNoZWV0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVy
L2NhY2hlL0NhY2hlZENTU1N0eWxlU2hlZXQuaApAQCAtNTYsNiArNTYsNyBAQCBuYW1lc3BhY2Ug
V2ViQ29yZSB7CiAgICAgcHJpdmF0ZToKICAgICAgICAgYm9vbCBjYW5Vc2VTaGVldChib29sIGVu
Zm9yY2VNSU1FVHlwZSwgYm9vbCogaGFzVmFsaWRNSU1FVHlwZSkgY29uc3Q7CiAgICAgICAgIHZp
cnR1YWwgUHVyZ2VQcmlvcml0eSBwdXJnZVByaW9yaXR5KCkgY29uc3QgeyByZXR1cm4gUHVyZ2VM
YXN0OyB9CisgICAgICAgIHZpcnR1YWwgYm9vbCBtYXlUcnlSZXBsYWNlRW5jb2RlZERhdGEoKSBj
b25zdCBPVkVSUklERSB7IHJldHVybiB0cnVlOyB9CiAKICAgICBwcm90ZWN0ZWQ6CiAgICAgICAg
IHZpcnR1YWwgdm9pZCBjaGVja05vdGlmeSgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv
bG9hZGVyL2NhY2hlL0NhY2hlZEltYWdlLmggYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUv
Q2FjaGVkSW1hZ2UuaAppbmRleCBhZmFhZDRjLi4wMGY5MDY3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv
V2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkSW1hZ2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9s
b2FkZXIvY2FjaGUvQ2FjaGVkSW1hZ2UuaApAQCAtMTA4LDYgKzEwOCw3IEBAIHByaXZhdGU6CiAg
ICAgdm9pZCBjaGVja1Nob3VsZFBhaW50QnJva2VuSW1hZ2UoKTsKIAogICAgIHZpcnR1YWwgdm9p
ZCBzd2l0Y2hDbGllbnRzVG9SZXZhbGlkYXRlZFJlc291cmNlKCkgT1ZFUlJJREU7CisgICAgdmly
dHVhbCBib29sIG1heVRyeVJlcGxhY2VFbmNvZGVkRGF0YSgpIGNvbnN0IE9WRVJSSURFIHsgcmV0
dXJuIHRydWU7IH0KIAogICAgIHR5cGVkZWYgcGFpcjxJbnRTaXplLCBmbG9hdD4gU2l6ZUFuZFpv
b207CiAgICAgdHlwZWRlZiBIYXNoTWFwPGNvbnN0IENhY2hlZEltYWdlQ2xpZW50KiwgU2l6ZUFu
ZFpvb20+IENvbnRhaW5lclNpemVSZXF1ZXN0czsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl
L2xvYWRlci9jYWNoZS9DYWNoZWRSYXdSZXNvdXJjZS5oIGIvU291cmNlL1dlYkNvcmUvbG9hZGVy
L2NhY2hlL0NhY2hlZFJhd1Jlc291cmNlLmgKaW5kZXggMTYwNDZlNy4uYWUwNTM0ZiAxMDA2NDQK
LS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJhd1Jlc291cmNlLmgKKysr
IGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJhd1Jlc291cmNlLmgKQEAgLTYx
LDYgKzYxLDcgQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIHZvaWQgZGlkU2VuZERhdGEodW5zaWdu
ZWQgbG9uZyBsb25nIGJ5dGVzU2VudCwgdW5zaWduZWQgbG9uZyBsb25nIHRvdGFsQnl0ZXNUb0Jl
U2VudCk7CiAKICAgICB2aXJ0dWFsIHZvaWQgc3dpdGNoQ2xpZW50c1RvUmV2YWxpZGF0ZWRSZXNv
dXJjZSgpIE9WRVJSSURFOworICAgIHZpcnR1YWwgYm9vbCBtYXlUcnlSZXBsYWNlRW5jb2RlZERh
dGEoKSBjb25zdCBPVkVSUklERSB7IHJldHVybiB0cnVlOyB9CiAKICAgICB1bnNpZ25lZCBsb25n
IG1faWRlbnRpZmllcjsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hl
L0NhY2hlZFJlc291cmNlLmggYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVz
b3VyY2UuaAppbmRleCA1MGNkMmYwLi43NjhhYWM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2Fk
ZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2UuaApAQCAtMjk2LDcgKzI5Niw3IEBAIHByaXZhdGU6CiAg
ICAgdm9pZCBkZWNvZGVkRGF0YURlbGV0aW9uVGltZXJGaXJlZChUaW1lcjxDYWNoZWRSZXNvdXJj
ZT4qKTsKIAogICAgIHZpcnR1YWwgUHVyZ2VQcmlvcml0eSBwdXJnZVByaW9yaXR5KCkgY29uc3Qg
eyByZXR1cm4gUHVyZ2VEZWZhdWx0OyB9Ci0gICAgdmlydHVhbCBib29sIG1heVRyeVJlcGxhY2VF
bmNvZGVkRGF0YSgpIGNvbnN0IHsgcmV0dXJuIHRydWU7IH0KKyAgICB2aXJ0dWFsIGJvb2wgbWF5
VHJ5UmVwbGFjZUVuY29kZWREYXRhKCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KIAogICAgIGRv
dWJsZSBjdXJyZW50QWdlKCkgY29uc3Q7CiAgICAgZG91YmxlIGZyZXNobmVzc0xpZmV0aW1lKCkg
Y29uc3Q7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkU1ZH
RG9jdW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRTVkdEb2N1bWVu
dC5oCmluZGV4IDI2NTE3YWUuLjk5ZmI4Y2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xv
YWRlci9jYWNoZS9DYWNoZWRTVkdEb2N1bWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRl
ci9jYWNoZS9DYWNoZWRTVkdEb2N1bWVudC5oCkBAIC00NSw2ICs0NSw5IEBAIHB1YmxpYzoKIHBy
b3RlY3RlZDoKICAgICBSZWZQdHI8U1ZHRG9jdW1lbnQ+IG1fZG9jdW1lbnQ7CiAgICAgUmVmUHRy
PFRleHRSZXNvdXJjZURlY29kZXI+IG1fZGVjb2RlcjsKKworcHJpdmF0ZToKKyAgICB2aXJ0dWFs
IGJvb2wgbWF5VHJ5UmVwbGFjZUVuY29kZWREYXRhKCkgY29uc3QgT1ZFUlJJREUgeyByZXR1cm4g
dHJ1ZTsgfQogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNl
L1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFNjcmlwdC5oIGIvU291cmNlL1dlYkNvcmUvbG9h
ZGVyL2NhY2hlL0NhY2hlZFNjcmlwdC5oCmluZGV4IDQyOWM0MzUuLjVhMjM4MTYgMTAwNjQ0Ci0t
LSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRTY3JpcHQuaAorKysgYi9Tb3Vy
Y2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkU2NyaXB0LmgKQEAgLTUyLDYgKzUyLDcgQEAg
bmFtZXNwYWNlIFdlYkNvcmUgewogCiAgICAgcHJpdmF0ZToKICAgICAgICAgdmlydHVhbCBQdXJn
ZVByaW9yaXR5IHB1cmdlUHJpb3JpdHkoKSBjb25zdCB7IHJldHVybiBQdXJnZUxhc3Q7IH0KKyAg
ICAgICAgdmlydHVhbCBib29sIG1heVRyeVJlcGxhY2VFbmNvZGVkRGF0YSgpIGNvbnN0IE9WRVJS
SURFIHsgcmV0dXJuIHRydWU7IH0KIAogICAgICAgICBTdHJpbmcgbV9zY3JpcHQ7CiAgICAgICAg
IFJlZlB0cjxUZXh0UmVzb3VyY2VEZWNvZGVyPiBtX2RlY29kZXI7CmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkU2hhZGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9s
b2FkZXIvY2FjaGUvQ2FjaGVkU2hhZGVyLmgKaW5kZXggZDU3NzM1Ny4uMTFiOTE4MCAxMDA2NDQK
LS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFNoYWRlci5oCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRTaGFkZXIuaApAQCAtNDcsNiArNDcsOCBA
QCBwdWJsaWM6CiAgICAgdm9pZCBkYXRhKFBhc3NSZWZQdHI8UmVzb3VyY2VCdWZmZXI+LCBib29s
IGFsbERhdGFSZWNlaXZlZCk7CiAKIHByaXZhdGU6CisgICAgdmlydHVhbCBib29sIG1heVRyeVJl
cGxhY2VFbmNvZGVkRGF0YSgpIGNvbnN0IE9WRVJSSURFIHsgcmV0dXJuIHRydWU7IH0KKwogICAg
IFJlZlB0cjxUZXh0UmVzb3VyY2VEZWNvZGVyPiBtX2RlY29kZXI7CiAgICAgU3RyaW5nIG1fc2hh
ZGVyU3RyaW5nOwogfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9D
YWNoZWRUZXh0VHJhY2suaCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRUZXh0
VHJhY2suaAppbmRleCAyYmM2MGQwLi43OGM2YzkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9sb2FkZXIvY2FjaGUvQ2FjaGVkVGV4dFRyYWNrLmgKKysrIGIvU291cmNlL1dlYkNvcmUvbG9h
ZGVyL2NhY2hlL0NhY2hlZFRleHRUcmFjay5oCkBAIC0zOSw2ICszOSw5IEBAIHB1YmxpYzoKICAg
ICB2aXJ0dWFsIH5DYWNoZWRUZXh0VHJhY2soKTsKIAogICAgIHZpcnR1YWwgdm9pZCBkYXRhKFBh
c3NSZWZQdHI8UmVzb3VyY2VCdWZmZXI+IGRhdGEsIGJvb2wgYWxsRGF0YVJlY2VpdmVkKTsKKwor
cHJpdmF0ZToKKyAgICB2aXJ0dWFsIGJvb2wgbWF5VHJ5UmVwbGFjZUVuY29kZWREYXRhKCkgY29u
c3QgT1ZFUlJJREUgeyByZXR1cm4gdHJ1ZTsgfQogfTsKIAogfQpkaWZmIC0tZ2l0IGEvU291cmNl
L1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFhTTFN0eWxlU2hlZXQuaCBiL1NvdXJjZS9XZWJD
b3JlL2xvYWRlci9jYWNoZS9DYWNoZWRYU0xTdHlsZVNoZWV0LmgKaW5kZXggN2JmN2QwOC4uZGY2
ZDkwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFhTTFN0
eWxlU2hlZXQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkWFNMU3R5
bGVTaGVldC5oCkBAIC01Miw2ICs1Miw5IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogICAgICAg
ICBTdHJpbmcgbV9zaGVldDsKICAgICAgICAgUmVmUHRyPFRleHRSZXNvdXJjZURlY29kZXI+IG1f
ZGVjb2RlcjsKKworICAgIHByaXZhdGU6CisgICAgICAgIHZpcnR1YWwgYm9vbCBtYXlUcnlSZXBs
YWNlRW5jb2RlZERhdGEoKSBjb25zdCBPVkVSUklERSB7IHJldHVybiB0cnVlOyB9CiAgICAgfTsK
IAogI2VuZGlmCg==
</data>
<flag name="review"
          id="221059"
          type_id="1"
          status="+"
          setter="bdakin"
    />
          </attachment>
      

    </bug>

</bugzilla>