<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>115121</bug_id>
          
          <creation_ts>2013-04-24 12:12:06 -0700</creation_ts>
          <short_desc>Clean up unused code in ViewportArguments.h</short_desc>
          <delta_ts>2013-04-24 13:11:12 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jacky Jiang">jkjiang</reporter>
          <assigned_to name="Jacky Jiang">jkjiang</assigned_to>
          <cc>benjamin</cc>
    
    <cc>cgarcia</cc>
    
    <cc>commit-queue</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>kenneth</cc>
    
    <cc>rwlbuis</cc>
    
    <cc>staikos</cc>
    
    <cc>yong.li.webkit</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>880738</commentid>
    <comment_count>0</comment_count>
    <who name="Jacky Jiang">jkjiang</who>
    <bug_when>2013-04-24 12:12:06 -0700</bug_when>
    <thetext>Target-densityDPi viewport property emulation implementation for android has been removed by bug114136; however, there are still some remaining unused code in ViewportArguments.h below which should be cleaned up as well:
ValueDeviceDPI = -6,
ValueLowDPI = -7,
ValueMediumDPI = -8,
ValueHighDPI = -9</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>880757</commentid>
    <comment_count>1</comment_count>
      <attachid>199510</attachid>
    <who name="Jacky Jiang">jkjiang</who>
    <bug_when>2013-04-24 12:43:47 -0700</bug_when>
    <thetext>Created attachment 199510
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>880770</commentid>
    <comment_count>2</comment_count>
    <who name="Jacky Jiang">jkjiang</who>
    <bug_when>2013-04-24 13:11:12 -0700</bug_when>
    <thetext>Committed r149062: &lt;http://trac.webkit.org/changeset/149062&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>199510</attachid>
            <date>2013-04-24 12:43:47 -0700</date>
            <delta_ts>2013-04-24 12:50:29 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-115121-20130424154310.patch</filename>
            <type>text/plain</type>
            <size>1418</size>
            <attacher name="Jacky Jiang">jkjiang</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5MDUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTk4NTk5ODg2NmY1OWM4
ZjJlM2ViNWE2M2Y5MDUzNmUzZGRlYjg1OC4uODEwMzQyODcyNTE2MzU4MjA2ODQ4ZWVhOWE1NGU4
M2IzZDdkMDkzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA0LTI0ICBKYWNr
eSBKaWFuZyAgPHpoYWppYW5nQGJsYWNrYmVycnkuY29tPgorCisgICAgICAgIENsZWFuIHVwIHVu
dXNlZCBjb2RlIGluIFZpZXdwb3J0QXJndW1lbnRzLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNTEyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSB0YXJnZXQtZGVuc2l0eURQSSBlbXVsYXRpb24g
aW1wbGVtZW50YXRpb24gaGFzIGJlZW4gcmVtb3ZlZCBieQorICAgICAgICByMTQ3ODkzLCBzbyBj
bGVhbiB1cCB0aGUgcmVtYWluaW5nIGNvZGUgYXMgd2VsbC4KKworICAgICAgICAqIGRvbS9WaWV3
cG9ydEFyZ3VtZW50cy5oOgorCiAyMDEzLTA0LTI0ICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFj
aEBhcHBsZS5jb20+CiAKICAgICAgICAgQVg6IFdBSS1BUklBIGxhbmRtYXJrcyBubyBsb25nZXIg
c3BlYWsgdHlwZSBvZiBsYW5kbWFyayBvbiBpT1MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl
L2RvbS9WaWV3cG9ydEFyZ3VtZW50cy5oIGIvU291cmNlL1dlYkNvcmUvZG9tL1ZpZXdwb3J0QXJn
dW1lbnRzLmgKaW5kZXggNTI1ZjM3YTY0ZGJhOGE1YmM5Yjg3YmEzYmU4ZDNkMWVhZjQ2NmI2Ny4u
NWFhMzMyYjBhYmFmZjgxNTViOWYyOGI2MzVkNzgwOWU2YjBhNjYzYSAxMDA2NDQKLS0tIGEvU291
cmNlL1dlYkNvcmUvZG9tL1ZpZXdwb3J0QXJndW1lbnRzLmgKKysrIGIvU291cmNlL1dlYkNvcmUv
ZG9tL1ZpZXdwb3J0QXJndW1lbnRzLmgKQEAgLTcyLDExICs3Miw3IEBAIHN0cnVjdCBWaWV3cG9y
dEFyZ3VtZW50cyB7CiAgICAgICAgIFZhbHVlRGV2aWNlV2lkdGggPSAtMiwKICAgICAgICAgVmFs
dWVEZXZpY2VIZWlnaHQgPSAtMywKICAgICAgICAgVmFsdWVQb3J0cmFpdCA9IC00LAotICAgICAg
ICBWYWx1ZUxhbmRzY2FwZSA9IC01LAotICAgICAgICBWYWx1ZURldmljZURQSSA9IC02LAotICAg
ICAgICBWYWx1ZUxvd0RQSSA9IC03LAotICAgICAgICBWYWx1ZU1lZGl1bURQSSA9IC04LAotICAg
ICAgICBWYWx1ZUhpZ2hEUEkgPSAtOQorICAgICAgICBWYWx1ZUxhbmRzY2FwZSA9IC01CiAgICAg
fTsKIAogICAgIFZpZXdwb3J0QXJndW1lbnRzKFR5cGUgdHlwZSA9IEltcGxpY2l0KQo=
</data>
<flag name="review"
          id="221027"
          type_id="1"
          status="+"
          setter="benjamin"
    />
          </attachment>
      

    </bug>

</bugzilla>