<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>115118</bug_id>
          
          <creation_ts>2013-04-24 10:36:23 -0700</creation_ts>
          <short_desc>[GTK] Use stamp files for generate-forwarding-headers makefile rules</short_desc>
          <delta_ts>2013-04-24 11:33:17 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Carlos Garcia Campos">cgarcia</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>xan.lopez</cc>
    
    <cc>zan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>880695</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2013-04-24 10:36:23 -0700</bug_when>
    <thetext>We are currently running the generate-forwarding-headers.pl script 6 times everytime we run make even if nothing has changed. This is because the makefile rules that call the script don&apos;t create a file that can be checked to decide whether to run the rule or not.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>880702</commentid>
    <comment_count>1</comment_count>
      <attachid>199499</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2013-04-24 10:43:15 -0700</bug_when>
    <thetext>Created attachment 199499
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>880715</commentid>
    <comment_count>2</comment_count>
      <attachid>199499</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2013-04-24 11:12:38 -0700</bug_when>
    <thetext>Comment on attachment 199499
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199499&amp;action=review

Looks good. I just have one question...

&gt; Source/WebKit2/GNUmakefile.am:326
&gt;  BUILT_SOURCES += generate-webkit2-forwarding-headers

Would it make more sense to add the stamp files to BUILT_SOURCES now?

&gt; Tools/TestWebKitAPI/GNUmakefile.am:229
&gt; +wk2_tests_sources = $(Programs_TestWebKitAPI_TestWebKit2_SOURCES) $(Libraries_libTestWebKitAPIInjectedBundle_la_SOURCES)

I don&apos;t think there&apos;s any need for this intermediate variable, unless it&apos;s used somewhere else.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>880721</commentid>
    <comment_count>3</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2013-04-24 11:18:52 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; (From update of attachment 199499 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=199499&amp;action=review
&gt; 
&gt; Looks good. I just have one question...
&gt; 
&gt; &gt; Source/WebKit2/GNUmakefile.am:326
&gt; &gt;  BUILT_SOURCES += generate-webkit2-forwarding-headers
&gt; 
&gt; Would it make more sense to add the stamp files to BUILT_SOURCES now?

hmm, I think you are right, and we don&apos;t need to add them to cleanfiles either since all built source are already in cleanfiles. Let me try.

&gt; &gt; Tools/TestWebKitAPI/GNUmakefile.am:229
&gt; &gt; +wk2_tests_sources = $(Programs_TestWebKitAPI_TestWebKit2_SOURCES) $(Libraries_libTestWebKitAPIInjectedBundle_la_SOURCES)
&gt; 
&gt; I don&apos;t think there&apos;s any need for this intermediate variable, unless it&apos;s used somewhere else.

It makes the rule easier to read, that&apos;s all.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>880723</commentid>
    <comment_count>4</comment_count>
      <attachid>199505</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2013-04-24 11:26:29 -0700</bug_when>
    <thetext>Created attachment 199505
Updated patch

Removed intermediate rules</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>880725</commentid>
    <comment_count>5</comment_count>
      <attachid>199505</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2013-04-24 11:27:26 -0700</bug_when>
    <thetext>Comment on attachment 199505
Updated patch

Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>880730</commentid>
    <comment_count>6</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2013-04-24 11:33:17 -0700</bug_when>
    <thetext>Committed r149052: &lt;http://trac.webkit.org/changeset/149052&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>199499</attachid>
            <date>2013-04-24 10:43:15 -0700</date>
            <delta_ts>2013-04-24 11:26:29 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>wk2-forwarding-headers.diff</filename>
            <type>text/plain</type>
            <size>5495</size>
            <attacher name="Carlos Garcia Campos">cgarcia</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No
YW5nZUxvZwppbmRleCA3YTc5M2ZhLi45YzE2MjQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcg
QEAKIDIwMTMtMDQtMjQgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t
PgogCisgICAgICAgIFtHVEtdIFVzZSBzdGFtcCBmaWxlcyBmb3IgZ2VuZXJhdGUtZm9yd2FyZGlu
Zy1oZWFkZXJzIG1ha2VmaWxlIHJ1bGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD0xMTUxMTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICBVc2UgYSBzdGFtcCBmaWxlIGZvciB0aGUgV2ViS2l0MiBmb3J3YXJk
aW5nIGdlbmVyYXRvciBydWxlLiBBbHNvCisgICAgICAgIGZpeCB0aGUgcnVsZSBkZXBlbmRlbmNp
ZXMgdGhhdCBwb2ludGVkIHRvIGEgbm9uIGV4aXN0ZW50IHZhcmlhYmxlLgorCisgICAgICAgICog
R05VbWFrZWZpbGUuYW06CisKKzIwMTMtMDQtMjQgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dh
cmNpYUBpZ2FsaWEuY29tPgorCiAgICAgICAgIFtXZWJLaXQyXSBBZGQgQ29vcmRpbmF0ZWRHcmFw
aGljcyB0byB0aGUgbGlzdCBvZiBwbGF0Zm9ybXMgaW4gZ2VuZXJhdGUtZm9yd2FyZGluZy1oZWFk
ZXJzLnBsCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x
MTUwOTgKIApkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmlu
ZGV4IDBjNmJkYmEuLjljZDY1MGYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U
b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMy0wNC0yNCAgQ2FybG9zIEdhcmNp
YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gVXNlIHN0YW1w
IGZpbGVzIGZvciBnZW5lcmF0ZS1mb3J3YXJkaW5nLWhlYWRlcnMgbWFrZWZpbGUgcnVsZXMKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNTExOAorCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBhIHN0YW1w
IGZpbGUgZm9yIHRoZSBUZXN0V2ViS2l0QVBJIGFuZCBXZWJLaXRUZXN0UnVubmVyCisgICAgICAg
IGZvcndhcmRpbmcgZ2VuZXJhdG9yIHJ1bGVzIGFuZCBkb24ndCBjYWxsIGl0IGZvciBzb3VwIHNp
bmNlIHRoZXJlCisgICAgICAgIGFyZW4ndCBzb3VwIGRpcmVjdG9yaWVzIGluIFRlc3RXZWJLaXRB
UEkgYW5kIFdlYktpdFRlc3RSdW5uZXIuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL0dOVW1h
a2VmaWxlLmFtOgorICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvR05VbWFrZWZpbGUuYW06CisK
IDIwMTMtMDQtMjQgIENocmlzdG9waGUgRHVtZXogIDxjaC5kdW1lekBzaXNhLnNhbXN1bmcuY29t
PgogCiAgICAgICAgIFtFRkxdW1dLMl0gV2ViS2l0VGVzdFJ1bm5lciBmYWlsdXJlcyBkdWUgdG8g
SWNvbkRhdGFiYXNlIGFzc2VydGlvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0dOVW1h
a2VmaWxlLmFtIGIvU291cmNlL1dlYktpdDIvR05VbWFrZWZpbGUuYW0KaW5kZXggNzNiMjk1ZC4u
OTA0ZDdmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvR05VbWFrZWZpbGUuYW0KKysrIGIv
U291cmNlL1dlYktpdDIvR05VbWFrZWZpbGUuYW0KQEAgLTMxNSwxMyArMzE1LDE2IEBAIENMRUFO
RklMRVMgKz0gV2ViS2l0Mi1AV0VCS0lUR1RLX0FQSV9WRVJTSU9OQC5naXIgV2ViS2l0Mi1AV0VC
S0lUR1RLX0FQSV9WRVJTSU9OCiBlbmRpZgogZW5kaWYKIAotIyBXZWJLaXQyIHNwZWNpZmljIHZh
cmlhYmxlcwotZm9yd2FyZGluZ19oZWFkZXJzIDo9ICQoR0VOU09VUkNFU19XRUJLSVQyKS9pbmNs
dWRlCi1nZW5lcmF0ZS13ZWJraXQyLWZvcndhcmRpbmctaGVhZGVyczogJChXZWJLaXQyKS9TY3Jp
cHRzL2dlbmVyYXRlLWZvcndhcmRpbmctaGVhZGVycy5wbCAkKGxpYldlYktpdDJfbGFfU09VUkNF
UykKLQkkKEFNX1ZfR0VOKSQoUEVSTCkgJDwgJChXZWJLaXQyKSAkKGZvcndhcmRpbmdfaGVhZGVy
cykgZ3RrCi0JJChBTV9WX0dFTikkKFBFUkwpICQ8ICQoV2ViS2l0MikgJChmb3J3YXJkaW5nX2hl
YWRlcnMpIHNvdXAKK2dlbmVyYXRlLXdlYmtpdDItZm9yd2FyZGluZy1oZWFkZXJzOiBzdGFtcC13
ZWJraXQyLWZvcndhcmRpbmctaGVhZGVycworCUB0cnVlCisKK3N0YW1wLXdlYmtpdDItZm9yd2Fy
ZGluZy1oZWFkZXJzOiAkKFdlYktpdDIpL1NjcmlwdHMvZ2VuZXJhdGUtZm9yd2FyZGluZy1oZWFk
ZXJzLnBsICQod2Via2l0Ml9zb3VyY2VzKQorCSQoQU1fVl9HRU4pJChQRVJMKSAkPCAkKFdlYktp
dDIpICQoR0VOU09VUkNFU19XRUJLSVQyKS9pbmNsdWRlIGd0ayBcCisJJiYgJChQRVJMKSAkPCAk
KFdlYktpdDIpICQoR0VOU09VUkNFU19XRUJLSVQyKS9pbmNsdWRlIHNvdXAgXAorCSYmIGVjaG8g
dGltZXN0YW1wID4gJChARikKIAogQlVJTFRfU09VUkNFUyArPSBnZW5lcmF0ZS13ZWJraXQyLWZv
cndhcmRpbmctaGVhZGVycworQ0xFQU5GSUxFUyArPSAkKHRvcF9idWlsZGRpcikvc3RhbXAtd2Vi
a2l0Mi1mb3J3YXJkaW5nLWhlYWRlcnMKIAogJChHRU5TT1VSQ0VTX1dFQktJVDIpL3dlYmtpdDJn
dGsvaW5jbHVkZS93ZWJraXQyOiAkKGxpYndlYmtpdDJndGtpbmNsdWRlX0hFQURFUlMpCiAJJChB
TV9WX0dFTilta2RpciAtcCAkKEdFTlNPVVJDRVNfV0VCS0lUMikvd2Via2l0Mmd0ay9pbmNsdWRl
IFwKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvR05VbWFrZWZpbGUuYW0gYi9Ub29s
cy9UZXN0V2ViS2l0QVBJL0dOVW1ha2VmaWxlLmFtCmluZGV4IDliMjBlMDMuLmJmOThkYTggMTAw
NjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvR05VbWFrZWZpbGUuYW0KKysrIGIvVG9vbHMv
VGVzdFdlYktpdEFQSS9HTlVtYWtlZmlsZS5hbQpAQCAtMSwxMCArMSwzIEBACi1CVUlMVF9TT1VS
Q0VTICs9IFwKLQlnZW5lcmF0ZS10ZXN0d2Via2l0YXBpLWZvcndhcmRpbmctaGVhZGVycwotd2sy
X3Rlc3RzX3NvdXJjZXMgPSAkKHNoZWxsIGxzICQoc3JjZGlyKS9Ub29scy9UZXN0V2ViS2l0QVBJ
L1Rlc3RzL1dlYktpdDIvKi5jcHApCi1nZW5lcmF0ZS10ZXN0d2Via2l0YXBpLWZvcndhcmRpbmct
aGVhZGVyczogJChXZWJLaXQyKS9TY3JpcHRzL2dlbmVyYXRlLWZvcndhcmRpbmctaGVhZGVycy5w
bCAkKHdrMl90ZXN0c19zb3VyY2VzKQotCSQoQU1fVl9HRU4pJChQRVJMKSAkPCAkKHNyY2Rpcikv
VG9vbHMvVGVzdFdlYktpdEFQSSAkKEdFTlNPVVJDRVNfV0VCS0lUMikvaW5jbHVkZSBndGsKLQkk
KEFNX1ZfR0VOKSQoUEVSTCkgJDwgJChzcmNkaXIpL1Rvb2xzL1Rlc3RXZWJLaXRBUEkgJChHRU5T
T1VSQ0VTX1dFQktJVDIpL2luY2x1ZGUgc291cAotCiBub2luc3RfTFRMSUJSQVJJRVMgKz0gXAog
CUxpYnJhcmllcy9saWJUZXN0V2ViS2l0QVBJTWFpbi5sYQogCkBAIC0yMjksNiArMjIyLDE4IEBA
IExpYnJhcmllc19saWJUZXN0V2ViS2l0QVBJSW5qZWN0ZWRCdW5kbGVfbGFfQ1hYRkxBR1MgPSBc
CiAKIExpYnJhcmllc19saWJUZXN0V2ViS2l0QVBJSW5qZWN0ZWRCdW5kbGVfbGFfQ0ZMQUdTID0g
XAogCSQoZ2xvYmFsX2NmbGFncykKKworZ2VuZXJhdGUtdGVzdHdlYmtpdGFwaS1mb3J3YXJkaW5n
LWhlYWRlcnM6IHN0YW1wLXRlc3R3ZWJraXRhcGktZm9yd2FyZGluZy1oZWFkZXJzCisJQHRydWUK
Kword2syX3Rlc3RzX3NvdXJjZXMgPSAkKFByb2dyYW1zX1Rlc3RXZWJLaXRBUElfVGVzdFdlYktp
dDJfU09VUkNFUykgJChMaWJyYXJpZXNfbGliVGVzdFdlYktpdEFQSUluamVjdGVkQnVuZGxlX2xh
X1NPVVJDRVMpCitzdGFtcC10ZXN0d2Via2l0YXBpLWZvcndhcmRpbmctaGVhZGVyczogJChXZWJL
aXQyKS9TY3JpcHRzL2dlbmVyYXRlLWZvcndhcmRpbmctaGVhZGVycy5wbCAkKHdrMl90ZXN0c19z
b3VyY2VzKQorCSQoQU1fVl9HRU4pJChQRVJMKSAkPCAkKHNyY2RpcikvVG9vbHMvVGVzdFdlYktp
dEFQSSAkKEdFTlNPVVJDRVNfV0VCS0lUMikvaW5jbHVkZSBndGsgXAorCSYmIGVjaG8gdGltZXN0
YW1wID4gJChARikKKworQlVJTFRfU09VUkNFUyArPSBnZW5lcmF0ZS10ZXN0d2Via2l0YXBpLWZv
cndhcmRpbmctaGVhZGVycworQ0xFQU5GSUxFUyArPSAkKHRvcF9idWlsZGRpcikvc3RhbXAtdGVz
dHdlYmtpdGFwaS1mb3J3YXJkaW5nLWhlYWRlcnMKKwogZW5kaWYgIyBFTkFCTEVfV0VCS0lUMgog
CiBFWFRSQV9ESVNUICs9IFwKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvR05V
bWFrZWZpbGUuYW0gYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0dOVW1ha2VmaWxlLmFtCmluZGV4
IDE4MTI1NjkuLmZhY2YyYmExIDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0dO
VW1ha2VmaWxlLmFtCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvR05VbWFrZWZpbGUuYW0K
QEAgLTEsOSArMSwxMyBAQAotQlVJTFRfU09VUkNFUyArPSBcCi0JZ2VuZXJhdGUtd2Via2l0dGVz
dHJ1bm5lci1mb3J3YXJkaW5nLWhlYWRlcnMKIAotZ2VuZXJhdGUtd2Via2l0dGVzdHJ1bm5lci1m
b3J3YXJkaW5nLWhlYWRlcnM6ICQoV2ViS2l0MikvU2NyaXB0cy9nZW5lcmF0ZS1mb3J3YXJkaW5n
LWhlYWRlcnMucGwgJChQcm9ncmFtc19XZWJLaXRUZXN0UnVubmVyX1NPVVJDRVMpCi0JJChBTV9W
X0dFTikkKFBFUkwpICQ8ICQoc3JjZGlyKS9Ub29scy9XZWJLaXRUZXN0UnVubmVyICQoR0VOU09V
UkNFU19XRUJLSVQyKS9pbmNsdWRlIGd0awotCSQoQU1fVl9HRU4pJChQRVJMKSAkPCAkKHNyY2Rp
cikvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lciAkKEdFTlNPVVJDRVNfV0VCS0lUMikvaW5jbHVkZSBz
b3VwCitnZW5lcmF0ZS13ZWJraXR0ZXN0cnVubmVyLWZvcndhcmRpbmctaGVhZGVyczogc3RhbXAt
d2Via2l0dGVzdHJ1bm5lci1mb3J3YXJkaW5nLWhlYWRlcnMKKwlAdHJ1ZQorCitzdGFtcC13ZWJr
aXR0ZXN0cnVubmVyLWZvcndhcmRpbmctaGVhZGVyczogJChXZWJLaXQyKS9TY3JpcHRzL2dlbmVy
YXRlLWZvcndhcmRpbmctaGVhZGVycy5wbCAkKFByb2dyYW1zX1dlYktpdFRlc3RSdW5uZXJfU09V
UkNFUykKKwkkKEFNX1ZfR0VOKSQoUEVSTCkgJDwgJChzcmNkaXIpL1Rvb2xzL1dlYktpdFRlc3RS
dW5uZXIgJChHRU5TT1VSQ0VTX1dFQktJVDIpL2luY2x1ZGUgZ3RrIFwKKwkmJiBlY2hvIHRpbWVz
dGFtcCA+ICQoQEYpCisKK0JVSUxUX1NPVVJDRVMgKz0gZ2VuZXJhdGUtd2Via2l0dGVzdHJ1bm5l
ci1mb3J3YXJkaW5nLWhlYWRlcnMKK0NMRUFORklMRVMgKz0gJCh0b3BfYnVpbGRkaXIpL3N0YW1w
LXdlYmtpdHRlc3RydW5uZXItZm9yd2FyZGluZy1oZWFkZXJzCiAKIGlmIEVOQUJMRV9XRUJLSVQy
CiBub2luc3RfUFJPR1JBTVMgKz0gXAo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>199505</attachid>
            <date>2013-04-24 11:26:29 -0700</date>
            <delta_ts>2013-04-24 11:27:26 -0700</delta_ts>
            <desc>Updated patch</desc>
            <filename>wk2-forwarding-headers2.diff</filename>
            <type>text/plain</type>
            <size>5064</size>
            <attacher name="Carlos Garcia Campos">cgarcia</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No
YW5nZUxvZwppbmRleCA3YTc5M2ZhLi45YzE2MjQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcg
QEAKIDIwMTMtMDQtMjQgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t
PgogCisgICAgICAgIFtHVEtdIFVzZSBzdGFtcCBmaWxlcyBmb3IgZ2VuZXJhdGUtZm9yd2FyZGlu
Zy1oZWFkZXJzIG1ha2VmaWxlIHJ1bGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD0xMTUxMTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICBVc2UgYSBzdGFtcCBmaWxlIGZvciB0aGUgV2ViS2l0MiBmb3J3YXJk
aW5nIGdlbmVyYXRvciBydWxlLiBBbHNvCisgICAgICAgIGZpeCB0aGUgcnVsZSBkZXBlbmRlbmNp
ZXMgdGhhdCBwb2ludGVkIHRvIGEgbm9uIGV4aXN0ZW50IHZhcmlhYmxlLgorCisgICAgICAgICog
R05VbWFrZWZpbGUuYW06CisKKzIwMTMtMDQtMjQgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dh
cmNpYUBpZ2FsaWEuY29tPgorCiAgICAgICAgIFtXZWJLaXQyXSBBZGQgQ29vcmRpbmF0ZWRHcmFw
aGljcyB0byB0aGUgbGlzdCBvZiBwbGF0Zm9ybXMgaW4gZ2VuZXJhdGUtZm9yd2FyZGluZy1oZWFk
ZXJzLnBsCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x
MTUwOTgKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvR05VbWFrZWZpbGUuYW0gYi9Tb3Vy
Y2UvV2ViS2l0Mi9HTlVtYWtlZmlsZS5hbQppbmRleCA3M2IyOTVkLi41MTQ1NjE4IDEwMDY0NAot
LS0gYS9Tb3VyY2UvV2ViS2l0Mi9HTlVtYWtlZmlsZS5hbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9H
TlVtYWtlZmlsZS5hbQpAQCAtMzE1LDEzICszMTUsMTIgQEAgQ0xFQU5GSUxFUyArPSBXZWJLaXQy
LUBXRUJLSVRHVEtfQVBJX1ZFUlNJT05ALmdpciBXZWJLaXQyLUBXRUJLSVRHVEtfQVBJX1ZFUlNJ
T04KIGVuZGlmCiBlbmRpZgogCi0jIFdlYktpdDIgc3BlY2lmaWMgdmFyaWFibGVzCi1mb3J3YXJk
aW5nX2hlYWRlcnMgOj0gJChHRU5TT1VSQ0VTX1dFQktJVDIpL2luY2x1ZGUKLWdlbmVyYXRlLXdl
YmtpdDItZm9yd2FyZGluZy1oZWFkZXJzOiAkKFdlYktpdDIpL1NjcmlwdHMvZ2VuZXJhdGUtZm9y
d2FyZGluZy1oZWFkZXJzLnBsICQobGliV2ViS2l0Ml9sYV9TT1VSQ0VTKQotCSQoQU1fVl9HRU4p
JChQRVJMKSAkPCAkKFdlYktpdDIpICQoZm9yd2FyZGluZ19oZWFkZXJzKSBndGsKLQkkKEFNX1Zf
R0VOKSQoUEVSTCkgJDwgJChXZWJLaXQyKSAkKGZvcndhcmRpbmdfaGVhZGVycykgc291cAorc3Rh
bXAtd2Via2l0Mi1mb3J3YXJkaW5nLWhlYWRlcnM6ICQoV2ViS2l0MikvU2NyaXB0cy9nZW5lcmF0
ZS1mb3J3YXJkaW5nLWhlYWRlcnMucGwgJCh3ZWJraXQyX3NvdXJjZXMpCisJJChBTV9WX0dFTikk
KFBFUkwpICQ8ICQoV2ViS2l0MikgJChHRU5TT1VSQ0VTX1dFQktJVDIpL2luY2x1ZGUgZ3RrIFwK
KwkmJiAkKFBFUkwpICQ8ICQoV2ViS2l0MikgJChHRU5TT1VSQ0VTX1dFQktJVDIpL2luY2x1ZGUg
c291cCBcCisJJiYgZWNobyB0aW1lc3RhbXAgPiAkKEBGKQogCi1CVUlMVF9TT1VSQ0VTICs9IGdl
bmVyYXRlLXdlYmtpdDItZm9yd2FyZGluZy1oZWFkZXJzCitCVUlMVF9TT1VSQ0VTICs9ICQodG9w
X2J1aWxkZGlyKS9zdGFtcC13ZWJraXQyLWZvcndhcmRpbmctaGVhZGVycwogCiAkKEdFTlNPVVJD
RVNfV0VCS0lUMikvd2Via2l0Mmd0ay9pbmNsdWRlL3dlYmtpdDI6ICQobGlid2Via2l0Mmd0a2lu
Y2x1ZGVfSEVBREVSUykKIAkkKEFNX1ZfR0VOKW1rZGlyIC1wICQoR0VOU09VUkNFU19XRUJLSVQy
KS93ZWJraXQyZ3RrL2luY2x1ZGUgXApkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9v
bHMvQ2hhbmdlTG9nCmluZGV4IDBjNmJkYmEuLjljZDY1MGYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0No
YW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMy0wNC0y
NCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAg
W0dUS10gVXNlIHN0YW1wIGZpbGVzIGZvciBnZW5lcmF0ZS1mb3J3YXJkaW5nLWhlYWRlcnMgbWFr
ZWZpbGUgcnVsZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTExNTExOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg
ICAgIFVzZSBhIHN0YW1wIGZpbGUgZm9yIHRoZSBUZXN0V2ViS2l0QVBJIGFuZCBXZWJLaXRUZXN0
UnVubmVyCisgICAgICAgIGZvcndhcmRpbmcgZ2VuZXJhdG9yIHJ1bGVzIGFuZCBkb24ndCBjYWxs
IGl0IGZvciBzb3VwIHNpbmNlIHRoZXJlCisgICAgICAgIGFyZW4ndCBzb3VwIGRpcmVjdG9yaWVz
IGluIFRlc3RXZWJLaXRBUEkgYW5kIFdlYktpdFRlc3RSdW5uZXIuCisKKyAgICAgICAgKiBUZXN0
V2ViS2l0QVBJL0dOVW1ha2VmaWxlLmFtOgorICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvR05V
bWFrZWZpbGUuYW06CisKIDIwMTMtMDQtMjQgIENocmlzdG9waGUgRHVtZXogIDxjaC5kdW1lekBz
aXNhLnNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdW1dLMl0gV2ViS2l0VGVzdFJ1bm5lciBm
YWlsdXJlcyBkdWUgdG8gSWNvbkRhdGFiYXNlIGFzc2VydGlvbnMKZGlmZiAtLWdpdCBhL1Rvb2xz
L1Rlc3RXZWJLaXRBUEkvR05VbWFrZWZpbGUuYW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL0dOVW1h
a2VmaWxlLmFtCmluZGV4IDliMjBlMDMuLjI0MjcyYzcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RX
ZWJLaXRBUEkvR05VbWFrZWZpbGUuYW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9HTlVtYWtl
ZmlsZS5hbQpAQCAtMSwxMCArMSwzIEBACi1CVUlMVF9TT1VSQ0VTICs9IFwKLQlnZW5lcmF0ZS10
ZXN0d2Via2l0YXBpLWZvcndhcmRpbmctaGVhZGVycwotd2syX3Rlc3RzX3NvdXJjZXMgPSAkKHNo
ZWxsIGxzICQoc3JjZGlyKS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDIvKi5jcHAp
Ci1nZW5lcmF0ZS10ZXN0d2Via2l0YXBpLWZvcndhcmRpbmctaGVhZGVyczogJChXZWJLaXQyKS9T
Y3JpcHRzL2dlbmVyYXRlLWZvcndhcmRpbmctaGVhZGVycy5wbCAkKHdrMl90ZXN0c19zb3VyY2Vz
KQotCSQoQU1fVl9HRU4pJChQRVJMKSAkPCAkKHNyY2RpcikvVG9vbHMvVGVzdFdlYktpdEFQSSAk
KEdFTlNPVVJDRVNfV0VCS0lUMikvaW5jbHVkZSBndGsKLQkkKEFNX1ZfR0VOKSQoUEVSTCkgJDwg
JChzcmNkaXIpL1Rvb2xzL1Rlc3RXZWJLaXRBUEkgJChHRU5TT1VSQ0VTX1dFQktJVDIpL2luY2x1
ZGUgc291cAotCiBub2luc3RfTFRMSUJSQVJJRVMgKz0gXAogCUxpYnJhcmllcy9saWJUZXN0V2Vi
S2l0QVBJTWFpbi5sYQogCkBAIC0yMjksNiArMjIyLDEzIEBAIExpYnJhcmllc19saWJUZXN0V2Vi
S2l0QVBJSW5qZWN0ZWRCdW5kbGVfbGFfQ1hYRkxBR1MgPSBcCiAKIExpYnJhcmllc19saWJUZXN0
V2ViS2l0QVBJSW5qZWN0ZWRCdW5kbGVfbGFfQ0ZMQUdTID0gXAogCSQoZ2xvYmFsX2NmbGFncykK
Kworc3RhbXAtdGVzdHdlYmtpdGFwaS1mb3J3YXJkaW5nLWhlYWRlcnM6ICQoV2ViS2l0MikvU2Ny
aXB0cy9nZW5lcmF0ZS1mb3J3YXJkaW5nLWhlYWRlcnMucGwgJChQcm9ncmFtc19UZXN0V2ViS2l0
QVBJX1Rlc3RXZWJLaXQyX1NPVVJDRVMpICQoTGlicmFyaWVzX2xpYlRlc3RXZWJLaXRBUElJbmpl
Y3RlZEJ1bmRsZV9sYV9TT1VSQ0VTKQorCSQoQU1fVl9HRU4pJChQRVJMKSAkPCAkKHNyY2Rpcikv
VG9vbHMvVGVzdFdlYktpdEFQSSAkKEdFTlNPVVJDRVNfV0VCS0lUMikvaW5jbHVkZSBndGsgXAor
CSYmIGVjaG8gdGltZXN0YW1wID4gJChARikKKworQlVJTFRfU09VUkNFUyArPSAkKHRvcF9idWls
ZGRpcikvc3RhbXAtdGVzdHdlYmtpdGFwaS1mb3J3YXJkaW5nLWhlYWRlcnMKKwogZW5kaWYgIyBF
TkFCTEVfV0VCS0lUMgogCiBFWFRSQV9ESVNUICs9IFwKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktp
dFRlc3RSdW5uZXIvR05VbWFrZWZpbGUuYW0gYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0dOVW1h
a2VmaWxlLmFtCmluZGV4IDE4MTI1NjkuLjI4YTMyMzggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktp
dFRlc3RSdW5uZXIvR05VbWFrZWZpbGUuYW0KKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9H
TlVtYWtlZmlsZS5hbQpAQCAtMSw5ICsxLDkgQEAKLUJVSUxUX1NPVVJDRVMgKz0gXAotCWdlbmVy
YXRlLXdlYmtpdHRlc3RydW5uZXItZm9yd2FyZGluZy1oZWFkZXJzCiAKLWdlbmVyYXRlLXdlYmtp
dHRlc3RydW5uZXItZm9yd2FyZGluZy1oZWFkZXJzOiAkKFdlYktpdDIpL1NjcmlwdHMvZ2VuZXJh
dGUtZm9yd2FyZGluZy1oZWFkZXJzLnBsICQoUHJvZ3JhbXNfV2ViS2l0VGVzdFJ1bm5lcl9TT1VS
Q0VTKQotCSQoQU1fVl9HRU4pJChQRVJMKSAkPCAkKHNyY2RpcikvVG9vbHMvV2ViS2l0VGVzdFJ1
bm5lciAkKEdFTlNPVVJDRVNfV0VCS0lUMikvaW5jbHVkZSBndGsKLQkkKEFNX1ZfR0VOKSQoUEVS
TCkgJDwgJChzcmNkaXIpL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIgJChHRU5TT1VSQ0VTX1dFQktJ
VDIpL2luY2x1ZGUgc291cAorc3RhbXAtd2Via2l0dGVzdHJ1bm5lci1mb3J3YXJkaW5nLWhlYWRl
cnM6ICQoV2ViS2l0MikvU2NyaXB0cy9nZW5lcmF0ZS1mb3J3YXJkaW5nLWhlYWRlcnMucGwgJChQ
cm9ncmFtc19XZWJLaXRUZXN0UnVubmVyX1NPVVJDRVMpCisJJChBTV9WX0dFTikkKFBFUkwpICQ8
ICQoc3JjZGlyKS9Ub29scy9XZWJLaXRUZXN0UnVubmVyICQoR0VOU09VUkNFU19XRUJLSVQyKS9p
bmNsdWRlIGd0ayBcCisJJiYgZWNobyB0aW1lc3RhbXAgPiAkKEBGKQorCitCVUlMVF9TT1VSQ0VT
ICs9ICQodG9wX2J1aWxkZGlyKS9zdGFtcC13ZWJraXR0ZXN0cnVubmVyLWZvcndhcmRpbmctaGVh
ZGVycwogCiBpZiBFTkFCTEVfV0VCS0lUMgogbm9pbnN0X1BST0dSQU1TICs9IFwK
</data>
<flag name="review"
          id="221021"
          type_id="1"
          status="+"
          setter="mrobinson"
    />
          </attachment>
      

    </bug>

</bugzilla>