115114 2013-04-24 09:36:10 -0700 ref-tests should compare the entire page instead of the viewport 2013-04-24 13:24:57 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 zoltan webkit-unassigned benjamin bjonesbe glenn jberlin rniwa simon.fraser thorton oldest_to_newest 880673 0 zoltan 2013-04-24 09:36:10 -0700 The topic was discussed in https://lists.webkit.org/pipermail/webkit-dev/2013-April/024766.html 880763 1 glenn 2013-04-24 12:51:45 -0700 if existing reftests assume that only a particular (e.g., 800x600) area is compared, then we should not change the default to compare the entire page; that is, comparing the entire page should be opt-in due to prior usage 880767 2 rniwa 2013-04-24 13:05:39 -0700 (In reply to comment #1) > if existing reftests assume that only a particular (e.g., 800x600) area is compared, then we should not change the default to compare the entire page; that is, comparing the entire page should be opt-in due to prior usage We shouldn’t make such assumptions in reftests. If there are ref tests that make such a bad assumption, then we should fix them all. 880771 3 glenn 2013-04-24 13:24:57 -0700 (In reply to comment #2) > (In reply to comment #1) > > if existing reftests assume that only a particular (e.g., 800x600) area is compared, then we should not change the default to compare the entire page; that is, comparing the entire page should be opt-in due to prior usage > > We shouldn’t make such assumptions in reftests. If there are ref tests that make such a bad assumption, then we should fix them all. ok, in that case, the documentations about creating reftests [1] should make this explicit; authors may have assumed that 800x600 holds due to the language in [2] [1] http://trac.webkit.org/wiki/Writing%20Reftests [2] http://trac.webkit.org/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree#Howtowriteportablepixeltests