115102 2013-04-24 05:21:46 -0700 Use std::move in AtomicString 2013-04-25 09:46:53 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mikhail.pozdnyakov mikhail.pozdnyakov andersca ap benjamin cmarcelo commit-queue kling oldest_to_newest 880447 0 mikhail.pozdnyakov 2013-04-24 05:21:46 -0700 SSIA. 880455 1 199418 mikhail.pozdnyakov 2013-04-24 05:54:52 -0700 Created attachment 199418 WIP Newly added file is not yet included into proj files. 880537 2 andersca 2013-04-24 07:23:23 -0700 I like it, but I think it should just go into TypeTraits.h directly. 880547 3 199454 mikhail.pozdnyakov 2013-04-24 07:53:28 -0700 Created attachment 199454 patch Put 'move()' to TypeTraits.h as requested by Anders. 880647 4 ap 2013-04-24 08:55:13 -0700 What is the difference with std::move? I'm wondering if we can just use it directly. 880800 5 benjamin 2013-04-24 14:36:31 -0700 (In reply to comment #4) > What is the difference with std::move? I'm wondering if we can just use it directly. Same question here. 880807 6 andersca 2013-04-24 14:42:35 -0700 Good point. We could just state that any C++ compiles that supports rvalue references must also have an implementation of std::move. 880810 7 199454 benjamin 2013-04-24 14:44:20 -0700 Comment on attachment 199454 patch Looks like we should use std::move in AtomicString instead of introducing our own. 881107 8 mikhail.pozdnyakov 2013-04-25 00:07:12 -0700 (In reply to comment #5) > (In reply to comment #4) > > What is the difference with std::move? I'm wondering if we can just use it directly. > > Same question here. Ok, I was just thinking that one of the reasons for having WTF is that we do not want to use STL, this assumption seems to be wrong however. 881109 9 benjamin 2013-04-25 00:25:55 -0700 > Ok, I was just thinking that one of the reasons for having WTF is that we do not want to use STL, this assumption seems to be wrong however. The STL is pretty crappy when it come to ADT. Apart from that, I don't think there is any problem with using STL. 881141 10 199631 mikhail.pozdnyakov 2013-04-25 01:28:10 -0700 Created attachment 199631 patch v3 Use std::move. 881193 11 mikhail.pozdnyakov 2013-04-25 04:32:59 -0700 (In reply to comment #9) > > Ok, I was just thinking that one of the reasons for having WTF is that we do not want to use STL, this assumption seems to be wrong however. > > The STL is pretty crappy when it come to ADT. Apart from that, I don't think there is any problem with using STL. btw, why do we use WTF TypeTraits? could we use std::type_traits as well? 881239 12 199631 andersca 2013-04-25 07:21:58 -0700 Comment on attachment 199631 patch v3 View in context: https://bugs.webkit.org/attachment.cgi?id=199631&action=review > Source/WTF/wtf/text/AtomicString.h:26 > +#if COMPILER_SUPPORTS(CXX_RVALUE_REFERENCES) > +#include <utility> > +#endif I think we can just always include this. 881247 13 199660 mikhail.pozdnyakov 2013-04-25 07:41:02 -0700 Created attachment 199660 to be landed 881251 14 andersca 2013-04-25 08:04:09 -0700 (In reply to comment #11) > (In reply to comment #9) > > > Ok, I was just thinking that one of the reasons for having WTF is that we do not want to use STL, this assumption seems to be wrong however. > > > > The STL is pretty crappy when it come to ADT. Apart from that, I don't think there is any problem with using STL. I think using STL for type traits is a great idea! > > btw, why do we use WTF TypeTraits? could we use std::type_traits as well? I believe that the STL type traits are C++11 only (but we could change the WTF type traits to emulate them when building with C++98). 881258 15 commit-queue 2013-04-25 08:15:33 -0700 The commit-queue encountered the following flaky tests while processing attachment 199660: svg/as-image/img-relative-height.html bug 114140 (author: zimmermann@kde.org) The commit-queue is continuing to process your patch. 881260 16 199660 commit-queue 2013-04-25 08:16:54 -0700 Comment on attachment 199660 to be landed Clearing flags on attachment: 199660 Committed r149112: <http://trac.webkit.org/changeset/149112> 881261 17 commit-queue 2013-04-25 08:16:56 -0700 All reviewed patches have been landed. Closing bug. 881321 18 ap 2013-04-25 09:46:53 -0700 > Ok, I was just thinking that one of the reasons for having WTF is that we do not want to use STL, this assumption seems to be wrong however. The main reasons for reimplementing some containers and algorithms are: 1. We can fine tune performance to our needs. 2. We can disable exceptions and still have reasonable behavior. 199418 2013-04-24 05:54:52 -0700 2013-04-24 07:53:28 -0700 WIP bug115102 text/plain 4396 mikhail.pozdnyakov Y29tbWl0IDExZTI3ZGU5ZWExMGIwZDQ0ODg3Njk3MzVhZTYyMGUzNTQzYzE5OWQKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg V2VkIEFwciAyNCAxNToyMzowMiAyMDEzICswMzAwCgogICAgYnVnMTE1MTAyCgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dURi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwppbmRleCBlNGY2 OGI0Li4xZmYxOGVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA0LTI0ICBNaWtoYWlsIFBv emRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgorCisgICAgICAgIEludHJv ZHVjZSBzdGQ6Om1vdmUgYW5hbG9ndWUgdG8gV1RGCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTUxMDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9VdGlsaXR5Lmg6IEFkZGVkLgorICAgICAgICAo V1RGOjptb3ZlKTogQWRkZWQgV1RGOjptb3ZlKCksIGFuIHN0ZDo6bW92ZSgpIGFuYWxvZ3VlIGZ1 bmN0aW9uLgorICAgICAgICAqIHd0Zi90ZXh0L0F0b21pY1N0cmluZy5oOgorICAgICAgICAoV1RG OjpBdG9taWNTdHJpbmc6OkF0b21pY1N0cmluZyk6IFVzZXMgV1RGOjptb3ZlKCkgdG8gYXNzaWdu IGNsYXNzIG1lbWJlcnMuCisgICAgICAgIChXVEY6OkF0b21pY1N0cmluZzo6b3BlcmF0b3I9KTog RGl0dG8uCisKIDIwMTMtMDQtMjMgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4K IAogICAgICAgICBGaWxsZWQgb3V0IG1vcmUgY2FzZXMgb2YgYnJhbmNoIGZvbGRpbmcgaW4gYnl0 ZWNvZGUgd2hlbiBlbWl0dGluZyBleHByZXNzaW9ucyBpbnRvIGEgYnJhbmNoaW5nIGNvbnRleHQK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1V0aWxpdHkuaCBiL1NvdXJjZS9XVEYvd3RmL1V0 aWxpdHkuaApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5kYTc2ZTAyCi0tLSAv ZGV2L251bGwKKysrIGIvU291cmNlL1dURi93dGYvVXRpbGl0eS5oCkBAIC0wLDAgKzEsNDMgQEAK Ky8qCisgKiBDb3B5cmlnaHQgKEMpIDIwMTMgSW50ZWwgQ29ycG9yYXRpb24uIEFsbCByaWdodHMg cmVzZXJ2ZWQuCisgKgorICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJp bmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0 ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKKyAqIGFyZSBtZXQ6Cisg KiAxLiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3Zl IGNvcHlyaWdodAorICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhl IGZvbGxvd2luZyBkaXNjbGFpbWVyLgorICogMi4gUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBm b3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgIG5vdGljZSwgdGhp cyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUK KyAqICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRo IHRoZSBkaXN0cmlidXRpb24uCisgKgorICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBB UFBMRSBJTkMuIEFORCBJVFMgQ09OVFJJQlVUT1JTIGBgQVMgSVMnJworICogQU5EIEFOWSBFWFBS RVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8s CisgKiBUSEUgSU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVT UyBGT1IgQSBQQVJUSUNVTEFSCisgKiBQVVJQT1NFIEFSRSBESVNDTEFJTUVELiBJTiBOTyBFVkVO VCBTSEFMTCBBUFBMRSBJTkMuIE9SIElUUyBDT05UUklCVVRPUlMKKyAqIEJFIExJQUJMRSBGT1Ig QU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IK KyAqIENPTlNFUVVFTlRJQUwgREFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8s IFBST0NVUkVNRU5UIE9GCisgKiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9G IFVTRSwgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MKKyAqIElOVEVSUlVQVElPTikgSE9X RVZFUiBDQVVTRUQgQU5EIE9OIEFOWSBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVSIElOCisg KiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVCAoSU5DTFVESU5HIE5FR0xJR0VO Q0UgT1IgT1RIRVJXSVNFKQorICogQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFIE9G IFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRgorICogVEhFIFBPU1NJQklMSVRZIE9G IFNVQ0ggREFNQUdFLgorICovCisKKyNpZm5kZWYgVXRpbGl0eV9oCisjZGVmaW5lIFV0aWxpdHlf aAorCisjaW5jbHVkZSA8d3RmL1R5cGVUcmFpdHMuaD4KKworbmFtZXNwYWNlIFdURiB7CisKKyNp ZiBDT01QSUxFUl9TVVBQT1JUUyhDWFhfUlZBTFVFX1JFRkVSRU5DRVMpCit0ZW1wbGF0ZTxjbGFz cyBUPgordHlwZW5hbWUgUmVtb3ZlUmVmZXJlbmNlPFQ+OjpUeXBlJiYgbW92ZShUJiYgdikKK3sK KyAgICByZXR1cm4gc3RhdGljX2Nhc3Q8dHlwZW5hbWUgUmVtb3ZlUmVmZXJlbmNlPFQ+OjpUeXBl JiY+KHYpOworfQorI2VuZGlmIC8vICNpZiBDT01QSUxFUl9TVVBQT1JUUyhDWFhfUlZBTFVFX1JF RkVSRU5DRVMpCisKK30gLy8gbmFtZXNwYWNlIFdURgorCisjZW5kaWYgLy8gVXRpbGl0eV9oCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L0F0b21pY1N0cmluZy5oIGIvU291cmNlL1dU Ri93dGYvdGV4dC9BdG9taWNTdHJpbmcuaAppbmRleCA5NTU1MTgzLi4wYzI5Y2M2IDEwMDY0NAot LS0gYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L0F0b21pY1N0cmluZy5oCisrKyBiL1NvdXJjZS9XVEYv d3RmL3RleHQvQXRvbWljU3RyaW5nLmgKQEAgLTIxLDYgKzIxLDcgQEAKICNpZm5kZWYgQXRvbWlj U3RyaW5nX2gKICNkZWZpbmUgQXRvbWljU3RyaW5nX2gKIAorI2luY2x1ZGUgPHd0Zi9VdGlsaXR5 Lmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvQXRvbWljU3RyaW5nSW1wbC5oPgogI2luY2x1ZGUgPHd0 Zi90ZXh0L1dURlN0cmluZy5oPgogCkBAIC03NiwxMiArNzcsMTAgQEAgcHVibGljOgogI2lmIENP TVBJTEVSX1NVUFBPUlRTKENYWF9SVkFMVUVfUkVGRVJFTkNFUykKICAgICAvLyBXZSBoYXZlIHRv IGRlY2xhcmUgdGhlIGNvcHkgY29uc3RydWN0b3IgYW5kIGNvcHkgYXNzaWdubWVudCBvcGVyYXRv ciBhcyB3ZWxsLCBvdGhlcndpc2UKICAgICAvLyB0aGV5J2xsIGJlIGltcGxpY2l0bHkgZGVsZXRl ZCBieSBhZGRpbmcgdGhlIG1vdmUgY29uc3RydWN0b3IgYW5kIG1vdmUgYXNzaWdubWVudCBvcGVy YXRvci4KLSAgICAvLyBGSVhNRTogSW5zdGVhZCBvZiBleHBsaWNpdGx5IGNhc3RpbmcgdG8gU3Ry aW5nJiYgaGVyZSwgd2Ugc2hvdWxkIHVzZSBzdGQ6Om1vdmUsIGJ1dCB0aGF0IHJlcXVpcmVzIHVz IHRvCi0gICAgLy8gaGF2ZSBhIHN0YW5kYXJkIGxpYnJhcnkgdGhhdCBzdXBwb3J0cyBtb3ZlIHNl bWFudGljcy4KICAgICBBdG9taWNTdHJpbmcoY29uc3QgQXRvbWljU3RyaW5nJiBvdGhlcikgOiBt X3N0cmluZyhvdGhlci5tX3N0cmluZykgeyB9Ci0gICAgQXRvbWljU3RyaW5nKEF0b21pY1N0cmlu ZyYmIG90aGVyKSA6IG1fc3RyaW5nKHN0YXRpY19jYXN0PFN0cmluZyYmPihvdGhlci5tX3N0cmlu ZykpIHsgfQorICAgIEF0b21pY1N0cmluZyhBdG9taWNTdHJpbmcmJiBvdGhlcikgOiBtX3N0cmlu ZyhXVEY6Om1vdmUob3RoZXIubV9zdHJpbmcpKSB7IH0KICAgICBBdG9taWNTdHJpbmcmIG9wZXJh dG9yPShjb25zdCBBdG9taWNTdHJpbmcmIG90aGVyKSB7IG1fc3RyaW5nID0gb3RoZXIubV9zdHJp bmc7IHJldHVybiAqdGhpczsgfQotICAgIEF0b21pY1N0cmluZyYgb3BlcmF0b3I9KEF0b21pY1N0 cmluZyYmIG90aGVyKSB7IG1fc3RyaW5nID0gc3RhdGljX2Nhc3Q8U3RyaW5nJiY+KG90aGVyLm1f c3RyaW5nKTsgcmV0dXJuICp0aGlzOyB9CisgICAgQXRvbWljU3RyaW5nJiBvcGVyYXRvcj0oQXRv bWljU3RyaW5nJiYgb3RoZXIpIHsgbV9zdHJpbmcgPSBXVEY6Om1vdmUob3RoZXIubV9zdHJpbmcp OyByZXR1cm4gKnRoaXM7IH0KICNlbmRpZgogCiAgICAgLy8gSGFzaCB0YWJsZSBkZWxldGVkIHZh bHVlcywgd2hpY2ggYXJlIG9ubHkgY29uc3RydWN0ZWQgYW5kIG5ldmVyIGNvcGllZCBvciBkZXN0 cm95ZWQuCg== 199454 2013-04-24 07:53:28 -0700 2013-04-25 01:28:10 -0700 patch bug115102_v2 text/plain 3172 mikhail.pozdnyakov Y29tbWl0IDAyNDZjZmRhYWM5ZWY0YWM5NjE3NzE2NzNiNThkMzI1M2M4NmQ0MWYKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg V2VkIEFwciAyNCAxNzozMDozMiAyMDEzICswMzAwCgogICAgYnVnMTE1MTAyCgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dURi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwppbmRleCBlNGY2 OGI0Li42ZmFmYmJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA0LTI0ICBNaWtoYWlsIFBv emRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgorCisgICAgICAgIEludHJv ZHVjZSBzdGQ6Om1vdmUgYW5hbG9ndWUgdG8gV1RGCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTUxMDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9UeXBlVHJhaXRzLmg6CisgICAgICAgIChXVEY6 Om1vdmUpOiBBZGRlZCBXVEY6Om1vdmUoKSwgYW4gc3RkOjptb3ZlKCkgYW5hbG9ndWUgZnVuY3Rp b24uCisgICAgICAgICogd3RmL3RleHQvQXRvbWljU3RyaW5nLmg6CisgICAgICAgIChBdG9taWNT dHJpbmcpOgorICAgICAgICAoV1RGOjpBdG9taWNTdHJpbmc6OkF0b21pY1N0cmluZyk6IFVzZXMg V1RGOjptb3ZlKCkgdG8gYXNzaWduIGNsYXNzIG1lbWJlcnMuCisgICAgICAgIChXVEY6OkF0b21p Y1N0cmluZzo6b3BlcmF0b3I9KTogRGl0dG8uCisKIDIwMTMtMDQtMjMgIEdlb2ZmcmV5IEdhcmVu ICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBGaWxsZWQgb3V0IG1vcmUgY2FzZXMgb2Yg YnJhbmNoIGZvbGRpbmcgaW4gYnl0ZWNvZGUgd2hlbiBlbWl0dGluZyBleHByZXNzaW9ucyBpbnRv IGEgYnJhbmNoaW5nIGNvbnRleHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1R5cGVUcmFp dHMuaCBiL1NvdXJjZS9XVEYvd3RmL1R5cGVUcmFpdHMuaAppbmRleCBiOWU0NmJjLi4wODU5ZWE3 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9UeXBlVHJhaXRzLmgKKysrIGIvU291cmNlL1dU Ri93dGYvVHlwZVRyYWl0cy5oCkBAIC0xLDYgKzEsNyBAQAogIC8qCiAgKiBDb3B5cmlnaHQgKEMp IDIwMDYsIDIwMDcsIDIwMDggQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICogQ29w eXJpZ2h0IChDKSAyMDA5LCAyMDEwIEdvb2dsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisg KiBDb3B5cmlnaHQgKEMpIDIwMTMgSW50ZWwgQ29ycG9yYXRpb24uIEFsbCByaWdodHMgcmVzZXJ2 ZWQuCiAgKgogICogVGhpcyBsaWJyYXJ5IGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0 cmlidXRlIGl0IGFuZC9vcgogICogbW9kaWZ5IGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05V IExpYnJhcnkgR2VuZXJhbCBQdWJsaWMKQEAgLTI1Niw2ICsyNTcsMTQgQEAgbmFtZXNwYWNlIFdU RiB7CiAgICAgfTsKICNlbmRpZgogCisjaWYgQ09NUElMRVJfU1VQUE9SVFMoQ1hYX1JWQUxVRV9S RUZFUkVOQ0VTKQordGVtcGxhdGU8Y2xhc3MgVD4KK3R5cGVuYW1lIFJlbW92ZVJlZmVyZW5jZTxU Pjo6VHlwZSYmIG1vdmUoVCYmIHYpCit7CisgICAgcmV0dXJuIHN0YXRpY19jYXN0PHR5cGVuYW1l IFJlbW92ZVJlZmVyZW5jZTxUPjo6VHlwZSYmPih2KTsKK30KKyNlbmRpZiAvLyAjaWYgQ09NUElM RVJfU1VQUE9SVFMoQ1hYX1JWQUxVRV9SRUZFUkVOQ0VTKQorCiB9IC8vIG5hbWVzcGFjZSBXVEYK IAogI2VuZGlmIC8vIFR5cGVUcmFpdHNfaApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvdGV4 dC9BdG9taWNTdHJpbmcuaCBiL1NvdXJjZS9XVEYvd3RmL3RleHQvQXRvbWljU3RyaW5nLmgKaW5k ZXggOTU1NTE4My4uNDYwN2M2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvdGV4dC9BdG9t aWNTdHJpbmcuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L0F0b21pY1N0cmluZy5oCkBAIC03 NiwxMiArNzYsMTAgQEAgcHVibGljOgogI2lmIENPTVBJTEVSX1NVUFBPUlRTKENYWF9SVkFMVUVf UkVGRVJFTkNFUykKICAgICAvLyBXZSBoYXZlIHRvIGRlY2xhcmUgdGhlIGNvcHkgY29uc3RydWN0 b3IgYW5kIGNvcHkgYXNzaWdubWVudCBvcGVyYXRvciBhcyB3ZWxsLCBvdGhlcndpc2UKICAgICAv LyB0aGV5J2xsIGJlIGltcGxpY2l0bHkgZGVsZXRlZCBieSBhZGRpbmcgdGhlIG1vdmUgY29uc3Ry dWN0b3IgYW5kIG1vdmUgYXNzaWdubWVudCBvcGVyYXRvci4KLSAgICAvLyBGSVhNRTogSW5zdGVh ZCBvZiBleHBsaWNpdGx5IGNhc3RpbmcgdG8gU3RyaW5nJiYgaGVyZSwgd2Ugc2hvdWxkIHVzZSBz dGQ6Om1vdmUsIGJ1dCB0aGF0IHJlcXVpcmVzIHVzIHRvCi0gICAgLy8gaGF2ZSBhIHN0YW5kYXJk IGxpYnJhcnkgdGhhdCBzdXBwb3J0cyBtb3ZlIHNlbWFudGljcy4KICAgICBBdG9taWNTdHJpbmco Y29uc3QgQXRvbWljU3RyaW5nJiBvdGhlcikgOiBtX3N0cmluZyhvdGhlci5tX3N0cmluZykgeyB9 Ci0gICAgQXRvbWljU3RyaW5nKEF0b21pY1N0cmluZyYmIG90aGVyKSA6IG1fc3RyaW5nKHN0YXRp Y19jYXN0PFN0cmluZyYmPihvdGhlci5tX3N0cmluZykpIHsgfQorICAgIEF0b21pY1N0cmluZyhB dG9taWNTdHJpbmcmJiBvdGhlcikgOiBtX3N0cmluZyhXVEY6Om1vdmUob3RoZXIubV9zdHJpbmcp KSB7IH0KICAgICBBdG9taWNTdHJpbmcmIG9wZXJhdG9yPShjb25zdCBBdG9taWNTdHJpbmcmIG90 aGVyKSB7IG1fc3RyaW5nID0gb3RoZXIubV9zdHJpbmc7IHJldHVybiAqdGhpczsgfQotICAgIEF0 b21pY1N0cmluZyYgb3BlcmF0b3I9KEF0b21pY1N0cmluZyYmIG90aGVyKSB7IG1fc3RyaW5nID0g c3RhdGljX2Nhc3Q8U3RyaW5nJiY+KG90aGVyLm1fc3RyaW5nKTsgcmV0dXJuICp0aGlzOyB9Cisg ICAgQXRvbWljU3RyaW5nJiBvcGVyYXRvcj0oQXRvbWljU3RyaW5nJiYgb3RoZXIpIHsgbV9zdHJp bmcgPSBXVEY6Om1vdmUob3RoZXIubV9zdHJpbmcpOyByZXR1cm4gKnRoaXM7IH0KICNlbmRpZgog CiAgICAgLy8gSGFzaCB0YWJsZSBkZWxldGVkIHZhbHVlcywgd2hpY2ggYXJlIG9ubHkgY29uc3Ry dWN0ZWQgYW5kIG5ldmVyIGNvcGllZCBvciBkZXN0cm95ZWQuCg== 199631 2013-04-25 01:28:10 -0700 2013-04-25 07:41:02 -0700 patch v3 bug115102_v3 text/plain 2462 mikhail.pozdnyakov Y29tbWl0IDkyYzNkYjBiODk1ZGI2NDliZWRjMTU2NWYyYjBhMjBkODJkODhiNTIKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg VGh1IEFwciAyNSAxMDo0MjoxNSAyMDEzICswMzAwCgogICAgYnVnMTE1MTAyCgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dURi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwppbmRleCBlNGY2 OGI0Li5hNzI3ZTkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA0LTI1ICBNaWtoYWlsIFBv emRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgorCisgICAgICAgIFVzZSBz dGQ6Om1vdmUgaW4gQXRvbWljU3RyaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMTUxMDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBVc2Ugc3RkOjptb3ZlIGluIEF0b21pY1N0cmluZyBpbnN0ZWFkIG9m IGRpcmVjdCBjYXN0aW5nIHRvIHJ2YWx1ZSByZWZlcmVuY2VzLgorCisgICAgICAgICogd3RmL3Rl eHQvQXRvbWljU3RyaW5nLmg6CisgICAgICAgIChBdG9taWNTdHJpbmcpOgorICAgICAgICAoV1RG OjpBdG9taWNTdHJpbmc6OkF0b21pY1N0cmluZyk6CisgICAgICAgIChXVEY6OkF0b21pY1N0cmlu Zzo6b3BlcmF0b3I9KToKKwogMjAxMy0wNC0yMyAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBw bGUuY29tPgogCiAgICAgICAgIEZpbGxlZCBvdXQgbW9yZSBjYXNlcyBvZiBicmFuY2ggZm9sZGlu ZyBpbiBieXRlY29kZSB3aGVuIGVtaXR0aW5nIGV4cHJlc3Npb25zIGludG8gYSBicmFuY2hpbmcg Y29udGV4dApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvdGV4dC9BdG9taWNTdHJpbmcuaCBi L1NvdXJjZS9XVEYvd3RmL3RleHQvQXRvbWljU3RyaW5nLmgKaW5kZXggOTU1NTE4My4uODZmYzgz ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvdGV4dC9BdG9taWNTdHJpbmcuaAorKysgYi9T b3VyY2UvV1RGL3d0Zi90ZXh0L0F0b21pY1N0cmluZy5oCkBAIC0yMSw2ICsyMSwxMCBAQAogI2lm bmRlZiBBdG9taWNTdHJpbmdfaAogI2RlZmluZSBBdG9taWNTdHJpbmdfaAogCisjaWYgQ09NUElM RVJfU1VQUE9SVFMoQ1hYX1JWQUxVRV9SRUZFUkVOQ0VTKQorI2luY2x1ZGUgPHV0aWxpdHk+Cisj ZW5kaWYKKwogI2luY2x1ZGUgPHd0Zi90ZXh0L0F0b21pY1N0cmluZ0ltcGwuaD4KICNpbmNsdWRl IDx3dGYvdGV4dC9XVEZTdHJpbmcuaD4KIApAQCAtNzYsMTIgKzgwLDEwIEBAIHB1YmxpYzoKICNp ZiBDT01QSUxFUl9TVVBQT1JUUyhDWFhfUlZBTFVFX1JFRkVSRU5DRVMpCiAgICAgLy8gV2UgaGF2 ZSB0byBkZWNsYXJlIHRoZSBjb3B5IGNvbnN0cnVjdG9yIGFuZCBjb3B5IGFzc2lnbm1lbnQgb3Bl cmF0b3IgYXMgd2VsbCwgb3RoZXJ3aXNlCiAgICAgLy8gdGhleSdsbCBiZSBpbXBsaWNpdGx5IGRl bGV0ZWQgYnkgYWRkaW5nIHRoZSBtb3ZlIGNvbnN0cnVjdG9yIGFuZCBtb3ZlIGFzc2lnbm1lbnQg b3BlcmF0b3IuCi0gICAgLy8gRklYTUU6IEluc3RlYWQgb2YgZXhwbGljaXRseSBjYXN0aW5nIHRv IFN0cmluZyYmIGhlcmUsIHdlIHNob3VsZCB1c2Ugc3RkOjptb3ZlLCBidXQgdGhhdCByZXF1aXJl cyB1cyB0bwotICAgIC8vIGhhdmUgYSBzdGFuZGFyZCBsaWJyYXJ5IHRoYXQgc3VwcG9ydHMgbW92 ZSBzZW1hbnRpY3MuCiAgICAgQXRvbWljU3RyaW5nKGNvbnN0IEF0b21pY1N0cmluZyYgb3RoZXIp IDogbV9zdHJpbmcob3RoZXIubV9zdHJpbmcpIHsgfQotICAgIEF0b21pY1N0cmluZyhBdG9taWNT dHJpbmcmJiBvdGhlcikgOiBtX3N0cmluZyhzdGF0aWNfY2FzdDxTdHJpbmcmJj4ob3RoZXIubV9z dHJpbmcpKSB7IH0KKyAgICBBdG9taWNTdHJpbmcoQXRvbWljU3RyaW5nJiYgb3RoZXIpIDogbV9z dHJpbmcoc3RkOjptb3ZlKG90aGVyLm1fc3RyaW5nKSkgeyB9CiAgICAgQXRvbWljU3RyaW5nJiBv cGVyYXRvcj0oY29uc3QgQXRvbWljU3RyaW5nJiBvdGhlcikgeyBtX3N0cmluZyA9IG90aGVyLm1f c3RyaW5nOyByZXR1cm4gKnRoaXM7IH0KLSAgICBBdG9taWNTdHJpbmcmIG9wZXJhdG9yPShBdG9t aWNTdHJpbmcmJiBvdGhlcikgeyBtX3N0cmluZyA9IHN0YXRpY19jYXN0PFN0cmluZyYmPihvdGhl ci5tX3N0cmluZyk7IHJldHVybiAqdGhpczsgfQorICAgIEF0b21pY1N0cmluZyYgb3BlcmF0b3I9 KEF0b21pY1N0cmluZyYmIG90aGVyKSB7IG1fc3RyaW5nID0gc3RkOjptb3ZlKG90aGVyLm1fc3Ry aW5nKTsgcmV0dXJuICp0aGlzOyB9CiAjZW5kaWYKIAogICAgIC8vIEhhc2ggdGFibGUgZGVsZXRl ZCB2YWx1ZXMsIHdoaWNoIGFyZSBvbmx5IGNvbnN0cnVjdGVkIGFuZCBuZXZlciBjb3BpZWQgb3Ig ZGVzdHJveWVkLgo= 199660 2013-04-25 07:41:02 -0700 2013-04-25 08:16:53 -0700 to be landed bug115102_v4 text/plain 2406 mikhail.pozdnyakov Y29tbWl0IDNkYzIyMTY5OGJkOTYyYWJkOWFmMjgxODRmOTI1ZGZmMmU2NDRhNDQKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg VGh1IEFwciAyNSAxMDo0MjoxNSAyMDEzICswMzAwCgogICAgYnVnMTE1MTAyCgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dURi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwppbmRleCBlNGY2 OGI0Li5mMWRiYjIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA0LTI1ICBNaWtoYWlsIFBv emRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgorCisgICAgICAgIFVzZSBz dGQ6Om1vdmUgaW4gQXRvbWljU3RyaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMTUxMDIKKworICAgICAgICBSZXZpZXdlZCBieSBBbmRlcnMgQ2Fy bHNzb24uCisKKyAgICAgICAgVXNlIHN0ZDo6bW92ZSBpbiBBdG9taWNTdHJpbmcgaW5zdGVhZCBv ZiBkaXJlY3QgY2FzdGluZyB0byBydmFsdWUgcmVmZXJlbmNlcy4KKworICAgICAgICAqIHd0Zi90 ZXh0L0F0b21pY1N0cmluZy5oOgorICAgICAgICAoQXRvbWljU3RyaW5nKToKKyAgICAgICAgKFdU Rjo6QXRvbWljU3RyaW5nOjpBdG9taWNTdHJpbmcpOgorICAgICAgICAoV1RGOjpBdG9taWNTdHJp bmc6Om9wZXJhdG9yPSk6CisKIDIwMTMtMDQtMjMgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFw cGxlLmNvbT4KIAogICAgICAgICBGaWxsZWQgb3V0IG1vcmUgY2FzZXMgb2YgYnJhbmNoIGZvbGRp bmcgaW4gYnl0ZWNvZGUgd2hlbiBlbWl0dGluZyBleHByZXNzaW9ucyBpbnRvIGEgYnJhbmNoaW5n IGNvbnRleHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3RleHQvQXRvbWljU3RyaW5nLmgg Yi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L0F0b21pY1N0cmluZy5oCmluZGV4IDk1NTUxODMuLjNkN2I2 NTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL3RleHQvQXRvbWljU3RyaW5nLmgKKysrIGIv U291cmNlL1dURi93dGYvdGV4dC9BdG9taWNTdHJpbmcuaApAQCAtMjEsNiArMjEsNyBAQAogI2lm bmRlZiBBdG9taWNTdHJpbmdfaAogI2RlZmluZSBBdG9taWNTdHJpbmdfaAogCisjaW5jbHVkZSA8 dXRpbGl0eT4KICNpbmNsdWRlIDx3dGYvdGV4dC9BdG9taWNTdHJpbmdJbXBsLmg+CiAjaW5jbHVk ZSA8d3RmL3RleHQvV1RGU3RyaW5nLmg+CiAKQEAgLTc2LDEyICs3NywxMCBAQCBwdWJsaWM6CiAj aWYgQ09NUElMRVJfU1VQUE9SVFMoQ1hYX1JWQUxVRV9SRUZFUkVOQ0VTKQogICAgIC8vIFdlIGhh dmUgdG8gZGVjbGFyZSB0aGUgY29weSBjb25zdHJ1Y3RvciBhbmQgY29weSBhc3NpZ25tZW50IG9w ZXJhdG9yIGFzIHdlbGwsIG90aGVyd2lzZQogICAgIC8vIHRoZXknbGwgYmUgaW1wbGljaXRseSBk ZWxldGVkIGJ5IGFkZGluZyB0aGUgbW92ZSBjb25zdHJ1Y3RvciBhbmQgbW92ZSBhc3NpZ25tZW50 IG9wZXJhdG9yLgotICAgIC8vIEZJWE1FOiBJbnN0ZWFkIG9mIGV4cGxpY2l0bHkgY2FzdGluZyB0 byBTdHJpbmcmJiBoZXJlLCB3ZSBzaG91bGQgdXNlIHN0ZDo6bW92ZSwgYnV0IHRoYXQgcmVxdWly ZXMgdXMgdG8KLSAgICAvLyBoYXZlIGEgc3RhbmRhcmQgbGlicmFyeSB0aGF0IHN1cHBvcnRzIG1v dmUgc2VtYW50aWNzLgogICAgIEF0b21pY1N0cmluZyhjb25zdCBBdG9taWNTdHJpbmcmIG90aGVy KSA6IG1fc3RyaW5nKG90aGVyLm1fc3RyaW5nKSB7IH0KLSAgICBBdG9taWNTdHJpbmcoQXRvbWlj U3RyaW5nJiYgb3RoZXIpIDogbV9zdHJpbmcoc3RhdGljX2Nhc3Q8U3RyaW5nJiY+KG90aGVyLm1f c3RyaW5nKSkgeyB9CisgICAgQXRvbWljU3RyaW5nKEF0b21pY1N0cmluZyYmIG90aGVyKSA6IG1f c3RyaW5nKHN0ZDo6bW92ZShvdGhlci5tX3N0cmluZykpIHsgfQogICAgIEF0b21pY1N0cmluZyYg b3BlcmF0b3I9KGNvbnN0IEF0b21pY1N0cmluZyYgb3RoZXIpIHsgbV9zdHJpbmcgPSBvdGhlci5t X3N0cmluZzsgcmV0dXJuICp0aGlzOyB9Ci0gICAgQXRvbWljU3RyaW5nJiBvcGVyYXRvcj0oQXRv bWljU3RyaW5nJiYgb3RoZXIpIHsgbV9zdHJpbmcgPSBzdGF0aWNfY2FzdDxTdHJpbmcmJj4ob3Ro ZXIubV9zdHJpbmcpOyByZXR1cm4gKnRoaXM7IH0KKyAgICBBdG9taWNTdHJpbmcmIG9wZXJhdG9y PShBdG9taWNTdHJpbmcmJiBvdGhlcikgeyBtX3N0cmluZyA9IHN0ZDo6bW92ZShvdGhlci5tX3N0 cmluZyk7IHJldHVybiAqdGhpczsgfQogI2VuZGlmCiAKICAgICAvLyBIYXNoIHRhYmxlIGRlbGV0 ZWQgdmFsdWVzLCB3aGljaCBhcmUgb25seSBjb25zdHJ1Y3RlZCBhbmQgbmV2ZXIgY29waWVkIG9y IGRlc3Ryb3llZC4K