115095 2013-04-24 01:03:47 -0700 [EFL][WK2] WebKitTestRunner failures due to IconDatabase assertions 2013-04-29 23:56:40 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez alexander.shalamov benjamin cgarcia commit-queue d-r gustavo gyuyoung.kim kenneth laszlo.gombos lucas.de.marchi mrobinson pnormand tonikitoo oldest_to_newest 880384 0 cdumez 2013-04-24 01:03:47 -0700 We recently started hitting assertion in the IconDatabase code such as this one: crash log for WebKitTestRunner (pid 1194): STDOUT: <empty> STDERR: ERROR: Preparing statement DELETE FROM PageURL WHERE url = (?); failed STDERR: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebCore/loader/icon/IconDatabase.cpp(1881) : void WebCore::readySQLiteStatement(WTF::OwnPtr<WebCore::SQLiteStatement>&, WebCore::SQLiteDatabase&, const WTF::String&) STDERR: ASSERTION FAILED: m_isPrepared STDERR: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebCore/platform/sql/SQLiteStatement.cpp(198) : int WebCore::SQLiteStatement::bindText(int, const WTF::String&) STDERR: 1 0x7f7546224025 WebCore::SQLiteStatement::bindText(int, WTF::String const&) STDERR: 2 0x7f7545fc99c1 WebCore::IconDatabase::removePageURLFromSQLDatabase(WTF::String const&) STDERR: 3 0x7f7545fc884b WebCore::IconDatabase::writeToDatabase() STDERR: 4 0x7f7545fc7332 WebCore::IconDatabase::syncThreadMainLoop() STDERR: 5 0x7f7545fc5978 WebCore::IconDatabase::iconDatabaseSyncThread() STDERR: 6 0x7f7545fc55dc WebCore::IconDatabase::iconDatabaseSyncThreadStart(void*) STDERR: 7 0x7f754a4fc67d STDERR: 8 0x7f754a51f1a2 STDERR: 9 0x7f7540f00e9a STDERR: 10 0x7f7540717cbd clone STDERR: LEAK: 18 CachedResource It started happening after <http://trac.webkit.org/changeset/148886>. 880387 1 199402 cdumez 2013-04-24 01:09:16 -0700 Created attachment 199402 Patch 880388 2 199403 cdumez 2013-04-24 01:12:12 -0700 Created attachment 199403 Patch Fix typo in Changelog. 880389 3 cdumez 2013-04-24 01:17:08 -0700 This started happening <http://trac.webkit.org/changeset/148886> because the EFL port now properly uses the given diskCacheDirectory WebProcess parameter which is the DumpRenderTree temporary folder in the WKTR case. Before that, we were ignoring the given cache path and using the default one for the platform. Therefore, the libsoup cache was in a different folder than the rest. 880392 4 cdumez 2013-04-24 01:27:09 -0700 FYI, We have about 80 crashes on the debug build bot due to this issue: http://build.webkit.org/results/EFL%20Linux%2064-bit%20Debug%20WK2/r149016%20(11666)/results.html 880427 5 199403 tonikitoo 2013-04-24 04:20:50 -0700 Comment on attachment 199403 Patch It looks reasonable. Is it a new problem, though? 880430 6 cdumez 2013-04-24 04:31:23 -0700 (In reply to comment #5) > (From update of attachment 199403 [details]) > It looks reasonable. Is it a new problem, though? It started happening because of the fix in: <http://trac.webkit.org/changeset/148886> We did not see the problem before the fix because EFL was not using the path provided by WKTR for the cache. Please see my earlier comment: https://bugs.webkit.org/show_bug.cgi?id=115095#c3 880436 7 199403 commit-queue 2013-04-24 05:00:32 -0700 Comment on attachment 199403 Patch Clearing flags on attachment: 199403 Committed r149027: <http://trac.webkit.org/changeset/149027> 880437 8 commit-queue 2013-04-24 05:00:40 -0700 All reviewed patches have been landed. Closing bug. 882447 9 benjamin 2013-04-28 20:57:40 -0700 Please don't mark patches as "EFL" if they are not EFL specific. That makes it harder to track changes. 882940 10 cdumez 2013-04-29 23:56:40 -0700 (In reply to comment #9) > Please don't mark patches as "EFL" if they are not EFL specific. That makes it harder to track changes. Sorry about that. The bug was EFL specific but the patch is indeed "generic", I forgot to update the tags. 199402 2013-04-24 01:09:16 -0700 2013-04-24 01:12:12 -0700 Patch 115095_cache_path_wktr.patch text/plain 3080 cdumez ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyYzY1 ZGVhLi5hMjk5ZThmIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTMtMDQtMjQgIENocmlzdG9waGUgRHVtZXogIDxj aC5kdW1lekBzaXNhLnNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdW1dLMl0gV2ViS2l0VGVz dFJ1bm5lciBmYWlsdXJlcyBkdWUgdG8gSWNvbkRhdGFiYXNlIGFzc2VydGlvbnMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNTA5NQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBkaWZmZXJlbnQgc3Vi Zm9sZGVycyB1bmRlciBEdW1wUmVuZGVyVHJlZSBUZW1wIGZvbGRlciBmb3IgZXZlcnkKKyAgICAg ICAgZnVuY3Rpb25hbGl0eSAoaWNvbiBkYXRhYmFzZSwgY2FjaGUsIGxvY2Fsc3RvcmFnZSwgLi4u KS4gVGhpcyBtYWtlcworICAgICAgICBzdXJlIHRoZXJlIGlzIG5vIGNvbmZsaWN0IGJldHdlZW4g dGhlIGZ1bmN0aW9uYWxpdGllcy4KKworICAgICAgICBJbiBFRkwncyBjYXNlLCBsaWJzb3VwIGNh Y2hlIHdhcyBjYXVzZXMgcHJvYmxlbXMgZm9yIHRoZSBpY29uCisgICAgICAgIGRhdGFiYXNlIGlm IHNoYXJpbmcgdGhlIHNhbWUgZm9sZGVyLgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9U ZXN0Q29udHJvbGxlci5jcHA6CisgICAgICAgIChXVFI6OlRlc3RDb250cm9sbGVyOjppbml0aWFs aXplKToKKwogMjAxMy0wNC0yMyAgRGF2aWQgR3JvZ2FuICA8ZGdyb2dhbkBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgVW5yZXZpZXdlZC4gUmVtb3ZlIG15c2VsZiBmcm9tIHdhdGNobGlzdC4KZGlm ZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwIGIvVG9v bHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKaW5kZXggYmU3NjIwZi4uYTMx YjQ4ZSAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5j cHAKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKQEAgLTM0 MSwxMSArMzQxLDcgQEAgdm9pZCBUZXN0Q29udHJvbGxlcjo6aW5pdGlhbGl6ZShpbnQgYXJnYywg Y29uc3QgY2hhciogYXJndltdKQogICAgIG1fZ2VvbG9jYXRpb25Qcm92aWRlciA9IGFkb3B0UHRy KG5ldyBHZW9sb2NhdGlvblByb3ZpZGVyTW9jayhtX2NvbnRleHQuZ2V0KCkpKTsKIAogICAgIGlm IChjb25zdCBjaGFyKiBkdW1wUmVuZGVyVHJlZVRlbXAgPSBsaWJyYXJ5UGF0aEZvclRlc3Rpbmco KSkgewotICAgICAgICBXS1JldGFpblB0cjxXS1N0cmluZ1JlZj4gZHVtcFJlbmRlclRyZWVUZW1w V0soQWRvcHRXSywgV0tTdHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmcoZHVtcFJlbmRlclRyZWVU ZW1wKSk7Ci0gICAgICAgIFdLQ29udGV4dFNldERhdGFiYXNlRGlyZWN0b3J5KG1fY29udGV4dC5n ZXQoKSwgZHVtcFJlbmRlclRyZWVUZW1wV0suZ2V0KCkpOwotICAgICAgICBXS0NvbnRleHRTZXRM b2NhbFN0b3JhZ2VEaXJlY3RvcnkobV9jb250ZXh0LmdldCgpLCBkdW1wUmVuZGVyVHJlZVRlbXBX Sy5nZXQoKSk7Ci0gICAgICAgIFdLQ29udGV4dFNldERpc2tDYWNoZURpcmVjdG9yeShtX2NvbnRl eHQuZ2V0KCksIGR1bXBSZW5kZXJUcmVlVGVtcFdLLmdldCgpKTsKLSAgICAgICAgV0tDb250ZXh0 U2V0Q29va2llU3RvcmFnZURpcmVjdG9yeShtX2NvbnRleHQuZ2V0KCksIGR1bXBSZW5kZXJUcmVl VGVtcFdLLmdldCgpKTsKKyAgICAgICAgU3RyaW5nIHRlbXBvcmFyeUZvbGRlciA9IFN0cmluZzo6 ZnJvbVVURjgoZHVtcFJlbmRlclRyZWVUZW1wKTsKIAogICAgICAgICAvLyBXZWJDb3JlOjpwYXRo QnlBcHBlbmRpbmdDb21wb25lbnQgaXMgbm90IHVzZWQgaGVyZSBiZWNhdXNlIG9mIHRoZSBuYW1l c3BhY2UsCiAgICAgICAgIC8vIHdoaWNoIGxlYWRzIHVzIHRvIHRoaXMgdWdseSAjaWZkZWYgYW5k IGZpbGUgcGF0aCBjb25jYXRlbmF0aW9uLgpAQCAtMzU0LDggKzM1MCwxMiBAQCB2b2lkIFRlc3RD b250cm9sbGVyOjppbml0aWFsaXplKGludCBhcmdjLCBjb25zdCBjaGFyKiBhcmd2W10pCiAjZWxz ZQogICAgICAgICBjb25zdCBjaGFyIHNlcGFyYXRvciA9ICcvJzsKICNlbmRpZgotICAgICAgICBT dHJpbmcgaWNvbkRhdGFiYXNlRmlsZVRlbXAgPSBTdHJpbmc6OmZyb21VVEY4KGR1bXBSZW5kZXJU cmVlVGVtcCkgKyBzZXBhcmF0b3IgKyBTdHJpbmcoQVNDSUlMaXRlcmFsKCJXZWJwYWdlSWNvbnMu ZGIiKSk7Ci0gICAgICAgIFdLQ29udGV4dFNldEljb25EYXRhYmFzZVBhdGgobV9jb250ZXh0Lmdl dCgpLCB0b1dLKGljb25EYXRhYmFzZUZpbGVUZW1wKS5nZXQoKSk7CisKKyAgICAgICAgV0tDb250 ZXh0U2V0RGF0YWJhc2VEaXJlY3RvcnkobV9jb250ZXh0LmdldCgpLCB0b1dLKHRlbXBvcmFyeUZv bGRlciArIHNlcGFyYXRvciArICJEYXRhYmFzZXMiKS5nZXQoKSk7CisgICAgICAgIFdLQ29udGV4 dFNldExvY2FsU3RvcmFnZURpcmVjdG9yeShtX2NvbnRleHQuZ2V0KCksIHRvV0sodGVtcG9yYXJ5 Rm9sZGVyICsgc2VwYXJhdG9yICsgIkxvY2FsU3RvcmFnZSIpLmdldCgpKTsKKyAgICAgICAgV0tD b250ZXh0U2V0RGlza0NhY2hlRGlyZWN0b3J5KG1fY29udGV4dC5nZXQoKSwgdG9XSyh0ZW1wb3Jh cnlGb2xkZXIgKyBzZXBhcmF0b3IgKyAiQ2FjaGUiKS5nZXQoKSk7CisgICAgICAgIFdLQ29udGV4 dFNldENvb2tpZVN0b3JhZ2VEaXJlY3RvcnkobV9jb250ZXh0LmdldCgpLCB0b1dLKHRlbXBvcmFy eUZvbGRlciArIHNlcGFyYXRvciArICJDb29raWVzIikuZ2V0KCkpOworICAgICAgICBXS0NvbnRl eHRTZXRJY29uRGF0YWJhc2VQYXRoKG1fY29udGV4dC5nZXQoKSwgdG9XSyh0ZW1wb3JhcnlGb2xk ZXIgKyBzZXBhcmF0b3IgKyAiSWNvbkRhdGFiYXNlIiArIHNlcGFyYXRvciArICJXZWJwYWdlSWNv bnMuZGIiKS5nZXQoKSk7CiAgICAgfQogCiAgICAgcGxhdGZvcm1Jbml0aWFsaXplQ29udGV4dCgp Owo= 199403 2013-04-24 01:12:12 -0700 2013-04-24 05:00:32 -0700 Patch 115095_cache_path_wktr.patch text/plain 3081 cdumez ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyYzY1 ZGVhLi4xNTZkMGQ0IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTMtMDQtMjQgIENocmlzdG9waGUgRHVtZXogIDxj aC5kdW1lekBzaXNhLnNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdW1dLMl0gV2ViS2l0VGVz dFJ1bm5lciBmYWlsdXJlcyBkdWUgdG8gSWNvbkRhdGFiYXNlIGFzc2VydGlvbnMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNTA5NQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBkaWZmZXJlbnQgc3Vi Zm9sZGVycyB1bmRlciBEdW1wUmVuZGVyVHJlZSBUZW1wIGZvbGRlciBmb3IgZXZlcnkKKyAgICAg ICAgZnVuY3Rpb25hbGl0eSAoaWNvbiBkYXRhYmFzZSwgY2FjaGUsIGxvY2Fsc3RvcmFnZSwgLi4u KS4gVGhpcyBtYWtlcworICAgICAgICBzdXJlIHRoZXJlIGlzIG5vIGNvbmZsaWN0IGJldHdlZW4g dGhlIGZ1bmN0aW9uYWxpdGllcy4KKworICAgICAgICBJbiBFRkwncyBjYXNlLCBsaWJzb3VwIGNh Y2hlIHdhcyBjYXVzaW5nIHByb2JsZW1zIGZvciB0aGUgaWNvbgorICAgICAgICBkYXRhYmFzZSBp ZiBzaGFyaW5nIHRoZSBzYW1lIGZvbGRlci4KKworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIv VGVzdENvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV1RSOjpUZXN0Q29udHJvbGxlcjo6aW5pdGlh bGl6ZSk6CisKIDIwMTMtMDQtMjMgIERhdmlkIEdyb2dhbiAgPGRncm9nYW5AY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFVucmV2aWV3ZWQuIFJlbW92ZSBteXNlbGYgZnJvbSB3YXRjaGxpc3QuCmRp ZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcCBiL1Rv b2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCmluZGV4IGJlNzYyMGYuLmEz MWI0OGUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIu Y3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCkBAIC0z NDEsMTEgKzM0MSw3IEBAIHZvaWQgVGVzdENvbnRyb2xsZXI6OmluaXRpYWxpemUoaW50IGFyZ2Ms IGNvbnN0IGNoYXIqIGFyZ3ZbXSkKICAgICBtX2dlb2xvY2F0aW9uUHJvdmlkZXIgPSBhZG9wdFB0 cihuZXcgR2VvbG9jYXRpb25Qcm92aWRlck1vY2sobV9jb250ZXh0LmdldCgpKSk7CiAKICAgICBp ZiAoY29uc3QgY2hhciogZHVtcFJlbmRlclRyZWVUZW1wID0gbGlicmFyeVBhdGhGb3JUZXN0aW5n KCkpIHsKLSAgICAgICAgV0tSZXRhaW5QdHI8V0tTdHJpbmdSZWY+IGR1bXBSZW5kZXJUcmVlVGVt cFdLKEFkb3B0V0ssIFdLU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKGR1bXBSZW5kZXJUcmVl VGVtcCkpOwotICAgICAgICBXS0NvbnRleHRTZXREYXRhYmFzZURpcmVjdG9yeShtX2NvbnRleHQu Z2V0KCksIGR1bXBSZW5kZXJUcmVlVGVtcFdLLmdldCgpKTsKLSAgICAgICAgV0tDb250ZXh0U2V0 TG9jYWxTdG9yYWdlRGlyZWN0b3J5KG1fY29udGV4dC5nZXQoKSwgZHVtcFJlbmRlclRyZWVUZW1w V0suZ2V0KCkpOwotICAgICAgICBXS0NvbnRleHRTZXREaXNrQ2FjaGVEaXJlY3RvcnkobV9jb250 ZXh0LmdldCgpLCBkdW1wUmVuZGVyVHJlZVRlbXBXSy5nZXQoKSk7Ci0gICAgICAgIFdLQ29udGV4 dFNldENvb2tpZVN0b3JhZ2VEaXJlY3RvcnkobV9jb250ZXh0LmdldCgpLCBkdW1wUmVuZGVyVHJl ZVRlbXBXSy5nZXQoKSk7CisgICAgICAgIFN0cmluZyB0ZW1wb3JhcnlGb2xkZXIgPSBTdHJpbmc6 OmZyb21VVEY4KGR1bXBSZW5kZXJUcmVlVGVtcCk7CiAKICAgICAgICAgLy8gV2ViQ29yZTo6cGF0 aEJ5QXBwZW5kaW5nQ29tcG9uZW50IGlzIG5vdCB1c2VkIGhlcmUgYmVjYXVzZSBvZiB0aGUgbmFt ZXNwYWNlLAogICAgICAgICAvLyB3aGljaCBsZWFkcyB1cyB0byB0aGlzIHVnbHkgI2lmZGVmIGFu ZCBmaWxlIHBhdGggY29uY2F0ZW5hdGlvbi4KQEAgLTM1NCw4ICszNTAsMTIgQEAgdm9pZCBUZXN0 Q29udHJvbGxlcjo6aW5pdGlhbGl6ZShpbnQgYXJnYywgY29uc3QgY2hhciogYXJndltdKQogI2Vs c2UKICAgICAgICAgY29uc3QgY2hhciBzZXBhcmF0b3IgPSAnLyc7CiAjZW5kaWYKLSAgICAgICAg U3RyaW5nIGljb25EYXRhYmFzZUZpbGVUZW1wID0gU3RyaW5nOjpmcm9tVVRGOChkdW1wUmVuZGVy VHJlZVRlbXApICsgc2VwYXJhdG9yICsgU3RyaW5nKEFTQ0lJTGl0ZXJhbCgiV2VicGFnZUljb25z LmRiIikpOwotICAgICAgICBXS0NvbnRleHRTZXRJY29uRGF0YWJhc2VQYXRoKG1fY29udGV4dC5n ZXQoKSwgdG9XSyhpY29uRGF0YWJhc2VGaWxlVGVtcCkuZ2V0KCkpOworCisgICAgICAgIFdLQ29u dGV4dFNldERhdGFiYXNlRGlyZWN0b3J5KG1fY29udGV4dC5nZXQoKSwgdG9XSyh0ZW1wb3JhcnlG b2xkZXIgKyBzZXBhcmF0b3IgKyAiRGF0YWJhc2VzIikuZ2V0KCkpOworICAgICAgICBXS0NvbnRl eHRTZXRMb2NhbFN0b3JhZ2VEaXJlY3RvcnkobV9jb250ZXh0LmdldCgpLCB0b1dLKHRlbXBvcmFy eUZvbGRlciArIHNlcGFyYXRvciArICJMb2NhbFN0b3JhZ2UiKS5nZXQoKSk7CisgICAgICAgIFdL Q29udGV4dFNldERpc2tDYWNoZURpcmVjdG9yeShtX2NvbnRleHQuZ2V0KCksIHRvV0sodGVtcG9y YXJ5Rm9sZGVyICsgc2VwYXJhdG9yICsgIkNhY2hlIikuZ2V0KCkpOworICAgICAgICBXS0NvbnRl eHRTZXRDb29raWVTdG9yYWdlRGlyZWN0b3J5KG1fY29udGV4dC5nZXQoKSwgdG9XSyh0ZW1wb3Jh cnlGb2xkZXIgKyBzZXBhcmF0b3IgKyAiQ29va2llcyIpLmdldCgpKTsKKyAgICAgICAgV0tDb250 ZXh0U2V0SWNvbkRhdGFiYXNlUGF0aChtX2NvbnRleHQuZ2V0KCksIHRvV0sodGVtcG9yYXJ5Rm9s ZGVyICsgc2VwYXJhdG9yICsgIkljb25EYXRhYmFzZSIgKyBzZXBhcmF0b3IgKyAiV2VicGFnZUlj b25zLmRiIikuZ2V0KCkpOwogICAgIH0KIAogICAgIHBsYXRmb3JtSW5pdGlhbGl6ZUNvbnRleHQo KTsK