115093 2013-04-24 00:28:28 -0700 Do not use static string in DiagnosticLoggingKeys 2013-04-24 12:45:34 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin jer.noble oldest_to_newest 880373 0 benjamin 2013-04-24 00:28:28 -0700 Do not use static string in DiagnosticLoggingKeys 880374 1 199398 benjamin 2013-04-24 00:30:23 -0700 Created attachment 199398 Patch 880420 2 199398 kling 2013-04-24 04:11:02 -0700 Comment on attachment 199398 Patch Sure. 880758 3 199398 benjamin 2013-04-24 12:45:32 -0700 Comment on attachment 199398 Patch Clearing flags on attachment: 199398 Committed r149057: <http://trac.webkit.org/changeset/149057> 880759 4 benjamin 2013-04-24 12:45:34 -0700 All reviewed patches have been landed. Closing bug. 199398 2013-04-24 00:30:23 -0700 2013-04-24 12:45:32 -0700 Patch bug-115093-20130424002946.patch text/plain 6817 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5MDE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmE5MmZlOWVlNmNkNWIz NTY0NTQ3NWI3NTU3NDRkMDU5MDI4NDQxOC4uYTc0NWY3OGQ4OWQ3MWVjOWRiY2FkODFlM2E5OTgw NmQ3ZjEwNjIxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEzLTA0LTI0ICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIERvIG5vdCB1c2Ug c3RhdGljIHN0cmluZyBpbiBEaWFnbm9zdGljTG9nZ2luZ0tleXMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNTA5MworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBjb2RlIGlzIG5vdCBob3QgZW5vdWdo IHRvIGp1c3RpZnkga2VlcGluZyB0aGUgbWVtb3J5IGFyb3VuZC4KKyAgICAgICAgVGhpcyByZW1v dmVzIDNrYiBmcm9tIHRoZSBiaW5hcnkgb24geDg2XzY0LgorCisgICAgICAgICogcGFnZS9EaWFn bm9zdGljTG9nZ2luZ0tleXMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RGlhZ25vc3RpY0xvZ2dp bmdLZXlzOjptZWRpYUxvYWRlZEtleSk6CisgICAgICAgIChXZWJDb3JlOjpEaWFnbm9zdGljTG9n Z2luZ0tleXM6Om1lZGlhTG9hZGluZ0ZhaWxlZEtleSk6CisgICAgICAgIChXZWJDb3JlOjpEaWFn bm9zdGljTG9nZ2luZ0tleXM6OnBsdWdpbkxvYWRlZEtleSk6CisgICAgICAgIChXZWJDb3JlOjpE aWFnbm9zdGljTG9nZ2luZ0tleXM6OnBsdWdpbkxvYWRpbmdGYWlsZWRLZXkpOgorICAgICAgICAo V2ViQ29yZTo6RGlhZ25vc3RpY0xvZ2dpbmdLZXlzOjpwYWdlQ29udGFpbnNQbHVnaW5LZXkpOgor ICAgICAgICAoV2ViQ29yZTo6RGlhZ25vc3RpY0xvZ2dpbmdLZXlzOjpwYWdlQ29udGFpbnNBdExl YXN0T25lUGx1Z2luS2V5KToKKyAgICAgICAgKFdlYkNvcmU6OkRpYWdub3N0aWNMb2dnaW5nS2V5 czo6cGFnZUNvbnRhaW5zTWVkaWFFbmdpbmVLZXkpOgorICAgICAgICAoV2ViQ29yZTo6RGlhZ25v c3RpY0xvZ2dpbmdLZXlzOjpwYWdlQ29udGFpbnNBdExlYXN0T25lTWVkaWFFbmdpbmVLZXkpOgor ICAgICAgICAoV2ViQ29yZTo6RGlhZ25vc3RpY0xvZ2dpbmdLZXlzOjpwYXNzS2V5KToKKyAgICAg ICAgKFdlYkNvcmU6OkRpYWdub3N0aWNMb2dnaW5nS2V5czo6ZmFpbEtleSk6CisgICAgICAgIChX ZWJDb3JlOjpEaWFnbm9zdGljTG9nZ2luZ0tleXM6Om5vb3BLZXkpOgorICAgICAgICAqIHBhZ2Uv RGlhZ25vc3RpY0xvZ2dpbmdLZXlzLmg6CisgICAgICAgIChEaWFnbm9zdGljTG9nZ2luZ0tleXMp OgorCiAyMDEzLTA0LTIzICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAg ICAgICBSZW1vdmUgVGV4dEZpZWxkRGVjb3JhdGlvbiBmZWF0dXJlCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0RpYWdub3N0aWNMb2dnaW5nS2V5cy5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wYWdlL0RpYWdub3N0aWNMb2dnaW5nS2V5cy5jcHAKaW5kZXggOGYzYjRkNjAzZTI3NDI2MGI4 NzJhNWI1NGFhZGM3ZjkwNGRhMTdiMy4uMWJhMmE2MmQ1OWUwNzgwMjViZjNmMzUyNzJmMGI2ZDE1 ZjIwYzMxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9EaWFnbm9zdGljTG9nZ2lu Z0tleXMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRGlhZ25vc3RpY0xvZ2dpbmdLZXlz LmNwcApAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMTIgQXBwbGUgSW5j LiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDEzIEFwcGxlIEluYy4g QWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNv dXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwg YXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAt MjgsNzAgKzI4LDU5IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotY29uc3QgU3RyaW5nJiBE aWFnbm9zdGljTG9nZ2luZ0tleXM6Om1lZGlhTG9hZGVkS2V5KCkKK1N0cmluZyBEaWFnbm9zdGlj TG9nZ2luZ0tleXM6Om1lZGlhTG9hZGVkS2V5KCkKIHsKLSAgICBERUZJTkVfU1RBVElDX0xPQ0FM KGNvbnN0IFN0cmluZywga2V5LCAoQVNDSUlMaXRlcmFsKCJtZWRpYUxvYWRlZCIpKSk7Ci0gICAg cmV0dXJuIGtleTsKKyAgICByZXR1cm4gQVNDSUlMaXRlcmFsKCJtZWRpYUxvYWRlZCIpOwogfQog Ci1jb25zdCBTdHJpbmcmIERpYWdub3N0aWNMb2dnaW5nS2V5czo6bWVkaWFMb2FkaW5nRmFpbGVk S2V5KCkKK1N0cmluZyBEaWFnbm9zdGljTG9nZ2luZ0tleXM6Om1lZGlhTG9hZGluZ0ZhaWxlZEtl eSgpCiB7Ci0gICAgREVGSU5FX1NUQVRJQ19MT0NBTChjb25zdCBTdHJpbmcsIGtleSwgKEFTQ0lJ TGl0ZXJhbCgibWVkaWFGYWlsZWRMb2FkaW5nIikpKTsKLSAgICByZXR1cm4ga2V5OworICAgIHJl dHVybiBBU0NJSUxpdGVyYWwoIm1lZGlhRmFpbGVkTG9hZGluZyIpOwogfQogCi1jb25zdCBTdHJp bmcmIERpYWdub3N0aWNMb2dnaW5nS2V5czo6cGx1Z2luTG9hZGVkS2V5KCkKK1N0cmluZyBEaWFn bm9zdGljTG9nZ2luZ0tleXM6OnBsdWdpbkxvYWRlZEtleSgpCiB7Ci0gICAgREVGSU5FX1NUQVRJ Q19MT0NBTChjb25zdCBTdHJpbmcsIGtleSwgKEFTQ0lJTGl0ZXJhbCgicGx1Z2luTG9hZGVkIikp KTsKLSAgICByZXR1cm4ga2V5OworICAgIHJldHVybiBBU0NJSUxpdGVyYWwoInBsdWdpbkxvYWRl ZCIpOwogfQogCi1jb25zdCBTdHJpbmcmIERpYWdub3N0aWNMb2dnaW5nS2V5czo6cGx1Z2luTG9h ZGluZ0ZhaWxlZEtleSgpCitTdHJpbmcgRGlhZ25vc3RpY0xvZ2dpbmdLZXlzOjpwbHVnaW5Mb2Fk aW5nRmFpbGVkS2V5KCkKIHsKLSAgICBERUZJTkVfU1RBVElDX0xPQ0FMKGNvbnN0IFN0cmluZywg a2V5LCAoQVNDSUlMaXRlcmFsKCJwbHVnaW5GYWlsZWRMb2FkaW5nIikpKTsKLSAgICByZXR1cm4g a2V5OworICAgIHJldHVybiBBU0NJSUxpdGVyYWwoInBsdWdpbkZhaWxlZExvYWRpbmciKTsKIH0K IAotY29uc3QgU3RyaW5nJiBEaWFnbm9zdGljTG9nZ2luZ0tleXM6OnBhZ2VDb250YWluc1BsdWdp bktleSgpCitTdHJpbmcgRGlhZ25vc3RpY0xvZ2dpbmdLZXlzOjpwYWdlQ29udGFpbnNQbHVnaW5L ZXkoKQogewotICAgIERFRklORV9TVEFUSUNfTE9DQUwoY29uc3QgU3RyaW5nLCBrZXksIChBU0NJ SUxpdGVyYWwoInBhZ2VDb250YWluc1BsdWdpbiIpKSk7Ci0gICAgcmV0dXJuIGtleTsKKyAgICBy ZXR1cm4gQVNDSUlMaXRlcmFsKCJwYWdlQ29udGFpbnNQbHVnaW4iKTsKIH0KIAotY29uc3QgU3Ry aW5nJiBEaWFnbm9zdGljTG9nZ2luZ0tleXM6OnBhZ2VDb250YWluc0F0TGVhc3RPbmVQbHVnaW5L ZXkoKQorU3RyaW5nIERpYWdub3N0aWNMb2dnaW5nS2V5czo6cGFnZUNvbnRhaW5zQXRMZWFzdE9u ZVBsdWdpbktleSgpCiB7Ci0gICAgREVGSU5FX1NUQVRJQ19MT0NBTChjb25zdCBTdHJpbmcsIGtl eSwgKEFTQ0lJTGl0ZXJhbCgicGFnZUNvbnRhaW5zQXRMZWFzdE9uZVBsdWdpbiIpKSk7Ci0gICAg cmV0dXJuIGtleTsKKyAgICByZXR1cm4gQVNDSUlMaXRlcmFsKCJwYWdlQ29udGFpbnNBdExlYXN0 T25lUGx1Z2luIik7CiB9CiAKLWNvbnN0IFN0cmluZyYgRGlhZ25vc3RpY0xvZ2dpbmdLZXlzOjpw YWdlQ29udGFpbnNNZWRpYUVuZ2luZUtleSgpCitTdHJpbmcgRGlhZ25vc3RpY0xvZ2dpbmdLZXlz OjpwYWdlQ29udGFpbnNNZWRpYUVuZ2luZUtleSgpCiB7Ci0gICAgREVGSU5FX1NUQVRJQ19MT0NB TChjb25zdCBTdHJpbmcsIGtleSwgKEFTQ0lJTGl0ZXJhbCgicGFnZUNvbnRhaW5zTWVkaWFFbmdp bmUiKSkpOwotICAgIHJldHVybiBrZXk7CisgICAgcmV0dXJuIEFTQ0lJTGl0ZXJhbCgicGFnZUNv bnRhaW5zTWVkaWFFbmdpbmUiKTsKIH0KIAotY29uc3QgU3RyaW5nJiBEaWFnbm9zdGljTG9nZ2lu Z0tleXM6OnBhZ2VDb250YWluc0F0TGVhc3RPbmVNZWRpYUVuZ2luZUtleSgpCitTdHJpbmcgRGlh Z25vc3RpY0xvZ2dpbmdLZXlzOjpwYWdlQ29udGFpbnNBdExlYXN0T25lTWVkaWFFbmdpbmVLZXko KQogewotICAgIERFRklORV9TVEFUSUNfTE9DQUwoY29uc3QgU3RyaW5nLCBrZXksIChBU0NJSUxp dGVyYWwoInBhZ2VDb250YWluc0F0TGVhc3RPbmVNZWRpYUVuZ2luZSIpKSk7Ci0gICAgcmV0dXJu IGtleTsKKyAgICByZXR1cm4gQVNDSUlMaXRlcmFsKCJwYWdlQ29udGFpbnNBdExlYXN0T25lTWVk aWFFbmdpbmUiKTsKIH0KIAotY29uc3QgU3RyaW5nJiBEaWFnbm9zdGljTG9nZ2luZ0tleXM6OnBh c3NLZXkoKQorU3RyaW5nIERpYWdub3N0aWNMb2dnaW5nS2V5czo6cGFzc0tleSgpCiB7Ci0gICAg REVGSU5FX1NUQVRJQ19MT0NBTChjb25zdCBTdHJpbmcsIGtleSwgKEFTQ0lJTGl0ZXJhbCgicGFz cyIpKSk7Ci0gICAgcmV0dXJuIGtleTsKKyAgICByZXR1cm4gQVNDSUlMaXRlcmFsKCJwYXNzIik7 CiB9CiAKLWNvbnN0IFN0cmluZyYgRGlhZ25vc3RpY0xvZ2dpbmdLZXlzOjpmYWlsS2V5KCkKK1N0 cmluZyBEaWFnbm9zdGljTG9nZ2luZ0tleXM6OmZhaWxLZXkoKQogewotICAgIERFRklORV9TVEFU SUNfTE9DQUwoY29uc3QgU3RyaW5nLCBrZXksIChBU0NJSUxpdGVyYWwoImZhaWwiKSkpOwotICAg IHJldHVybiBrZXk7CisgICAgcmV0dXJuIEFTQ0lJTGl0ZXJhbCgiZmFpbCIpOwogfQogCi1jb25z dCBTdHJpbmcmIERpYWdub3N0aWNMb2dnaW5nS2V5czo6bm9vcEtleSgpCitTdHJpbmcgRGlhZ25v c3RpY0xvZ2dpbmdLZXlzOjpub29wS2V5KCkKIHsKLSAgICBERUZJTkVfU1RBVElDX0xPQ0FMKGNv bnN0IFN0cmluZywga2V5LCAoQVNDSUlMaXRlcmFsKCJub29wIikpKTsKLSAgICByZXR1cm4ga2V5 OworICAgIHJldHVybiBBU0NJSUxpdGVyYWwoIm5vb3AiKTsKIH0KIAogfQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGFnZS9EaWFnbm9zdGljTG9nZ2luZ0tleXMuaCBiL1NvdXJjZS9XZWJD b3JlL3BhZ2UvRGlhZ25vc3RpY0xvZ2dpbmdLZXlzLmgKaW5kZXggNTJlODk2NGM5N2E1MWU5ODA3 NWU5ZDNmN2VmNDYxZTUxYTM2OWJjNS4uYmFhNTE1NjNlMjFlNzdlYmM3YjYwMTY2ZGFiNTdhZDE0 M2ZjNjY3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9EaWFnbm9zdGljTG9nZ2lu Z0tleXMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RpYWdub3N0aWNMb2dnaW5nS2V5cy5o CkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoQykgMjAxMiBBcHBsZSBJbmMuIEFs bCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMTIsIDIwMTMgQXBwbGUgSW5j LiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4g c291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9u LCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBA IC0zMiwyMCArMzIsMjAgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiBjbGFzcyBEaWFnbm9zdGlj TG9nZ2luZ0tleXMgewogcHVibGljOgotICAgIC8vIE1lc3NhZ2Uga2V5cwotICAgIHN0YXRpYyBj b25zdCBTdHJpbmcmIG1lZGlhTG9hZGVkS2V5KCk7Ci0gICAgc3RhdGljIGNvbnN0IFN0cmluZyYg bWVkaWFMb2FkaW5nRmFpbGVkS2V5KCk7Ci0gICAgc3RhdGljIGNvbnN0IFN0cmluZyYgcGx1Z2lu TG9hZGVkS2V5KCk7Ci0gICAgc3RhdGljIGNvbnN0IFN0cmluZyYgcGx1Z2luTG9hZGluZ0ZhaWxl ZEtleSgpOwotICAgIHN0YXRpYyBjb25zdCBTdHJpbmcmIHBhZ2VDb250YWluc1BsdWdpbktleSgp OwotICAgIHN0YXRpYyBjb25zdCBTdHJpbmcmIHBhZ2VDb250YWluc0F0TGVhc3RPbmVQbHVnaW5L ZXkoKTsKLSAgICBzdGF0aWMgY29uc3QgU3RyaW5nJiBwYWdlQ29udGFpbnNNZWRpYUVuZ2luZUtl eSgpOwotICAgIHN0YXRpYyBjb25zdCBTdHJpbmcmIHBhZ2VDb250YWluc0F0TGVhc3RPbmVNZWRp YUVuZ2luZUtleSgpOworICAgIC8vIE1lc3NhZ2Uga2V5cy4KKyAgICBzdGF0aWMgU3RyaW5nIG1l ZGlhTG9hZGVkS2V5KCk7CisgICAgc3RhdGljIFN0cmluZyBtZWRpYUxvYWRpbmdGYWlsZWRLZXko KTsKKyAgICBzdGF0aWMgU3RyaW5nIHBsdWdpbkxvYWRlZEtleSgpOworICAgIHN0YXRpYyBTdHJp bmcgcGx1Z2luTG9hZGluZ0ZhaWxlZEtleSgpOworICAgIHN0YXRpYyBTdHJpbmcgcGFnZUNvbnRh aW5zUGx1Z2luS2V5KCk7CisgICAgc3RhdGljIFN0cmluZyBwYWdlQ29udGFpbnNBdExlYXN0T25l UGx1Z2luS2V5KCk7CisgICAgc3RhdGljIFN0cmluZyBwYWdlQ29udGFpbnNNZWRpYUVuZ2luZUtl eSgpOworICAgIHN0YXRpYyBTdHJpbmcgcGFnZUNvbnRhaW5zQXRMZWFzdE9uZU1lZGlhRW5naW5l S2V5KCk7CiAKLSAgICAvLyBTdWNjZXNzIGtleXMKLSAgICBzdGF0aWMgY29uc3QgU3RyaW5nJiBw YXNzS2V5KCk7Ci0gICAgc3RhdGljIGNvbnN0IFN0cmluZyYgZmFpbEtleSgpOwotICAgIHN0YXRp YyBjb25zdCBTdHJpbmcmIG5vb3BLZXkoKTsKKyAgICAvLyBTdWNjZXNzIGtleXMuCisgICAgc3Rh dGljIFN0cmluZyBwYXNzS2V5KCk7CisgICAgc3RhdGljIFN0cmluZyBmYWlsS2V5KCk7CisgICAg c3RhdGljIFN0cmluZyBub29wS2V5KCk7CiB9OwogCiB9Cg==