115092 2013-04-24 00:25:36 -0700 [BlackBerry] Remove the setContentsToColor flavor of LayerTiler::TextureJob 2013-04-24 01:08:52 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 anilsson anilsson anilsson anlo cgarcia commit-queue jpetsovits rwlbuis oldest_to_newest 880370 0 anilsson 2013-04-24 00:25:36 -0700 This is dead code that was used with the Skia backend, but no longer useful. With Skia, when we detected that a layer contained only solid color, we'd draw a 1x1 texture containing that color across the layer bounds. With the GL renderer, for solid color layers the display list will only contain commands to draw the solid color, so the optimization is "built in". This cleanup is done as part of PR 273550. The WebOverlay still uses the TextureCacheCompositingThread::textureForColor() so that one can stay for now. 880375 1 199399 anilsson 2013-04-24 00:33:44 -0700 Created attachment 199399 Patch 880380 2 199399 anilsson 2013-04-24 00:41:51 -0700 Comment on attachment 199399 Patch Thanks cgarcia =) 880385 3 199399 commit-queue 2013-04-24 01:08:50 -0700 Comment on attachment 199399 Patch Clearing flags on attachment: 199399 Committed r149019: <http://trac.webkit.org/changeset/149019> 880386 4 commit-queue 2013-04-24 01:08:52 -0700 All reviewed patches have been landed. Closing bug. 199399 2013-04-24 00:33:44 -0700 2013-04-24 01:08:50 -0700 Patch bug-115092-20130424093300.patch text/plain 6531 anilsson U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4NzAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWY1MTNkOWVhN2FkZGZh Mzk5NmE1ODUwNzRiMDViNzFiMjU2ZGM1My4uMGVhMDQ4YjQ2NDRjNTk4MjMzZmM2MTlmYTk0MjM4 MjQyNTg2MGY0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMzIEBACisyMDEzLTA0LTI0ICBBcnZp ZCBOaWxzc29uICA8YW5pbHNzb25AcmltLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gUmVt b3ZlIHRoZSBzZXRDb250ZW50c1RvQ29sb3IgZmxhdm9yIG9mIExheWVyVGlsZXI6OlRleHR1cmVK b2IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNTA5 MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdpdGgg dGhlIFNraWEgYmFja2VuZCwgd2UgaGFkIGFuIG9wdGltaXphdGlvbiB0byBkZXRlY3Qgc29saWQg Y29sb3IKKyAgICAgICAgbGF5ZXJzLiBUaGUgU2tpYSBjb2RlIGhhcyBiZWVuIHB1cmdlZCwgYnV0 IHRoZXNlIGJpdHMgcmVtYWluZWQuIFdpdGgKKyAgICAgICAgQmxhY2tCZXJyeTo6UGxhdGZvcm06 OkdyYXBoaWNzOjpQbGF0Zm9ybUdyYXBoaWNzQ29udGV4dCwgb25seSB0aGUgc29saWQKKyAgICAg ICAgY29sb3Igd2lsbCBiZSBkcmF3biBhbnl3YXksIHNvIHdlIGRvbid0IG5lZWQgdG8gZGV0ZWN0 IHN1Y2ggbGF5ZXJzIGF0CisgICAgICAgIHRoZSBXZWJDb3JlIGxldmVsLiBGaXhlZCBieSByZW1v dmluZyB0aGUgc2V0Q29udGVudHNUb0NvbG9yIGZsYXZvciBvZgorICAgICAgICBMYXllclRpbGVy OjpUZXh0dXJlSm9iLgorCisgICAgICAgIEJsYWNrQmVycnk6OldlYktpdDo6V2ViT3ZlcmxheSBz dGlsbCB1c2VzCisgICAgICAgIFRleHR1cmVDYWNoZUNvbXBvc2l0aW5nVGhyZWFkOjp0ZXh0dXJl Rm9yQ29sb3IoKSBzbyB0aGF0IG9uZSBjYW4gc3RheQorICAgICAgICBmb3Igbm93LgorCisgICAg ICAgIFRoaXMgd2FzIGRlYWQgY29kZSBzbyBubyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0xheWVyVGlsZS5jcHA6CisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9MYXllclRpbGUuaDoKKyAgICAgICAgKExheWVyVGlsZSk6 CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9MYXllclRpbGVyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkxheWVyVGlsZXI6OnByb2Nlc3NUZXh0dXJlSm9iKToKKyAgICAg ICAgKFdlYkNvcmU6OkxheWVyVGlsZXI6OnBlcmZvcm1UaWxlSm9iKToKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0xheWVyVGlsZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6 OkxheWVyVGlsZXI6OlRleHR1cmVKb2I6OnNldENvbnRlbnRzKToKKyAgICAgICAgKFRleHR1cmVK b2IpOgorCiAyMDEzLTA0LTE4ICBBbGJlcnRvIEdhcmNpYSAgPGFnYXJjaWFAaWdhbGlhLmNvbT4K IAogICAgICAgICBSZW1vdmUgb2Jzb2xldGUgbWFjcm9zIGZyb20gbGlicG5nCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0xheWVyVGlsZS5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0xheWVyVGls ZS5jcHAKaW5kZXggMGJkZmRjYmVlZWIwOTM0NTdmMzNhMzc4ODFkNjI1ZmRkNzgyYjNlNi4uMDRl MWVkNTAzNWQyZDZlNzEyNzE3ZmFmZTQwYWQxMjIzZTY5YTFjOSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9MYXllclRpbGUuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvTGF5ZXJUaWxlLmNw cApAQCAtNDQsMTEgKzQ0LDYgQEAgdm9pZCBMYXllclRpbGU6OnNldENvbnRlbnRzKEJsYWNrQmVy cnk6OlBsYXRmb3JtOjpHcmFwaGljczo6QnVmZmVyKiBjb250ZW50cykKICAgICBzZXRUZXh0dXJl KHRleHR1cmVDYWNoZUNvbXBvc2l0aW5nVGhyZWFkKCktPnRleHR1cmVGb3JDb250ZW50cyhjb250 ZW50cykpOwogfQogCi12b2lkIExheWVyVGlsZTo6c2V0Q29udGVudHNUb0NvbG9yKGNvbnN0IENv bG9yJiBjb2xvcikKLXsKLSAgICBzZXRUZXh0dXJlKHRleHR1cmVDYWNoZUNvbXBvc2l0aW5nVGhy ZWFkKCktPnRleHR1cmVGb3JDb2xvcihjb2xvcikpOwotfQotCiB2b2lkIExheWVyVGlsZTo6dXBk YXRlQ29udGVudHMoQmxhY2tCZXJyeTo6UGxhdGZvcm06OkdyYXBoaWNzOjpCdWZmZXIqIGNvbnRl bnRzKQogewogICAgIHNldFRleHR1cmUodGV4dHVyZUNhY2hlQ29tcG9zaXRpbmdUaHJlYWQoKS0+ dXBkYXRlQ29udGVudHMobV90ZXh0dXJlLCBjb250ZW50cykpOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9MYXllclRpbGUuaCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvTGF5ZXJUaWxlLmgKaW5kZXgg YjM5OWJmY2NkMDlmOTExZDgwY2EzYjI5MGNhZGEyZGJiOTgwZGYyOS4uMTNkMzJjOWVjNzA1ZjQz YTFlZTBkMGZkMTU3YWMxOTM4ODE2YzRmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9MYXllclRpbGUuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0xheWVyVGlsZS5oCkBAIC0yNyw3ICsyNyw2 IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotY2xhc3MgQ29sb3I7CiBjbGFzcyBJbnRSZWN0 OwogY2xhc3MgVGlsZUluZGV4OwogCkBAIC00Nyw3ICs0Niw2IEBAIHB1YmxpYzoKICAgICBib29s IGhhc1RleHR1cmUoKSBjb25zdCB7IHJldHVybiBtX3RleHR1cmUgJiYgbV90ZXh0dXJlLT5idWZm ZXIoKTsgfQogCiAgICAgdm9pZCBzZXRDb250ZW50cyhCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6R3Jh cGhpY3M6OkJ1ZmZlciopOwotICAgIHZvaWQgc2V0Q29udGVudHNUb0NvbG9yKGNvbnN0IENvbG9y Jik7CiAgICAgdm9pZCB1cGRhdGVDb250ZW50cyhCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6R3JhcGhp Y3M6OkJ1ZmZlciopOwogICAgIHZvaWQgZGlzY2FyZENvbnRlbnRzKCk7CiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvTGF5ZXJUaWxlci5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0xheWVyVGls ZXIuY3BwCmluZGV4IDU4M2EyOGMyMWEzOTU4MDFhYTczYzliZGYwNGJmOGFiMWY1MjUxYzUuLjY1 N2YzZjk4YjRjOWYxZmUyMWMwOWQ1OGRhNmJhNjA3OWFmMDQ4NjcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvTGF5ZXJUaWxlci5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9MYXllclRpbGVy LmNwcApAQCAtMzgyLDExICszODIsNiBAQCB2b2lkIExheWVyVGlsZXI6OnByb2Nlc3NUZXh0dXJl Sm9iKGNvbnN0IFRleHR1cmVKb2ImIGpvYiwgVGlsZUpvYnNNYXAmIHRpbGVKb2JzTQogICAgICAg ICByZXR1cm47CiAgICAgfQogCi0gICAgaWYgKGpvYi5tX3R5cGUgPT0gVGV4dHVyZUpvYjo6U2V0 Q29udGVudHNUb0NvbG9yKSB7Ci0gICAgICAgIGFkZFRpbGVKb2Ioam9iLm1faW5kZXgsIGpvYiwg dGlsZUpvYnNNYXApOwotICAgICAgICByZXR1cm47Ci0gICAgfQotCiAgICAgYWRkVGlsZUpvYihp bmRleE9mVGlsZShqb2IubV9kaXJ0eVJlY3QubWluWE1pbllDb3JuZXIoKSksIGpvYiwgdGlsZUpv YnNNYXApOwogfQogCkBAIC00MTMsOSArNDA4LDYgQEAgdm9pZCBMYXllclRpbGVyOjphZGRUaWxl Sm9iKGNvbnN0IFRpbGVJbmRleCYgaW5kZXgsIGNvbnN0IFRleHR1cmVKb2ImIGpvYiwgVGlsZUoK IHZvaWQgTGF5ZXJUaWxlcjo6cGVyZm9ybVRpbGVKb2IoTGF5ZXJUaWxlKiB0aWxlLCBjb25zdCBU ZXh0dXJlSm9iJiBqb2IpCiB7CiAgICAgc3dpdGNoIChqb2IubV90eXBlKSB7Ci0gICAgY2FzZSBU ZXh0dXJlSm9iOjpTZXRDb250ZW50c1RvQ29sb3I6Ci0gICAgICAgIHRpbGUtPnNldENvbnRlbnRz VG9Db2xvcihqb2IubV9jb2xvcik7Ci0gICAgICAgIHJldHVybjsKICAgICBjYXNlIFRleHR1cmVK b2I6OlNldENvbnRlbnRzOgogICAgICAgICB0aWxlLT5zZXRDb250ZW50cyhqb2IubV9jb250ZW50 cyk7CiAgICAgICAgIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2JsYWNrYmVycnkvTGF5ZXJUaWxlci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvYmxhY2tiZXJyeS9MYXllclRpbGVyLmgKaW5kZXggYmQ0MDcxNjc2MThjMjk1ZDhlYzg1 OTJhNGUyYTAyZTAzYTY0OTA5Yy4uMmVmNmIyMzUzOTg5MmJkMTMzNWZkZDE2N2Y5NjY4Y2VjOWEz N2FjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2ti ZXJyeS9MYXllclRpbGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv YmxhY2tiZXJyeS9MYXllclRpbGVyLmgKQEAgLTIxLDcgKzIxLDYgQEAKIAogI2lmIFVTRShBQ0NF TEVSQVRFRF9DT01QT1NJVElORykKIAotI2luY2x1ZGUgIkNvbG9yLmgiCiAjaW5jbHVkZSAiRmxv YXRSZWN0LmgiCiAjaW5jbHVkZSAiSW50UmVjdC5oIgogI2luY2x1ZGUgIkxheWVyQ29tcG9zaXRp bmdUaHJlYWRDbGllbnQuaCIKQEAgLTc1LDcgKzc0LDcgQEAgcHVibGljOgogCiBwcml2YXRlOgog ICAgIHN0cnVjdCBUZXh0dXJlSm9iIHsKLSAgICAgICAgZW51bSBUeXBlIHsgVW5rbm93biwgU2V0 Q29udGVudHMsIFNldENvbnRlbnRzVG9Db2xvciwgVXBkYXRlQ29udGVudHMsIERpc2NhcmRDb250 ZW50cywgUmVzaXplQ29udGVudHMsIERpcnR5Q29udGVudHMgfTsKKyAgICAgICAgZW51bSBUeXBl IHsgVW5rbm93biwgU2V0Q29udGVudHMsIFVwZGF0ZUNvbnRlbnRzLCBEaXNjYXJkQ29udGVudHMs IFJlc2l6ZUNvbnRlbnRzLCBEaXJ0eUNvbnRlbnRzIH07CiAKICAgICAgICAgVGV4dHVyZUpvYigp CiAgICAgICAgICAgICA6IG1fdHlwZShVbmtub3duKQpAQCAtMTA4LDIwICsxMDcsMTAgQEAgcHJp dmF0ZToKICAgICAgICAgICAgIEFTU0VSVChjb250ZW50cyk7CiAgICAgICAgIH0KIAotICAgICAg ICBUZXh0dXJlSm9iKFR5cGUgdHlwZSwgY29uc3QgQ29sb3ImIGNvbG9yLCBjb25zdCBUaWxlSW5k ZXgmIGluZGV4KQotICAgICAgICAgICAgOiBtX3R5cGUodHlwZSkKLSAgICAgICAgICAgICwgbV9j b250ZW50cygwKQotICAgICAgICAgICAgLCBtX2NvbG9yKGNvbG9yKQotICAgICAgICAgICAgLCBt X2luZGV4KGluZGV4KQotICAgICAgICB7Ci0gICAgICAgICAgICBBU1NFUlQodHlwZSA9PSBTZXRD b250ZW50c1RvQ29sb3IpOwotICAgICAgICB9Ci0KICAgICAgICAgc3RhdGljIFRleHR1cmVKb2Ig c2V0Q29udGVudHMoQmxhY2tCZXJyeTo6UGxhdGZvcm06OkdyYXBoaWNzOjpCdWZmZXIqIGNvbnRl bnRzLCBjb25zdCBJbnRSZWN0JiBjb250ZW50c1JlY3QpCiAgICAgICAgIHsKICAgICAgICAgICAg IHJldHVybiBUZXh0dXJlSm9iKFNldENvbnRlbnRzLCBjb250ZW50cywgY29udGVudHNSZWN0KTsK ICAgICAgICAgfQotICAgICAgICBzdGF0aWMgVGV4dHVyZUpvYiBzZXRDb250ZW50c1RvQ29sb3Io Y29uc3QgQ29sb3ImIGNvbG9yLCBjb25zdCBUaWxlSW5kZXgmIGluZGV4KSB7IHJldHVybiBUZXh0 dXJlSm9iKFNldENvbnRlbnRzVG9Db2xvciwgY29sb3IsIGluZGV4KTsgfQogICAgICAgICBzdGF0 aWMgVGV4dHVyZUpvYiB1cGRhdGVDb250ZW50cyhCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6R3JhcGhp Y3M6OkJ1ZmZlciogY29udGVudHMsIGNvbnN0IEludFJlY3QmIGRpcnR5UmVjdCkgeyByZXR1cm4g VGV4dHVyZUpvYihVcGRhdGVDb250ZW50cywgY29udGVudHMsIGRpcnR5UmVjdCk7IH0KICAgICAg ICAgc3RhdGljIFRleHR1cmVKb2IgZGlzY2FyZENvbnRlbnRzKGNvbnN0IEludFJlY3QmIGRpcnR5 UmVjdCkgeyByZXR1cm4gVGV4dHVyZUpvYihEaXNjYXJkQ29udGVudHMsIGRpcnR5UmVjdCk7IH0K ICAgICAgICAgc3RhdGljIFRleHR1cmVKb2IgcmVzaXplQ29udGVudHMoY29uc3QgSW50U2l6ZSYg bmV3U2l6ZSkgeyByZXR1cm4gVGV4dHVyZUpvYihSZXNpemVDb250ZW50cywgbmV3U2l6ZSk7IH0K QEAgLTEzMiw3ICsxMjEsNiBAQCBwcml2YXRlOgogICAgICAgICBUeXBlIG1fdHlwZTsKICAgICAg ICAgQmxhY2tCZXJyeTo6UGxhdGZvcm06OkdyYXBoaWNzOjpCdWZmZXIqIG1fY29udGVudHM7CiAg ICAgICAgIEludFJlY3QgbV9kaXJ0eVJlY3Q7Ci0gICAgICAgIENvbG9yIG1fY29sb3I7CiAgICAg ICAgIFRpbGVJbmRleCBtX2luZGV4OwogICAgIH07CiAK