115089 2013-04-23 22:57:08 -0700 Function parameter quotePair can be passed by reference 2013-04-24 17:43:10 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kangil.han kangil.han commit-queue esprehn+autocc oldest_to_newest 880331 0 kangil.han 2013-04-23 22:57:08 -0700 Function parameter quotePair can be passed by reference 880333 1 199388 kangil.han 2013-04-23 22:59:53 -0700 Created attachment 199388 Patch 880652 2 199388 ap 2013-04-24 09:02:55 -0700 Comment on attachment 199388 Patch r=me I don't think that "[Minor code refactoring]" is a useful prefix. We use bracketed prefixes for platform specific bugs/patches as a signal that most people can skip those. 880891 3 199538 kangil.han 2013-04-24 17:15:39 -0700 Created attachment 199538 Patch 880892 4 kangil.han 2013-04-24 17:16:21 -0700 (In reply to comment #2) > I don't think that "[Minor code refactoring]" is a useful prefix. We use bracketed prefixes for platform specific bugs/patches as a signal that most people can skip those. Done. :) 880900 5 199538 commit-queue 2013-04-24 17:43:09 -0700 Comment on attachment 199538 Patch Clearing flags on attachment: 199538 Committed r149080: <http://trac.webkit.org/changeset/149080> 880901 6 commit-queue 2013-04-24 17:43:10 -0700 All reviewed patches have been landed. Closing bug. 199388 2013-04-23 22:59:53 -0700 2013-04-24 17:15:34 -0700 Patch bug-115089-20130424145923.patch text/plain 2058 kangil.han U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5MDEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjFhMGMzN2NkY2ZhNzJl OTczYjQ4MDc4MjJlNjFkY2FkMzI3ODI4Ni4uNDY3MDI2ZTcxMTU4YTIzMWE0OTRkM2FiOTYyNjAz MGYyNjkxN2UyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA0LTIzICBLYW5n aWwgSGFuICA8a2FuZ2lsLmhhbkBzYW1zdW5nLmNvbT4KKworICAgICAgICBbTWlub3IgY29kZSBy ZWZhY3RvcmluZ10gRnVuY3Rpb24gcGFyYW1ldGVyIHF1b3RlUGFpciBjYW4gYmUgcGFzc2VkIGJ5 IHJlZmVyZW5jZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTE1MDg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgTWlub3IgcGVyZm9ybWFuY2UgcGF0Y2guCisKKyAgICAgICAgKiByZW5kZXJpbmcvc3R5bGUv UXVvdGVzRGF0YS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpRdW90ZXNEYXRhOjphZGRQYWlyKToK KyAgICAgICAgKiByZW5kZXJpbmcvc3R5bGUvUXVvdGVzRGF0YS5oOgorICAgICAgICAoUXVvdGVz RGF0YSk6CisKIDIwMTMtMDQtMjMgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgog CiAgICAgICAgIE1pY3JvLW9wdGltaXplIExlbmd0aDo6aW5pdEZyb21MZW5ndGgoKS4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9RdW90ZXNEYXRhLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9RdW90ZXNEYXRhLmNwcAppbmRleCBhNmE3YzVl ZjJlNDQxYTg5YTc1OWM4NzRlYjI3OTNmZDZiYmNiOWM5Li45MDBmOGVhYmMwNjE3MTM3ZjdhM2M2 Y2Q3MmY2YzA2MzBlZWRiNzQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv c3R5bGUvUXVvdGVzRGF0YS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxl L1F1b3Rlc0RhdGEuY3BwCkBAIC0zOSw3ICszOSw3IEBAIFBhc3NSZWZQdHI8UXVvdGVzRGF0YT4g UXVvdGVzRGF0YTo6Y3JlYXRlKFN0cmluZyBvcGVuMSwgU3RyaW5nIGNsb3NlMSwgU3RyaW5nIG9w CiAgICAgcmV0dXJuIGRhdGE7CiB9CiAKLXZvaWQgUXVvdGVzRGF0YTo6YWRkUGFpcihzdGQ6OnBh aXI8U3RyaW5nLCBTdHJpbmc+IHF1b3RlUGFpcikKK3ZvaWQgUXVvdGVzRGF0YTo6YWRkUGFpcihj b25zdCBzdGQ6OnBhaXI8U3RyaW5nLCBTdHJpbmc+JiBxdW90ZVBhaXIpCiB7CiAgICAgbV9xdW90 ZVBhaXJzLmFwcGVuZChxdW90ZVBhaXIpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL3N0eWxlL1F1b3Rlc0RhdGEuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9z dHlsZS9RdW90ZXNEYXRhLmgKaW5kZXggNTY5OWYzMjQ1NTNlZDBmMzI4MzU4MjdmMjUwNTEyNWFj Nzk1NzIyMi4uMmZjOGE2OTUwYjViM2EzYmE5ZmMyZDY3NDRkNzZiOGNjYWM4MGYyZiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1F1b3Rlc0RhdGEuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUXVvdGVzRGF0YS5oCkBAIC0zOCw3ICszOCw3 IEBAIHB1YmxpYzoKICAgICAvLyBGSVhNRTogdGhpcyBzaG91bGQgYmUgYW4gb3BlcmF0b3I9PS4K ICAgICBzdGF0aWMgYm9vbCBlcXVhbHMoY29uc3QgUXVvdGVzRGF0YSosIGNvbnN0IFF1b3Rlc0Rh dGEqKTsKIAotICAgIHZvaWQgYWRkUGFpcihjb25zdCBzdGQ6OnBhaXI8U3RyaW5nLCBTdHJpbmc+ IHF1b3RlUGFpcik7CisgICAgdm9pZCBhZGRQYWlyKGNvbnN0IHN0ZDo6cGFpcjxTdHJpbmcsIFN0 cmluZz4mIHF1b3RlUGFpcik7CiAgICAgY29uc3QgU3RyaW5nIGdldE9wZW5RdW90ZShpbnQgaW5k ZXgpIGNvbnN0OwogICAgIGNvbnN0IFN0cmluZyBnZXRDbG9zZVF1b3RlKGludCBpbmRleCkgY29u c3Q7CiAK 199538 2013-04-24 17:15:39 -0700 2013-04-24 17:43:09 -0700 Patch bug-115089-20130425091509.patch text/plain 2092 kangil.han U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5MDc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2NiMGJmNGRiODc0OGIw ZTBjODcwNmFjZDFmMmQ3NTQ4YmE4NTI0Yi4uNTk4ZDliMjdlYjA5ODJkMGNiNTcyMzkxZjMwM2Y4 YTg3ODhmNGUxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA0LTI0ICBLYW5n aWwgSGFuICA8a2FuZ2lsLmhhbkBzYW1zdW5nLmNvbT4KKworICAgICAgICBGdW5jdGlvbiBwYXJh bWV0ZXIgcXVvdGVQYWlyIGNhbiBiZSBwYXNzZWQgYnkgcmVmZXJlbmNlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTUwODkKKworICAgICAgICBSZXZp ZXdlZCBieSBBbGV4ZXkgUHJvc2t1cnlha292LgorCisgICAgICAgIE1pbm9yIHBlcmZvcm1hbmNl IHBhdGNoLgorCisgICAgICAgICogcmVuZGVyaW5nL3N0eWxlL1F1b3Rlc0RhdGEuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UXVvdGVzRGF0YTo6YWRkUGFpcik6CisgICAgICAgICogcmVuZGVyaW5n L3N0eWxlL1F1b3Rlc0RhdGEuaDoKKyAgICAgICAgKFF1b3Rlc0RhdGEpOgorCiAyMDEzLTA0LTI0 ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBPbmNlIGEgY3Vz dG9tIGZvbnQgaXMgY2FjaGVkIHRvIGRpc2ssIGl0IHN0YXJ0cyBmYWlsaW5nIHRvIHJlbmRlciB1 bnRpbCB0aGUgcGFnZSBpcyByZWZyZXNoZWQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvc3R5bGUvUXVvdGVzRGF0YS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv c3R5bGUvUXVvdGVzRGF0YS5jcHAKaW5kZXggYTZhN2M1ZWYyZTQ0MWE4OWE3NTljODc0ZWIyNzkz ZmQ2YmJjYjljOS4uOTAwZjhlYWJjMDYxNzEzN2Y3YTNjNmNkNzJmNmMwNjMwZWVkYjc0MyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1F1b3Rlc0RhdGEuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9RdW90ZXNEYXRhLmNwcApAQCAtMzks NyArMzksNyBAQCBQYXNzUmVmUHRyPFF1b3Rlc0RhdGE+IFF1b3Rlc0RhdGE6OmNyZWF0ZShTdHJp bmcgb3BlbjEsIFN0cmluZyBjbG9zZTEsIFN0cmluZyBvcAogICAgIHJldHVybiBkYXRhOwogfQog Ci12b2lkIFF1b3Rlc0RhdGE6OmFkZFBhaXIoc3RkOjpwYWlyPFN0cmluZywgU3RyaW5nPiBxdW90 ZVBhaXIpCit2b2lkIFF1b3Rlc0RhdGE6OmFkZFBhaXIoY29uc3Qgc3RkOjpwYWlyPFN0cmluZywg U3RyaW5nPiYgcXVvdGVQYWlyKQogewogICAgIG1fcXVvdGVQYWlycy5hcHBlbmQocXVvdGVQYWly KTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9RdW90ZXNE YXRhLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUXVvdGVzRGF0YS5oCmluZGV4 IDU2OTlmMzI0NTUzZWQwZjMyODM1ODI3ZjI1MDUxMjVhYzc5NTcyMjIuLjJmYzhhNjk1MGI1YjNh M2JhOWZjMmQ2NzQ0ZDc2YjhjY2FjODBmMmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9zdHlsZS9RdW90ZXNEYXRhLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L3N0eWxlL1F1b3Rlc0RhdGEuaApAQCAtMzgsNyArMzgsNyBAQCBwdWJsaWM6CiAgICAgLy8gRklY TUU6IHRoaXMgc2hvdWxkIGJlIGFuIG9wZXJhdG9yPT0uCiAgICAgc3RhdGljIGJvb2wgZXF1YWxz KGNvbnN0IFF1b3Rlc0RhdGEqLCBjb25zdCBRdW90ZXNEYXRhKik7CiAKLSAgICB2b2lkIGFkZFBh aXIoY29uc3Qgc3RkOjpwYWlyPFN0cmluZywgU3RyaW5nPiBxdW90ZVBhaXIpOworICAgIHZvaWQg YWRkUGFpcihjb25zdCBzdGQ6OnBhaXI8U3RyaW5nLCBTdHJpbmc+JiBxdW90ZVBhaXIpOwogICAg IGNvbnN0IFN0cmluZyBnZXRPcGVuUXVvdGUoaW50IGluZGV4KSBjb25zdDsKICAgICBjb25zdCBT dHJpbmcgZ2V0Q2xvc2VRdW90ZShpbnQgaW5kZXgpIGNvbnN0OwogCg==