115066 2013-04-23 17:04:51 -0700 [EFL][WK2] Build break after r149004 2013-04-23 17:21:44 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi cmarcelo commit-queue lucas.de.marchi luiz noam simon.fraser thorton zeno oldest_to_newest 880181 0 ryuan.choi 2013-04-23 17:04:51 -0700 Below errors occured. [ 83%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/CoordinatedLayerTreeHostMessageReceiver.cpp.o /home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp: In static member function ‘static WTF::PassRefPtr<WebKit::CoordinatedLayerTreeHost> WebKit::CoordinatedLayerTreeHost::create(WebKit::WebPage*)’: /home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:66:57: error: cannot allocate an object of abstract type ‘WebKit::CoordinatedLayerTreeHost’ In file included from /home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:31:0: /home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:48:7: note: because the following virtual functions are pure within ‘WebKit::CoordinatedLayerTreeHost’: In file included from /home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:26:0, from /home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:31: /home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit2/WebProcess/WebPage/LayerTreeHost.h:75:18: note: virtual void WebKit::LayerTreeHost::pageBackgroundTransparencyChanged() /home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:67:1: error: control reaches end of non-void function [-Werror=return-type] cc1plus: all warnings being treated as errors make[2]: *** [Source/WebKit2/CMakeFiles/ewebkit2.dir/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp.o] Error 1 880188 1 199339 ryuan.choi 2013-04-23 17:13:10 -0700 Created attachment 199339 Patch 880191 2 ryuan.choi 2013-04-23 17:19:31 -0700 Committed r149008: <http://trac.webkit.org/changeset/149008> 880192 3 199339 ryuan.choi 2013-04-23 17:21:44 -0700 Comment on attachment 199339 Patch clear the flag. thank you. 199339 2013-04-23 17:13:10 -0700 2013-04-23 17:21:43 -0700 Patch bug-115066-20130424091233.patch text/plain 2541 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5MDA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDFkYTc2YzU5OTAyY2Ex ODkxY2IwMmY4YmRmMmViNDIyM2RhNmUxOS4uMGIwMzU4YWMxYmE3YjgyMjIxZmIwODJmMzZhOTU0 YWJiYjRlMzFkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA0LTIzICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIEJ1 aWxkIGJyZWFrIGFmdGVyIHIxNDkwMDQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExNTA2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3Mv Q29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q29vcmRpbmF0 ZWRMYXllclRyZWVIb3N0OjpwYWdlQmFja2dyb3VuZFRyYW5zcGFyZW5jeUNoYW5nZWQpOgorICAg ICAgICBBZGRlZCBkdW1teSBtZXRob2QgZm9yIG5ldyB2aXJ0dWFsIG1ldGhvZC4KKyAgICAgICAg KiBXZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZExheWVy VHJlZUhvc3QuaDoKKyAgICAgICAgKENvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdCk6IERpdHRvLgor CiAyMDEzLTA0LTIzICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAg ICAgICAgIFdoZW4gdGhlIHdlYiBwYWdlIHRyYW5zcGFyZW5jeSBjaGFuZ2VzLCBEcmF3aW5nQXJl YUltcGwgbmVlZHMgdG8ga25vdyBhYm91dCBpdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRy ZWVIb3N0LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRl ZEdyYXBoaWNzL0Nvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdC5jcHAKaW5kZXggNGFlYWI5MTRmYjNk NTBkYTA0Y2I0NmI2ZDI1ZThiMjUyMTJjMWQzMi4uZjQxYjJjOWU3MGVmZWFkZTdkNmUwYzdhMTQ0 M2Q4NGMyOWU2ZmMxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9D b29yZGluYXRlZExheWVyVHJlZUhvc3QuY3BwCkBAIC02OTEsNiArNjkxLDEwIEBAIHZvaWQgQ29v cmRpbmF0ZWRMYXllclRyZWVIb3N0OjpkZXZpY2VPclBhZ2VTY2FsZUZhY3RvckNoYW5nZWQoKQog ICAgICAgICBtX3BhZ2VPdmVybGF5TGF5ZXItPmRldmljZU9yUGFnZVNjYWxlRmFjdG9yQ2hhbmdl ZCgpOwogfQogCit2b2lkIENvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdDo6cGFnZUJhY2tncm91bmRU cmFuc3BhcmVuY3lDaGFuZ2VkKCkKK3sKK30KKwogR3JhcGhpY3NMYXllckZhY3RvcnkqIENvb3Jk aW5hdGVkTGF5ZXJUcmVlSG9zdDo6Z3JhcGhpY3NMYXllckZhY3RvcnkoKQogewogICAgIHJldHVy biB0aGlzOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nv b3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmggYi9Tb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZExh eWVyVHJlZUhvc3QuaAppbmRleCAyMzI2M2IzZDYyMGUzNWVlN2QwMGQ2NGEwYTNhMTJkZDU0NGY2 OTNjLi43NmFjNjUzYWE2ZjllMjRjNTYxZDVhYWI1MDEwZjBiYWRhY2I3MGIyIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9D b29yZGluYXRlZExheWVyVHJlZUhvc3QuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZExheWVyVHJlZUhvc3QuaApA QCAtODEsNiArODEsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHBhdXNlUmVuZGVyaW5n KCkgeyBtX2lzU3VzcGVuZGVkID0gdHJ1ZTsgfQogICAgIHZpcnR1YWwgdm9pZCByZXN1bWVSZW5k ZXJpbmcoKSB7IG1faXNTdXNwZW5kZWQgPSBmYWxzZTsgc2NoZWR1bGVMYXllckZsdXNoKCk7IH0K ICAgICB2aXJ0dWFsIHZvaWQgZGV2aWNlT3JQYWdlU2NhbGVGYWN0b3JDaGFuZ2VkKCkgT1ZFUlJJ REU7CisgICAgdmlydHVhbCB2b2lkIHBhZ2VCYWNrZ3JvdW5kVHJhbnNwYXJlbmN5Q2hhbmdlZCgp IE9WRVJSSURFOwogCiAgICAgdmlydHVhbCB2b2lkIHJlbmRlck5leHRGcmFtZSgpOwogICAgIHZp cnR1YWwgdm9pZCBwdXJnZUJhY2tpbmdTdG9yZXMoKTsK