115054 2013-04-23 13:20:06 -0700 Remove redundant code in ViewportArguments::resolve 2013-04-23 14:00:38 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jkjiang jkjiang commit-queue esprehn+autocc kenneth rwlbuis staikos tmpsantos oldest_to_newest 880098 0 jkjiang 2013-04-23 13:20:06 -0700 In ViewportArguments.cpp ViewportArguments::resolve(), "result.orientation = orientation" appears twice which looks redundant to me, removing one of them. 880104 1 199322 jkjiang 2013-04-23 13:36:38 -0700 Created attachment 199322 Patch 880115 2 jkjiang 2013-04-23 14:00:38 -0700 Committed r148990: <http://trac.webkit.org/changeset/148990> 199322 2013-04-23 13:36:38 -0700 2013-04-23 13:37:40 -0700 Patch bug-115054-20130423163602.patch text/plain 1317 jkjiang U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4OTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjBjZTU5MDZhZGJmODlk NTQ2Njk5MjA2ZDJjMTc3OGQ5NDhmODgxOS4uYzUxMzY0MTE2NTVhYmFhZjAxOTUyOGE3YTViMDRh M2Y2MTgyODZhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA0LTIzICBKYWNr eSBKaWFuZyAgPHpoYWppYW5nQGJsYWNrYmVycnkuY29tPgorCisgICAgICAgIFJlbW92ZSByZWR1 bmRhbnQgY29kZSBpbiBWaWV3cG9ydEFyZ3VtZW50czo6cmVzb2x2ZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1MDU0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHJlZHVuZGFudCBjb2RlICJy ZXN1bHQub3JpZW50YXRpb24gPSBvcmllbnRhdGlvbjsiLgorCisgICAgICAgICogZG9tL1ZpZXdw b3J0QXJndW1lbnRzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlZpZXdwb3J0QXJndW1lbnRzOjpy ZXNvbHZlKToKKwogMjAxMy0wNC0yMyAgUm9nZXIgRm9uZyAgPHJvZ2VyX2ZvbmdAYXBwbGUuY29t PgogCiAgICAgICAgIEFwcGxlV2luIGJ1aWxkIGZpeC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2RvbS9WaWV3cG9ydEFyZ3VtZW50cy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vVmlld3Bv cnRBcmd1bWVudHMuY3BwCmluZGV4IGRhOGIzYmZmYmY1ODNkZjE1MThmM2E4ZTA5NjJiMzRhN2Vj MzE1NmQuLjk3ZWU5ZjdjMTg1MWI5ZjA1MjVkODA0NjMwY2Q1NWY4ZTYzNDFjMWYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9WaWV3cG9ydEFyZ3VtZW50cy5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvZG9tL1ZpZXdwb3J0QXJndW1lbnRzLmNwcApAQCAtMTkzLDcgKzE5Myw2IEBAIFZp ZXdwb3J0QXR0cmlidXRlcyBWaWV3cG9ydEFyZ3VtZW50czo6cmVzb2x2ZShjb25zdCBGbG9hdFNp emUmIGluaXRpYWxWaWV3cG9ydFNpCiAgICAgfQogCiAgICAgVmlld3BvcnRBdHRyaWJ1dGVzIHJl c3VsdDsKLSAgICByZXN1bHQub3JpZW50YXRpb24gPSBvcmllbnRhdGlvbjsKIAogICAgIC8vIFJl c29sdmUgbWluaW11bS1zY2FsZSBhbmQgbWF4aW11bS1zY2FsZSB2YWx1ZXMgYWNjb3JkaW5nIHRv IHNwZWMuCiAgICAgaWYgKHJlc3VsdE1pblpvb20gPT0gVmlld3BvcnRBcmd1bWVudHM6OlZhbHVl QXV0bykK