115041 2013-04-23 08:12:28 -0700 [BlackBerry] Do not access BackForwardListImpl from DRT 2013-04-23 09:02:39 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 xan.lopez webkit-unassigned cgarcia commit-queue rwlbuis staikos xan.lopez oldest_to_newest 879864 0 xan.lopez 2013-04-23 08:12:28 -0700 Our DRT implementation casts the BF list client class (BackForwardListBlackBerry) to BackForwardListImpl through a static_cast. This is wrong because the impl is a private member of BackForwardListBlackBerry, *not* its parent class. Most fast/history tests are failing via memory corruption because of this. 879870 1 199242 xan.lopez 2013-04-23 08:28:12 -0700 Created attachment 199242 bflist.diff This fixes every single crash in fast/history. 879874 2 199242 cgarcia 2013-04-23 08:33:36 -0700 Comment on attachment 199242 bflist.diff Good catch, this is indeed my fault, I missed this one when added BackForwardListBlackBerry. Thanks! 879879 3 199242 commit-queue 2013-04-23 09:02:37 -0700 Comment on attachment 199242 bflist.diff Clearing flags on attachment: 199242 Committed r148969: <http://trac.webkit.org/changeset/148969> 879880 4 commit-queue 2013-04-23 09:02:39 -0700 All reviewed patches have been landed. Closing bug. 199242 2013-04-23 08:28:12 -0700 2013-04-23 09:02:36 -0700 bflist.diff bflist.diff text/plain 5817 xan.lopez RnJvbSA4YWUxZGZkN2U3Y2Q5NTY0OTQwNzdlNTYzZmZlMGI0MTk0ZGRlM2ZkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhhbkBpZ2FsaWEuY29tPgpEYXRlOiBUdWUs IDIzIEFwciAyMDEzIDE3OjI2OjQ2ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gW0JsYWNrQmVycnld IERvIG5vdCBhY2Nlc3MgQmFja0ZvcndhcmRMaXN0SW1wbCBmcm9tIERSVAogaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNTA0MQoKUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCgpTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnk6CgpFeHBvcnQgdGhlIG5lY2Vzc2FyeSBm dW5jdGlvbmFsaXR5IGluIG91ciBCYWNrRm9yd2FyZExpc3QgcG9ydApjbGllbnQgaW4gb3JkZXIg Zm9yIERSVCB0byB3b3JrLgoKKiBXZWJDb3JlU3VwcG9ydC9CYWNrRm9yd2FyZExpc3RCbGFja0Jl cnJ5LmNwcDoKKFdlYkNvcmU6OkJhY2tGb3J3YXJkTGlzdEJsYWNrQmVycnk6OmJhY2tMaXN0V2l0 aExpbWl0KToKKFdlYkNvcmUpOgooV2ViQ29yZTo6QmFja0ZvcndhcmRMaXN0QmxhY2tCZXJyeTo6 Zm9yd2FyZExpc3RXaXRoTGltaXQpOgooV2ViQ29yZTo6QmFja0ZvcndhcmRMaXN0QmxhY2tCZXJy eTo6Y2FwYWNpdHkpOgoqIFdlYkNvcmVTdXBwb3J0L0JhY2tGb3J3YXJkTGlzdEJsYWNrQmVycnku aDoKKEJhY2tGb3J3YXJkTGlzdEJsYWNrQmVycnkpOgoKVG9vbHM6CgpVc2UgdGhlIHJpZ2h0IGNs YXNzIHRvIGFjY2VzcyB0aGUgYmZsaXN0IGZ1bmN0aW9uYWxpdHkuCgoqIER1bXBSZW5kZXJUcmVl L2JsYWNrYmVycnkvRHVtcFJlbmRlclRyZWUuY3BwOgooQmxhY2tCZXJyeTo6V2ViS2l0OjpkdW1w QmFja0ZvcndhcmRMaXN0Rm9yV2ViVmlldyk6Ci0tLQogU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICB8ICAgMTggKysrKysrKysrKysrKysrKysrCiAu Li4vV2ViQ29yZVN1cHBvcnQvQmFja0ZvcndhcmRMaXN0QmxhY2tCZXJyeS5jcHAgICAgIHwgICAx NSArKysrKysrKysrKysrKysKIC4uLi9XZWJDb3JlU3VwcG9ydC9CYWNrRm9yd2FyZExpc3RCbGFj a0JlcnJ5LmggICAgICAgfCAgICAzICsrKwogVG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTIgKysrKysrKysrKysrCiBUb29scy9EdW1wUmVu ZGVyVHJlZS9ibGFja2JlcnJ5L0R1bXBSZW5kZXJUcmVlLmNwcCAgIHwgICAgNSArKystLQogNSBm aWxlcyBjaGFuZ2VkLCA1MSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IDQ1ZDA0NzAuLmU4YTBmNjIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDEzLTA0LTIzICBYYW4gTG9wZXog IDx4bG9wZXpAaWdhbGlhLmNvbT4KIAorICAgICAgICBbQmxhY2tCZXJyeV0gRG8gbm90IGFjY2Vz cyBCYWNrRm9yd2FyZExpc3RJbXBsIGZyb20gRFJUCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTUwNDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBFeHBvcnQgdGhlIG5lY2Vzc2FyeSBmdW5jdGlvbmFsaXR5 IGluIG91ciBCYWNrRm9yd2FyZExpc3QgcG9ydAorICAgICAgICBjbGllbnQgaW4gb3JkZXIgZm9y IERSVCB0byB3b3JrLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvQmFja0ZvcndhcmRMaXN0 QmxhY2tCZXJyeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpCYWNrRm9yd2FyZExpc3RCbGFja0Jl cnJ5OjpiYWNrTGlzdFdpdGhMaW1pdCk6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdl YkNvcmU6OkJhY2tGb3J3YXJkTGlzdEJsYWNrQmVycnk6OmZvcndhcmRMaXN0V2l0aExpbWl0KToK KyAgICAgICAgKFdlYkNvcmU6OkJhY2tGb3J3YXJkTGlzdEJsYWNrQmVycnk6OmNhcGFjaXR5KToK KyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9CYWNrRm9yd2FyZExpc3RCbGFja0JlcnJ5Lmg6Cisg ICAgICAgIChCYWNrRm9yd2FyZExpc3RCbGFja0JlcnJ5KToKKworMjAxMy0wNC0yMyAgWGFuIExv cGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CisKICAgICAgICAgW0JsYWNrQmVycnldIFNpbXBsaWZ5 IEJhY2tGb3J3YXJkTGlzdEJsYWNrQmVycnk6OmNsZWFyCiAgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTUwMjkKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0JhY2tGb3J3YXJkTGlzdEJsYWNrQmVycnku Y3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0JhY2tGb3J3YXJk TGlzdEJsYWNrQmVycnkuY3BwCmluZGV4IDE3NjIwYjEuLmQxN2E3MzggMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9CYWNrRm9yd2FyZExpc3RCbGFj a0JlcnJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQv QmFja0ZvcndhcmRMaXN0QmxhY2tCZXJyeS5jcHAKQEAgLTExMyw2ICsxMTMsMjEgQEAgSGlzdG9y eUl0ZW1WZWN0b3ImIEJhY2tGb3J3YXJkTGlzdEJsYWNrQmVycnk6OmVudHJpZXMoKQogICAgIHJl dHVybiBtX2ltcGwtPmVudHJpZXMoKTsKIH0KIAordm9pZCBCYWNrRm9yd2FyZExpc3RCbGFja0Jl cnJ5OjpiYWNrTGlzdFdpdGhMaW1pdChpbnQgbGltaXQsIEhpc3RvcnlJdGVtVmVjdG9yJiBsaXN0 KQoreworICAgIG1faW1wbC0+YmFja0xpc3RXaXRoTGltaXQobGltaXQsIGxpc3QpOworfQorCit2 b2lkIEJhY2tGb3J3YXJkTGlzdEJsYWNrQmVycnk6OmZvcndhcmRMaXN0V2l0aExpbWl0KGludCBs aW1pdCwgSGlzdG9yeUl0ZW1WZWN0b3ImIGxpc3QpCit7CisgICAgbV9pbXBsLT5mb3J3YXJkTGlz dFdpdGhMaW1pdChsaW1pdCwgbGlzdCk7Cit9CisKK2ludCBCYWNrRm9yd2FyZExpc3RCbGFja0Jl cnJ5OjpjYXBhY2l0eSgpCit7CisgICAgcmV0dXJuIG1faW1wbC0+Y2FwYWNpdHkoKTsKK30KKwog SGlzdG9yeUl0ZW0qIEJhY2tGb3J3YXJkTGlzdEJsYWNrQmVycnk6OmN1cnJlbnRJdGVtKCkKIHsK ICAgICByZXR1cm4gbV9pbXBsLT5jdXJyZW50SXRlbSgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0JhY2tGb3J3YXJkTGlzdEJsYWNrQmVycnku aCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9CYWNrRm9yd2FyZExp c3RCbGFja0JlcnJ5LmgKaW5kZXggY2IyNTNmNi4uMGIxNTk0ZSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0JhY2tGb3J3YXJkTGlzdEJsYWNrQmVy cnkuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvQmFja0Zv cndhcmRMaXN0QmxhY2tCZXJyeS5oCkBAIC00MCw2ICs0MCw5IEBAIHB1YmxpYzoKICAgICB2b2lk IGNsZWFyKCk7CiAgICAgSGlzdG9yeUl0ZW1WZWN0b3ImIGVudHJpZXMoKTsKICAgICBIaXN0b3J5 SXRlbSogY3VycmVudEl0ZW0oKTsKKyAgICB2b2lkIGJhY2tMaXN0V2l0aExpbWl0KGludCwgSGlz dG9yeUl0ZW1WZWN0b3ImKTsKKyAgICB2b2lkIGZvcndhcmRMaXN0V2l0aExpbWl0KGludCwgSGlz dG9yeUl0ZW1WZWN0b3ImKTsKKyAgICBpbnQgY2FwYWNpdHkoKTsKIAogcHJpdmF0ZToKICAgICBl eHBsaWNpdCBCYWNrRm9yd2FyZExpc3RCbGFja0JlcnJ5KEJsYWNrQmVycnk6OldlYktpdDo6V2Vi UGFnZVByaXZhdGUqKTsKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5n ZUxvZwppbmRleCAyNzEyZjBmLi5hY2ViMjhjIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cK KysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMDQtMjMgIFhhbiBM b3BleiAgPHhsb3BlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBEbyBub3Qg YWNjZXNzIEJhY2tGb3J3YXJkTGlzdEltcGwgZnJvbSBEUlQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNTA0MQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSB0aGUgcmlnaHQgY2xhc3MgdG8gYWNjZXNz IHRoZSBiZmxpc3QgZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2Js YWNrYmVycnkvRHVtcFJlbmRlclRyZWUuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0 OjpkdW1wQmFja0ZvcndhcmRMaXN0Rm9yV2ViVmlldyk6CisKIDIwMTMtMDQtMTggIFh1ZWZlaSBS ZW4gIDx4cmVuQGJsYWNrYmVycnkuY29tPgogCiAgICAgICAgIHJlbW92ZSBidWlsZCB3YXJuaW5n KHVudXNlZCBwYXJhbWV0ZXIpCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9ibGFj a2JlcnJ5L0R1bXBSZW5kZXJUcmVlLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2JsYWNrYmVy cnkvRHVtcFJlbmRlclRyZWUuY3BwCmluZGV4IGQyMzE1OTEuLmM4ODJlZGYgMTAwNjQ0Ci0tLSBh L1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2JsYWNrYmVycnkvRHVtcFJlbmRlclRyZWUuY3BwCisrKyBi L1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2JsYWNrYmVycnkvRHVtcFJlbmRlclRyZWUuY3BwCkBAIC0y Miw3ICsyMiw3IEBACiAjaW5jbHVkZSAiQVBJQ2FzdC5oIgogI2luY2x1ZGUgIkFjY2Vzc2liaWxp dHlDb250cm9sbGVyLmgiCiAjaW5jbHVkZSAiQmFja0ZvcndhcmRDb250cm9sbGVyLmgiCi0jaW5j bHVkZSAiQmFja0ZvcndhcmRMaXN0SW1wbC5oIgorI2luY2x1ZGUgIkJhY2tGb3J3YXJkTGlzdEJs YWNrQmVycnkuaCIKICNpbmNsdWRlICJDcmVkZW50aWFsLmgiCiAjaW5jbHVkZSAiRGF0YWJhc2VU cmFja2VyLmgiCiAjaW5jbHVkZSAiRG9jdW1lbnRMb2FkZXIuaCIKQEAgLTUwOSw3ICs1MDksOCBA QCBzdGF0aWMgU3RyaW5nIGR1bXBCYWNrRm9yd2FyZExpc3RGb3JXZWJWaWV3KCkKICAgICAvLyBG T1JNQVQ6CiAgICAgLy8gIiAgICAgICAgKGZpbGUgdGVzdCk6ZmFzdC9sb2FkZXIvcmVzb3VyY2Vz L2NsaWNrLWZyYWdtZW50LWxpbmsuaHRtbCAgKipuYXYgdGFyZ2V0KioiCiAgICAgLy8gImN1cnIt PiAgKGZpbGUgdGVzdCk6ZmFzdC9sb2FkZXIvcmVzb3VyY2VzL2NsaWNrLWZyYWdtZW50LWxpbmsu aHRtbCN0ZXN0ZnJhZ21lbnQgICoqbmF2IHRhcmdldCoqIgotICAgIFdlYkNvcmU6OkJhY2tGb3J3 YXJkTGlzdEltcGwqIGJmTGlzdCA9IHN0YXRpY19jYXN0PFdlYkNvcmU6OkJhY2tGb3J3YXJkTGlz dEltcGwqPihtYWluRnJhbWUtPnBhZ2UoKS0+YmFja0ZvcndhcmQoKS0+Y2xpZW50KCkpOworICAg IFdlYkNvcmU6OkJhY2tGb3J3YXJkTGlzdEJsYWNrQmVycnkqIGJmTGlzdCA9IHN0YXRpY19jYXN0 PFdlYkNvcmU6OkJhY2tGb3J3YXJkTGlzdEJsYWNrQmVycnkqPihtYWluRnJhbWUtPnBhZ2UoKS0+ YmFja0ZvcndhcmQoKS0+Y2xpZW50KCkpOworCiAgICAgaW50IG1heEl0ZW1zID0gYmZMaXN0LT5j YXBhY2l0eSgpOwogICAgIFdlYkNvcmU6Okhpc3RvcnlJdGVtVmVjdG9yIGVudHJpZXM7CiAgICAg YmZMaXN0LT5iYWNrTGlzdFdpdGhMaW1pdChtYXhJdGVtcywgZW50cmllcyk7Ci0tIAoxLjcuMTAu NAoK