115036 2013-04-23 07:07:24 -0700 Fix cast-align WebCore/platform/graphics/GraphicsContext3D.cpp on ARM 2013-04-24 06:10:58 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ossy ossy commit-queue dino gtk-ews loki ossy xan.lopez zherczeg oldest_to_newest 879825 0 ossy 2013-04-23 07:07:24 -0700 warnings: ---------- build/Source/WebCore/platform/graphics/GraphicsContext3D.cpp:1338:13: warning: cast from 'WTF::OwnArrayPtr<unsigned char>::PtrType {aka unsigned char*}' to 'IntermediateSrcType* {aka float*}' increases required alignment of target type [-Wcast-align] build/Source/WebCore/platform/graphics/GraphicsContext3D.cpp:1339:13: warning: cast from 'WTF::OwnArrayPtr<unsigned char>::PtrType {aka unsigned char*}' to 'IntermediateSrcType* {aka float*}' increases required alignment of target type [-Wcast-align] Fix is coming soon. 879843 1 ossy 2013-04-23 07:50:56 -0700 m_unpackedIntermediateSrcData is an uint8_t array allocated with new. DataTypeForFormat<IntermediateSrcFormat>::Type IntermediateSrcType; --> IntermediateSrcType can be uint8_t, float or uint16_t. new should return aligned pointer for these types, so it is safe to ignore this warning and use reinterpret_cast_ptr here. 879844 2 199235 ossy 2013-04-23 07:52:09 -0700 Created attachment 199235 Patch 879876 3 199235 gtk-ews 2013-04-23 08:39:22 -0700 Comment on attachment 199235 Patch Attachment 199235 did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/204132 880458 4 199235 ossy 2013-04-24 06:10:54 -0700 Comment on attachment 199235 Patch Clearing flags on attachment: 199235 Committed r149031: <http://trac.webkit.org/changeset/149031> 880459 5 ossy 2013-04-24 06:10:58 -0700 All reviewed patches have been landed. Closing bug. 199235 2013-04-23 07:52:09 -0700 2013-04-24 06:10:53 -0700 Patch bug-115036-20130423165150.patch text/plain 1864 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4OTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmMyOTIzNjg1ZGY1MjQ4 ZTY4YzcwZGQyMDNkNjA0YTk1YTA2NjRjMi4uZTNlYWYyMDNmOTkwNGZhNGUwNjUyMjAwZmRmMThm MTMxOTNiOThiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA0LTIzICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IGNhc3QtYWxp Z24gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRC5jcHAgb24gQVJN CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTUwMzYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNELmNwcDoKKyAgICAgICAgKFdlYkNvcmUpOgor CiAyMDEzLTA0LTIzICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CiAKICAgICAg ICAgSW5pdGlhbCBhZHZhbmNlIG9mIHRleHQgcnVucyBzaG91bGQgYmUgdGFrZW4gaW50byBhY2Nv dW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGlj c0NvbnRleHQzRC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGlj c0NvbnRleHQzRC5jcHAKaW5kZXggNGI1YjlmZDRlMjY3MTg0ODc2YWE2MjliMjYwNWRjMGRlMzVj NTQ3My4uMDVmMWM3OTY5YTA3MGQ4NDI4OTg0NDdiODkyNmQyNGUxMDgyMjY4YiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNE LmNwcApAQCAtMTMzNSw4ICsxMzM1LDggQEAgQUxXQVlTX0lOTElORSB2b2lkIEZvcm1hdENvbnZl cnRlcjo6Y29udmVydCgpCiAgICAgICAgIH0KICAgICB9IGVsc2UgaWYgKCF0cml2aWFsVW5wYWNr ICYmICF0cml2aWFsUGFjaykgewogICAgICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IG1faGVp Z2h0OyArK2kpIHsKLSAgICAgICAgICAgIHVucGFjazxTcmNGb3JtYXQ+KHNyY1Jvd1N0YXJ0LCBy ZWludGVycHJldF9jYXN0PEludGVybWVkaWF0ZVNyY1R5cGUqPihtX3VucGFja2VkSW50ZXJtZWRp YXRlU3JjRGF0YS5nZXQoKSksIG1fd2lkdGgpOwotICAgICAgICAgICAgcGFjazxEc3RGb3JtYXQs IGFscGhhT3A+KHJlaW50ZXJwcmV0X2Nhc3Q8SW50ZXJtZWRpYXRlU3JjVHlwZSo+KG1fdW5wYWNr ZWRJbnRlcm1lZGlhdGVTcmNEYXRhLmdldCgpKSwgZHN0Um93U3RhcnQsIG1fd2lkdGgpOworICAg ICAgICAgICAgdW5wYWNrPFNyY0Zvcm1hdD4oc3JjUm93U3RhcnQsIHJlaW50ZXJwcmV0X2Nhc3Rf cHRyPEludGVybWVkaWF0ZVNyY1R5cGUqPihtX3VucGFja2VkSW50ZXJtZWRpYXRlU3JjRGF0YS5n ZXQoKSksIG1fd2lkdGgpOworICAgICAgICAgICAgcGFjazxEc3RGb3JtYXQsIGFscGhhT3A+KHJl aW50ZXJwcmV0X2Nhc3RfcHRyPEludGVybWVkaWF0ZVNyY1R5cGUqPihtX3VucGFja2VkSW50ZXJt ZWRpYXRlU3JjRGF0YS5nZXQoKSksIGRzdFJvd1N0YXJ0LCBtX3dpZHRoKTsKICAgICAgICAgICAg IHNyY1Jvd1N0YXJ0ICs9IHNyY1N0cmlkZUluRWxlbWVudHM7CiAgICAgICAgICAgICBkc3RSb3dT dGFydCArPSBkc3RTdHJpZGVJbkVsZW1lbnRzOwogICAgICAgICB9Cg==