115029 2013-04-23 04:23:19 -0700 [BlackBerry] Simplify BackForwardListBlackBerry::clear 2013-04-23 10:07:52 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 xan.lopez webkit-unassigned cgarcia commit-queue rwlbuis xan.lopez oldest_to_newest 879776 0 xan.lopez 2013-04-23 04:23:19 -0700 The current code manually removes every single entry in the list, which in turn makes the implementation search them one by one to remove from the list. Since we want to remove all of them just set the capacity to zero, which does the same thing but more efficiently. 879778 1 199212 xan.lopez 2013-04-23 04:25:40 -0700 Created attachment 199212 simplify-clear-method.diff 879795 2 199212 cgarcia 2013-04-23 05:11:02 -0700 Comment on attachment 199212 simplify-clear-method.diff View in context: https://bugs.webkit.org/attachment.cgi?id=199212&action=review > Source/WebKit/blackberry/WebCoreSupport/BackForwardListBlackBerry.cpp:106 > - while (!m_impl->entries().isEmpty()) > - m_impl->removeItem(m_impl->entries().last().get()); > + m_impl->setCapacity(0); I'm not sure it's the same, removeItem doesn't change the capacity and setCapacity also removes the items from the page cache. 879797 3 xan.lopez 2013-04-23 05:17:46 -0700 (In reply to comment #2) > > Source/WebKit/blackberry/WebCoreSupport/BackForwardListBlackBerry.cpp:106 > > - while (!m_impl->entries().isEmpty()) > > - m_impl->removeItem(m_impl->entries().last().get()); > > + m_impl->setCapacity(0); > > I'm not sure it's the same, removeItem doesn't change the capacity and setCapacity also removes the items from the page cache. About the capacity: you are right, the patch is even wrong. What is needed is set it to zero to clear it up and then re-set to the previous capacity (so in the end it won't be changed). Not sure about the page cache, we can look into it, but fwiw other ports clear the bf list in a similar way. 879798 4 199212 xan.lopez 2013-04-23 05:18:10 -0700 Comment on attachment 199212 simplify-clear-method.diff This needs at least to not change the capacity, so marking r- for now. 879877 5 199245 xan.lopez 2013-04-23 08:42:29 -0700 Created attachment 199245 bflistclear.diff This would be correct as far as the capacity is concerned, and is what other ports do. The tests also work with it. 879957 6 commit-queue 2013-04-23 10:06:59 -0700 The commit-queue encountered the following flaky tests while processing attachment 199245: platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: rniwa@webkit.org) transitions/color-transition-rounding.html bug 114182 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: peter@chromium.org) transitions/interrupt-zero-duration.html bug 114184 (authors: cmarrin@apple.com, rniwa@webkit.org, and simon.fraser@apple.com) transitions/multiple-background-transitions.html bug 114185 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-color.html bug 114186 (author: peter@chromium.org) transitions/multiple-shadow-transitions.html bug 114187 (author: simon.fraser@apple.com) transitions/mismatched-shadow-transitions.html bug 114188 (author: simon.fraser@apple.com) transitions/color-transition-all.html bug 114189 (authors: ossy@webkit.org and simon.fraser@apple.com) transitions/negative-delay.html bug 114190 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: peter@chromium.org) transitions/min-max-width-height-transitions.html bug 114192 (author: simon.fraser@apple.com) transitions/cancel-transition.html bug 114193 (authors: ojan@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com) transitions/border-radius-transition.html bug 114194 (author: simon.fraser@apple.com) transitions/flex-transitions.html bug 114195 (author: tony@chromium.org) transitions/mixed-type.html bug 114196 (author: mikelawther@chromium.org) transitions/multiple-mask-transitions.html bug 114197 (author: simon.fraser@apple.com) transitions/color-transition-premultiplied.html bug 114198 (author: simon.fraser@apple.com) transitions/mismatched-shadow-styles.html bug 114199 (author: simon.fraser@apple.com) transitions/mask-transitions.html bug 114200 (authors: ojan@chromium.org, oliver@apple.com, and simon.fraser@apple.com) transitions/cubic-bezier-overflow-length.html bug 114201 (author: peter@chromium.org) transitions/multiple-background-size-transitions.html bug 114202 (authors: mitz@webkit.org and simon.fraser@apple.com) transitions/clip-transition.html bug 114203 (authors: dglazkov@chromium.org and simon.fraser@apple.com) transitions/cubic-bezier-overflow-transform.html bug 114204 (author: peter@chromium.org) transitions/shorthand-border-transitions.html bug 114205 (authors: ojan@chromium.org and simon.fraser@apple.com) transitions/interrupted-accelerated-transition.html bug 56242 (authors: rniwa@webkit.org, simon.fraser@apple.com, and tonyg@chromium.org) transitions/background-transitions.html bug 114206 (author: simon.fraser@apple.com) http/tests/security/cookies/third-party-cookie-blocking-user-action.html bug 114511 (authors: ap@webkit.org, jochen@chromium.org, and rniwa@webkit.org) http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: abarth@webkit.org and rniwa@webkit.org) fast/loader/javascript-url-in-object.html bug 114210 (authors: rniwa@webkit.org and sam@webkit.org) The commit-queue is continuing to process your patch. 879958 7 199245 commit-queue 2013-04-23 10:07:48 -0700 Comment on attachment 199245 bflistclear.diff Clearing flags on attachment: 199245 Committed r148972: <http://trac.webkit.org/changeset/148972> 879959 8 commit-queue 2013-04-23 10:07:52 -0700 All reviewed patches have been landed. Closing bug. 199212 2013-04-23 04:25:40 -0700 2013-04-23 08:42:29 -0700 simplify-clear-method.diff simplify-clear-method.diff text/plain 2482 xan.lopez RnJvbSA3Njc4YzU3ZjIyZjAxYjhmMGYzZjJkNTVlNWFiMGQxMjRkNTcwOThhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhhbkBpZ2FsaWEuY29tPgpEYXRlOiBUdWUs IDIzIEFwciAyMDEzIDEzOjI0OjE5ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gW0JsYWNrQmVycnld IFNpbXBsaWZ5IEJhY2tGb3J3YXJkTGlzdEJsYWNrQmVycnk6OmNsZWFyCiBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1MDI5CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KClNpbXBsaWZ5IHRoZSBpbXBsZW1lbnRhdGlvbiBvZiB0aGUgY2xlYXIgbWV0aG9kLiBJ bnN0ZWFkIG9mIGFza2luZwp0aGUgV2ViQ29yZSBpbXBsZW1lbnRhdGlvbiB0byBzZWFyY2ggZWFj aCBpdGVtIGFuZCBkZWxldGUgaXQsIHNldAp0aGUgY2FwYWNpdHkgb2YgdGhlIGxpc3QgdG8gemVy byBkaXJlY3RseSwgd2hpY2ggd2lsbCBkbyB0aGUgc2FtZQp0aGluZyBidXQgbW9yZSBlZmZpY2ll bnRseS4KCk5vIGNoYW5nZSBpbiBiZWhhdmlvciwgbm8gbmV3IHRlc3RzLgoKKiBXZWJDb3JlU3Vw cG9ydC9CYWNrRm9yd2FyZExpc3RCbGFja0JlcnJ5LmNwcDoKKFdlYkNvcmU6OkJhY2tGb3J3YXJk TGlzdEJsYWNrQmVycnk6OmNsZWFyKToKLS0tCiBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hh bmdlTG9nICAgICAgICAgICAgICAgICAgICB8ICAgMTcgKysrKysrKysrKysrKysrKysKIC4uLi9X ZWJDb3JlU3VwcG9ydC9CYWNrRm9yd2FyZExpc3RCbGFja0JlcnJ5LmNwcCAgICAgIHwgICAgMyAr LS0KIDIgZmlsZXMgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwppbmRleCAzZmY3OTU2Li40NWQwNDcwIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMy0wNC0yMyAgWGFu IExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIFNpbXBs aWZ5IEJhY2tGb3J3YXJkTGlzdEJsYWNrQmVycnk6OmNsZWFyCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTUwMjkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaW1wbGlmeSB0aGUgaW1wbGVtZW50YXRpb24g b2YgdGhlIGNsZWFyIG1ldGhvZC4gSW5zdGVhZCBvZiBhc2tpbmcKKyAgICAgICAgdGhlIFdlYkNv cmUgaW1wbGVtZW50YXRpb24gdG8gc2VhcmNoIGVhY2ggaXRlbSBhbmQgZGVsZXRlIGl0LCBzZXQK KyAgICAgICAgdGhlIGNhcGFjaXR5IG9mIHRoZSBsaXN0IHRvIHplcm8gZGlyZWN0bHksIHdoaWNo IHdpbGwgZG8gdGhlIHNhbWUKKyAgICAgICAgdGhpbmcgYnV0IG1vcmUgZWZmaWNpZW50bHkuCisK KyAgICAgICAgTm8gY2hhbmdlIGluIGJlaGF2aW9yLCBubyBuZXcgdGVzdHMuCisKKyAgICAgICAg KiBXZWJDb3JlU3VwcG9ydC9CYWNrRm9yd2FyZExpc3RCbGFja0JlcnJ5LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkJhY2tGb3J3YXJkTGlzdEJsYWNrQmVycnk6OmNsZWFyKToKKwogMjAxMy0wNC0y MiAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnld IEFTU0VSVCBpbiBGcmFtZUxvYWRlckNsaWVudDo6Y29udmVydE1haW5SZXNvdXJjZUxvYWRUb0Rv d25sb2FkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBv cnQvQmFja0ZvcndhcmRMaXN0QmxhY2tCZXJyeS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvV2ViQ29yZVN1cHBvcnQvQmFja0ZvcndhcmRMaXN0QmxhY2tCZXJyeS5jcHAKaW5kZXggMGE3 ZDlhNi4uMjE5OWQ4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNv cmVTdXBwb3J0L0JhY2tGb3J3YXJkTGlzdEJsYWNrQmVycnkuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9CYWNrRm9yd2FyZExpc3RCbGFja0JlcnJ5LmNw cApAQCAtMTAzLDggKzEwMyw3IEBAIHZvaWQgQmFja0ZvcndhcmRMaXN0QmxhY2tCZXJyeTo6Y2xv c2UoKQogCiB2b2lkIEJhY2tGb3J3YXJkTGlzdEJsYWNrQmVycnk6OmNsZWFyKCkKIHsKLSAgICB3 aGlsZSAoIW1faW1wbC0+ZW50cmllcygpLmlzRW1wdHkoKSkKLSAgICAgICAgbV9pbXBsLT5yZW1v dmVJdGVtKG1faW1wbC0+ZW50cmllcygpLmxhc3QoKS5nZXQoKSk7CisgICAgbV9pbXBsLT5zZXRD YXBhY2l0eSgwKTsKIH0KIAogSGlzdG9yeUl0ZW1WZWN0b3ImIEJhY2tGb3J3YXJkTGlzdEJsYWNr QmVycnk6OmVudHJpZXMoKQotLSAKMS43LjEwLjQKCg== 199245 2013-04-23 08:42:29 -0700 2013-04-23 10:07:48 -0700 bflistclear.diff bflistclear.diff text/plain 2560 xan.lopez RnJvbSAxZjUyZWUyZDE0YWRlZTdlMDIwYjJjY2NiNmIyZDA0YTY2OWZiZTQyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhhbkBpZ2FsaWEuY29tPgpEYXRlOiBUdWUs IDIzIEFwciAyMDEzIDEzOjI0OjE5ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gW0JsYWNrQmVycnld IFNpbXBsaWZ5IEJhY2tGb3J3YXJkTGlzdEJsYWNrQmVycnk6OmNsZWFyCiBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1MDI5CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KClNpbXBsaWZ5IHRoZSBpbXBsZW1lbnRhdGlvbiBvZiB0aGUgY2xlYXIgbWV0aG9kLiBJ bnN0ZWFkIG9mIGFza2luZwp0aGUgV2ViQ29yZSBpbXBsZW1lbnRhdGlvbiB0byBzZWFyY2ggZWFj aCBpdGVtIGFuZCBkZWxldGUgaXQsIHNldAp0aGUgY2FwYWNpdHkgb2YgdGhlIGxpc3QgdG8gemVy byBkaXJlY3RseSwgd2hpY2ggd2lsbCBkbyB0aGUgc2FtZQp0aGluZyBidXQgbW9yZSBlZmZpY2ll bnRseS4KCk5vIGNoYW5nZSBpbiBiZWhhdmlvciwgbm8gbmV3IHRlc3RzLgoKKiBXZWJDb3JlU3Vw cG9ydC9CYWNrRm9yd2FyZExpc3RCbGFja0JlcnJ5LmNwcDoKKFdlYkNvcmU6OkJhY2tGb3J3YXJk TGlzdEJsYWNrQmVycnk6OmNsZWFyKToKLS0tCiBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hh bmdlTG9nICAgICAgICAgICAgICAgICAgICB8ICAgMTcgKysrKysrKysrKysrKysrKysKIC4uLi9X ZWJDb3JlU3VwcG9ydC9CYWNrRm9yd2FyZExpc3RCbGFja0JlcnJ5LmNwcCAgICAgIHwgICAgNSAr KystLQogMiBmaWxlcyBjaGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IDNmZjc5NTYuLjQ1ZDA0NzAgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA0LTIzICBY YW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gU2lt cGxpZnkgQmFja0ZvcndhcmRMaXN0QmxhY2tCZXJyeTo6Y2xlYXIKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNTAyOQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbXBsaWZ5IHRoZSBpbXBsZW1lbnRhdGlv biBvZiB0aGUgY2xlYXIgbWV0aG9kLiBJbnN0ZWFkIG9mIGFza2luZworICAgICAgICB0aGUgV2Vi Q29yZSBpbXBsZW1lbnRhdGlvbiB0byBzZWFyY2ggZWFjaCBpdGVtIGFuZCBkZWxldGUgaXQsIHNl dAorICAgICAgICB0aGUgY2FwYWNpdHkgb2YgdGhlIGxpc3QgdG8gemVybyBkaXJlY3RseSwgd2hp Y2ggd2lsbCBkbyB0aGUgc2FtZQorICAgICAgICB0aGluZyBidXQgbW9yZSBlZmZpY2llbnRseS4K KworICAgICAgICBObyBjaGFuZ2UgaW4gYmVoYXZpb3IsIG5vIG5ldyB0ZXN0cy4KKworICAgICAg ICAqIFdlYkNvcmVTdXBwb3J0L0JhY2tGb3J3YXJkTGlzdEJsYWNrQmVycnkuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6QmFja0ZvcndhcmRMaXN0QmxhY2tCZXJyeTo6Y2xlYXIpOgorCiAyMDEzLTA0 LTIyICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJy eV0gQVNTRVJUIGluIEZyYW1lTG9hZGVyQ2xpZW50Ojpjb252ZXJ0TWFpblJlc291cmNlTG9hZFRv RG93bmxvYWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3Vw cG9ydC9CYWNrRm9yd2FyZExpc3RCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9XZWJDb3JlU3VwcG9ydC9CYWNrRm9yd2FyZExpc3RCbGFja0JlcnJ5LmNwcAppbmRleCAw YTdkOWE2Li4xNzYyMGIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2Vi Q29yZVN1cHBvcnQvQmFja0ZvcndhcmRMaXN0QmxhY2tCZXJyeS5jcHAKKysrIGIvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0JhY2tGb3J3YXJkTGlzdEJsYWNrQmVycnku Y3BwCkBAIC0xMDMsOCArMTAzLDkgQEAgdm9pZCBCYWNrRm9yd2FyZExpc3RCbGFja0JlcnJ5Ojpj bG9zZSgpCiAKIHZvaWQgQmFja0ZvcndhcmRMaXN0QmxhY2tCZXJyeTo6Y2xlYXIoKQogewotICAg IHdoaWxlICghbV9pbXBsLT5lbnRyaWVzKCkuaXNFbXB0eSgpKQotICAgICAgICBtX2ltcGwtPnJl bW92ZUl0ZW0obV9pbXBsLT5lbnRyaWVzKCkubGFzdCgpLmdldCgpKTsKKyAgICBpbnQgY2FwYWNp dHkgPSBtX2ltcGwtPmNhcGFjaXR5KCk7CisgICAgbV9pbXBsLT5zZXRDYXBhY2l0eSgwKTsKKyAg ICBtX2ltcGwtPnNldENhcGFjaXR5KGNhcGFjaXR5KTsKIH0KIAogSGlzdG9yeUl0ZW1WZWN0b3Im IEJhY2tGb3J3YXJkTGlzdEJsYWNrQmVycnk6OmVudHJpZXMoKQotLSAKMS43LjEwLjQKCg==