114996 2013-04-22 16:10:08 -0700 Remove the Chromium-specific helper from run_webkit_tests.py 2013-04-24 10:06:00 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 seokju webkit-unassigned commit-queue dpranke rniwa oldest_to_newest 879495 0 seokju 2013-04-22 16:10:08 -0700 $./Tools/Scripts/run-webkit-tests --help Chromium-specific Options: --nocheck-sys-deps Don't check the system dependencies (themes) --adb-device=ADB_DEVICE Run Android layout tests on these devices. 879497 1 199123 seokju 2013-04-22 16:10:57 -0700 Created attachment 199123 Patch 879535 2 199123 commit-queue 2013-04-22 17:10:31 -0700 Comment on attachment 199123 Patch Rejecting attachment 199123 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: manager.run(args) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 191, in run if not self._set_up_run(tests_to_run): File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 156, in _set_up_run if not self._options.nocheck_sys_deps: AttributeError: Values instance has no attribute 'nocheck_sys_deps' Failed to execute Tools/Scripts/new-run-webkit-tests at Tools/Scripts/run-webkit-tests line 106. Full output: http://webkit-queues.appspot.com/results/118339 879551 3 199135 seokju 2013-04-22 18:24:14 -0700 Created attachment 199135 Patch 880419 4 seokju 2013-04-24 04:10:02 -0700 dpranke : What do you think about 2nd patch? 880681 5 199135 commit-queue 2013-04-24 10:05:57 -0700 Comment on attachment 199135 Patch Clearing flags on attachment: 199135 Committed r149046: <http://trac.webkit.org/changeset/149046> 880682 6 commit-queue 2013-04-24 10:06:00 -0700 All reviewed patches have been landed. Closing bug. 199123 2013-04-22 16:10:57 -0700 2013-04-22 18:24:08 -0700 Patch bug-114996-20130423081021.patch text/plain 1918 seokju U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4OTE5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzYxOGQxMjE1MWYzYTAwZDgyNDJiMTFhOTM2YjViOWZk ZmJhM2IyYS4uMjgyNTRkNzY0YmY3ZjQzNGJhYThjNzczMzE5ZDE1ZmIyZjE1NmNiMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDEzLTA0LTIyICBTZW9ranUgS3dvbiAgPHNlb2tqdS5rd29uQGdtYWlsLmNvbT4KKwor ICAgICAgICBSZW1vdmUgdGhlIENocm9taXVtLXNwZWNpZmljIGhlbHBlciBmcm9tIHJ1bl93ZWJr aXRfdGVzdHMucHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTExNDk5NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weToK KyAgICAgICAgKHBhcnNlX2FyZ3MpOgorCiAyMDEzLTA0LTIyICBNYXJ0aW4gUm9iaW5zb24gIDxt cm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBFbmFibGUgaW50cm9zcGVjdGlv biBhbHdheXMgZm9yIGRldmVsb3BlciBidWlsZHMKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5CmluZGV4IDc0Y2I2OWI2 MTNkMmVhNjg1YTNiYWZjZWJkZTAzM2JmYWM0MzEwNTIuLjc5Nzk4Zjc5ZTQ1MTM0MjMwYWM4Njkw YTVlNmMwNDI2YjgzZTU4NTMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQpAQCAtOTksMTYgKzk5LDYgQEAgZGVm IHBhcnNlX2FyZ3MoYXJncyk6CiAgICAgb3B0aW9uX2dyb3VwX2RlZmluaXRpb25zLmFwcGVuZCgo IkNvbmZpZ3VyYXRpb24gb3B0aW9ucyIsIGNvbmZpZ3VyYXRpb25fb3B0aW9ucygpKSkKICAgICBv cHRpb25fZ3JvdXBfZGVmaW5pdGlvbnMuYXBwZW5kKCgiUHJpbnRpbmcgT3B0aW9ucyIsIHByaW50 aW5nLnByaW50X29wdGlvbnMoKSkpCiAKLSAgICAjIEZJWE1FOiBUaGVzZSBvcHRpb25zIHNob3Vs ZCBtb3ZlIG9udG8gdGhlIENocm9taXVtUG9ydC4KLSAgICBvcHRpb25fZ3JvdXBfZGVmaW5pdGlv bnMuYXBwZW5kKCgiQ2hyb21pdW0tc3BlY2lmaWMgT3B0aW9ucyIsIFsKLSAgICAgICAgb3B0cGFy c2UubWFrZV9vcHRpb24oIi0tbm9jaGVjay1zeXMtZGVwcyIsIGFjdGlvbj0ic3RvcmVfdHJ1ZSIs Ci0gICAgICAgICAgICBkZWZhdWx0PUZhbHNlLAotICAgICAgICAgICAgaGVscD0iRG9uJ3QgY2hl Y2sgdGhlIHN5c3RlbSBkZXBlbmRlbmNpZXMgKHRoZW1lcykiKSwKLSAgICAgICAgb3B0cGFyc2Uu bWFrZV9vcHRpb24oIi0tYWRiLWRldmljZSIsCi0gICAgICAgICAgICBhY3Rpb249ImFwcGVuZCIs IGRlZmF1bHQ9W10sCi0gICAgICAgICAgICBoZWxwPSJSdW4gQW5kcm9pZCBsYXlvdXQgdGVzdHMg b24gdGhlc2UgZGV2aWNlcy4iKSwKLSAgICBdKSkKLQogICAgIG9wdGlvbl9ncm91cF9kZWZpbml0 aW9ucy5hcHBlbmQoKCJFRkwtc3BlY2lmaWMgT3B0aW9ucyIsIFsKICAgICAgICAgb3B0cGFyc2Uu bWFrZV9vcHRpb24oIi0td2VicHJvY2Vzcy1jbWQtcHJlZml4IiwgdHlwZT0ic3RyaW5nIiwKICAg ICAgICAgICAgIGRlZmF1bHQ9RmFsc2UsIGhlbHA9IlByZWZpeCB1c2VkIHdoZW4gc3Bhd25pbmcg dGhlIFdlYiBwcm9jZXNzIChEZWJ1ZyBtb2RlIG9ubHkpIiksCg== 199135 2013-04-22 18:24:14 -0700 2013-04-24 10:05:57 -0700 Patch bug-114996-20130423102338.patch text/plain 2509 seokju U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4OTM4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTY3YTc1YjhmZGUwODc3MDUyNmNmYWIzYzU2YjI2MjA4 NmVkMGE2Zi4uMTJjMWMzNjczMTAzYTUxNGNlODBmOTQ3NTEwYjRjN2U1NWQwNDMyZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDEzLTA0LTIyICBTZW9ranUgS3dvbiAgPHNlb2tqdS5rd29uQGdtYWlsLmNvbT4KKwor ICAgICAgICBSZW1vdmUgdGhlIENocm9taXVtLXNwZWNpZmljIGhlbHBlciBmcm9tIHJ1bl93ZWJr aXRfdGVzdHMucHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTExNDk5NgorCisgICAgICAgIFJldmlld2VkIGJ5IERpcmsgUHJhbmtlLgorCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weToKKyAg ICAgICAgKHBhcnNlX2FyZ3MpOgorCiAyMDEzLTA0LTIyICBNYXJrIFJvd2UgIDxtcm93ZUBhcHBs ZS5jb20+CiAKICAgICAgICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvMTE0OTg5PiBBZGQgYSB1c2Vy IGRlZmF1bHQgdG8gYWxsb3cgdXNlIG9mIHRoZSBTYWZhcmkgYmluYXJ5IHJhdGhlciB0aGFuIFNh ZmFyaUZvcldlYktpdERldmVsb3BtZW50CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQppbmRleCA3NGNiNjliNjEzZDJl YTY4NWEzYmFmY2ViZGUwMzNiZmFjNDMxMDUyLi44YjFjMTEzMjY2N2EyM2YwNTMyYjM2N2UyNjg0 YjU5NWE1ZDY0NjhmIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkKQEAgLTk5LDE2ICs5OSw2IEBAIGRlZiBwYXJz ZV9hcmdzKGFyZ3MpOgogICAgIG9wdGlvbl9ncm91cF9kZWZpbml0aW9ucy5hcHBlbmQoKCJDb25m aWd1cmF0aW9uIG9wdGlvbnMiLCBjb25maWd1cmF0aW9uX29wdGlvbnMoKSkpCiAgICAgb3B0aW9u X2dyb3VwX2RlZmluaXRpb25zLmFwcGVuZCgoIlByaW50aW5nIE9wdGlvbnMiLCBwcmludGluZy5w cmludF9vcHRpb25zKCkpKQogCi0gICAgIyBGSVhNRTogVGhlc2Ugb3B0aW9ucyBzaG91bGQgbW92 ZSBvbnRvIHRoZSBDaHJvbWl1bVBvcnQuCi0gICAgb3B0aW9uX2dyb3VwX2RlZmluaXRpb25zLmFw cGVuZCgoIkNocm9taXVtLXNwZWNpZmljIE9wdGlvbnMiLCBbCi0gICAgICAgIG9wdHBhcnNlLm1h a2Vfb3B0aW9uKCItLW5vY2hlY2stc3lzLWRlcHMiLCBhY3Rpb249InN0b3JlX3RydWUiLAotICAg ICAgICAgICAgZGVmYXVsdD1GYWxzZSwKLSAgICAgICAgICAgIGhlbHA9IkRvbid0IGNoZWNrIHRo ZSBzeXN0ZW0gZGVwZW5kZW5jaWVzICh0aGVtZXMpIiksCi0gICAgICAgIG9wdHBhcnNlLm1ha2Vf b3B0aW9uKCItLWFkYi1kZXZpY2UiLAotICAgICAgICAgICAgYWN0aW9uPSJhcHBlbmQiLCBkZWZh dWx0PVtdLAotICAgICAgICAgICAgaGVscD0iUnVuIEFuZHJvaWQgbGF5b3V0IHRlc3RzIG9uIHRo ZXNlIGRldmljZXMuIiksCi0gICAgXSkpCi0KICAgICBvcHRpb25fZ3JvdXBfZGVmaW5pdGlvbnMu YXBwZW5kKCgiRUZMLXNwZWNpZmljIE9wdGlvbnMiLCBbCiAgICAgICAgIG9wdHBhcnNlLm1ha2Vf b3B0aW9uKCItLXdlYnByb2Nlc3MtY21kLXByZWZpeCIsIHR5cGU9InN0cmluZyIsCiAgICAgICAg ICAgICBkZWZhdWx0PUZhbHNlLCBoZWxwPSJQcmVmaXggdXNlZCB3aGVuIHNwYXduaW5nIHRoZSBX ZWIgcHJvY2VzcyAoRGVidWcgbW9kZSBvbmx5KSIpLApAQCAtMjAzLDYgKzE5MywxMCBAQCBkZWYg cGFyc2VfYXJncyhhcmdzKToKICAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0taWdub3Jl LW1ldHJpY3MiLCBhY3Rpb249InN0b3JlX3RydWUiLCBkZXN0PSJpZ25vcmVfbWV0cmljcyIsCiAg ICAgICAgICAgICBkZWZhdWx0PUZhbHNlLCBoZWxwPSJJZ25vcmUgcmVuZGVyaW5nIG1ldHJpY3Mg cmVsYXRlZCBpbmZvcm1hdGlvbiBmcm9tIHRlc3QgIgogICAgICAgICAgICAgIm91dHB1dCwgb25s eSBjb21wYXJlIHRoZSBzdHJ1Y3R1cmUgb2YgdGhlIHJlbmRlcnRyZWUuIiksCisgICAgICAgIG9w dHBhcnNlLm1ha2Vfb3B0aW9uKCItLW5vY2hlY2stc3lzLWRlcHMiLCBhY3Rpb249InN0b3JlX3Ry dWUiLAorICAgICAgICAgICAgZGVmYXVsdD1GYWxzZSwKKyAgICAgICAgICAgIGhlbHA9IkRvbid0 IGNoZWNrIHRoZSBzeXN0ZW0gZGVwZW5kZW5jaWVzICh0aGVtZXMpIiksCisKICAgICBdKSkKIAog ICAgIG9wdGlvbl9ncm91cF9kZWZpbml0aW9ucy5hcHBlbmQoKCJUZXN0aW5nIE9wdGlvbnMiLCBb Cg==