114993 2013-04-22 15:09:01 -0700 branchAdd32 missing implementation in SH4 base JIT 2013-04-22 16:24:33 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 jbriance webkit-unassigned commit-queue mark.lam oliver oldest_to_newest 879458 0 jbriance 2013-04-22 15:09:01 -0700 The following function prototype is missing in SH4 base JIT: Jump branchAdd32(ResultCondition, TrustedImm32, AbsoluteAddress) This function is needed since r148893. 879463 1 199116 jbriance 2013-04-22 15:16:33 -0700 Created attachment 199116 branchAdd32 missing implementation in SH4 base JIT 879510 2 199116 commit-queue 2013-04-22 16:24:31 -0700 Comment on attachment 199116 branchAdd32 missing implementation in SH4 base JIT Clearing flags on attachment: 199116 Committed r148926: <http://trac.webkit.org/changeset/148926> 879511 3 commit-queue 2013-04-22 16:24:33 -0700 All reviewed patches have been landed. Closing bug. 199116 2013-04-22 15:16:33 -0700 2013-04-22 16:24:31 -0700 branchAdd32 missing implementation in SH4 base JIT bug_114993.patch text/plain 2655 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ4OTE1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEzLTA0LTIyICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VhdUBuZHMuY29tPgorCisg ICAgICAgIEFkZCBicmFuY2hBZGQzMiBtaXNzaW5nIGltcGxlbWVudGF0aW9uIGluIFNINCBiYXNl IEpJVC4KKyAgICAgICAgVGhpcyBzaG91bGQgZml4IFNINCBidWlsZCwgYnJva2VuIHNpbmNlIHIx NDg4OTMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MTQ5OTMuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJTSDQuaDoKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3Nl bWJsZXJTSDQ6OmJyYW5jaEFkZDMyKToKKyAgICAgICAgKE1hY3JvQXNzZW1ibGVyU0g0KToKKwog MjAxMy0wNC0yMiAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgRml4 IGJyb2tlbiAzMi1iaXQgYnVpbGQgdG8gZ3JlZW4gdGhlIGJvdHMuCkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyU0g0LmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclNINC5oCShyZXZp c2lvbiAxNDg5MTEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNz ZW1ibGVyU0g0LmgJKHdvcmtpbmcgY29weSkKQEAgLTE5NzUsNiArMTk3NSw0MCBAQCB2b2lkIG9y MzIoVHJ1c3RlZEltbTMyIGltbSwgUmVnaXN0ZXJJRCBzCiAgICAgICAgIHJldHVybiBicmFuY2hU cnVlKCk7CiAgICAgfQogCisgICAgSnVtcCBicmFuY2hBZGQzMihSZXN1bHRDb25kaXRpb24gY29u ZCwgVHJ1c3RlZEltbTMyIGltbSwgQWJzb2x1dGVBZGRyZXNzIGRlc3QpCisgICAgeworICAgICAg ICBBU1NFUlQoKGNvbmQgPT0gT3ZlcmZsb3cpIHx8IChjb25kID09IFNpZ25lZCkgfHwgKGNvbmQg PT0gUG9zaXRpdmVPclplcm8pIHx8IChjb25kID09IFplcm8pIHx8IChjb25kID09IE5vblplcm8p KTsKKyAgICAgICAgSnVtcCByZXN1bHQ7CisKKyAgICAgICAgbW92ZShpbW0sIHNjcmF0Y2hSZWcz KTsKKyAgICAgICAgUmVnaXN0ZXJJRCBkZXN0cHRyID0gY2xhaW1TY3JhdGNoKCk7CisgICAgICAg IFJlZ2lzdGVySUQgZGVzdHZhbCA9IGNsYWltU2NyYXRjaCgpOworICAgICAgICBtX2Fzc2VtYmxl ci5sb2FkQ29uc3RhbnQocmVpbnRlcnByZXRfY2FzdDx1aW50MzJfdD4oZGVzdC5tX3B0ciksIGRl c3RwdHIpOworICAgICAgICBtX2Fzc2VtYmxlci5tb3ZsTWVtUmVnKGRlc3RwdHIsIGRlc3R2YWwp OworICAgICAgICBpZiAoY29uZCA9PSBPdmVyZmxvdykgeworICAgICAgICAgICAgbV9hc3NlbWJs ZXIuYWRkdmxSZWdSZWcoc2NyYXRjaFJlZzMsIGRlc3R2YWwpOworICAgICAgICAgICAgcmVzdWx0 ID0gYnJhbmNoVHJ1ZSgpOworICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAgbV9hc3NlbWJs ZXIuYWRkbFJlZ1JlZyhzY3JhdGNoUmVnMywgZGVzdHZhbCk7CisKKyAgICAgICAgICAgIGlmIChj b25kID09IFNpZ25lZCkgeworICAgICAgICAgICAgICAgIG1fYXNzZW1ibGVyLmNtcHB6KGRlc3R2 YWwpOworICAgICAgICAgICAgICAgIHJlc3VsdCA9IGJyYW5jaEZhbHNlKCk7CisgICAgICAgICAg ICB9IGVsc2UgaWYgKGNvbmQgPT0gUG9zaXRpdmVPclplcm8pIHsKKyAgICAgICAgICAgICAgICBt X2Fzc2VtYmxlci5jbXBweihkZXN0dmFsKTsKKyAgICAgICAgICAgICAgICByZXN1bHQgPSBicmFu Y2hUcnVlKCk7CisgICAgICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAgICAgIG1fYXNzZW1i bGVyLm1vdkltbTgoMCwgc2NyYXRjaFJlZzMpOworICAgICAgICAgICAgICAgIG1fYXNzZW1ibGVy LmNtcGxSZWdSZWcoc2NyYXRjaFJlZzMsIGRlc3R2YWwsIFNINENvbmRpdGlvbihjb25kKSk7Cisg ICAgICAgICAgICAgICAgcmVzdWx0ID0gKGNvbmQgPT0gTm9uWmVybykgPyBicmFuY2hGYWxzZSgp IDogYnJhbmNoVHJ1ZSgpOworICAgICAgICAgICAgfQorICAgICAgICB9CisgICAgICAgIG1fYXNz ZW1ibGVyLm1vdmxSZWdNZW0oZGVzdHZhbCwgZGVzdHB0cik7CisgICAgICAgIHJlbGVhc2VTY3Jh dGNoKGRlc3R2YWwpOworICAgICAgICByZWxlYXNlU2NyYXRjaChkZXN0cHRyKTsKKyAgICAgICAg cmV0dXJuIHJlc3VsdDsKKyAgICB9CisKICAgICBKdW1wIGJyYW5jaE11bDMyKFJlc3VsdENvbmRp dGlvbiBjb25kLCBSZWdpc3RlcklEIHNyYywgUmVnaXN0ZXJJRCBkZXN0KQogICAgIHsKICAgICAg ICAgQVNTRVJUKChjb25kID09IE92ZXJmbG93KSB8fCAoY29uZCA9PSBTaWduZWQpIHx8IChjb25k ID09IFplcm8pIHx8IChjb25kID09IE5vblplcm8pKTsK