114983 2013-04-22 12:30:03 -0700 [GTK] Enable introspection always for developer builds 2013-04-22 15:15:40 -0700 1 1 1 Unclassified WebKit WebKitGTK 523.x (Safari 3) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrobinson mrobinson cgarcia commit-queue dbates gustavo pnormand zan oldest_to_newest 879384 0 mrobinson 2013-04-22 12:30:03 -0700 If we enable introspection always we can sniff out issues sooner and turn the EWS bubble red when API is introduced without proper annotations. 879430 1 199107 mrobinson 2013-04-22 14:01:39 -0700 Created attachment 199107 Patch 879446 2 199107 gustavo 2013-04-22 14:51:09 -0700 Comment on attachment 199107 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199107&action=review > Source/WebKit2/ChangeLog:8 > + * GNUmakefile.am: Make warnings cause the build to fail. Eliminate Be good to make it obvious you're talking about the scanner build here. > Source/WebKit/gtk/GNUmakefile.am:300 > - $(AM_V_GEN)$(G_IR_SCANNER) -v --warn-all \ > + $(AM_V_GEN) \ > + CFLAGS="$(CFLAGS) -Wno-deprecated-declarations" \ > + $(G_IR_SCANNER) \ > + --quiet \ Is girscanner still verbose enough to help debug issues shown by the EWS after replacing -v with --quiet here? Other than that it's a great idea, and the patch looks OK to me. 879461 3 mrobinson 2013-04-22 15:14:31 -0700 Committed r148916: <http://trac.webkit.org/changeset/148916> 879462 4 mrobinson 2013-04-22 15:15:40 -0700 (In reply to comment #2) > (From update of attachment 199107 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=199107&action=review > > > Source/WebKit2/ChangeLog:8 > > + * GNUmakefile.am: Make warnings cause the build to fail. Eliminate > > Be good to make it obvious you're talking about the scanner build here. Sound good. > > Source/WebKit/gtk/GNUmakefile.am:300 > > - $(AM_V_GEN)$(G_IR_SCANNER) -v --warn-all \ > > + $(AM_V_GEN) \ > > + CFLAGS="$(CFLAGS) -Wno-deprecated-declarations" \ > > + $(G_IR_SCANNER) \ > > + --quiet \ > > Is girscanner still verbose enough to help debug issues shown by the EWS after replacing -v with --quiet here? Other than that it's a great idea, and the patch looks OK to me. When not in quiet mode, g-ir-scanner prints the command-line it uses to compile the scanning program, which, for us, is many lines long. On the other hand it does print out the details of any problems it finds when --quiet is active. 199107 2013-04-22 14:01:39 -0700 2013-04-22 14:51:09 -0700 Patch bug-114983-20130422140104.patch text/plain 7120 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4NzczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggNGE2ZGE4YmQ2 YzAxYzVmYmM3NGE5MTA2ZDgxZTBlMjNlNWE3NWU0Zi4uODI3N2ZiM2JhZWRlMDZhMWRlZDJhYzAy MGUwMTI4ZTNhN2QyNjJkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDEz LTA0LTIyICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAorICAgICAg ICBbR1RLXSBFbmFibGUgaW50cm9zcGVjdGlvbiBhbHdheXMgZm9yIGRldmVsb3BlciBidWlsZHMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDk4Mwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogR05VbWFr ZWZpbGUuYW06IE1ha2Ugd2FybmluZ3MgY2F1c2UgdGhlIGJ1aWxkIHRvIGZhaWwuIEVsaW1pbmF0 ZQorICAgICAgICB3YXJuaW5ncyBhYm91dCBkZXByZWNhdGVkIEFQSSB0aGF0IHRoZSBnLWlyLXNj YW5uZXIgdXNlcyB3aGVuIGdlbmVyYXRpbmcKKyAgICAgICAgdGhlIHNjYW5uZXIgcHJvZ3JhbS4g VXNlIC0tcXVpZXQgdG8gYXZvaWQgcHJpbnRpbmcgbG90cyBvZiBvdXRwdXQgdG8KKyAgICAgICAg bm9uLXZlcmJvc2UgYnVpbGRzLgorCisyMDEzLTA0LTIyICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9i aW5zb25AaWdhbGlhLmNvbT4KKwogICAgICAgICBbR1RLXSBGaXggcmVtYWluaW5nIGludHJvc3Bl Y3Rpb24gd2FybmluZ3MKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTExNDk4MAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTFmYWQ0OTNjYjM2MzU5YTRhNzBmNDg5MTEy YTAxZGUyNTVlYzhkMC4uNTdjZTVjNzFhMjg1OWE3M2YwNjhjYjIwZTRlMGE3ZTY5ZDQxZjk0YyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQy L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA0LTIyICBNYXJ0aW4gUm9iaW5zb24g IDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBFbmFibGUgaW50cm9zcGVj dGlvbiBhbHdheXMgZm9yIGRldmVsb3BlciBidWlsZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDk4MworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogR05VbWFrZWZpbGUuYW06IE1ha2Ugd2FybmluZ3Mg Y2F1c2UgdGhlIGJ1aWxkIHRvIGZhaWwuIEVsaW1pbmF0ZQorICAgICAgICB3YXJuaW5ncyBhYm91 dCBkZXByZWNhdGVkIEFQSSB0aGF0IHRoZSBnLWlyLXNjYW5uZXIgdXNlcyB3aGVuIGdlbmVyYXRp bmcKKyAgICAgICAgdGhlIHNjYW5uZXIgcHJvZ3JhbS4gVXNlIC0tcXVpZXQuCisKIDIwMTMtMDQt MTkgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBKb2lu RXhpc3RpbmdTZXNzaW9uIHRvIHRoZSBXZWJDb250ZXh0IFhQQy4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvZ3RrL0dOVW1ha2VmaWxlLmFtIGIvU291cmNlL1dlYktpdC9ndGsvR05VbWFrZWZp bGUuYW0KaW5kZXggZTBjZmZmZTZlMjJmNGNhMjU1NGNlMDg3YmE0NWExOGI1YjAwMmU1MC4uZDlk NWRlODk3ZjVkMDBjMDY5NmQ1MjUzOTFhMTc4N2NiZTExN2NmOSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9ndGsvR05VbWFrZWZpbGUuYW0KKysrIGIvU291cmNlL1dlYktpdC9ndGsvR05VbWFr ZWZpbGUuYW0KQEAgLTI5NCw3ICsyOTQsMTIgQEAgcGtnY29uZmlnX0RBVEEgKz0gU291cmNlL1dl YktpdC9ndGsvQFdFQktJVEdUS19QQ19OQU1FQC1AV0VCS0lUR1RLX0FQSV9WRVJTSU9OQC4KIAog aWYgRU5BQkxFX0lOVFJPU1BFQ1RJT04KIFdlYktpdC1AV0VCS0lUR1RLX0FQSV9WRVJTSU9OQC5n aXI6ICQoR19JUl9TQ0FOTkVSKSBKYXZhU2NyaXB0Q29yZS1AV0VCS0lUR1RLX0FQSV9WRVJTSU9O QC5naXIgbGlid2Via2l0Z3RrLUBXRUJLSVRHVEtfQVBJX01BSk9SX1ZFUlNJT05ALkBXRUJLSVRH VEtfQVBJX01JTk9SX1ZFUlNJT05ALmxhCi0JJChBTV9WX0dFTikkKEdfSVJfU0NBTk5FUikgLXYg LS13YXJuLWFsbCBcCisJJChBTV9WX0dFTikgXAorCSAgICAgQ0ZMQUdTPSIkKENGTEFHUykgLVdu by1kZXByZWNhdGVkLWRlY2xhcmF0aW9ucyIgXAorCSAgICAgJChHX0lSX1NDQU5ORVIpIFwKKwkg ICAgIC0tcXVpZXQgXAorCSAgICAgLS13YXJuLWFsbCBcCisJICAgICAtLXdhcm4tZXJyb3IgXAog CSAgICAgLS1zeW1ib2wtcHJlZml4PXdlYmtpdCBcCiAJICAgICAtLWlkZW50aWZpZXItcHJlZml4 PVdlYktpdCBcCiAJICAgICAtLW5hbWVzcGFjZT1XZWJLaXQgXApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvR05VbWFrZWZpbGUuYW0gYi9Tb3VyY2UvV2ViS2l0Mi9HTlVtYWtlZmlsZS5hbQpp bmRleCBjMzUxODI3NmRkMmI4NDc3NTk5ODk5MDc0ZTk3ZGE4Mzk2NTAwZWYyLi5iNTk0ZTQzNTc1 NDZmYmNhMDgyNGMwMzEwODE3N2ZlMDNjYmMwOTFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9HTlVtYWtlZmlsZS5hbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9HTlVtYWtlZmlsZS5hbQpAQCAt MjYxLDcgKzI2MSwxMiBAQCBwa2djb25maWdfREFUQSArPSBTb3VyY2UvV2ViS2l0Mi93ZWJraXQy Z3RrLUBXRUJLSVRHVEtfQVBJX1ZFUlNJT05ALnBjCiBpZiBFTkFCTEVfSU5UUk9TUEVDVElPTgog CiBXZWJLaXQyLUBXRUJLSVRHVEtfQVBJX1ZFUlNJT05ALmdpcjogJChHX0lSX1NDQU5ORVIpIGxp YndlYmtpdDJndGstQFdFQktJVEdUS19BUElfTUFKT1JfVkVSU0lPTkAuQFdFQktJVEdUS19BUElf TUlOT1JfVkVSU0lPTkAubGEKLQkkKEFNX1ZfR0VOKSQoR19JUl9TQ0FOTkVSKSAtdiAtLXdhcm4t YWxsIFwKKwkkKEFNX1ZfR0VOKSBcCisJICAgICBDRkxBR1M9IiQoQ0ZMQUdTKSAtV25vLWRlcHJl Y2F0ZWQtZGVjbGFyYXRpb25zIiBcCisJICAgICAkKEdfSVJfU0NBTk5FUikgXAorCSAgICAgLS1x dWlldCBcCisJICAgICAtLXdhcm4tYWxsIFwKKwkgICAgIC0td2Fybi1lcnJvciBcCiAJICAgICAt LXN5bWJvbC1wcmVmaXg9d2Via2l0IFwKIAkgICAgIC0taWRlbnRpZmllci1wcmVmaXg9V2ViS2l0 IFwKIAkgICAgIC0tbmFtZXNwYWNlPVdlYktpdDIgXApkaWZmIC0tZ2l0IGEvU291cmNlL2F1dG90 b29scy9TZXR1cEF1dG9jb25mSGVhZGVyLm00IGIvU291cmNlL2F1dG90b29scy9TZXR1cEF1dG9j b25mSGVhZGVyLm00CmluZGV4IDRmNWNiMmU3ODM3ZGNlMzJhYTRhZTM1NTYzYmYxZGJhMTdkYzg1 YTMuLjJjYjQwZWFkODk4YzNiMDQzYTYxNzM1N2RiNmYyMzA1ZmJmMTFhMzcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9hdXRvdG9vbHMvU2V0dXBBdXRvY29uZkhlYWRlci5tNAorKysgYi9Tb3VyY2UvYXV0 b3Rvb2xzL1NldHVwQXV0b2NvbmZIZWFkZXIubTQKQEAgLTU4LDEwICs1OCw2IEBAIGlmIHRlc3Qg IiRlbmFibGVfb3Bjb2RlX3N0YXRzIiA9ICJ5ZXMiOyB0aGVuCiAgICAgQUNfREVGSU5FKFtFTkFC TEVfT1BDT0RFX1NUQVRTXSwgWzFdLCBbRGVmaW5lIHRvIGVuYWJsZSBPcGNvZGUgc3RhdGlzdGlj c10pCiBmaQogCi1pZiB0ZXN0ICIkZW5hYmxlX2ludHJvc3BlY3Rpb24iID0gInllcyI7IHRoZW4K LSAgICBBQ19ERUZJTkUoW0VOQUJMRV9JTlRST1NQRUNUSU9OXSwgWzFdLCBbRGVmaW5lIHRvIGVu YWJsZSBHT2JqZWN0IGludHJvc3BlY3Rpb24gc3VwcG9ydF0pCi1maQotCiBpZiB0ZXN0ICIkZW5h YmxlX3ZpZGVvIiA9ICJ5ZXMiIHx8IHRlc3QgIiRlbmFibGVfd2ViX2F1ZGlvIiA9ICJ5ZXMiOyB0 aGVuCiAgICAgQUNfREVGSU5FKFtXVEZfVVNFX0dTVFJFQU1FUl0sIFsxXSwgWyBdKQogICAgIGlm IHRlc3QgIiRlbmFibGVfZGVidWciID0gInllcyI7IHRoZW4KZGlmZiAtLWdpdCBhL1Rvb2xzL0No YW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxZDc1ODhkODFmMjg4ZGNjZDljYzZhZWEx NWY3YWU0MDE3OWJjMTc3Li4yMWU2NDEzNjMwZjAzOGE5NTgzZjQxODgzYzg0Y2VkY2FkNTkxYTEw IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTcgQEAKKzIwMTMtMDQtMjIgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEtdIEVuYWJsZSBpbnRyb3NwZWN0aW9uIGFsd2F5cyBmb3Ig ZGV2ZWxvcGVyIGJ1aWxkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTE0OTgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06CisgICAgICAgIChydW5BdXRvZ2VuRm9y QXV0b3Rvb2xzUHJvamVjdElmTmVjZXNzYXJ5KTogQWx3YXlzIGVuYWJsZSBpbnRyb3NwZWN0aW9u CisgICAgICAgIHdoZW4gdXNpbmcgYnVpbGQtd2Via2l0LgorICAgICAgICAqIGd0ay9qaGJ1aWxk cmM6IEVuYWJsZSBkb2N1bWVudGF0aW9uIGZvciBhbGwgamhidWlsZCBtb2R1bGVzIGFuZCBleHBs aWNpdGx5CisgICAgICAgIGNob29zZSB0aGUgbWVtb3J5IGdzZXR0aW5ncyBiYWNrZW5kIHdoaWxl IGluIHRoZSBqaGJ1aWxkLiBUaGlzIGVsaW1pbmF0ZXMKKyAgICAgICAgd2FybmluZ3MgZnJvbSBw cm9ncmFtcyB0aGF0IGZhbGwgYmFjayB0byB0aGUgbWVtb3J5IGJhY2tlbmQuCisKIDIwMTMtMDQt MTcgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGduc0Bnbm9tZS5vcmc+CiAKICAgICAgICAgW0dU S10gTWFrZSB0aGUgMzIgYml0cyBib3Qgb25seSBidWlsZCBhbmQgcnVuIEFQSSB0ZXN0cwpkaWZm IC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRkaXJzLnBtCmluZGV4IDM4MjY1ODRhMTQ2MTYwMTUzOWNhYzFmZDU5NTNjMDYzN2Q3Y2UzMjgu LjAyODU0M2UxYjJiM2NmMWQ1ZjVhZDdlMmQwYThkZGE2OTg5ZjQ4NjQgMTAwNzU1Ci0tLSBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMu cG0KQEAgLTE5OTQsNiArMTk5NCw5IEBAIHN1YiBydW5BdXRvZ2VuRm9yQXV0b3Rvb2xzUHJvamVj dElmTmVjZXNzYXJ5KCRAKQogewogICAgIG15ICgkZGlyLCAkcHJlZml4LCAkc291cmNlRGlyLCAk cHJvamVjdCwgJGpvaW5lZE92ZXJyaWRhYmxlRmVhdHVyZXMsIEBidWlsZEFyZ3MpID0gQF87CiAK KyAgICAjIEFsd2F5cyBlbmFibGUgaW50cm9zcGVjdGlvbiB3aGVuIGJ1aWxkaW5nIFdlYktpdEdU SysuCisgICAgdW5zaGlmdChAYnVpbGRBcmdzLCAiLS1lbmFibGUtaW50cm9zcGVjdGlvbiIpOwor CiAgICAgbXkgJGpvaW5lZEJ1aWxkQXJncyA9IGpvaW4oIiAiLCBAYnVpbGRBcmdzKTsKIAogICAg IGlmICgtZSAiR05VbWFrZWZpbGUiKSB7CmRpZmYgLS1naXQgYS9Ub29scy9ndGsvamhidWlsZHJj IGIvVG9vbHMvZ3RrL2poYnVpbGRyYwppbmRleCA3MWU3ZjM3ZWI3MjBjZDdkNzg3MWQzMTMyYmQ0 Y2RjZTIyN2Q1M2UyLi5mNTgyYjI3N2IwYTRlNjcwZGE1ZGY2NjZjZDgxMTJlMmU0OGJmOThhIDEw MDY0NAotLS0gYS9Ub29scy9ndGsvamhidWlsZHJjCisrKyBiL1Rvb2xzL2d0ay9qaGJ1aWxkcmMK QEAgLTU0LDMgKzU0LDExIEBAIG1vZHVsZV9tYWtlYXJnc1snZ3RrKyddID0gJ0xERkxBR1M9Ii1s bSIgJyArIG1ha2VhcmdzCiAjIEF2b2lkIHJ1bnRpbWUgY29uZmxpY3RzIHdpdGggR1N0cmVhbWVy IHN5c3RlbS13aWRlIHBsdWdpbnMuIFdlIHdhbnQKICMgdG8gdXNlIG9ubHkgdGhlIHBsdWdpbnMg d2UgYnVpbGQgaW4gSkhCdWlsZC4KIG9zLmVudmlyb25bJ0dTVF9QTFVHSU5fU1lTVEVNX1BBVEgn XSA9ICcnCisKKyMgV2Ugb2Z0ZW4gZW5kIHVwIHVzaW5nIHRoZSBtZW1vcnkgYmFja2VuZCBhbnl3 YXksIHNvIGV4cGxpY2l0bHkgY2hvb3NpbmcKKyMgaXQgd2lsbCBwcmV2ZW50IHRoZSB3YXJuaW5n IG1lc3NhZ2UuCitvcy5lbnZpcm9uWydHU0VUVElOR1NfQkFDS0VORCddID0gJ21lbW9yeScKKwor IyBXZSBhbHdheXMgZW5hYmxlIGludHJvc3BlY3Rpb24gc28gdGhhdCB3ZSBjYW4gc25pZmYgb3V0 IHByb2JsZW1zIHdpdGggb3VyCisjIGFubm90YXRpb25zIHNvb25lciByYXRoZXIgdGhhbiBsYXRl ci4KK2F1dG9nZW5hcmdzPSctLWVuYWJsZS1pbnRyb3NwZWN0aW9uJwpkaWZmIC0tZ2l0IGEvQ2hh bmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDg4ZjU0N2I5ZWMyMjQwZjAzYjM2ZmExYmE4N2QyMjhj ZWQ1YmQ0N2MuLjE5MzY2NGI4YTQxOWI5NTg1NzEwZWM4NzYyZDFjZGRkNWVlNDNkZTQgMTAwNjQ0 Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMy0w NC0yMiAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAgICAg W0dUS10gRW5hYmxlIGludHJvc3BlY3Rpb24gYWx3YXlzIGZvciBkZXZlbG9wZXIgYnVpbGRzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTQ5ODMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9h dXRvdG9vbHMvU2V0dXBBdXRvY29uZkhlYWRlci5tNDogTm8gbG9uZ2VyIGV4cG9zZSB0aGUgRU5B QkxFX0lOVFJPU1BFQ1RJT04KKyAgICAgICAgYXV0b2NvbmYgaGVhZGVyIHZhcmlhYmxlLiBJdCBp c24ndCB1c2VkIGFuZCBpdCBtZWFucyB0aGF0IHdoZW4gaW50cm9zcGVjdGlvbiBpcyBlbmFibGVk CisgICAgICAgIG9yIGRpc2FibGVkLCB0aGVyZSBpcyBhbiB1bm5lY2Vzc2FyeSBmdWxsIHJlYnVp bGQuCisKIDIwMTMtMDQtMTkgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29t PgogCiAgICAgICAgIFtHVEtdIEpTQ29yZS5naXIuaW4gaGFzIGEgZmV3IHByb2JsZW1zCg==