114980 2013-04-22 12:01:51 -0700 [GTK] Fix remaining introspection warnings 2013-10-18 09:20:21 -0700 1 1 1 Unclassified WebKit WebKitGTK 523.x (Safari 3) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrobinson mrobinson abarth anthony cgarcia commit-queue gustavo haraken japhet julo42 plaes pnormand xan.lopez zan oldest_to_newest 879310 0 mrobinson 2013-04-22 12:01:51 -0700 There are a few introspection warnings. We should fix them. 879374 1 199089 mrobinson 2013-04-22 12:13:31 -0700 Created attachment 199089 Patch 879377 2 commit-queue 2013-04-22 12:15:33 -0700 Attachment 199089 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/bindings/gobject/WebKitDOMCustom.h', u'Source/WebCore/bindings/gobject/WebKitDOMEventTarget.h', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/webkit/webkitspellchecker.h', u'Source/WebKit/gtk/webkit/webkitversion.h.in']" exit_code: 1 Source/WebCore/bindings/gobject/WebKitDOMEventTarget.h:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/bindings/gobject/WebKitDOMEventTarget.h:47: Extra space between gpointer and user_data [whitespace/declaration] [3] Source/WebCore/bindings/gobject/WebKitDOMEventTarget.h:47: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/bindings/gobject/WebKitDOMEventTarget.h:47: user_data is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebCore/bindings/gobject/WebKitDOMEventTarget.h:49: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Source/WebCore/bindings/gobject/WebKitDOMEventTarget.h:71: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Source/WebCore/bindings/gobject/WebKitDOMEventTarget.h:74: Extra space between gpointer and user_data [whitespace/declaration] [3] Source/WebCore/bindings/gobject/WebKitDOMEventTarget.h:74: user_data is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebCore/bindings/gobject/WebKitDOMEventTarget.h:85: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/bindings/gobject/WebKitDOMCustom.h:39: The parameter name "input" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/bindings/gobject/WebKitDOMCustom.h:117: The parameter name "flow" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/bindings/gobject/WebKitDOMCustom.h:127: The parameter name "flow" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 12 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 879382 3 mrobinson 2013-04-22 12:21:16 -0700 (In reply to comment #2) > Attachment 199089 [details] did not pass style-queue: I believe these warnings are due to the fact that WebKitDOMEventTarget.h (which is a public header) is not skipped by the style bot. 879402 4 199089 gustavo 2013-04-22 13:14:31 -0700 Comment on attachment 199089 Patch OK 879447 5 199089 mrobinson 2013-04-22 14:52:51 -0700 Comment on attachment 199089 Patch Clearing flags on attachment: 199089 Committed r148914: <http://trac.webkit.org/changeset/148914> 879448 6 mrobinson 2013-04-22 14:52:53 -0700 All reviewed patches have been landed. Closing bug. 879625 7 199089 cgarcia 2013-04-22 23:43:43 -0700 Comment on attachment 199089 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199089&action=review I think you could have added the custom bindings headers to the list of files ignored by the style checker. > Source/WebCore/bindings/gobject/WebKitDOMCustom.h:32 > +/** > + * webkit_dom_html_text_area_element_is_edited: > + * @input: A #WebKitDOMHTMLTextAreaElement > + * > + */ > +WEBKIT_API gboolean webkit_dom_html_text_area_element_is_edited(WebKitDOMHTMLTextAreaElement* input); Doesn't this cause a warning? A method returning a boolean without a Returns: tag? >> Source/WebCore/bindings/gobject/WebKitDOMCustom.h:39 >> +WEBKIT_API gboolean webkit_dom_html_input_element_is_edited(WebKitDOMHTMLInputElement* input); > > The parameter name "input" adds no information, so it should be removed. [readability/parameter_name] [5] Ditto. > Source/WebCore/bindings/gobject/WebKitDOMCustom.h:-30 > -/* Compatibility */ Why removing this? If we add the deprecated tag to deprecated methods, this comment becomes redundant, otherwise I think it's useful. > Source/WebCore/bindings/gobject/WebKitDOMCustom.h:49 > + * Returns: (transfer none): > + */ Now that we have doc comments here we could add the deprecated tag. > Source/WebCore/bindings/gobject/WebKitDOMCustom.h:57 > + * Why this extra line here? > Source/WebCore/bindings/gobject/WebKitDOMCustom.h:65 > + * Ditto. > Source/WebCore/bindings/gobject/WebKitDOMCustom.h:74 > + * Ditto. > Source/WebCore/bindings/gobject/WebKitDOMCustom.h:81 > + * Ditto. > Source/WebCore/bindings/gobject/WebKitDOMCustom.h:88 > + * Ditto. > Source/WebCore/bindings/gobject/WebKitDOMCustom.h:97 > + * Ditto. > Source/WebCore/bindings/gobject/WebKitDOMCustom.h:106 > + * Ditto. > Source/WebCore/bindings/gobject/WebKitDOMCustom.h:115 > + * Ditto. > Source/WebCore/bindings/gobject/WebKitDOMCustom.h:125 > + * Ditto. 879834 8 mrobinson 2013-04-23 07:27:35 -0700 (In reply to comment #7) > (From update of attachment 199089 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=199089&action=review > > I think you could have added the custom bindings headers to the list of files ignored by the style checker. It's best handled in another bug. > > Source/WebCore/bindings/gobject/WebKitDOMCustom.h:32 > > +/** > > + * webkit_dom_html_text_area_element_is_edited: > > + * @input: A #WebKitDOMHTMLTextAreaElement > > + * > > + */ > > +WEBKIT_API gboolean webkit_dom_html_text_area_element_is_edited(WebKitDOMHTMLTextAreaElement* input); > > Doesn't this cause a warning? A method returning a boolean without a Returns: tag? No. gbooleans aren't transferred and have no scope so they need neither the scope nor the transfer annotation. > > Source/WebCore/bindings/gobject/WebKitDOMCustom.h:-30 > > -/* Compatibility */ > > Why removing this? If we add the deprecated tag to deprecated methods, this comment becomes redundant, otherwise I think it's useful. > > > Source/WebCore/bindings/gobject/WebKitDOMCustom.h:49 > > + * Returns: (transfer none): > > + */ It didn't seem to be adding much information. git blame is sufficient for explaining why they are there. I'm happy to restore it though, if you think it's severe enough. > Now that we have doc comments here we could add the deprecated tag. Sure. > > Source/WebCore/bindings/gobject/WebKitDOMCustom.h:57 > > + * > > Why this extra line here? Extra line nits a day after the patch has landed? :) You are welcome to fix them and any other issues you see with the gtkdoc and I'll be happy to review without delay. Another issue with the style is that the C++ file isn't in WebKit style. 941209 9 anthony 2013-10-18 08:35:29 -0700 this patch doesn't fix anything introspection related with regards to add/remove_event_listener, as painstakingly detailed by this entirety bug: https://bugs.webkit.org/show_bug.cgi?id=77835 https://bugs.webkit.org/show_bug.cgi?id=77835#c12 https://bugs.webkit.org/show_bug.cgi?id=77835#c16 https://bugs.webkit.org/show_bug.cgi?id=77835#c22 https://bugs.webkit.org/show_bug.cgi?id=77835#c45 https://bugs.webkit.org/show_bug.cgi?id=77835#c49 https://bugs.webkit.org/show_bug.cgi?id=77835#c51 ...i have had WORKING PATCHES IN QUEUE for almost 2 years now! when, when, when can this be fixed properly? WebKit7? seriously, who do i have to beg to make it happen? i was given the impression that it might "[...] go in 1.8.1 since it's pretty important for bindings", but here we are now at WebKit-next-next-next... to be perfectly clear: THE LACK OF add/remove_event_listener() IN INTROSPECTED BINDINGS RENDERS WEBKIT WORSE THAN USELESS FOR *EVERYONE* OTHER THAN C. please, please, revisit this, or revert this patch, because now the problem looks "fixed" when it very clearly is not. `async` is INCORRECT transfer. and even if it did work, remove_event_listener() won't work with it anyway (the reasons are detailed in the links). people are working around this is disgusting ways: http://stackoverflow.com/questions/17322872/cant-find-domeventtarget-add-event-listener-in-python ...can i get some closure here please? i think i've gone WAY ABOVE AND BEYOND trying to get this damn thing merged, and at this point (2... YEARS), i'm pretty irritated from being BLOWN OFF AND BLATANTLY IGNORED. this is a REAL problem. please LET ME SOLVE IT. *now*. thank you. 941217 10 anthony 2013-10-18 08:58:27 -0700 apologize for duplicate emails, i didn't realize i could add multiple people with commas (and prob spaces now that i think of it). i'm also sorry if i appear crass or whatever, but i honestly don't know what more i can do short of physically walking to Apple and picketing outside. if it seems like i'm YELLING, it's because I AM SHOUTING OBSCENITIES AS I TYPE THIS. c'mon guys, i did all the work 3 times over and implemented in multiple ways, just pick one. any one. i fully intend on setting a reminder to ping both of these bugs until i can get a concrete path forward... i don't need an immediate resolution, but you guys could throw me a bone and give me some glimmer of hope by simply ACKNOWLEDGING THE PROBLEM *OFFICIALLY* BY ACCEPTING THIS BUG: https://bugs.webkit.org/show_bug.cgi?id=77835 thanks. 199089 2013-04-22 12:13:31 -0700 2013-04-22 23:43:43 -0700 Patch bug-114980-20130422121256.patch text/plain 10572 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4NzczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTQzNjZlOTA1Y2Y5NWY3 M2NjYjM4MzBiYjg1Y2JlZmMzZWU3OWFhMS4uYjllM2M0ODJhODM0ZmVjYWJhODExNjg4NmY4ZmFm MzNmNzRhMGRiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA0LTIyICBNYXJ0 aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBGaXgg cmVtYWluaW5nIGludHJvc3BlY3Rpb24gd2FybmluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDk4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogYmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01DdXN0 b20uaDogQWRkIHNjb3BlIGFuZCB0cmFuc2ZlciBhbm5vdGF0aW9ucyBhbmQgZmxlc2gKKyAgICAg ICAgb3V0IGd0a2RvYyBmb3IgY29tcGxldGVuZXNzLgorICAgICAgICAqIGJpbmRpbmdzL2dvYmpl Y3QvV2ViS2l0RE9NRXZlbnRUYXJnZXQuaDoKKyAgICAgICAgKF9XZWJLaXRET01FdmVudFRhcmdl dElmYWNlKTogRGl0dG8gYW5kIGFsc28gYWxpZ24gdmlydHVhbCBtZXRob2QgbmFtZXMgd2l0aCB0 aG9zZSB1c2VkCisgICAgICAgIGZvciB0aGUgY29uY3JldGUgb25lcy4KKwogMjAxMy0wNC0xOSAg QmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVXNlIFZl Y3RvciBpbnN0ZWFkIG9mIFN0cmluZ0J1aWxkZXIgZm9yIENTU1ByZWxvYWRTY2FubmVyJ3MgYnVm ZmVycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9ndGsvQ2hhbmdlTG9nCmluZGV4IDBlZGIxYjRjMmMwNGIyOGFlYTM3NDMzY2E3MDhmMTc0 YjNjMjc2NGEuLjRhNmRhOGJkNmMwMWM1ZmJjNzRhOTEwNmQ4MWUwZTIzZTVhNzVlNGYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMy0wNC0yMiAgTWFydGluIFJvYmluc29u ICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gRml4IHJlbWFpbmluZyBp bnRyb3NwZWN0aW9uIHdhcm5pbmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMTQ5ODAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIHdlYmtpdC93ZWJraXRzcGVsbGNoZWNrZXIuaDoKKyAgICAgICAgKF9X ZWJLaXRTcGVsbENoZWNrZXJJbnRlcmZhY2UpOiBBbGlnbiB0aGUgbmFtZSBvZiB0aGUgY2hlY2tf c3BlbGxpbmdfb2Zfc3RyaW5nIHZpcnR1YWwKKyAgICAgICAgbWV0aG9kIHdpdGggdGhlIGNvbmNy ZXRlIG1ldGhvZCB0byBhdm9pZCBhIGctaXItc2Nhbm5lciB3YXJuaW5nLgorICAgICAgICAqIHdl YmtpdC93ZWJraXR2ZXJzaW9uLmguaW46IFNraXAgV0VCS0lUR1RLX0FQSV9WRVJTSU9OIGZvciBp bnRyb3NwZWN0aW9uIGJlY2F1c2UgaXQKKyAgICAgICAgZG9lc24ndCBmb2xsb3cgdGhlIGFwcHJv cHJpYXRlIG5hbWVzcGFjZSBuYW1lLgorCiAyMDEzLTA0LTE5ICBNYXJ0aW4gUm9iaW5zb24gIDxt cm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBKU0NvcmUuZ2lyLmluIGhhcyBh IGZldyBwcm9ibGVtcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29iamVj dC9XZWJLaXRET01DdXN0b20uaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dvYmplY3QvV2Vi S2l0RE9NQ3VzdG9tLmgKaW5kZXggNjViYzUwNzM5NmE4NzNhM2FmOWZjNDk1NWQxYTczNzUyMDNh NDQzMy4uYWEyMjE5ZTliYzA3MmE2MmE0NTFhYjgxMTQ2NzdkM2E4OGQ3NmRiNCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01DdXN0b20uaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTUN1c3RvbS5oCkBAIC0y NCwyMCArMjQsMTA3IEBACiAKIEdfQkVHSU5fREVDTFMKIAotV0VCS0lUX0FQSSBnYm9vbGVhbiB3 ZWJraXRfZG9tX2h0bWxfdGV4dF9hcmVhX2VsZW1lbnRfaXNfZWRpdGVkKFdlYktpdERPTUhUTUxU ZXh0QXJlYUVsZW1lbnQqKTsKLVdFQktJVF9BUEkgZ2Jvb2xlYW4gd2Via2l0X2RvbV9odG1sX2lu cHV0X2VsZW1lbnRfaXNfZWRpdGVkKFdlYktpdERPTUhUTUxJbnB1dEVsZW1lbnQqKTsKKy8qKgor ICogd2Via2l0X2RvbV9odG1sX3RleHRfYXJlYV9lbGVtZW50X2lzX2VkaXRlZDoKKyAqIEBpbnB1 dDogQSAjV2ViS2l0RE9NSFRNTFRleHRBcmVhRWxlbWVudAorICoKKyAqLworV0VCS0lUX0FQSSBn Ym9vbGVhbiB3ZWJraXRfZG9tX2h0bWxfdGV4dF9hcmVhX2VsZW1lbnRfaXNfZWRpdGVkKFdlYktp dERPTUhUTUxUZXh0QXJlYUVsZW1lbnQqIGlucHV0KTsKKworLyoqCisgKiB3ZWJraXRfZG9tX2h0 bWxfaW5wdXRfZWxlbWVudF9pc19lZGl0ZWQ6CisgKiBAaW5wdXQ6IEEgI1dlYktpdERPTUhUTUxJ bnB1dEVsZW1lbnQKKyAqCisgKi8KK1dFQktJVF9BUEkgZ2Jvb2xlYW4gd2Via2l0X2RvbV9odG1s X2lucHV0X2VsZW1lbnRfaXNfZWRpdGVkKFdlYktpdERPTUhUTUxJbnB1dEVsZW1lbnQqIGlucHV0 KTsKIAotLyogQ29tcGF0aWJpbGl0eSAqLworLyoqCisgKiB3ZWJraXRfZG9tX2Jsb2Jfd2Via2l0 X3NsaWNlOgorICogQHNlbGY6IEEgI1dlYktpdERPTUJsb2IKKyAqIEBzdGFydDogQSAjZ2ludDY0 CisgKiBAZW5kOiBBICNnaW50NjQKKyAqIEBjb250ZW50X3R5cGU6IEEgI2djaGFyCisgKgorICog UmV0dXJuczogKHRyYW5zZmVyIG5vbmUpOgorICovCiBXRUJLSVRfQVBJIFdlYktpdERPTUJsb2Iq IHdlYmtpdF9kb21fYmxvYl93ZWJraXRfc2xpY2UoV2ViS2l0RE9NQmxvYiogc2VsZiwgZ2ludDY0 IHN0YXJ0LCBnaW50NjQgZW5kLCBjb25zdCBnY2hhciogY29udGVudF90eXBlKTsKKworLyoqCisg KiB3ZWJraXRfZG9tX2h0bWxfZWxlbWVudF9nZXRfY2xhc3NfbmFtZToKKyAqIEBlbGVtZW50OiBB ICNXZWJLaXRET01IVE1MRWxlbWVudAorICoKKyAqIFJldHVybnM6CisgKgorICovCiBXRUJLSVRf QVBJIGdjaGFyKiB3ZWJraXRfZG9tX2h0bWxfZWxlbWVudF9nZXRfY2xhc3NfbmFtZShXZWJLaXRE T01IVE1MRWxlbWVudCogZWxlbWVudCk7CisKKy8qKgorICogd2Via2l0X2RvbV9odG1sX2VsZW1l bnRfc2V0X2NsYXNzX25hbWU6CisgKiBAZWxlbWVudDogQSAjV2ViS2l0RE9NSFRNTEVsZW1lbnQK KyAqIEB2YWx1ZTogQSAjZ2NoYXIKKyAqCisgKi8KIFdFQktJVF9BUEkgdm9pZCB3ZWJraXRfZG9t X2h0bWxfZWxlbWVudF9zZXRfY2xhc3NfbmFtZShXZWJLaXRET01IVE1MRWxlbWVudCogZWxlbWVu dCwgY29uc3QgZ2NoYXIqIHZhbHVlKTsKKworLyoqCisgKiB3ZWJraXRfZG9tX2h0bWxfZWxlbWVu dF9nZXRfY2xhc3NfbGlzdDoKKyAqIEBlbGVtZW50OiBBICNXZWJLaXRET01IVE1MRWxlbWVudAor ICoKKyAqIFJldHVybnM6ICh0cmFuc2ZlciBub25lKToKKyAqCisgKi8KIFdFQktJVF9BUEkgV2Vi S2l0RE9NRE9NVG9rZW5MaXN0KiB3ZWJraXRfZG9tX2h0bWxfZWxlbWVudF9nZXRfY2xhc3NfbGlz dChXZWJLaXRET01IVE1MRWxlbWVudCogZWxlbWVudCk7CisKKy8qKgorICogd2Via2l0X2RvbV9o dG1sX2Zvcm1fZWxlbWVudF9kaXNwYXRjaF9mb3JtX2NoYW5nZToKKyAqIEBzZWxmOiBBICNXZWJL aXRET01IVE1MRm9ybUVsZW1lbnQKKyAqCisgKi8KIFdFQktJVF9BUEkgdm9pZCB3ZWJraXRfZG9t X2h0bWxfZm9ybV9lbGVtZW50X2Rpc3BhdGNoX2Zvcm1fY2hhbmdlKFdlYktpdERPTUhUTUxGb3Jt RWxlbWVudCogc2VsZik7CisKKy8qKgorICogd2Via2l0X2RvbV9odG1sX2Zvcm1fZWxlbWVudF9k aXNwYXRjaF9mb3JtX2lucHV0OgorICogQHNlbGY6IEEgI1dlYktpdERPTUhUTUxGb3JtRWxlbWVu dAorICoKKyAqLwogV0VCS0lUX0FQSSB2b2lkIHdlYmtpdF9kb21faHRtbF9mb3JtX2VsZW1lbnRf ZGlzcGF0Y2hfZm9ybV9pbnB1dChXZWJLaXRET01IVE1MRm9ybUVsZW1lbnQqIHNlbGYpOworCisv KioKKyAqIHdlYmtpdF9kb21fd2Via2l0X25hbWVkX2Zsb3dfZ2V0X292ZXJmbG93OgorICogQGZs b3c6IEEgI1dlYktpdERPTVdlYktpdE5hbWVkRmxvdworICoKKyAqIFJldHVybnM6CisgKgorICov CiBXRUJLSVRfQVBJIGdib29sZWFuIHdlYmtpdF9kb21fd2Via2l0X25hbWVkX2Zsb3dfZ2V0X292 ZXJmbG93KFdlYktpdERPTVdlYktpdE5hbWVkRmxvdyogZmxvdyk7CisKKy8qKgorICogd2Via2l0 X2RvbV9lbGVtZW50X2dldF93ZWJraXRfcmVnaW9uX292ZXJmbG93OgorICogQGVsZW1lbnQ6IEEg I1dlYktpdERPTUVsZW1lbnQKKyAqCisgKiBSZXR1cm5zOgorICoKKyAqLwogV0VCS0lUX0FQSSBn Y2hhciogd2Via2l0X2RvbV9lbGVtZW50X2dldF93ZWJraXRfcmVnaW9uX292ZXJmbG93KFdlYktp dERPTUVsZW1lbnQqIGVsZW1lbnQpOwotV0VCS0lUX0FQSSBXZWJLaXRET01Ob2RlTGlzdCogd2Vi a2l0X2RvbV93ZWJraXRfbmFtZWRfZmxvd19nZXRfY29udGVudF9ub2RlcyhXZWJLaXRET01XZWJL aXROYW1lZEZsb3cqIG5hbWVkRmxvdyk7Ci1XRUJLSVRfQVBJIFdlYktpdERPTU5vZGVMaXN0KiB3 ZWJraXRfZG9tX3dlYmtpdF9uYW1lZF9mbG93X2dldF9yZWdpb25zX2J5X2NvbnRlbnRfbm9kZShX ZWJLaXRET01XZWJLaXROYW1lZEZsb3cqIG5hbWVkRmxvdywgV2ViS2l0RE9NTm9kZSogY29udGVu dE5vZGUpOworCisvKioKKyAqIHdlYmtpdF9kb21fd2Via2l0X25hbWVkX2Zsb3dfZ2V0X2NvbnRl bnRfbm9kZXM6CisgKiBAZmxvdzogQSAjV2ViS2l0RE9NV2ViS2l0TmFtZWRGbG93CisgKgorICog UmV0dXJuczogKHRyYW5zZmVyIG5vbmUpOgorICoKKyAqLworV0VCS0lUX0FQSSBXZWJLaXRET01O b2RlTGlzdCogd2Via2l0X2RvbV93ZWJraXRfbmFtZWRfZmxvd19nZXRfY29udGVudF9ub2RlcyhX ZWJLaXRET01XZWJLaXROYW1lZEZsb3cqIGZsb3cpOworCisvKioKKyAqIHdlYmtpdF9kb21fd2Vi a2l0X25hbWVkX2Zsb3dfZ2V0X3JlZ2lvbnNfYnlfY29udGVudF9ub2RlOgorICogQGZsb3c6IEEg I1dlYktpdERPTVdlYktpdE5hbWVkRmxvdworICogQGNvbnRlbnRfbm9kZTogQSAjV2ViS2l0RE9N Tm9kZQorICoKKyAqIFJldHVybnM6ICh0cmFuc2ZlciBub25lKToKKyAqCisgKi8KK1dFQktJVF9B UEkgV2ViS2l0RE9NTm9kZUxpc3QqIHdlYmtpdF9kb21fd2Via2l0X25hbWVkX2Zsb3dfZ2V0X3Jl Z2lvbnNfYnlfY29udGVudF9ub2RlKFdlYktpdERPTVdlYktpdE5hbWVkRmxvdyogZmxvdywgV2Vi S2l0RE9NTm9kZSogY29udGVudF9ub2RlKTsKIAogR19FTkRfREVDTFMKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01FdmVudFRhcmdldC5oIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01FdmVudFRhcmdldC5oCmlu ZGV4IDZmMmQ2ZmViOTk5N2ViOGVmNTIzYjQ3ZGQ1Y2Y3Y2NmNjI4ZGJlYTYuLjEwMmM5NDY2YjA2 MzAyNTZjM2Q0YzBkZDE5ODk2NzY2YWNkM2YyOGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL2dvYmplY3QvV2ViS2l0RE9NRXZlbnRUYXJnZXQuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTUV2ZW50VGFyZ2V0LmgKQEAgLTQxLDEyICs0 MSwxMiBAQCBzdHJ1Y3QgX1dlYktpdERPTUV2ZW50VGFyZ2V0SWZhY2UgewogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIEdFcnJvciAgICAgICAgICAgICAgKiplcnJvcik7CiAK ICAgICBnYm9vbGVhbiAgICAgICgqIGFkZF9ldmVudF9saXN0ZW5lcikoV2ViS2l0RE9NRXZlbnRU YXJnZXQgKnRhcmdldCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg Y29uc3QgY2hhciAgICAgICAgICAqZXZlbnROYW1lLAorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBjb25zdCBjaGFyICAgICAgICAgICAqZXZlbnRfbmFtZSwKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgR0NhbGxiYWNrICAgICAgICAgICAg IGhhbmRsZXIsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdib29s ZWFuICAgICAgICAgICAgICBidWJibGUsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGdwb2ludGVyICAgICAgICAgICAgICB1c2VyRGF0YSk7CisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdwb2ludGVyICAgICAgICAgICAgICB1c2VyX2Rh dGEpOwogICAgIGdib29sZWFuICAgICAgKCogcmVtb3ZlX2V2ZW50X2xpc3RlbmVyKShXZWJLaXRE T01FdmVudFRhcmdldCAqdGFyZ2V0LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBjb25zdCBjaGFyICAgICAgICAgICAqZXZlbnROYW1lLAorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBjaGFyICAgICAgICAgICAqZXZl bnRfbmFtZSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgR0Nh bGxiYWNrICAgICAgICAgICAgIGhhbmRsZXIsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGdib29sZWFuICAgICAgICAgICAgICBidWJibGUpOwogfTsKQEAgLTU4 LDE0ICs1OCwzMSBAQCBXRUJLSVRfQVBJIHZvaWQgICAgICB3ZWJraXRfZG9tX2V2ZW50X3Rhcmdl dF9kaXNwYXRjaF9ldmVudChXZWJLaXRET01FdmVudFRhcmdldAogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgV2ViS2l0RE9NRXZlbnQg ICAgICAgKmV2ZW50LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgR0Vycm9yICAgICAgICAgICAgICAqKmVycm9yKTsKIAorLyoqCisg KiB3ZWJraXRfZG9tX2V2ZW50X3RhcmdldF9hZGRfZXZlbnRfbGlzdGVuZXI6CisgKiBAdGFyZ2V0 OiBBICNXZWJLaXRET01FdmVudFRhcmdldAorICogQGV2ZW50X25hbWU6IEEgI2djaGFyCisgKiBA aGFuZGxlcjogKHNjb3BlIGFzeW5jKTogQSAjR0NhbGxiYWNrCisgKiBAYnViYmxlOiBBICNnYm9v bGVhbgorICogQHVzZXJfZGF0YTogQSAjZ3BvaW50ZXIKKyAqCisgKi8KIFdFQktJVF9BUEkgZ2Jv b2xlYW4gIHdlYmtpdF9kb21fZXZlbnRfdGFyZ2V0X2FkZF9ldmVudF9saXN0ZW5lcihXZWJLaXRE T01FdmVudFRhcmdldCAqdGFyZ2V0LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IGNoYXIgICAgICAgICAgICpldmVu dE5hbWUsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgY29uc3QgY2hhciAgICAgICAgICAgKmV2ZW50X25hbWUsCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg R0NhbGxiYWNrICAgICAgICAgICAgIGhhbmRsZXIsCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ2Jvb2xlYW4gICAgICAgICAg ICAgIGJ1YmJsZSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBncG9pbnRlciAgICAgICAgICAgICAgdXNlckRhdGEpOworICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGdwb2ludGVyICAgICAgICAgICAgICB1c2VyX2RhdGEpOwogCisvKioKKyAqIHdlYmtpdF9k b21fZXZlbnRfdGFyZ2V0X3JlbW92ZV9ldmVudF9saXN0ZW5lcjoKKyAqIEB0YXJnZXQ6IEEgI1dl YktpdERPTUV2ZW50VGFyZ2V0CisgKiBAZXZlbnRfbmFtZTogQSAjZ2NoYXIKKyAqIEBoYW5kbGVy OiAoc2NvcGUgY2FsbCk6IEEgI0dDYWxsYmFjaworICogQGJ1YmJsZTogQSAjZ2Jvb2xlYW4KKyAq CisgKi8KIFdFQktJVF9BUEkgZ2Jvb2xlYW4gIHdlYmtpdF9kb21fZXZlbnRfdGFyZ2V0X3JlbW92 ZV9ldmVudF9saXN0ZW5lcihXZWJLaXRET01FdmVudFRhcmdldCAqdGFyZ2V0LAotICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGNvbnN0IGNoYXIgICAgICAgICAgICpldmVudE5hbWUsCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgY2hhciAg ICAgICAgICAgKmV2ZW50X25hbWUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgR0NhbGxiYWNrICAgICAgICAgICAgIGhh bmRsZXIsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgZ2Jvb2xlYW4gICAgICAgICAgICAgIGJ1YmJsZSk7CiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRzcGVsbGNoZWNrZXIuaCBiL1Nv dXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRzcGVsbGNoZWNrZXIuaAppbmRleCBiNzBlMmQw MzM2YzAwNmJjZTYyN2YyODc4YzVlZjczZjIyZjBkYjM3Li4zZGY5NTYxZDUzNDgzM2U4OTljMjk2 MmRmMDc3ZGUxZDY3NTMyM2MyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQv d2Via2l0c3BlbGxjaGVja2VyLmgKKysrIGIvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtp dHNwZWxsY2hlY2tlci5oCkBAIC0zMyw3ICszMyw3IEBAIEdfQkVHSU5fREVDTFMKIHN0cnVjdCBf V2ViS2l0U3BlbGxDaGVja2VySW50ZXJmYWNlIHsKICAgICBHVHlwZUludGVyZmFjZSBnX2lmYWNl OwogCi0gICAgdm9pZCAgICgqY2hlY2tfc3BlbGxpbmdfb2Zfc3RyaW5nKSAgICAgICAgICAgICAg ICAgICAgICAgIChXZWJLaXRTcGVsbENoZWNrZXIqIGNoZWNrZXIsIGNvbnN0IGNoYXIqIHdvcmQs IGludCogbWlzc3BlbGxpbmdfbG9jYXRpb24sIGludCogbWlzc3BlbGxpbmdfbGVuZ3RoKTsKKyAg ICB2b2lkICAgKCpjaGVja19zcGVsbGluZ19vZl9zdHJpbmcpICAgICAgICAgICAgICAgICAgICAg ICAgKFdlYktpdFNwZWxsQ2hlY2tlciogY2hlY2tlciwgY29uc3QgY2hhciogc3RyaW5nLCBpbnQq IG1pc3NwZWxsaW5nX2xvY2F0aW9uLCBpbnQqIG1pc3NwZWxsaW5nX2xlbmd0aCk7CiAgICAgY2hh cioqICgqZ2V0X2d1ZXNzZXNfZm9yX3dvcmQpICAgICAgICAgICAgICAgICAgICAgICAgICAgIChX ZWJLaXRTcGVsbENoZWNrZXIqIGNoZWNrZXIsIGNvbnN0IGNoYXIqIHdvcmQsIGNvbnN0IGNoYXIq IGNvbnRleHQpOwogICAgIHZvaWQgICAoKnVwZGF0ZV9zcGVsbF9jaGVja2luZ19sYW5ndWFnZXMp ICAgICAgICAgICAgICAgICAoV2ViS2l0U3BlbGxDaGVja2VyKiBjaGVja2VyLCBjb25zdCBjaGFy KiBsYW5ndWFnZXMpOwogICAgIGNoYXIqICAoKmdldF9hdXRvY29ycmVjdF9zdWdnZXN0aW9uc19m b3JfbWlzc3BlbGxlZF93b3JkKSAoV2ViS2l0U3BlbGxDaGVja2VyKiBjaGVja2VyLCBjb25zdCBj aGFyKiB3b3JkKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR2 ZXJzaW9uLmguaW4gYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0dmVyc2lvbi5oLmlu CmluZGV4IGNlNmI1Njk1ZGY2MTllMmE5YTMxNWZiMWMxNDQ0NzFlMWUwYjIxYTcuLjRkNjM2NTVj MzkwNjRlNDBkNzYwODU0OWU1NTU4ZTEyZGUyOWRlZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvZ3RrL3dlYmtpdC93ZWJraXR2ZXJzaW9uLmguaW4KKysrIGIvU291cmNlL1dlYktpdC9ndGsv d2Via2l0L3dlYmtpdHZlcnNpb24uaC5pbgpAQCAtMzAsNiArMzAsMTAgQEAgR19CRUdJTl9ERUNM UwogI2RlZmluZSBXRUJLSVRfTUlDUk9fVkVSU0lPTiAoQFdFQktJVF9NSUNST19WRVJTSU9OQCkK ICNkZWZpbmUgV0VCS0lUX1VTRVJfQUdFTlRfTUFKT1JfVkVSU0lPTiAoQFdFQktJVF9VU0VSX0FH RU5UX01BSk9SX1ZFUlNJT05AKQogI2RlZmluZSBXRUJLSVRfVVNFUl9BR0VOVF9NSU5PUl9WRVJT SU9OIChAV0VCS0lUX1VTRVJfQUdFTlRfTUlOT1JfVkVSU0lPTkApCisKKy8qKgorICogV0VCS0lU R1RLX0FQSV9WRVJTSU9OOiAoc2tpcCkKKyAqLwogI2RlZmluZSBXRUJLSVRHVEtfQVBJX1ZFUlNJ T04gKEBXRUJLSVRHVEtfQVBJX1ZFUlNJT05AKQogCiAjZGVmaW5lIFdFQktJVF9DSEVDS19WRVJT SU9OKG1ham9yLCBtaW5vciwgbWljcm8pIFwK