114978 2013-04-22 11:51:03 -0700 Use correct stack size on Solaris and OpenBSD 2013-05-27 23:32:53 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Other RESOLVED FIXED P2 Major --- 26276 1 david paroga barraclough benjamin cmarcelo commit-queue ggaren landry oliver robert oldest_to_newest 879303 0 199057 david 2013-04-22 11:51:03 -0700 Created attachment 199057 Use correct stack size on OpenBSD On OpenBSD, applications using webkit 2.0.1 get ** Message: console message: undefined @0: RangeError: Maximum call stack size exceeded. on startup with javascript enabled. It basically causes Javascript not to work. In StackBounds.cpp, webkit says // FIXME: remove this! - this code unsafely guesses at stack sizes! #if OS(WINDOWS) || OS(SOLARIS) || OS(OPENBSD) Well, on OpenBSD, we don't need to guess. Attached is a patch that uses stack size returned from pthread_stackseg_np. The makes things work just fine. No errors and no crashes. Been tested by multiple users. Also, on OpenBSD, hppa/hppa64 grows its stack size up, so add a define to give the hppa archs a chance to work. 880714 1 david 2013-04-24 11:07:23 -0700 Would anyone like to commit this? It has been tested and shown to fix i386/amd64/macppc. 885269 2 robert 2013-05-06 13:07:24 -0700 (In reply to comment #1) > Would anyone like to commit this? It has been tested and shown to fix i386/amd64/macppc. git or svn blame the file you are changing and cc recent contributors to that file on this bug so they can review it. Then follow http://www.webkit.org/coding/contributing.html and submit the patch again. 891715 3 202416 paroga 2013-05-21 05:17:50 -0700 Created attachment 202416 Patch 892980 4 202416 commit-queue 2013-05-23 11:51:55 -0700 Comment on attachment 202416 Patch Rejecting attachment 202416 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 202416, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 150596 = 74f0f738df2239e5026f59a7581cb5a04351add5 r150599 = 1f7190513b569f67969ff16ee88b3a53d3186922 r150600 = 49e6d85a525d1388359e9d470a4f19ff3e5e3b82 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.appspot.com/results/651042 892989 5 202416 paroga 2013-05-23 12:24:51 -0700 Comment on attachment 202416 Patch Clearing flags on attachment: 202416 Committed r150603: <http://trac.webkit.org/changeset /150603> 892990 6 paroga 2013-05-23 12:25:02 -0700 All reviewed patches have been landed. Closing bug. 894226 7 paroga 2013-05-27 23:32:53 -0700 Recommited in r150786 after rollout in r150621. 199057 2013-04-22 11:51:03 -0700 2013-05-21 05:17:50 -0700 Use correct stack size on OpenBSD openbsd-stackbounds.diff text/plain 1075 david LS0tIFNvdXJjZS9XVEYvd3RmL1N0YWNrQm91bmRzLmNwcC5vcmlnCVRodSBKdW4gMTQgMDY6MjM6 MTcgMjAxMgorKysgU291cmNlL1dURi93dGYvU3RhY2tCb3VuZHMuY3BwCU1vbiBBcHIgMjIgMTE6 MTM6MTIgMjAxMwpAQCAtNjAsMTAgKzYwLDEwIEBACiAvLyBUaGVzZSBwbGF0Zm9ybXMgc2hvdWxk IG5vdyBiZSB3b3JraW5nIGNvcnJlY3RseToKIC8vICAgICBEQVJXSU4sIFFOWCwgVU5JWAogLy8g VGhlc2UgcGxhdGZvcm1zIGFyZSBub3Q6Ci0vLyAgICAgV0lORE9XUywgU09MQVJJUywgT1BFTkJT RCwgV0lOQ0UKKy8vICAgICBXSU5ET1dTLCBTT0xBUklTLCBXSU5DRQogLy8KIC8vIEZJWE1FOiBy ZW1vdmUgdGhpcyEgLSB0aGlzIGNvZGUgdW5zYWZlbHkgZ3Vlc3NlcyBhdCBzdGFjayBzaXplcyEK LSNpZiBPUyhXSU5ET1dTKSB8fCBPUyhTT0xBUklTKSB8fCBPUyhPUEVOQlNEKQorI2lmIE9TKFdJ TkRPV1MpIHx8IE9TKFNPTEFSSVMpCiAvLyBCYXNlZCBvbiB0aGUgY3VycmVudCBsaW1pdCB1c2Vk IGJ5IHRoZSBKU0MgcGFyc2VyLCBndWVzcyB0aGUgc3RhY2sgc2l6ZS4KIHN0YXRpYyBjb25zdCBw dHJkaWZmX3QgZXN0aW1hdGVkU3RhY2tTaXplID0gMTI4ICogc2l6ZW9mKHZvaWQqKSAqIDEwMjQ7 CiAvLyBUaGlzIG1ldGhvZCBhc3N1bWVzIHRoZSBzdGFjayBpcyBncm93aW5nIGRvd253YXJkcy4K QEAgLTEyNSw3ICsxMjUsMTIgQEAKICAgICBzdGFja190IHN0YWNrOwogICAgIHB0aHJlYWRfc3Rh Y2tzZWdfbnAodGhyZWFkLCAmc3RhY2spOwogICAgIG1fb3JpZ2luID0gc3RhY2suc3Nfc3A7Ci0g ICAgbV9ib3VuZCA9IGVzdGltYXRlU3RhY2tCb3VuZChtX29yaWdpbik7CisjaWYgZGVmaW5lZChf X2hwcGFfXykgfHwgZGVmaW5lZChfX2hwcGE2NF9fKQorICAgIC8vIGhwcGEncyBzdGFjayBncm93 cyB1cAorICAgIG1fYm91bmQgPSBzdGF0aWNfY2FzdDxjaGFyKj4obV9vcmlnaW4pICsgc3RhY2su c3Nfc2l6ZTsKKyNlbHNlCisgICAgbV9ib3VuZCA9IHN0YXRpY19jYXN0PGNoYXIqPihtX29yaWdp bikgLSBzdGFjay5zc19zaXplOworI2VuZGlmCiB9CiAKICNlbGlmIE9TKFVOSVgpCg== 202416 2013-05-21 05:17:50 -0700 2013-05-23 12:24:50 -0700 Patch bug-114978.patch text/plain 2562 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggYTc1NzlkZi4uY2IxOWM5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMy0wNS0yMSAg UGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KKworICAgICAgICBVc2UgY29y cmVjdCBzdGFjayBzaXplIG9uIFNvbGFyaXMgYW5kIE9wZW5CU0QKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDk3OAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9yaWdpbmFsIHBhdGNoIGJ5IERhdmlkIEhp bGwgPGRhdmlkQHdtb2wuY29tPi4KKworICAgICAgICBVc2Ugc3RhY2tfdC5zc19zaXplIGZvciBn ZXR0aW5nIHRoZSBzaXplIG9mIHRoZSBzdGFjay4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5o OgorICAgICAgICAqIHd0Zi9TdGFja0JvdW5kcy5jcHA6CisgICAgICAgIChXVEYpOgorICAgICAg ICAoV1RGOjpTdGFja0JvdW5kczo6aW5pdGlhbGl6ZSk6CisKIDIwMTMtMDUtMTQgIFBhdHJpY2sg R2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgSW50cm9kdWNlIFVTRShX SU5HREkpIGZvciB0aGUgV2luZG93cyBwb3J0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9Q bGF0Zm9ybS5oIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAppbmRleCBiNjhhMWEwLi44Yzc5 NDU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCisrKyBiL1NvdXJjZS9X VEYvd3RmL1BsYXRmb3JtLmgKQEAgLTY1LDYgKzY1LDExIEBACiAjZGVmaW5lIFdURl9DUFVfQUxQ SEEgMQogI2VuZGlmCiAKKy8qIENQVShIUFBBKSAtIEhQIFBBLVJJU0MgKi8KKyNpZiBkZWZpbmVk KF9faHBwYV9fKSB8fCBkZWZpbmVkKF9faHBwYTY0X18pCisjZGVmaW5lIFdURl9DUFVfSFBQQSAx CisjZW5kaWYKKwogLyogQ1BVKElBNjQpIC0gSXRhbml1bSAvIElBLTY0ICovCiAjaWYgZGVmaW5l ZChfX2lhNjRfXykKICNkZWZpbmUgV1RGX0NQVV9JQTY0IDEKZGlmZiAtLWdpdCBhL1NvdXJjZS9X VEYvd3RmL1N0YWNrQm91bmRzLmNwcCBiL1NvdXJjZS9XVEYvd3RmL1N0YWNrQm91bmRzLmNwcApp bmRleCBmYTI1Njg5Li42YWYxOGY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9TdGFja0Jv dW5kcy5jcHAKKysrIGIvU291cmNlL1dURi93dGYvU3RhY2tCb3VuZHMuY3BwCkBAIC01OCwxMiAr NTgsMTIgQEAgbmFtZXNwYWNlIFdURiB7CiAvLyBCdWcgMjYyNzYgLSBOZWVkIGEgbWVjaGFuaXNt IHRvIGRldGVybWluZSBzdGFjayBleHRlbnQKIC8vCiAvLyBUaGVzZSBwbGF0Zm9ybXMgc2hvdWxk IG5vdyBiZSB3b3JraW5nIGNvcnJlY3RseToKLS8vICAgICBEQVJXSU4sIFFOWCwgVU5JWAorLy8g ICAgIERBUldJTiwgT1BFTkJTRCwgUU5YLCBTT0xBUklTLCBVTklYCiAvLyBUaGVzZSBwbGF0Zm9y bXMgYXJlIG5vdDoKLS8vICAgICBXSU5ET1dTLCBTT0xBUklTLCBPUEVOQlNELCBXSU5DRQorLy8g ICAgIFdJTkRPV1MsIFdJTkNFCiAvLwogLy8gRklYTUU6IHJlbW92ZSB0aGlzISAtIHRoaXMgY29k ZSB1bnNhZmVseSBndWVzc2VzIGF0IHN0YWNrIHNpemVzIQotI2lmIE9TKFdJTkRPV1MpIHx8IE9T KFNPTEFSSVMpIHx8IE9TKE9QRU5CU0QpCisjaWYgT1MoV0lORE9XUykKIC8vIEJhc2VkIG9uIHRo ZSBjdXJyZW50IGxpbWl0IHVzZWQgYnkgdGhlIEpTQyBwYXJzZXIsIGd1ZXNzIHRoZSBzdGFjayBz aXplLgogc3RhdGljIGNvbnN0IHB0cmRpZmZfdCBlc3RpbWF0ZWRTdGFja1NpemUgPSAxMjggKiBz aXplb2Yodm9pZCopICogMTAyNDsKIC8vIFRoaXMgbWV0aG9kIGFzc3VtZXMgdGhlIHN0YWNrIGlz IGdyb3dpbmcgZG93bndhcmRzLgpAQCAtMTI0LDcgKzEyNCw3IEBAIHZvaWQgU3RhY2tCb3VuZHM6 OmluaXRpYWxpemUoKQogICAgIHN0YWNrX3QgczsKICAgICB0aHJfc3Rrc2VnbWVudCgmcyk7CiAg ICAgbV9vcmlnaW4gPSBzLnNzX3NwOwotICAgIG1fYm91bmQgPSBlc3RpbWF0ZVN0YWNrQm91bmQo bV9vcmlnaW4pOworICAgIG1fYm91bmQgPSBzdGF0aWNfY2FzdDxjaGFyKj4obV9vcmlnaW4pIC0g cy5zc19zaXplOwogfQogCiAjZWxpZiBPUyhPUEVOQlNEKQpAQCAtMTM1LDcgKzEzNSwxMSBAQCB2 b2lkIFN0YWNrQm91bmRzOjppbml0aWFsaXplKCkKICAgICBzdGFja190IHN0YWNrOwogICAgIHB0 aHJlYWRfc3RhY2tzZWdfbnAodGhyZWFkLCAmc3RhY2spOwogICAgIG1fb3JpZ2luID0gc3RhY2su c3Nfc3A7Ci0gICAgbV9ib3VuZCA9IGVzdGltYXRlU3RhY2tCb3VuZChtX29yaWdpbik7CisjaWYg Q1BVKEhQUEEpCisgICAgbV9ib3VuZCA9IHN0YXRpY19jYXN0PGNoYXIqPihtX29yaWdpbikgKyBz dGFjay5zc19zaXplOworI2Vsc2UKKyAgICBtX2JvdW5kID0gc3RhdGljX2Nhc3Q8Y2hhcio+KG1f b3JpZ2luKSAtIHN0YWNrLnNzX3NpemU7CisjZW5kaWYKIH0KIAogI2VsaWYgT1MoVU5JWCkK